<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178912] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178912">178912</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-01-22 04:22:03 -0800 (Thu, 22 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: [ATK] Mark accessibility/list-detection.html as a suitable test for EFL and GTK.
https://bugs.webkit.org/show_bug.cgi?id=140721
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2015-01-22
Reviewed by Chris Fleizach.
The test checks the heuristic to determine if a 'list' is really a list.
In the area of ATK a role for description list has been separated from the role AXList.
This made the test stopped giving positive results for ports EFL and GTK.
The proposed amendment restores test for these ports.
* accessibility/list-detection.html:
* platform/efl/TestExpectations:
* platform/efl/accessibility/list-detection-expected.txt: Added.
* platform/gtk/TestExpectations:
* platform/gtk/accessibility/list-detection-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitylistdetectionhtml">trunk/LayoutTests/accessibility/list-detection.html</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflaccessibilitylistdetectionexpectedtxt">trunk/LayoutTests/platform/efl/accessibility/list-detection-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilitylistdetectionexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (178911 => 178912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-22 10:23:35 UTC (rev 178911)
+++ trunk/LayoutTests/ChangeLog 2015-01-22 12:22:03 UTC (rev 178912)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-01-22 Andrzej Badowski <a.badowski@samsung.com>
+
+ AX: [ATK] Mark accessibility/list-detection.html as a suitable test for EFL and GTK.
+ https://bugs.webkit.org/show_bug.cgi?id=140721
+
+ Reviewed by Chris Fleizach.
+
+ The test checks the heuristic to determine if a 'list' is really a list.
+ In the area of ATK a role for description list has been separated from the role AXList.
+ This made the test stopped giving positive results for ports EFL and GTK.
+ The proposed amendment restores test for these ports.
+
+ * accessibility/list-detection.html:
+ * platform/efl/TestExpectations:
+ * platform/efl/accessibility/list-detection-expected.txt: Added.
+ * platform/gtk/TestExpectations:
+ * platform/gtk/accessibility/list-detection-expected.txt: Added.
+
</ins><span class="cx"> 2015-01-21 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Skip items spanning flex tracks when sizing content based tracks
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitylistdetectionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/list-detection.html (178911 => 178912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/list-detection.html 2015-01-22 10:23:35 UTC (rev 178911)
+++ trunk/LayoutTests/accessibility/list-detection.html 2015-01-22 12:22:03 UTC (rev 178912)
</span><span class="lines">@@ -86,7 +86,10 @@
</span><span class="cx"> var element = document.getElementById("list" + k);
</span><span class="cx"> var axElement = accessibilityController.accessibleElementById("list" + k);
</span><span class="cx"> debug(element.getAttribute("test-description"));
</span><del>- if (element.getAttribute("is-list") === "true") {
</del><ins>+ if (element.getAttribute("id") == "list4" && accessibilityController.platformName == "atk") {
+ shouldBeTrue("axElement.role == 'AXRole: AXDescriptionList'")
+ }
+ else if (element.getAttribute("is-list") === "true") {
</ins><span class="cx"> shouldBeTrue("axElement.role == 'AXRole: AXList'");
</span><span class="cx"> } else {
</span><span class="cx"> shouldBeFalse("axElement.role == 'AXRole: AXList'");
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (178911 => 178912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2015-01-22 10:23:35 UTC (rev 178911)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2015-01-22 12:22:03 UTC (rev 178912)
</span><span class="lines">@@ -1890,8 +1890,6 @@
</span><span class="cx"> webkit.org/b/128670 fast/forms/form-hides-table.html [ Failure ]
</span><span class="cx"> webkit.org/b/128670 js/dom/dom-static-property-for-in-iteration.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/128901 accessibility/list-detection.html [ Failure ]
-
</del><span class="cx"> webkit.org/b/128902 media/media-event-listeners.html [ Timeout ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/128973 fast/multicol/span/span-as-immediate-columns-child-dynamic.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflaccessibilitylistdetectionexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/efl/accessibility/list-detection-expected.txt (0 => 178912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/accessibility/list-detection-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/list-detection-expected.txt 2015-01-22 12:22:03 UTC (rev 178912)
</span><span class="lines">@@ -0,0 +1,65 @@
</span><ins>+This tests the heuristic to determine if a 'list' is really a list, or just being used for layout.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Ordered list is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Empty ordered list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Empty description list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Description list is a list.
+PASS axElement.role == 'AXRole: AXDescriptionList' is true
+
+
+ARIA role=list is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Empty ARIA list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+ARIA list with one item is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Default styled Unordered list is a list, because it shows markers.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with more than 1 item and no style is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with 1 item and no style is not list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+List with non list item children is not a list
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Unordered list with image for markers is a list - even if image fails to load.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with aria role and at least one aria list items is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Inline list elements with an aria role should be a list
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (178911 => 178912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-01-22 10:23:35 UTC (rev 178911)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-01-22 12:22:03 UTC (rev 178912)
</span><span class="lines">@@ -2043,8 +2043,6 @@
</span><span class="cx"> webkit.org/b/129958 svg/clip-path/mask-userspaceonuse-content-clip-transform.svg [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/129958 svg/clip-path/mask-userspaceonuse-content-clip.svg [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-webkit.org/b/128901 accessibility/list-detection.html [ Failure ]
-
</del><span class="cx"> webkit.org/b/127743 media/video-restricted-no-preload-auto.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> # .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilitylistdetectionexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt (0 => 178912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt 2015-01-22 12:22:03 UTC (rev 178912)
</span><span class="lines">@@ -0,0 +1,65 @@
</span><ins>+This tests the heuristic to determine if a 'list' is really a list, or just being used for layout.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Ordered list is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Empty ordered list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Empty description list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Description list is a list.
+PASS axElement.role == 'AXRole: AXDescriptionList' is true
+
+
+ARIA role=list is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Empty ARIA list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+ARIA list with one item is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Default styled Unordered list is a list, because it shows markers.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with more than 1 item and no style is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with 1 item and no style is not list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+List with non list item children is not a list
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Unordered list with image for markers is a list - even if image fails to load.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with aria role and at least one aria list items is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Inline list elements with an aria role should be a list
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre>
</div>
</div>
</body>
</html>