<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178604] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178604">178604</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2015-01-16 14:22:46 -0800 (Fri, 16 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>More WebPageProxy CTTE
https://bugs.webkit.org/show_bug.cgi?id=140565
Reviewed by Andreas Kling.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::connectionWillOpen):
(WebKit::WebPageProxy::connectionDidClose):
(WebKit::WebPageProxy::connectionWillClose): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionDidClose):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessProxycpp">trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (178603 => 178604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-01-16 22:13:08 UTC (rev 178603)
+++ trunk/Source/WebKit2/ChangeLog 2015-01-16 22:22:46 UTC (rev 178604)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2015-01-16 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ More WebPageProxy CTTE
+ https://bugs.webkit.org/show_bug.cgi?id=140565
+
+ Reviewed by Andreas Kling.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::connectionWillOpen):
+ (WebKit::WebPageProxy::connectionDidClose):
+ (WebKit::WebPageProxy::connectionWillClose): Deleted.
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::connectionWillOpen):
+ (WebKit::WebProcessProxy::connectionDidClose):
+
+2015-01-16 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Remove dead code
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=140563
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (178603 => 178604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-01-16 22:13:08 UTC (rev 178603)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-01-16 22:22:46 UTC (rev 178604)
</span><span class="lines">@@ -3220,17 +3220,17 @@
</span><span class="cx"> m_uiClient->didCancelTrackingPotentialLongMousePress(this, m_process->transformHandlesToObjects(userData.object()).get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebPageProxy::connectionWillOpen(IPC::Connection* connection)
</del><ins>+void WebPageProxy::connectionWillOpen(IPC::Connection& connection)
</ins><span class="cx"> {
</span><del>- ASSERT(connection == m_process->connection());
</del><ins>+ ASSERT(&connection == m_process->connection());
</ins><span class="cx">
</span><span class="cx"> m_webProcessLifetimeTracker.connectionWillOpen();
</span><del>- m_process->processPool().storageManager().setAllowedSessionStorageNamespaceConnection(m_pageID, connection);
</del><ins>+ m_process->processPool().storageManager().setAllowedSessionStorageNamespaceConnection(m_pageID, &connection);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void WebPageProxy::connectionWillClose(IPC::Connection* connection)
</del><ins>+void WebPageProxy::connectionDidClose(IPC::Connection& connection)
</ins><span class="cx"> {
</span><del>- ASSERT_UNUSED(connection, connection == m_process->connection());
</del><ins>+ ASSERT_UNUSED(connection, &connection == m_process->connection());
</ins><span class="cx">
</span><span class="cx"> m_webProcessLifetimeTracker.connectionWillClose();
</span><span class="cx"> m_process->processPool().storageManager().setAllowedSessionStorageNamespaceConnection(m_pageID, 0);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (178603 => 178604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2015-01-16 22:13:08 UTC (rev 178603)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2015-01-16 22:22:46 UTC (rev 178604)
</span><span class="lines">@@ -911,8 +911,8 @@
</span><span class="cx"> void didFinishCheckingText(uint64_t requestID, const Vector<WebCore::TextCheckingResult>&);
</span><span class="cx"> void didCancelCheckingText(uint64_t requestID);
</span><span class="cx">
</span><del>- void connectionWillOpen(IPC::Connection*);
- void connectionWillClose(IPC::Connection*);
</del><ins>+ void connectionWillOpen(IPC::Connection&);
+ void connectionDidClose(IPC::Connection&);
</ins><span class="cx">
</span><span class="cx"> void processDidFinishLaunching();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (178603 => 178604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-01-16 22:13:08 UTC (rev 178603)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-01-16 22:22:46 UTC (rev 178604)
</span><span class="lines">@@ -131,16 +131,16 @@
</span><span class="cx"> SecItemShimProxy::shared().initializeConnection(connection);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- for (WebPageProxyMap::iterator it = m_pageMap.begin(), end = m_pageMap.end(); it != end; ++it)
- it->value->connectionWillOpen(&connection);
</del><ins>+ for (auto& page : m_pageMap.values())
+ page->connectionWillOpen(connection);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebProcessProxy::connectionDidClose(IPC::Connection& connection)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(this->connection() == &connection);
</span><span class="cx">
</span><del>- for (WebPageProxyMap::iterator it = m_pageMap.begin(), end = m_pageMap.end(); it != end; ++it)
- it->value->connectionWillClose(&connection);
</del><ins>+ for (auto& page : m_pageMap.values())
+ page->connectionDidClose(connection);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebProcessProxy::disconnect()
</span></span></pre>
</div>
</div>
</body>
</html>