<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178598] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178598">178598</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2015-01-16 13:37:42 -0800 (Fri, 16 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Sprinkle some CTTE in ChildProcessProxy member functions
https://bugs.webkit.org/show_bug.cgi?id=140562
Reviewed by Andreas Kling.
* Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::clearConnection):
(WebKit::ChildProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::connectionDidClose):
(WebKit::ChildProcessProxy::connectionWillClose): Deleted.
* Shared/ChildProcessProxy.h:
* UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::connectionWillOpen): Deleted.
(WebKit::DatabaseProcessProxy::connectionWillClose): Deleted.
* UIProcess/Databases/DatabaseProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::connectionWillOpen):
(WebKit::NetworkProcessProxy::connectionWillClose): Deleted.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionDidClose):
(WebKit::WebProcessProxy::connectionWillClose): Deleted.
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::initializeConnection):
* UIProcess/mac/SecItemShimProxy.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedChildProcessProxycpp">trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedChildProcessProxyh">trunk/Source/WebKit2/Shared/ChildProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxycpp">trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxyh">trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessNetworkNetworkProcessProxycpp">trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessNetworkNetworkProcessProxyh">trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessProxycpp">trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessProxyh">trunk/Source/WebKit2/UIProcess/WebProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacSecItemShimProxycpp">trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacSecItemShimProxyh">trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/ChangeLog 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2015-01-16 Anders Carlsson <andersca@apple.com>
+
+ Sprinkle some CTTE in ChildProcessProxy member functions
+ https://bugs.webkit.org/show_bug.cgi?id=140562
+
+ Reviewed by Andreas Kling.
+
+ * Shared/ChildProcessProxy.cpp:
+ (WebKit::ChildProcessProxy::didFinishLaunching):
+ (WebKit::ChildProcessProxy::clearConnection):
+ (WebKit::ChildProcessProxy::connectionWillOpen):
+ (WebKit::ChildProcessProxy::connectionDidClose):
+ (WebKit::ChildProcessProxy::connectionWillClose): Deleted.
+ * Shared/ChildProcessProxy.h:
+ * UIProcess/Databases/DatabaseProcessProxy.cpp:
+ (WebKit::DatabaseProcessProxy::connectionWillOpen): Deleted.
+ (WebKit::DatabaseProcessProxy::connectionWillClose): Deleted.
+ * UIProcess/Databases/DatabaseProcessProxy.h:
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::connectionWillOpen):
+ (WebKit::NetworkProcessProxy::connectionWillClose): Deleted.
+ * UIProcess/Network/NetworkProcessProxy.h:
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::connectionWillOpen):
+ (WebKit::WebProcessProxy::connectionDidClose):
+ (WebKit::WebProcessProxy::connectionWillClose): Deleted.
+ * UIProcess/WebProcessProxy.h:
+ * UIProcess/mac/SecItemShimProxy.cpp:
+ (WebKit::SecItemShimProxy::initializeConnection):
+ * UIProcess/mac/SecItemShimProxy.h:
+
</ins><span class="cx"> 2015-01-16 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> Should cancel immediate action sooner in WK2
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedChildProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -138,7 +138,7 @@
</span><span class="cx"> m_connection->setShouldCloseConnectionOnMachExceptions();
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- connectionWillOpen(m_connection.get());
</del><ins>+ connectionWillOpen(*m_connection);
</ins><span class="cx"> m_connection->open();
</span><span class="cx">
</span><span class="cx"> for (size_t i = 0; i < m_pendingMessages.size(); ++i) {
</span><span class="lines">@@ -164,17 +164,18 @@
</span><span class="cx"> if (!m_connection)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- connectionWillClose(m_connection.get());
</del><ins>+ // FIXME: Call this after the connection has been invalidated.
+ connectionDidClose(*m_connection);
</ins><span class="cx">
</span><span class="cx"> m_connection->invalidate();
</span><span class="cx"> m_connection = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChildProcessProxy::connectionWillOpen(IPC::Connection*)
</del><ins>+void ChildProcessProxy::connectionWillOpen(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChildProcessProxy::connectionWillClose(IPC::Connection*)
</del><ins>+void ChildProcessProxy::connectionDidClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedChildProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/ChildProcessProxy.h (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/ChildProcessProxy.h 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/Shared/ChildProcessProxy.h 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -84,8 +84,8 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual void getLaunchOptions(ProcessLauncher::LaunchOptions&) = 0;
</span><del>- virtual void connectionWillOpen(IPC::Connection*);
- virtual void connectionWillClose(IPC::Connection*);
</del><ins>+ virtual void connectionWillOpen(IPC::Connection&);
+ virtual void connectionDidClose(IPC::Connection&);
</ins><span class="cx">
</span><span class="cx"> Vector<std::pair<std::unique_ptr<IPC::MessageEncoder>, unsigned>> m_pendingMessages;
</span><span class="cx"> RefPtr<ProcessLauncher> m_processLauncher;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -61,14 +61,6 @@
</span><span class="cx"> platformGetLaunchOptions(launchOptions);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseProcessProxy::connectionWillOpen(IPC::Connection*)
-{
-}
-
-void DatabaseProcessProxy::connectionWillClose(IPC::Connection*)
-{
-}
-
</del><span class="cx"> void DatabaseProcessProxy::didReceiveMessage(IPC::Connection& connection, IPC::MessageDecoder& decoder)
</span><span class="cx"> {
</span><span class="cx"> if (decoder.messageReceiverName() == Messages::DatabaseProcessProxy::messageReceiverName()) {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -49,8 +49,6 @@
</span><span class="cx">
</span><span class="cx"> // ChildProcessProxy
</span><span class="cx"> virtual void getLaunchOptions(ProcessLauncher::LaunchOptions&) override;
</span><del>- virtual void connectionWillOpen(IPC::Connection*) override;
- virtual void connectionWillClose(IPC::Connection*) override;
</del><span class="cx">
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessNetworkNetworkProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> platformGetLaunchOptions(launchOptions);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcessProxy::connectionWillOpen(IPC::Connection* connection)
</del><ins>+void NetworkProcessProxy::connectionWillOpen(IPC::Connection& connection)
</ins><span class="cx"> {
</span><span class="cx"> #if ENABLE(SEC_ITEM_SHIM)
</span><span class="cx"> SecItemShimProxy::shared().initializeConnection(connection);
</span><span class="lines">@@ -91,10 +91,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcessProxy::connectionWillClose(IPC::Connection*)
-{
-}
-
</del><span class="cx"> void NetworkProcessProxy::getNetworkProcessConnection(PassRefPtr<Messages::WebProcessProxy::GetNetworkProcessConnection::DelayedReply> reply)
</span><span class="cx"> {
</span><span class="cx"> m_pendingConnectionReplies.append(reply);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessNetworkNetworkProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -73,8 +73,7 @@
</span><span class="cx">
</span><span class="cx"> // ChildProcessProxy
</span><span class="cx"> virtual void getLaunchOptions(ProcessLauncher::LaunchOptions&) override;
</span><del>- virtual void connectionWillOpen(IPC::Connection*) override;
- virtual void connectionWillClose(IPC::Connection*) override;
</del><ins>+ virtual void connectionWillOpen(IPC::Connection&) override;
</ins><span class="cx">
</span><span class="cx"> void platformGetLaunchOptions(ProcessLauncher::LaunchOptions&);
</span><span class="cx"> void networkProcessCrashedOrFailedToLaunch();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -123,26 +123,26 @@
</span><span class="cx"> platformGetLaunchOptions(launchOptions);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessProxy::connectionWillOpen(IPC::Connection* connection)
</del><ins>+void WebProcessProxy::connectionWillOpen(IPC::Connection& connection)
</ins><span class="cx"> {
</span><del>- ASSERT(this->connection() == connection);
</del><ins>+ ASSERT(this->connection() == &connection);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(SEC_ITEM_SHIM)
</span><span class="cx"> SecItemShimProxy::shared().initializeConnection(connection);
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> for (WebPageProxyMap::iterator it = m_pageMap.begin(), end = m_pageMap.end(); it != end; ++it)
</span><del>- it->value->connectionWillOpen(connection);
</del><ins>+ it->value->connectionWillOpen(&connection);
</ins><span class="cx">
</span><span class="cx"> m_processPool->processWillOpenConnection(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessProxy::connectionWillClose(IPC::Connection* connection)
</del><ins>+void WebProcessProxy::connectionDidClose(IPC::Connection& connection)
</ins><span class="cx"> {
</span><del>- ASSERT(this->connection() == connection);
</del><ins>+ ASSERT(this->connection() == &connection);
</ins><span class="cx">
</span><span class="cx"> for (WebPageProxyMap::iterator it = m_pageMap.begin(), end = m_pageMap.end(); it != end; ++it)
</span><del>- it->value->connectionWillClose(connection);
</del><ins>+ it->value->connectionWillClose(&connection);
</ins><span class="cx">
</span><span class="cx"> m_processPool->processWillCloseConnection(this);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.h (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.h 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.h 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -149,8 +149,8 @@
</span><span class="cx"> // From ChildProcessProxy
</span><span class="cx"> virtual void getLaunchOptions(ProcessLauncher::LaunchOptions&) override;
</span><span class="cx"> void platformGetLaunchOptions(ProcessLauncher::LaunchOptions&);
</span><del>- virtual void connectionWillOpen(IPC::Connection*) override;
- virtual void connectionWillClose(IPC::Connection*) override;
</del><ins>+ virtual void connectionWillOpen(IPC::Connection&) override;
+ virtual void connectionDidClose(IPC::Connection&) override;
</ins><span class="cx">
</span><span class="cx"> // Called when the web process has crashed or we know that it will terminate soon.
</span><span class="cx"> // Will potentially cause the WebProcessProxy object to be freed.
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacSecItemShimProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -52,9 +52,9 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SecItemShimProxy::initializeConnection(IPC::Connection* connection)
</del><ins>+void SecItemShimProxy::initializeConnection(IPC::Connection& connection)
</ins><span class="cx"> {
</span><del>- connection->addWorkQueueMessageReceiver(Messages::SecItemShimProxy::messageReceiverName(), m_queue.get(), this);
</del><ins>+ connection.addWorkQueueMessageReceiver(Messages::SecItemShimProxy::messageReceiverName(), m_queue.get(), this);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SecItemShimProxy::secItemRequest(IPC::Connection& connection, uint64_t requestID, const SecItemRequestData& request)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacSecItemShimProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.h (178597 => 178598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.h 2015-01-16 21:33:01 UTC (rev 178597)
+++ trunk/Source/WebKit2/UIProcess/mac/SecItemShimProxy.h 2015-01-16 21:37:42 UTC (rev 178598)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static SecItemShimProxy& shared();
</span><span class="cx">
</span><del>- void initializeConnection(IPC::Connection*);
</del><ins>+ void initializeConnection(IPC::Connection&);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> SecItemShimProxy();
</span></span></pre>
</div>
</div>
</body>
</html>