<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178574] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178574">178574</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-01-15 22:13:45 -0800 (Thu, 15 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Element appears correctly but does not receive event with a large translation.
https://bugs.webkit.org/show_bug.cgi?id=139815
Reviewed by Simon Fraser.
When the hit point gets translated beyond the min/max value of LayoutRect (infiniteRect()),
we fail to find the corresponding layer.
When there's no clipping on a layer, we use min/max values to represent infiniteness.
However it does not work well across types. With IntPoint(hittest) we can address a point that's outside
of LayoutRect's boundary(clipping).
This patch addresses the immediate issue of not being able to hittest transformed layers properly.
Fixing the representation of infiniteness is tracked here: webkit.org/b/140533
Source/WebCore:
Test: transforms/hittest-translated-content-off-to-infinity-and-back.html
* rendering/ClipRect.cpp:
(WebCore::ClipRect::intersects):
LayoutTests:
* transforms/hittest-translated-content-off-to-infinity-and-back-expected.html: Added.
* transforms/hittest-translated-content-off-to-infinity-and-back.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingClipRectcpp">trunk/Source/WebCore/rendering/ClipRect.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTeststransformshittesttranslatedcontentofftoinfinityandbackexpectedhtml">trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back-expected.html</a></li>
<li><a href="#trunkLayoutTeststransformshittesttranslatedcontentofftoinfinityandbackhtml">trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (178573 => 178574)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-16 05:55:05 UTC (rev 178573)
+++ trunk/LayoutTests/ChangeLog 2015-01-16 06:13:45 UTC (rev 178574)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-01-15 Zalan Bujtas <zalan@apple.com>
+
+ Element appears correctly but does not receive event with a large translation.
+ https://bugs.webkit.org/show_bug.cgi?id=139815
+
+ Reviewed by Simon Fraser.
+
+ When the hit point gets translated beyond the min/max value of LayoutRect (infiniteRect()),
+ we fail to find the corresponding layer.
+ When there's no clipping on a layer, we use min/max values to represent infiniteness.
+ However it does not work well across types. With IntPoint(hittest) we can address a point that's outside
+ of LayoutRect's boundary(clipping).
+ This patch addresses the immediate issue of not being able to hittest transformed layers properly.
+ Fixing the representation of infiniteness is tracked here: webkit.org/b/140533
+
+ * transforms/hittest-translated-content-off-to-infinity-and-back-expected.html: Added.
+ * transforms/hittest-translated-content-off-to-infinity-and-back.html: Added.
+
</ins><span class="cx"> 2015-01-15 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> tables/mozilla/bugs/bug10633.html is flakey on Yosemite
</span></span></pre></div>
<a id="trunkLayoutTeststransformshittesttranslatedcontentofftoinfinityandbackexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back-expected.html (0 => 178574)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back-expected.html (rev 0)
+++ trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back-expected.html 2015-01-16 06:13:45 UTC (rev 178574)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<html>
+<head>
+<title>This test that hittest finds the box that is translated beyond min/max layout unit and back.</title>
+<style>
+ div {
+ position: absolute;
+ width: 100px;
+ height: 100px;
+ background-color: green;
+}
+</style>
+</head>
+<body>
+ <div style="left: 0px; top: 0px;"></div>
+ <div style="left: 100px; top: 100px;"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTeststransformshittesttranslatedcontentofftoinfinityandbackhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back.html (0 => 178574)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back.html (rev 0)
+++ trunk/LayoutTests/transforms/hittest-translated-content-off-to-infinity-and-back.html 2015-01-16 06:13:45 UTC (rev 178574)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<html>
+<head>
+<title>This test that hittest finds the box that is translated beyond min/max layout unit and back.</title>
+<style>
+ div {
+ position: absolute;
+ width: 100px;
+ height: 100px;
+ background-color: red;
+ top: 0px;
+ left: 0px;
+ }
+
+</style>
+</head>
+<body>
+ <div style="-webkit-transform: translate3d(-41946743px, -41946743px, 0px);">
+ <div style="-webkit-transform: translate3d(41946743px, 41946743px, 0px); top: 0px; left: 0px;"></div>
+ </div>
+ <div style="-webkit-transform: translate3d(41946743px, 41946743px, 0px);">
+ <div id=second style="-webkit-transform: translate3d(-41946743px, -41946743px, 0px); top: 100px; left: 100px;"></div>
+ </div>
+ <script>
+ document.elementFromPoint(0, 0).style.backgroundColor = "green";
+ document.elementFromPoint(100, 100).style.backgroundColor = "green";
+ </script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (178573 => 178574)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-01-16 05:55:05 UTC (rev 178573)
+++ trunk/Source/WebCore/ChangeLog 2015-01-16 06:13:45 UTC (rev 178574)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-01-15 Zalan Bujtas <zalan@apple.com>
+
+ Element appears correctly but does not receive event with a large translation.
+ https://bugs.webkit.org/show_bug.cgi?id=139815
+
+ Reviewed by Simon Fraser.
+
+ When the hit point gets translated beyond the min/max value of LayoutRect (infiniteRect()),
+ we fail to find the corresponding layer.
+ When there's no clipping on a layer, we use min/max values to represent infiniteness.
+ However it does not work well across types. With IntPoint(hittest) we can address a point that's outside
+ of LayoutRect's boundary(clipping).
+ This patch addresses the immediate issue of not being able to hittest transformed layers properly.
+ Fixing the representation of infiniteness is tracked here: webkit.org/b/140533
+
+ Test: transforms/hittest-translated-content-off-to-infinity-and-back.html
+
+ * rendering/ClipRect.cpp:
+ (WebCore::ClipRect::intersects):
+
</ins><span class="cx"> 2015-01-15 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> tables/mozilla/bugs/bug10633.html is flakey on Yosemite
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingClipRectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/ClipRect.cpp (178573 => 178574)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/ClipRect.cpp 2015-01-16 05:55:05 UTC (rev 178573)
+++ trunk/Source/WebCore/rendering/ClipRect.cpp 2015-01-16 06:13:45 UTC (rev 178574)
</span><span class="lines">@@ -32,6 +32,9 @@
</span><span class="cx">
</span><span class="cx"> bool ClipRect::intersects(const HitTestLocation& hitTestLocation) const
</span><span class="cx"> {
</span><ins>+ if (isInfinite())
+ return true;
+
</ins><span class="cx"> return hitTestLocation.intersects(m_rect);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>