<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178386] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178386">178386</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-01-13 15:49:33 -0800 (Tue, 13 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Missed images and missed new lines in the expected results of the imported w3c canvas layout tests.
https://bugs.webkit.org/show_bug.cgi?id=140409.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-01-13
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Fix some failures in the imported W3C canvas tests. These failures were happening because
of missing images or missing new lines at the end of the expected results.
* canvas/2d.pattern.paint.repeat.basic-expected.txt:
* canvas/2d.pattern.paint.repeat.outside-expected.txt:
* canvas/2d.pattern.paint.repeatx.basic-expected.txt:
* canvas/2d.pattern.paint.repeaty.basic-expected.txt:
* canvas/resources/background.png: Added.
* canvas/resources/green-16x16.png: Added.
* common/canvas-tests.css:
LayoutTests:
Fix some failures in the imported W3C canvas tests. These failures were happening because
of missing images or missing new lines at the end of the expected results.
* TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatbasicexpectedtxt">trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.basic-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatoutsideexpectedtxt">trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.outside-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatxbasicexpectedtxt">trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeatx.basic-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatybasicexpectedtxt">trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeaty.basic-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3ccommoncanvastestscss">trunk/LayoutTests/imported/w3c/common/canvas-tests.css</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3ccanvasresourcesbackgroundpng">trunk/LayoutTests/imported/w3c/canvas/resources/background.png</a></li>
<li><a href="#trunkLayoutTestsimportedw3ccanvasresourcesgreen16x16png">trunk/LayoutTests/imported/w3c/canvas/resources/green-16x16.png</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/ChangeLog 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-01-13 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Missed images and missed new lines in the expected results of the imported w3c canvas layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=140409.
+
+ Reviewed by Dean Jackson.
+
+ Fix some failures in the imported W3C canvas tests. These failures were happening because
+ of missing images or missing new lines at the end of the expected results.
+
+ * TestExpectations:
+
</ins><span class="cx"> 2015-01-13 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Filters aren't applied to elements in columns after the first
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/TestExpectations 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -225,7 +225,6 @@
</span><span class="cx"> webkit.org/b/137883 transitions/transition-timing-function.html [ Pass Failure ]
</span><span class="cx">
</span><span class="cx"> # Imported W3C canvas failed tests
</span><del>-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeaty.basic.html [ Failure ]
</del><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.pattern.image.null.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.pattern.image.incomplete.omitted.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.drawImage.null.html [ Failure ]
</span><span class="lines">@@ -239,14 +238,12 @@
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.fillStyle.parse.rgb-eof.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.imageData.put.null.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/security.pattern.image.strokeStyle.html [ Failure ]
</span><del>-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeat.basic.html [ Failure ]
</del><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.imageData.get.nonfinite.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.line.cap.round.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.gradient.object.invalidoffset.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/security.pattern.canvas.strokeStyle.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.gradient.radial.nonfinite.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.imageData.object.ctor.html [ Failure ]
</span><del>-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeatx.basic.html [ Failure ]
</del><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.drawImage.incomplete.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.imageData.create2.nonfinite.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.composite.operation.clear.html [ Failure ]
</span><span class="lines">@@ -255,7 +252,6 @@
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.drawImage.broken.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.imageData.create1.zero.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.gradient.linear.nonfinite.html [ Failure ]
</span><del>-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeat.outside.html [ Failure ]
</del><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/2d.fillStyle.parse.rgba-eof.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/security.drawImage.canvas.html [ Failure ]
</span><span class="cx"> webkit.org/b/138676 imported/w3c/canvas/security.pattern.image.fillStyle.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-01-13 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Missed images and missed new lines in the expected results of the imported w3c canvas layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=140409.
+
+ Reviewed by Dean Jackson.
+
+ Fix some failures in the imported W3C canvas tests. These failures were happening because
+ of missing images or missing new lines at the end of the expected results.
+
+ * canvas/2d.pattern.paint.repeat.basic-expected.txt:
+ * canvas/2d.pattern.paint.repeat.outside-expected.txt:
+ * canvas/2d.pattern.paint.repeatx.basic-expected.txt:
+ * canvas/2d.pattern.paint.repeaty.basic-expected.txt:
+ * canvas/resources/background.png: Added.
+ * canvas/resources/green-16x16.png: Added.
+ * common/canvas-tests.css:
+
</ins><span class="cx"> 2014-11-14 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Import w3c tests for canvas
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatbasicexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.basic-expected.txt (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.basic-expected.txt 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.basic-expected.txt 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -4,3 +4,4 @@
</span><span class="cx"> Expected output:
</span><span class="cx">
</span><span class="cx"> Passed
</span><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatoutsideexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.outside-expected.txt (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.outside-expected.txt 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.outside-expected.txt 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -4,3 +4,4 @@
</span><span class="cx"> Expected output:
</span><span class="cx">
</span><span class="cx"> Passed
</span><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatxbasicexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeatx.basic-expected.txt (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeatx.basic-expected.txt 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeatx.basic-expected.txt 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -4,3 +4,4 @@
</span><span class="cx"> Expected output:
</span><span class="cx">
</span><span class="cx"> Passed
</span><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3ccanvas2dpatternpaintrepeatybasicexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeaty.basic-expected.txt (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeaty.basic-expected.txt 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeaty.basic-expected.txt 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -4,3 +4,4 @@
</span><span class="cx"> Expected output:
</span><span class="cx">
</span><span class="cx"> Passed
</span><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3ccanvasresourcesbackgroundpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/imported/w3c/canvas/resources/background.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/imported/w3c/canvas/resources/background.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsimportedw3ccanvasresourcesgreen16x16png"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/imported/w3c/canvas/resources/green-16x16.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/imported/w3c/canvas/resources/green-16x16.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsimportedw3ccommoncanvastestscss"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/common/canvas-tests.css (178385 => 178386)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/common/canvas-tests.css 2015-01-13 23:35:20 UTC (rev 178385)
+++ trunk/LayoutTests/imported/w3c/common/canvas-tests.css 2015-01-13 23:49:33 UTC (rev 178386)
</span><span class="lines">@@ -70,13 +70,13 @@
</span><span class="cx"> display: none;
</span><span class="cx"> visibility: hidden;
</span><span class="cx"> border: 2px #f0f solid;
</span><del>- background: url(../images/background.png);
</del><ins>+ background: url(../resources/background.png);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> img.expected {
</span><span class="cx"> display: none;
</span><span class="cx"> border: 2px #f0f solid;
</span><del>- background: url(../images/background.png);
</del><ins>+ background: url(../resources/background.png);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> iframe {
</span></span></pre>
</div>
</div>
</body>
</html>