<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178285] trunk/Source/WebKit/mac</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178285">178285</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2015-01-12 10:41:38 -0800 (Mon, 12 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Delegates should be formal protocols
https://bugs.webkit.org/show_bug.cgi?id=140360
rdar://problem/17380856
Reviewed by Dan Bernstein.
This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
* DefaultDelegates/WebDefaultUIDelegate.h:
* Misc/WebDownload.h:
* WebView/WebEditingDelegate.h:
* WebView/WebFrameLoadDelegate.h:
* WebView/WebPolicyDelegate.h:
* WebView/WebUIDelegate.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacDefaultDelegatesWebDefaultUIDelegateh">trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.h</a></li>
<li><a href="#trunkSourceWebKitmacMiscWebDownloadh">trunk/Source/WebKit/mac/Misc/WebDownload.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebEditingDelegateh">trunk/Source/WebKit/mac/WebView/WebEditingDelegate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebFrameLoadDelegateh">trunk/Source/WebKit/mac/WebView/WebFrameLoadDelegate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPolicyDelegateh">trunk/Source/WebKit/mac/WebView/WebPolicyDelegate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebUIDelegateh">trunk/Source/WebKit/mac/WebView/WebUIDelegate.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (178284 => 178285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-01-12 18:26:11 UTC (rev 178284)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-01-12 18:41:38 UTC (rev 178285)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-01-12 Anders Carlsson <andersca@apple.com>
+
+ Delegates should be formal protocols
+ https://bugs.webkit.org/show_bug.cgi?id=140360
+ rdar://problem/17380856
+
+ Reviewed by Dan Bernstein.
+
+ This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
+
+ * DefaultDelegates/WebDefaultUIDelegate.h:
+ * Misc/WebDownload.h:
+ * WebView/WebEditingDelegate.h:
+ * WebView/WebFrameLoadDelegate.h:
+ * WebView/WebPolicyDelegate.h:
+ * WebView/WebUIDelegate.h:
+
</ins><span class="cx"> 2015-01-09 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Get rid of the database strategy
</span></span></pre></div>
<a id="trunkSourceWebKitmacDefaultDelegatesWebDefaultUIDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.h (178284 => 178285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.h 2015-01-12 18:26:11 UTC (rev 178284)
+++ trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.h 2015-01-12 18:41:38 UTC (rev 178285)
</span><span class="lines">@@ -26,9 +26,9 @@
</span><span class="cx"> * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#import <Foundation/Foundation.h>
</del><ins>+#import "WebUIDelegate.h"
</ins><span class="cx">
</span><del>-@interface WebDefaultUIDelegate : NSObject
</del><ins>+@interface WebDefaultUIDelegate : NSObject <WebUIDelegate>
</ins><span class="cx"> {
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> IBOutlet NSMenu *defaultMenu;
</span></span></pre></div>
<a id="trunkSourceWebKitmacMiscWebDownloadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Misc/WebDownload.h (178284 => 178285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Misc/WebDownload.h 2015-01-12 18:26:11 UTC (rev 178284)
+++ trunk/Source/WebKit/mac/Misc/WebDownload.h 2015-01-12 18:41:38 UTC (rev 178285)
</span><span class="lines">@@ -66,8 +66,10 @@
</span><span class="cx"> @discussion The WebDownloadDelegate delegate has one extra method used to choose
</span><span class="cx"> the right window when automatically prompting with a sheet.
</span><span class="cx"> */
</span><del>-@interface NSObject (WebDownloadDelegate)
</del><ins>+@protocol WebDownloadDelegate <NSURLDownloadDelegate>
</ins><span class="cx">
</span><ins>+@optional
+
</ins><span class="cx"> /*!
</span><span class="cx"> @method downloadWindowForAuthenticationSheet:
</span><span class="cx"> @abstract
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebEditingDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebEditingDelegate.h (178284 => 178285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebEditingDelegate.h 2015-01-12 18:26:11 UTC (rev 178284)
+++ trunk/Source/WebKit/mac/WebView/WebEditingDelegate.h 2015-01-12 18:41:38 UTC (rev 178285)
</span><span class="lines">@@ -44,7 +44,10 @@
</span><span class="cx"> WebViewInsertActionDropped,
</span><span class="cx"> };
</span><span class="cx">
</span><del>-@interface NSObject (WebViewEditingDelegate)
</del><ins>+@protocol WebEditingDelegate <NSObject>
+
+@optional
+
</ins><span class="cx"> - (BOOL)webView:(WebView *)webView shouldBeginEditingInDOMRange:(DOMRange *)range;
</span><span class="cx"> - (BOOL)webView:(WebView *)webView shouldEndEditingInDOMRange:(DOMRange *)range;
</span><span class="cx"> - (BOOL)webView:(WebView *)webView shouldInsertNode:(DOMNode *)node replacingDOMRange:(DOMRange *)range givenAction:(WebViewInsertAction)action;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebFrameLoadDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebFrameLoadDelegate.h (178284 => 178285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebFrameLoadDelegate.h 2015-01-12 18:26:11 UTC (rev 178284)
+++ trunk/Source/WebKit/mac/WebView/WebFrameLoadDelegate.h 2015-01-12 18:41:38 UTC (rev 178285)
</span><span class="lines">@@ -50,8 +50,10 @@
</span><span class="cx"> Once at least one byte is received, the data source is considered "committed". This is done
</span><span class="cx"> so the contents of the frame will not be lost if the new data source fails to successfully load.
</span><span class="cx"> */
</span><del>-@interface NSObject (WebFrameLoadDelegate)
</del><ins>+@protocol WebFrameLoadDelegate <NSObject>
</ins><span class="cx">
</span><ins>+@optional
+
</ins><span class="cx"> /*!
</span><span class="cx"> @method webView:didStartProvisionalLoadForFrame:
</span><span class="cx"> @abstract Notifies the delegate that the provisional load of a frame has started
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPolicyDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPolicyDelegate.h (178284 => 178285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPolicyDelegate.h 2015-01-12 18:26:11 UTC (rev 178284)
+++ trunk/Source/WebKit/mac/WebView/WebPolicyDelegate.h 2015-01-12 18:41:38 UTC (rev 178285)
</span><span class="lines">@@ -137,8 +137,10 @@
</span><span class="cx"> documents come in one navigation, with each replacing the last. In
</span><span class="cx"> this case, conent policy will be checked for each one.
</span><span class="cx"> */
</span><del>-@interface NSObject (WebPolicyDelegate)
</del><ins>+@protocol WebPolicyDelegate <NSObject>
</ins><span class="cx">
</span><ins>+@optional
+
</ins><span class="cx"> /*!
</span><span class="cx"> @method webView:decidePolicyForNavigationAction:request:frame:decisionListener:
</span><span class="cx"> @abstract This method is called to decide what to do with a proposed navigation.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebUIDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebUIDelegate.h (178284 => 178285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebUIDelegate.h 2015-01-12 18:26:11 UTC (rev 178284)
+++ trunk/Source/WebKit/mac/WebView/WebUIDelegate.h 2015-01-12 18:41:38 UTC (rev 178285)
</span><span class="lines">@@ -160,8 +160,10 @@
</span><span class="cx"> other aspects of web pages. These methods are used to open new
</span><span class="cx"> windows and control aspects of existing windows.
</span><span class="cx"> */
</span><del>-@interface NSObject (WebUIDelegate)
</del><ins>+@protocol WebUIDelegate <NSObject>
</ins><span class="cx">
</span><ins>+@optional
+
</ins><span class="cx"> /*!
</span><span class="cx"> @method webView:createWebViewWithRequest:
</span><span class="cx"> @abstract Create a new window and begin to load the specified request.
</span></span></pre>
</div>
</div>
</body>
</html>