<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178257] releases/WebKitGTK/webkit-2.6</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178257">178257</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-01-12 06:13:51 -0800 (Mon, 12 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/176311">r176311</a> - start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
https://bugs.webkit.org/show_bug.cgi?id=138739
Reviewed by Darin Adler.
Source/WebCore:
The patch is inspired by the following Blink revision by
<rtoy@google.com>:
<https://src.chromium.org/viewvc/blink?view=rev&revision=160845>
Test: webaudio/dom-exceptions.html
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::start):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::noteGrainOn):
(WebCore::AudioBufferSourceNode::startGrain): Deleted.
* Modules/webaudio/AudioBufferSourceNode.h:
* Modules/webaudio/AudioBufferSourceNode.idl:
* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):
* Modules/webaudio/AudioScheduledSourceNode.h:
* Modules/webaudio/OscillatorNode.idl:
LayoutTests:
* webaudio/dom-exceptions-expected.txt: Added.
* webaudio/dom-exceptions.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit26LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioBufferSourceNodecpp">releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioBufferSourceNodeh">releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioBufferSourceNodeidl">releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioScheduledSourceNodecpp">releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioScheduledSourceNodeh">releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioOscillatorNodeidl">releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/OscillatorNode.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit26LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-11-18 Philippe Normand <pnormand@igalia.com>
+
+ start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
+ https://bugs.webkit.org/show_bug.cgi?id=138739
+
+ Reviewed by Darin Adler.
+
+ * webaudio/dom-exceptions-expected.txt: Added.
+ * webaudio/dom-exceptions.html: Added.
+
</ins><span class="cx"> 2014-11-18 Joanmarie Diggs <jdiggs@igalia.com>
</span><span class="cx">
</span><span class="cx"> AX: [ATK] Crash getting the orientation of a MenuListOption after the MenuList was removed from the document
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -1,5 +1,31 @@
</span><span class="cx"> 2014-11-18 Philippe Normand <pnormand@igalia.com>
</span><span class="cx">
</span><ins>+ start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
+ https://bugs.webkit.org/show_bug.cgi?id=138739
+
+ Reviewed by Darin Adler.
+
+ The patch is inspired by the following Blink revision by
+ <rtoy@google.com>:
+ <https://src.chromium.org/viewvc/blink?view=rev&revision=160845>
+
+ Test: webaudio/dom-exceptions.html
+
+ * Modules/webaudio/AudioBufferSourceNode.cpp:
+ (WebCore::AudioBufferSourceNode::start):
+ (WebCore::AudioBufferSourceNode::startPlaying):
+ (WebCore::AudioBufferSourceNode::noteGrainOn):
+ (WebCore::AudioBufferSourceNode::startGrain): Deleted.
+ * Modules/webaudio/AudioBufferSourceNode.h:
+ * Modules/webaudio/AudioBufferSourceNode.idl:
+ * Modules/webaudio/AudioScheduledSourceNode.cpp:
+ (WebCore::AudioScheduledSourceNode::start):
+ (WebCore::AudioScheduledSourceNode::stop):
+ * Modules/webaudio/AudioScheduledSourceNode.h:
+ * Modules/webaudio/OscillatorNode.idl:
+
+2014-11-18 Philippe Normand <pnormand@igalia.com>
+
</ins><span class="cx"> HRTFDatabaseLoader is not an absolute condition to run audioContext
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=138829
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioBufferSourceNodecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -370,14 +370,28 @@
</span><span class="cx"> return output(0)->numberOfChannels();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AudioBufferSourceNode::startGrain(double when, double grainOffset, ExceptionCode& ec)
</del><ins>+void AudioBufferSourceNode::start(ExceptionCode& ec)
</ins><span class="cx"> {
</span><del>- // Duration of 0 has special value, meaning calculate based on the entire buffer's duration.
- startGrain(when, grainOffset, 0, ec);
</del><ins>+ startPlaying(Entire, 0, 0, buffer() ? buffer()->duration() : 0, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void AudioBufferSourceNode::startGrain(double when, double grainOffset, double grainDuration, ExceptionCode& ec)
</del><ins>+void AudioBufferSourceNode::start(double when, ExceptionCode& ec)
</ins><span class="cx"> {
</span><ins>+ startPlaying(Entire, when, 0, buffer() ? buffer()->duration() : 0, ec);
+}
+
+void AudioBufferSourceNode::start(double when, double grainOffset, ExceptionCode& ec)
+{
+ startPlaying(Partial, when, grainOffset, 0, ec);
+}
+
+void AudioBufferSourceNode::start(double when, double grainOffset, double grainDuration, ExceptionCode& ec)
+{
+ startPlaying(Partial, when, grainOffset, grainDuration, ec);
+}
+
+void AudioBufferSourceNode::startPlaying(BufferPlaybackMode playbackMode, double when, double grainOffset, double grainDuration, ExceptionCode& ec)
+{
</ins><span class="cx"> ASSERT(isMainThread());
</span><span class="cx">
</span><span class="cx"> if (ScriptController::processingUserGesture())
</span><span class="lines">@@ -388,26 +402,38 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if (!std::isfinite(when) || (when < 0)) {
+ ec = INVALID_STATE_ERR;
+ return;
+ }
+
+ if (!std::isfinite(grainOffset) || (grainOffset < 0)) {
+ ec = INVALID_STATE_ERR;
+ return;
+ }
+
+ if (!std::isfinite(grainDuration) || (grainDuration < 0)) {
+ ec = INVALID_STATE_ERR;
+ return;
+ }
+
</ins><span class="cx"> if (!buffer())
</span><span class="cx"> return;
</span><del>-
- // Do sanity checking of grain parameters versus buffer size.
- double bufferDuration = buffer()->duration();
</del><span class="cx">
</span><del>- grainOffset = std::max(0.0, grainOffset);
- grainOffset = std::min(bufferDuration, grainOffset);
- m_grainOffset = grainOffset;
</del><ins>+ m_isGrain = playbackMode == Partial;
+ if (m_isGrain) {
+ // Do sanity checking of grain parameters versus buffer size.
+ double bufferDuration = buffer()->duration();
</ins><span class="cx">
</span><del>- // Handle default/unspecified duration.
- double maxDuration = bufferDuration - grainOffset;
- if (!grainDuration)
- grainDuration = maxDuration;
</del><ins>+ m_grainOffset = std::min(bufferDuration, grainOffset);
</ins><span class="cx">
</span><del>- grainDuration = std::max(0.0, grainDuration);
- grainDuration = std::min(maxDuration, grainDuration);
- m_grainDuration = grainDuration;
</del><ins>+ double maxDuration = bufferDuration - m_grainOffset;
+ m_grainDuration = std::min(maxDuration, grainDuration);
+ } else {
+ m_grainOffset = 0.0;
+ m_grainDuration = DefaultGrainDuration;
+ }
</ins><span class="cx">
</span><del>- m_isGrain = true;
</del><span class="cx"> m_startTime = when;
</span><span class="cx">
</span><span class="cx"> // We call timeToSampleFrame here since at playbackRate == 1 we don't want to go through linear interpolation
</span><span class="lines">@@ -422,7 +448,10 @@
</span><span class="cx"> #if ENABLE(LEGACY_WEB_AUDIO)
</span><span class="cx"> void AudioBufferSourceNode::noteGrainOn(double when, double grainOffset, double grainDuration, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- startGrain(when, grainOffset, grainDuration, ec);
</del><ins>+ // Handle unspecified duration where 0 means the rest of the buffer.
+ if (!grainDuration)
+ grainDuration = buffer()->duration();
+ startPlaying(Partial, when, grainOffset, grainDuration, ec);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioBufferSourceNodeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -63,8 +63,10 @@
</span><span class="cx"> unsigned numberOfChannels();
</span><span class="cx">
</span><span class="cx"> // Play-state
</span><del>- void startGrain(double when, double grainOffset, ExceptionCode&);
- void startGrain(double when, double grainOffset, double grainDuration, ExceptionCode&);
</del><ins>+ void start(ExceptionCode&);
+ void start(double when, ExceptionCode&);
+ void start(double when, double grainOffset, ExceptionCode&);
+ void start(double when, double grainOffset, double grainDuration, ExceptionCode&);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(LEGACY_WEB_AUDIO)
</span><span class="cx"> void noteGrainOn(double when, double grainOffset, double grainDuration, ExceptionCode&);
</span><span class="lines">@@ -105,6 +107,13 @@
</span><span class="cx"> virtual double tailTime() const override { return 0; }
</span><span class="cx"> virtual double latencyTime() const override { return 0; }
</span><span class="cx">
</span><ins>+ enum BufferPlaybackMode {
+ Entire,
+ Partial
+ };
+
+ void startPlaying(BufferPlaybackMode, double when, double grainOffset, double grainDuration, ExceptionCode&);
+
</ins><span class="cx"> // Returns true on success.
</span><span class="cx"> bool renderFromBuffer(AudioBus*, unsigned destinationFrameOffset, size_t numberOfFrames);
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioBufferSourceNodeidl"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -44,10 +44,8 @@
</span><span class="cx"> attribute unrestricted double loopStart;
</span><span class="cx"> attribute unrestricted double loopEnd;
</span><span class="cx">
</span><del>- [RaisesException] void start(unrestricted double when);
- [ImplementedAs=startGrain, RaisesException] void start(unrestricted double when, unrestricted double grainOffset);
- [ImplementedAs=startGrain, RaisesException] void start(unrestricted double when, unrestricted double grainOffset, unrestricted double grainDuration);
- [RaisesException] void stop(unrestricted double when);
</del><ins>+ [RaisesException] void start(optional unrestricted double when, optional unrestricted double grainOffset, optional unrestricted double grainDuration);
+ [RaisesException] void stop(optional unrestricted double when);
</ins><span class="cx">
</span><span class="cx"> [Conditional=LEGACY_WEB_AUDIO] attribute boolean looping; // This is an alias for the .loop attribute for backwards compatibility.
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioScheduledSourceNodecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -137,6 +137,11 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void AudioScheduledSourceNode::start(ExceptionCode& ec)
+{
+ start(0, ec);
+}
+
</ins><span class="cx"> void AudioScheduledSourceNode::start(double when, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(isMainThread());
</span><span class="lines">@@ -149,10 +154,20 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if (!std::isfinite(when) || (when < 0)) {
+ ec = INVALID_STATE_ERR;
+ return;
+ }
+
</ins><span class="cx"> m_startTime = when;
</span><span class="cx"> m_playbackState = SCHEDULED_STATE;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void AudioScheduledSourceNode::stop(ExceptionCode& ec)
+{
+ stop(0, ec);
+}
+
</ins><span class="cx"> void AudioScheduledSourceNode::stop(double when, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(isMainThread());
</span><span class="lines">@@ -160,8 +175,12 @@
</span><span class="cx"> ec = INVALID_STATE_ERR;
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>-
- when = std::max<double>(0, when);
</del><ins>+
+ if (!std::isfinite(when) || (when < 0)) {
+ ec = INVALID_STATE_ERR;
+ return;
+ }
+
</ins><span class="cx"> m_endTime = when;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioAudioScheduledSourceNodeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -58,6 +58,8 @@
</span><span class="cx"> AudioScheduledSourceNode(AudioContext*, float sampleRate);
</span><span class="cx">
</span><span class="cx"> // Scheduling.
</span><ins>+ void start(ExceptionCode&);
+ void stop(ExceptionCode&);
</ins><span class="cx"> void start(double when, ExceptionCode&);
</span><span class="cx"> void stop(double when, ExceptionCode&);
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreModuleswebaudioOscillatorNodeidl"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/OscillatorNode.idl (178256 => 178257)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/OscillatorNode.idl 2015-01-12 14:06:41 UTC (rev 178256)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/Modules/webaudio/OscillatorNode.idl 2015-01-12 14:13:51 UTC (rev 178257)
</span><span class="lines">@@ -48,8 +48,8 @@
</span><span class="cx"> readonly attribute AudioParam frequency; // in Hertz
</span><span class="cx"> readonly attribute AudioParam detune; // in Cents
</span><span class="cx">
</span><del>- [RaisesException] void start(unrestricted double when);
- [RaisesException] void stop(unrestricted double when);
</del><ins>+ [RaisesException] void start(optional unrestricted double when);
+ [RaisesException] void stop(optional unrestricted double when);
</ins><span class="cx">
</span><span class="cx"> [Conditional=LEGACY_WEB_AUDIO, RaisesException] void noteOn(unrestricted double when);
</span><span class="cx"> [Conditional=LEGACY_WEB_AUDIO, RaisesException] void noteOff(unrestricted double when);
</span></span></pre>
</div>
</div>
</body>
</html>