<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178177] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178177">178177</a></dd>
<dt>Author</dt> <dd>ossy@webkit.org</dd>
<dt>Date</dt> <dd>2015-01-09 11:27:50 -0800 (Fri, 09 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/177925">r177925</a>): It broke the !ENABLE(INSPECTOR) build
https://bugs.webkit.org/show_bug.cgi?id=140098
Reviewed by Brian Burg.
Source/JavaScriptCore:
* inspector/InspectorBackendDispatcher.h: Missing ENABLE(INSPECTOR) guard added.
Source/WebCore:
* inspector/InspectorInstrumentationCookie.cpp: Removed ENABLE(INSPECTOR) guard,
becaue InspectorInstrumentationCookie is used everywhere unconditionally.
* inspector/InspectorInstrumentationCookie.h: Removed ENABLE(INSPECTOR) guard.
* loader/appcache/ApplicationCacheGroup.h: Removed ENABLE(INSPECTOR) guard around
m_currentResourceIdentifier, because it is used unconditionally in the cpp.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorInspectorBackendDispatcherh">trunk/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationCookiecpp">trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationCookieh">trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.h</a></li>
<li><a href="#trunkSourceWebCoreloaderappcacheApplicationCacheGrouph">trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (178176 => 178177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-01-09 18:58:29 UTC (rev 178176)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-01-09 19:27:50 UTC (rev 178177)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-01-09 Csaba Osztrogonác <ossy@webkit.org>
+
+ REGRESSION(r177925): It broke the !ENABLE(INSPECTOR) build
+ https://bugs.webkit.org/show_bug.cgi?id=140098
+
+ Reviewed by Brian Burg.
+
+ * inspector/InspectorBackendDispatcher.h: Missing ENABLE(INSPECTOR) guard added.
+
</ins><span class="cx"> 2015-01-08 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Argument object created by "Function dot arguments" should use a clone of the argument values.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorInspectorBackendDispatcherh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h (178176 => 178177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h 2015-01-09 18:58:29 UTC (rev 178176)
+++ trunk/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h 2015-01-09 19:27:50 UTC (rev 178177)
</span><span class="lines">@@ -27,6 +27,8 @@
</span><span class="cx"> #ifndef InspectorBackendDispatcher_h
</span><span class="cx"> #define InspectorBackendDispatcher_h
</span><span class="cx">
</span><ins>+#if ENABLE(INSPECTOR)
+
</ins><span class="cx"> #include "InspectorProtocolTypes.h"
</span><span class="cx"> #include <wtf/PassRefPtr.h>
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="lines">@@ -104,4 +106,5 @@
</span><span class="cx">
</span><span class="cx"> } // namespace Inspector
</span><span class="cx">
</span><ins>+#endif // ENABLE(INSPECTOR)
</ins><span class="cx"> #endif // !defined(InspectorBackendDispatcher_h)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (178176 => 178177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-01-09 18:58:29 UTC (rev 178176)
+++ trunk/Source/WebCore/ChangeLog 2015-01-09 19:27:50 UTC (rev 178177)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-01-09 Csaba Osztrogonác <ossy@webkit.org>
+
+ REGRESSION(r177925): It broke the !ENABLE(INSPECTOR) build
+ https://bugs.webkit.org/show_bug.cgi?id=140098
+
+ Reviewed by Brian Burg.
+
+ * inspector/InspectorInstrumentationCookie.cpp: Removed ENABLE(INSPECTOR) guard,
+ becaue InspectorInstrumentationCookie is used everywhere unconditionally.
+ * inspector/InspectorInstrumentationCookie.h: Removed ENABLE(INSPECTOR) guard.
+ * loader/appcache/ApplicationCacheGroup.h: Removed ENABLE(INSPECTOR) guard around
+ m_currentResourceIdentifier, because it is used unconditionally in the cpp.
+
</ins><span class="cx"> 2015-01-09 Byungseon Shin <sun.shin@lge.com>
</span><span class="cx">
</span><span class="cx"> [EFL] Fix crash introduced in r178029
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationCookiecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.cpp (178176 => 178177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.cpp 2015-01-09 18:58:29 UTC (rev 178176)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.cpp 2015-01-09 19:27:50 UTC (rev 178177)
</span><span class="lines">@@ -31,8 +31,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "InspectorInstrumentationCookie.h"
</span><span class="cx">
</span><del>-#if ENABLE(INSPECTOR)
-
</del><span class="cx"> #include "InstrumentingAgents.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -69,5 +67,3 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span><del>-
-#endif // ENABLE(INSPECTOR)
</del></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationCookieh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.h (178176 => 178177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.h 2015-01-09 18:58:29 UTC (rev 178176)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentationCookie.h 2015-01-09 19:27:50 UTC (rev 178177)
</span><span class="lines">@@ -33,8 +33,6 @@
</span><span class="cx">
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="cx">
</span><del>-#if ENABLE(INSPECTOR)
-
</del><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> class InspectorInstrumentation;
</span><span class="lines">@@ -59,6 +57,4 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><del>-#endif // ENABLE(INSPECTOR)
-
</del><span class="cx"> #endif // InspectorInstrumentationCookie_h
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderappcacheApplicationCacheGrouph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.h (178176 => 178177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.h 2015-01-09 18:58:29 UTC (rev 178176)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.h 2015-01-09 19:27:50 UTC (rev 178177)
</span><span class="lines">@@ -189,10 +189,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<ResourceHandle> m_currentHandle;
</span><span class="cx"> RefPtr<ApplicationCacheResource> m_currentResource;
</span><del>-
-#if ENABLE(INSPECTOR)
</del><span class="cx"> unsigned long m_currentResourceIdentifier;
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> RefPtr<ApplicationCacheResource> m_manifestResource;
</span><span class="cx"> RefPtr<ResourceHandle> m_manifestHandle;
</span></span></pre>
</div>
</div>
</body>
</html>