<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178167] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178167">178167</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-01-09 03:48:28 -0800 (Fri, 09 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add a script to check for platform layering violations
https://bugs.webkit.org/show_bug.cgi?id=140248
Reviewed by Darin Adler.
It prints all the cases where files inside platform include
headers that are not in platform directory.
* Scripts/check-for-platform-layering-violations: Added.
(get_platform_headers):
(check_source_file):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkToolsScriptscheckforplatformlayeringviolations">trunk/Tools/Scripts/check-for-platform-layering-violations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (178166 => 178167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-01-09 11:46:50 UTC (rev 178166)
+++ trunk/Tools/ChangeLog 2015-01-09 11:48:28 UTC (rev 178167)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Add a script to check for platform layering violations
+ https://bugs.webkit.org/show_bug.cgi?id=140248
+
+ Reviewed by Darin Adler.
+
+ It prints all the cases where files inside platform include
+ headers that are not in platform directory.
+
+ * Scripts/check-for-platform-layering-violations: Added.
+ (get_platform_headers):
+ (check_source_file):
+
</ins><span class="cx"> 2015-01-08 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac WK2] Test snapshots are 1600x1200 on Retina devices
</span></span></pre></div>
<a id="trunkToolsScriptscheckforplatformlayeringviolations"></a>
<div class="addfile"><h4>Added: trunk/Tools/Scripts/check-for-platform-layering-violations (0 => 178167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/check-for-platform-layering-violations (rev 0)
+++ trunk/Tools/Scripts/check-for-platform-layering-violations 2015-01-09 11:48:28 UTC (rev 178167)
</span><span class="lines">@@ -0,0 +1,79 @@
</span><ins>+#!/usr/bin/env python
+#
+# Copyright (C) 2015 Igalia S.L.
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Library General Public
+# License as published by the Free Software Foundation; either
+# version 2 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# Library General Public License for more details.
+#
+# You should have received a copy of the GNU Library General Public License
+# along with this library; see the file COPYING.LIB. If not, write to
+# the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+# Boston, MA 02110-1301, USA.
+
+import os, sys
+from webkitpy.common.host import Host
+
+PLATFORM_GENERATED_HEADERS = ("HTTPHeaderNames.h")
+
+def get_platform_headers(platform_dir):
+ platform_headers = ["config.h"]
+ for root, dirs, files in os.walk(platform_dir):
+ for file_name in files:
+ if file_name.endswith(".h"):
+ platform_headers.append(file_name)
+
+ return platform_headers
+
+def check_source_file(source_file, checkout_root, platform_headers):
+ failures_found = 0
+ line_count = 0
+ f = open(source_file, 'r')
+ for line in f.readlines():
+ line_count += 1
+ if line[0] != '#':
+ continue
+
+ tokens = line.split(' ')
+ if tokens[0] not in ('#include', '#import'):
+ continue
+
+ header = tokens[1]
+ if header[0] != '"':
+ continue
+
+ header = header[1:header.rfind('"')]
+ if not header.endswith('.h'):
+ continue
+
+ if header not in platform_headers and header not in PLATFORM_GENERATED_HEADERS:
+ print "ERROR: %s:%d %s" % (source_file[len(checkout_root) + 1:], line_count, line.strip('\n'))
+ failures_found += 1
+
+ f.close()
+
+ return failures_found
+
+host = Host()
+host.initialize_scm()
+checkout_root = host.scm().checkout_root
+platform_dir = os.path.join(checkout_root, "Source", "WebCore", "platform")
+platform_headers = get_platform_headers(platform_dir)
+
+layering_violations_count = 0
+for root, dirs, files in os.walk(platform_dir):
+ for file_name in files:
+ if os.path.splitext(file_name)[1] in ('.cpp', '.mm'):
+ layering_violations_count += check_source_file(os.path.join(root, file_name), checkout_root, platform_headers)
+
+if layering_violations_count:
+ print "Total: %d layering violations found in %s" % (layering_violations_count, platform_dir[len(checkout_root) + 1:])
+ sys.exit(1)
+
+sys.exit(0)
</ins><span class="cx">Property changes on: trunk/Tools/Scripts/check-for-platform-layering-violations
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
</div>
</body>
</html>