<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178171] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178171">178171</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2015-01-09 07:29:09 -0800 (Fri, 09 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Crash at -[WebAccessibilityObjectWrapperBase accessibilityTitle] + 31
https://bugs.webkit.org/show_bug.cgi?id=140286
Reviewed by Mario Sanchez Prada.
This is crashing because AppKit is checking if certain method names like "accessibilityTitle" exist,
and then it bypasses accessibilityAttributeValue: to call directly into those methods.
That bypasses are safety checks. I think a safe way to avoid this is rename our methods.
No new tests, problem only occurs when triggered through AppKit.
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
* accessibility/mac/WebAccessibilityObjectWrapperBase.h:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase baseAccessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityHelpText]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]): Deleted.
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]): Deleted.
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]): Deleted.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperBaseh">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperBasemm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (178170 => 178171)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-01-09 13:50:07 UTC (rev 178170)
+++ trunk/Source/WebCore/ChangeLog 2015-01-09 15:29:09 UTC (rev 178171)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2015-01-09 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Crash at -[WebAccessibilityObjectWrapperBase accessibilityTitle] + 31
+ https://bugs.webkit.org/show_bug.cgi?id=140286
+
+ Reviewed by Mario Sanchez Prada.
+
+ This is crashing because AppKit is checking if certain method names like "accessibilityTitle" exist,
+ and then it bypasses accessibilityAttributeValue: to call directly into those methods.
+
+ That bypasses are safety checks. I think a safe way to avoid this is rename our methods.
+
+ No new tests, problem only occurs when triggered through AppKit.
+
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityLabel]):
+ (-[WebAccessibilityObjectWrapper accessibilityHint]):
+ * accessibility/mac/WebAccessibilityObjectWrapperBase.h:
+ * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
+ (-[WebAccessibilityObjectWrapperBase baseAccessibilityTitle]):
+ (-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):
+ (-[WebAccessibilityObjectWrapperBase baseAccessibilityHelpText]):
+ (-[WebAccessibilityObjectWrapperBase accessibilityTitle]): Deleted.
+ (-[WebAccessibilityObjectWrapperBase accessibilityDescription]): Deleted.
+ (-[WebAccessibilityObjectWrapperBase accessibilityHelpText]): Deleted.
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
</ins><span class="cx"> 2015-01-06 Philippe Normand <pnormand@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GStreamer][MSE] ASSERT in MediaSourceClientGStreamer::addSourceBuffer
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (178170 => 178171)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2015-01-09 13:50:07 UTC (rev 178170)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2015-01-09 15:29:09 UTC (rev 178171)
</span><span class="lines">@@ -780,8 +780,8 @@
</span><span class="cx">
</span><span class="cx"> // iOS doesn't distinguish between a title and description field,
</span><span class="cx"> // so concatentation will yield the best result.
</span><del>- NSString *axTitle = [self accessibilityTitle];
- NSString *axDescription = [self accessibilityDescription];
</del><ins>+ NSString *axTitle = [self baseAccessibilityTitle];
+ NSString *axDescription = [self baseAccessibilityDescription];
</ins><span class="cx"> NSString *landmarkDescription = [self ariaLandmarkRoleDescription];
</span><span class="cx">
</span><span class="cx"> NSMutableString *result = [NSMutableString string];
</span><span class="lines">@@ -1011,7 +1011,7 @@
</span><span class="cx"> if (![self _prepareAccessibilityCall])
</span><span class="cx"> return nil;
</span><span class="cx">
</span><del>- return [self accessibilityHelpText];
</del><ins>+ return [self baseAccessibilityHelpText];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (NSURL *)accessibilityURL
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h (178170 => 178171)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h 2015-01-09 13:50:07 UTC (rev 178170)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h 2015-01-09 15:29:09 UTC (rev 178171)
</span><span class="lines">@@ -48,9 +48,10 @@
</span><span class="cx"> - (WebCore::AccessibilityObject*)accessibilityObject;
</span><span class="cx"> - (BOOL)updateObjectBackingStore;
</span><span class="cx">
</span><del>-- (NSString *)accessibilityTitle;
-- (NSString *)accessibilityDescription;
-- (NSString *)accessibilityHelpText;
</del><ins>+// These are pre-fixed with base so that AppKit does not end up calling into these directly (bypassing safety checks).
+- (NSString *)baseAccessibilityTitle;
+- (NSString *)baseAccessibilityDescription;
+- (NSString *)baseAccessibilityHelpText;
</ins><span class="cx">
</span><span class="cx"> - (NSString *)ariaLandmarkRoleDescription;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperBasemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm (178170 => 178171)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm 2015-01-09 13:50:07 UTC (rev 178170)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm 2015-01-09 15:29:09 UTC (rev 178171)
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx">
</span><span class="cx"> // This should be the "visible" text that's actually on the screen if possible.
</span><span class="cx"> // If there's alternative text, that can override the title.
</span><del>-- (NSString *)accessibilityTitle
</del><ins>+- (NSString *)baseAccessibilityTitle
</ins><span class="cx"> {
</span><span class="cx"> // Static text objects should not have a title. Its content is communicated in its AXValue.
</span><span class="cx"> if (m_object->roleValue() == StaticTextRole)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> return [NSString string];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (NSString *)accessibilityDescription
</del><ins>+- (NSString *)baseAccessibilityDescription
</ins><span class="cx"> {
</span><span class="cx"> // Static text objects should not have a description. Its content is communicated in its AXValue.
</span><span class="cx"> // One exception is the media control labels that have a value and a description. Those are set programatically.
</span><span class="lines">@@ -212,7 +212,7 @@
</span><span class="cx"> return [NSString string];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (NSString *)accessibilityHelpText
</del><ins>+- (NSString *)baseAccessibilityHelpText
</ins><span class="cx"> {
</span><span class="cx"> Vector<AccessibilityText> textOrder;
</span><span class="cx"> m_object->accessibilityText(textOrder);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (178170 => 178171)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-01-09 13:50:07 UTC (rev 178170)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-01-09 15:29:09 UTC (rev 178171)
</span><span class="lines">@@ -2417,7 +2417,7 @@
</span><span class="cx"> if (m_object->isMeter())
</span><span class="cx"> return [NSString string];
</span><span class="cx">
</span><del>- return [self accessibilityTitle];
</del><ins>+ return [self baseAccessibilityTitle];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ([attributeName isEqualToString: NSAccessibilityDescriptionAttribute]) {
</span><span class="lines">@@ -2425,7 +2425,7 @@
</span><span class="cx"> if ([[[self attachmentView] accessibilityAttributeNames] containsObject:NSAccessibilityDescriptionAttribute])
</span><span class="cx"> return [[self attachmentView] accessibilityAttributeValue:NSAccessibilityDescriptionAttribute];
</span><span class="cx"> }
</span><del>- return [self accessibilityDescription];
</del><ins>+ return [self baseAccessibilityDescription];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ([attributeName isEqualToString: NSAccessibilityValueAttribute]) {
</span><span class="lines">@@ -2490,7 +2490,7 @@
</span><span class="cx"> return [NSNumber numberWithFloat:m_object->maxValueForRange()];
</span><span class="cx">
</span><span class="cx"> if ([attributeName isEqualToString: NSAccessibilityHelpAttribute])
</span><del>- return [self accessibilityHelpText];
</del><ins>+ return [self baseAccessibilityHelpText];
</ins><span class="cx">
</span><span class="cx"> if ([attributeName isEqualToString: NSAccessibilityFocusedAttribute])
</span><span class="cx"> return [NSNumber numberWithBool: m_object->isFocused()];
</span><span class="lines">@@ -2794,7 +2794,7 @@
</span><span class="cx">
</span><span class="cx"> if ([attributeName isEqualToString:NSAccessibilityValueDescriptionAttribute]) {
</span><span class="cx"> if (m_object->isMeter())
</span><del>- return [self accessibilityTitle];
</del><ins>+ return [self baseAccessibilityTitle];
</ins><span class="cx">
</span><span class="cx"> return m_object->valueDescription();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>