<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178063] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178063">178063</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2015-01-07 15:56:01 -0800 (Wed, 07 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update css3/flexbox/auto-margins.html after <a href="http://trac.webkit.org/projects/webkit/changeset/177774">r177774</a>
https://bugs.webkit.org/show_bug.cgi?id=139975
Patch by Myles C. Maxfield <litherum@gmail.com> on 2015-01-07
Reviewed by Darin Adler.
This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire
box and therefore does all its math in floating point, while the
-expected uses the regular renderer hierarchy and therefore fixed-point
math. This patch updates the test to use Ahem so that the character
widths divide the same way in both cases.
* css3/flexbox/auto-margins-expected.html:
* css3/flexbox/auto-margins.html:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestscss3flexboxautomarginsexpectedhtml">trunk/LayoutTests/css3/flexbox/auto-margins-expected.html</a></li>
<li><a href="#trunkLayoutTestscss3flexboxautomarginshtml">trunk/LayoutTests/css3/flexbox/auto-margins.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (178062 => 178063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-07 23:50:17 UTC (rev 178062)
+++ trunk/LayoutTests/ChangeLog 2015-01-07 23:56:01 UTC (rev 178063)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-01-07 Myles C. Maxfield <litherum@gmail.com>
+
+ Update css3/flexbox/auto-margins.html after r177774
+ https://bugs.webkit.org/show_bug.cgi?id=139975
+
+ Reviewed by Darin Adler.
+
+ This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire
+ box and therefore does all its math in floating point, while the
+ -expected uses the regular renderer hierarchy and therefore fixed-point
+ math. This patch updates the test to use Ahem so that the character
+ widths divide the same way in both cases.
+
+ * css3/flexbox/auto-margins-expected.html:
+ * css3/flexbox/auto-margins.html:
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2015-01-07 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Unreviewed test gardening (writing-mode).
</span></span></pre></div>
<a id="trunkLayoutTestscss3flexboxautomarginsexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/css3/flexbox/auto-margins-expected.html (178062 => 178063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/flexbox/auto-margins-expected.html 2015-01-07 23:50:17 UTC (rev 178062)
+++ trunk/LayoutTests/css3/flexbox/auto-margins-expected.html 2015-01-07 23:56:01 UTC (rev 178063)
</span><span class="lines">@@ -16,13 +16,13 @@
</span><span class="cx"> <body>
</span><span class="cx"> <p>These tests are from the spec: <a href="http://dev.w3.org/csswg/css3-flexbox/#auto-margins">http://dev.w3.org/csswg/css3-flexbox/#auto-margins</a>.</p>
</span><span class="cx">
</span><del>-<p>The word OK should be centered vertically and horizontally.</p>
</del><ins>+<p>A black box should be centered vertically and horizontally.</p>
</ins><span class="cx"> <div style="width: 4em; height: 4em; background: silver">
</span><del>- <table style="width: 100%; height: 100%;"><tr><td style="text-align: center">OK</td></tr></table>
</del><ins>+ <table style="width: 100%; height: 100%;"><tr><td style="text-align: center; font-family: Ahem;">OK</td></tr></table>
</ins><span class="cx"> </div>
</span><span class="cx">
</span><span class="cx"> <div style="width: 4em; height: 4em; margin-top: 10px; background: silver; -webkit-writing-mode: vertical-rl">
</span><del>- <table style="width: 100%; height: 100%;"><tr><td style="text-align: center">OK</td></tr></table>
</del><ins>+ <table style="width: 100%; height: 100%;"><tr><td style="text-align: center; font-family: Ahem;">OK</td></tr></table>
</ins><span class="cx"> </div>
</span><span class="cx">
</span><span class="cx"> <p>You should see 3 blue concentric circles.</p>
</span></span></pre></div>
<a id="trunkLayoutTestscss3flexboxautomarginshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/css3/flexbox/auto-margins.html (178062 => 178063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/flexbox/auto-margins.html 2015-01-07 23:50:17 UTC (rev 178062)
+++ trunk/LayoutTests/css3/flexbox/auto-margins.html 2015-01-07 23:56:01 UTC (rev 178063)
</span><span class="lines">@@ -23,13 +23,13 @@
</span><span class="cx"> <body>
</span><span class="cx"> <p>These tests are from the spec: <a href="http://dev.w3.org/csswg/css3-flexbox/#auto-margins">http://dev.w3.org/csswg/css3-flexbox/#auto-margins</a>.</p>
</span><span class="cx">
</span><del>-<p>The word OK should be centered vertically and horizontally.</p>
</del><ins>+<p>A black box should be centered vertically and horizontally.</p>
</ins><span class="cx"> <div class="flexbox" style="width: 4em; height: 4em; background: silver">
</span><del>- <p id="ok" style="margin: auto;">OK</p>
</del><ins>+ <p id="ok" style="margin: auto; font-family: Ahem;">OK</p>
</ins><span class="cx"> </div>
</span><span class="cx">
</span><span class="cx"> <div class="flexbox" style="width: 4em; height: 4em; margin-top: 10px; background: silver; -webkit-writing-mode: vertical-rl">
</span><del>- <p id="okVertical" style="margin: auto;">OK</p>
</del><ins>+ <p id="okVertical" style="margin: auto; font-family: Ahem;">OK</p>
</ins><span class="cx"> </div>
</span><span class="cx">
</span><span class="cx"> <p>You should see 3 blue concentric circles.</p>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (178062 => 178063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-01-07 23:50:17 UTC (rev 178062)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-01-07 23:56:01 UTC (rev 178063)
</span><span class="lines">@@ -1339,7 +1339,6 @@
</span><span class="cx">
</span><span class="cx"> # Kerning, Ligatures, and Printer Fonts caused these tests to fail
</span><span class="cx"> # The following tests are reftests
</span><del>-webkit.org/b/139968 css3/flexbox/auto-margins.html [ ImageOnlyFailure ]
</del><span class="cx"> webkit.org/b/139968 css3/flexbox/csswg/flexbox_direction-row-reverse.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/139968 fast/box-decoration-break/box-decoration-break-rendering.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/139968 fast/css-generated-content/after-with-inline-continuation.html [ ImageOnlyFailure ]
</span></span></pre>
</div>
</div>
</body>
</html>