<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178006] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178006">178006</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2015-01-06 16:34:17 -0800 (Tue, 06 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Allow MathML in dashboard compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=140153
Reviewed by Alexey Proskuryakov.
Source/WebCore:
In what seems like an accident due to the way we used to disable SVG in
dashboard, MathML has been disable in dashboard compatibility mode. There
does not seem to be any reason to keep this accidental quirk.
Test: mathml/mathml-in-dashboard.html
* dom/make_names.pl:
(printFactoryCppFile):
LayoutTests:
* mathml/mathml-in-dashboard-expected.txt: Added.
* mathml/mathml-in-dashboard.html: Added.
* platform/mac/mathml/mathml-in-dashboard-expected.png: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredommake_namespl">trunk/Source/WebCore/dom/make_names.pl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmathmlmathmlindashboardexpectedtxt">trunk/LayoutTests/mathml/mathml-in-dashboard-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmathmlmathmlindashboardhtml">trunk/LayoutTests/mathml/mathml-in-dashboard.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacmathmlmathmlindashboardexpectedpng">trunk/LayoutTests/platform/mac/mathml/mathml-in-dashboard-expected.png</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (178005 => 178006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-07 00:26:01 UTC (rev 178005)
+++ trunk/LayoutTests/ChangeLog 2015-01-07 00:34:17 UTC (rev 178006)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-01-06 Sam Weinig <sam@webkit.org>
+
+ Allow MathML in dashboard compatibility mode
+ https://bugs.webkit.org/show_bug.cgi?id=140153
+
+ Reviewed by Alexey Proskuryakov.
+
+ * mathml/mathml-in-dashboard-expected.txt: Added.
+ * mathml/mathml-in-dashboard.html: Added.
+ * platform/mac/mathml/mathml-in-dashboard-expected.png: Added.
+
</ins><span class="cx"> 2015-01-06 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix this test to wait for the load event before dumping. Expected image
</span></span></pre></div>
<a id="trunkLayoutTestsmathmlmathmlindashboardexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/mathml/mathml-in-dashboard-expected.txt (0 => 178006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/mathml/mathml-in-dashboard-expected.txt (rev 0)
+++ trunk/LayoutTests/mathml/mathml-in-dashboard-expected.txt 2015-01-07 00:34:17 UTC (rev 178006)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x36
+ RenderText {#text} at (0,0) size 664x36
+ text run at (0,0) width 214: "This tests that MathML works in "
+ text run at (213,0) width 451: "dashboard compatibility mode. The render tree dump should include a"
+ text run at (0,18) width 142: "RenderMathMLMath."
+ RenderBlock (anonymous) at (0,52) size 784x0
+ RenderMathMLMath {math} at (0,0) size 2x0 [padding: 0 1 0 1]
+ RenderText {#text} at (0,0) size 0x0
</ins></span></pre></div>
<a id="trunkLayoutTestsmathmlmathmlindashboardhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/mathml/mathml-in-dashboard.html (0 => 178006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/mathml/mathml-in-dashboard.html (rev 0)
+++ trunk/LayoutTests/mathml/mathml-in-dashboard.html 2015-01-07 00:34:17 UTC (rev 178006)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+<script>
+ if (window.testRunner)
+ testRunner.setUseDashboardCompatibilityMode(true);
+
+</script>
+<p>This tests that MathML works in dashboard compatibility mode. The render tree dump should include a RenderMathMLMath.</p>
+<math></math>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacmathmlmathmlindashboardexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/platform/mac/mathml/mathml-in-dashboard-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/platform/mac/mathml/mathml-in-dashboard-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (178005 => 178006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-01-07 00:26:01 UTC (rev 178005)
+++ trunk/Source/WebCore/ChangeLog 2015-01-07 00:34:17 UTC (rev 178006)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-01-06 Sam Weinig <sam@webkit.org>
+
+ Allow MathML in dashboard compatibility mode
+ https://bugs.webkit.org/show_bug.cgi?id=140153
+
+ Reviewed by Alexey Proskuryakov.
+
+ In what seems like an accident due to the way we used to disable SVG in
+ dashboard, MathML has been disable in dashboard compatibility mode. There
+ does not seem to be any reason to keep this accidental quirk.
+
+ Test: mathml/mathml-in-dashboard.html
+
+ * dom/make_names.pl:
+ (printFactoryCppFile):
+
</ins><span class="cx"> 2015-01-06 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Some composting reflections tests are broken
</span></span></pre></div>
<a id="trunkSourceWebCoredommake_namespl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/make_names.pl (178005 => 178006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/make_names.pl 2015-01-07 00:26:01 UTC (rev 178005)
+++ trunk/Source/WebCore/dom/make_names.pl 2015-01-07 00:34:17 UTC (rev 178006)
</span><span class="lines">@@ -991,21 +991,6 @@
</span><span class="cx">
</span><span class="cx"> $smartPointerType<$parameters{namespace}Element> $parameters{namespace}ElementFactory::createElement(const QualifiedName& name, Document& document$formElementArgumentForDefinition, bool createdByParser)
</span><span class="cx"> {
</span><del>-END
- ;
-
- if ($parameters{namespace} ne "HTML" and $parameters{namespace} ne "SVG") {
- print F <<END
-#if ENABLE(DASHBOARD_SUPPORT)
- Settings* settings = document.settings();
- if (settings && settings->usesDashboardBackwardCompatibilityMode())
- return 0;
-#endif
-END
- ;
- }
-
- print F <<END
</del><span class="cx"> static NeverDestroyed<HashMap<AtomicStringImpl*, $parameters{namespace}ConstructorFunction>> functions;
</span><span class="cx"> if (functions.get().isEmpty())
</span><span class="cx"> populate$parameters{namespace}FactoryMap(functions);
</span></span></pre>
</div>
</div>
</body>
</html>