<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178009] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178009">178009</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-01-06 17:22:09 -0800 (Tue, 06 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Assertion in RenderGeometryMap::mapToContainer with LayoutUnit overflow.
https://bugs.webkit.org/show_bug.cgi?id=108619
rdar://problem/19391214
Use only FloatQuad in RenderGeometryMap::mapToContainer.
Due to the difference in the internal representation of FloatRect and FloatQuad,
with certain float values, converting FloatRect to FloatQuad and back
to FloatRect could produce a slightly different rect.
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/block/geometry-map-assertion-with-tall-content.html
* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
LayoutTests:
* fast/block/geometry-map-assertion-with-tall-content-expected.txt: Added.
* fast/block/geometry-map-assertion-with-tall-content.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderGeometryMapcpp">trunk/Source/WebCore/rendering/RenderGeometryMap.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastblockgeometrymapassertionwithtallcontentexpectedtxt">trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastblockgeometrymapassertionwithtallcontenthtml">trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (178008 => 178009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-07 01:03:25 UTC (rev 178008)
+++ trunk/LayoutTests/ChangeLog 2015-01-07 01:22:09 UTC (rev 178009)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-01-06 Zalan Bujtas <zalan@apple.com>
+
+ Assertion in RenderGeometryMap::mapToContainer with LayoutUnit overflow.
+ https://bugs.webkit.org/show_bug.cgi?id=108619
+ rdar://problem/19391214
+
+ Use only FloatQuad in RenderGeometryMap::mapToContainer.
+
+ Due to the difference in the internal representation of FloatRect and FloatQuad,
+ with certain float values, converting FloatRect to FloatQuad and back
+ to FloatRect could produce a slightly different rect.
+
+ Reviewed by Simon Fraser.
+
+ * fast/block/geometry-map-assertion-with-tall-content-expected.txt: Added.
+ * fast/block/geometry-map-assertion-with-tall-content.html: Added.
+
</ins><span class="cx"> 2015-01-06 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Allow MathML in dashboard compatibility mode
</span></span></pre></div>
<a id="trunkLayoutTestsfastblockgeometrymapassertionwithtallcontentexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content-expected.txt (0 => 178009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content-expected.txt 2015-01-07 01:22:09 UTC (rev 178009)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+PASS if no assert or crash in debug build.
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastblockgeometrymapassertionwithtallcontenthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content.html (0 => 178009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content.html (rev 0)
+++ trunk/LayoutTests/fast/block/geometry-map-assertion-with-tall-content.html 2015-01-07 01:22:09 UTC (rev 178009)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+<div>PASS if no assert or crash in debug build.</div>
+<pre>foo</pre>
+<style>
+pre {
+ margin: 446607073px;
+ outline: solid 3px black;
+ overflow: auto;
+}
+</style>
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (178008 => 178009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-01-07 01:03:25 UTC (rev 178008)
+++ trunk/Source/WebCore/ChangeLog 2015-01-07 01:22:09 UTC (rev 178009)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-01-06 Zalan Bujtas <zalan@apple.com>
+
+ Assertion in RenderGeometryMap::mapToContainer with LayoutUnit overflow.
+ https://bugs.webkit.org/show_bug.cgi?id=108619
+ rdar://problem/19391214
+
+ Use only FloatQuad in RenderGeometryMap::mapToContainer.
+
+ Due to the difference in the internal representation of FloatRect and FloatQuad,
+ with certain float values, converting FloatRect to FloatQuad and back
+ to FloatRect could produce a slightly different rect.
+
+ Reviewed by Simon Fraser.
+
+ Test: fast/block/geometry-map-assertion-with-tall-content.html
+
+ * rendering/RenderGeometryMap.cpp:
+ (WebCore::RenderGeometryMap::mapToContainer):
+
</ins><span class="cx"> 2015-01-06 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Allow MathML in dashboard compatibility mode
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderGeometryMapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderGeometryMap.cpp (178008 => 178009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderGeometryMap.cpp 2015-01-07 01:03:25 UTC (rev 178008)
+++ trunk/Source/WebCore/rendering/RenderGeometryMap.cpp 2015-01-07 01:22:09 UTC (rev 178009)
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx">
</span><span class="cx"> FloatQuad RenderGeometryMap::mapToContainer(const FloatRect& rect, const RenderLayerModelObject* container) const
</span><span class="cx"> {
</span><del>- FloatRect result;
</del><ins>+ FloatQuad result;
</ins><span class="cx">
</span><span class="cx"> if (!hasFixedPositionStep() && !hasTransformStep() && !hasNonUniformStep() && (!container || (m_mapping.size() && container == m_mapping[0].m_renderer))) {
</span><span class="cx"> result = rect;
</span><span class="lines">@@ -131,14 +131,14 @@
</span><span class="cx"> } else {
</span><span class="cx"> TransformState transformState(TransformState::ApplyTransformDirection, rect.center(), rect);
</span><span class="cx"> mapToContainer(transformState, container);
</span><del>- result = transformState.lastPlanarQuad().boundingBox();
</del><ins>+ result = transformState.lastPlanarQuad();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if !ASSERT_DISABLED
</span><span class="cx"> FloatRect rendererMappedResult = m_mapping.last().m_renderer->localToContainerQuad(rect, container, m_mapCoordinatesFlags).boundingBox();
</span><span class="cx"> // Inspector creates renderers with negative width <https://bugs.webkit.org/show_bug.cgi?id=87194>.
</span><span class="cx"> // Taking FloatQuad bounds avoids spurious assertions because of that.
</span><del>- ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()));
</del><ins>+ ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(result.boundingBox()));
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> return result;
</span></span></pre>
</div>
</div>
</body>
</html>