<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177905] releases/WebKitGTK/webkit-2.4</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177905">177905</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-01-05 03:34:37 -0800 (Mon, 05 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/175809">r175809</a> - Crash in WebCore::Node::getFlag
https://bugs.webkit.org/show_bug.cgi?id=137961
Reviewed by Antti Koivisto.
Source/WebCore:
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle): Null pointer check added.
LayoutTests:
* editing/execCommand/crash-137961-expected.txt: Added.
* editing/execCommand/crash-137961.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreeditingApplyStyleCommandcpp">releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/ApplyStyleCommand.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestseditingexecCommandcrash137961expectedtxt">releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestseditingexecCommandcrash137961html">releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit24LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog (177904 => 177905)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2015-01-05 11:28:05 UTC (rev 177904)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2015-01-05 11:34:37 UTC (rev 177905)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-11-10 Csaba Osztrogonác <ossy@webkit.org>
+
+ Crash in WebCore::Node::getFlag
+ https://bugs.webkit.org/show_bug.cgi?id=137961
+
+ Reviewed by Antti Koivisto.
+
+ * editing/execCommand/crash-137961-expected.txt: Added.
+ * editing/execCommand/crash-137961.html: Added.
+
</ins><span class="cx"> 2014-04-25 Miyoung Shin <myid.shin@samsung.com>
</span><span class="cx">
</span><span class="cx"> Web process is crashed during dispatching touchEvent created by JS.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestseditingexecCommandcrash137961expectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961-expected.txt (0 => 177905)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961-expected.txt 2015-01-05 11:34:37 UTC (rev 177905)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+Test for bug Crash in WebCore::Node::getFlag
+
+This test passes if it doesn't crash.
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestseditingexecCommandcrash137961html"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961.html (0 => 177905)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/editing/execCommand/crash-137961.html 2015-01-05 11:34:37 UTC (rev 177905)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<!DOCTYPE html>
+<html contenteditable>
+<head>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+function test() {
+ document.execCommand("selectAll", false, null);
+ document.execCommand("createlink", true, "http://www.example.com");
+ document.execCommand("removeFormat", false, null);
+ document.write("<p>Test for bug <a href=\"https://bugs.webkit.org/show_bug.cgi?id=137961\">Crash in WebCore::Node::getFlag</a></p>");
+ document.write("<p>This test passes if it doesn't crash.</p>");
+}
+</script>
+<style>
+* {
+ display:table-row-group;
+}
+</style>
+</head>
+<body onload='test();' hidden>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (177904 => 177905)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2015-01-05 11:28:05 UTC (rev 177904)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2015-01-05 11:34:37 UTC (rev 177905)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-11-10 Csaba Osztrogonác <ossy@webkit.org>
+
+ Crash in WebCore::Node::getFlag
+ https://bugs.webkit.org/show_bug.cgi?id=137961
+
+ Reviewed by Antti Koivisto.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyBlockStyle): Null pointer check added.
+
</ins><span class="cx"> 2014-11-11 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Protect Document in ProcessingInstruction::setXSLStyleSheet()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreeditingApplyStyleCommandcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/ApplyStyleCommand.cpp (177904 => 177905)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/ApplyStyleCommand.cpp 2015-01-05 11:28:05 UTC (rev 177904)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/ApplyStyleCommand.cpp 2015-01-05 11:34:37 UTC (rev 177905)
</span><span class="lines">@@ -267,6 +267,9 @@
</span><span class="cx"> #else
</span><span class="cx"> Node* scope = highestEditableRoot(visibleStart.deepEquivalent());
</span><span class="cx"> #endif
</span><ins>+ if (!scope)
+ return;
+
</ins><span class="cx"> RefPtr<Range> startRange = Range::create(document(), firstPositionInNode(scope), visibleStart.deepEquivalent().parentAnchoredEquivalent());
</span><span class="cx"> RefPtr<Range> endRange = Range::create(document(), firstPositionInNode(scope), visibleEnd.deepEquivalent().parentAnchoredEquivalent());
</span><span class="cx"> int startIndex = TextIterator::rangeLength(startRange.get(), true);
</span></span></pre>
</div>
</div>
</body>
</html>