<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177875] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177875">177875</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2015-01-04 12:14:45 -0800 (Sun, 04 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up some of the IPC code
https://bugs.webkit.org/show_bug.cgi?id=140057
Reviewed by Antti Koivisto.
Use std::mutex instead of WTF::Mutex. Change a couple of pointers to references in the connection client.
* DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):
* DatabaseProcess/DatabaseProcess.h:
* DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::didClose):
(WebKit::DatabaseToWebProcessConnection::didReceiveInvalidMessage):
* DatabaseProcess/DatabaseToWebProcessConnection.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):
* NetworkProcess/NetworkProcess.h:
* Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessage):
(IPC::Connection::waitForMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::sendOutgoingMessages):
(IPC::Connection::dispatchDidReceiveInvalidMessage):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchOneMessage):
* Platform/IPC/Connection.h:
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didClose):
(WebKit::PluginProcess::didReceiveInvalidMessage):
* PluginProcess/PluginProcess.h:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didClose):
(WebKit::WebProcessConnection::didReceiveInvalidMessage):
* PluginProcess/WebProcessConnection.h:
* UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::didClose):
(WebKit::DatabaseProcessProxy::didReceiveInvalidMessage):
* UIProcess/Databases/DatabaseProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didClose):
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
* UIProcess/WebProcessProxy.h:
* WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::didReceiveInvalidMessage):
* WebProcess/Databases/WebToDatabaseProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::didReceiveInvalidMessage):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didClose):
(WebKit::PluginProcessConnection::didReceiveInvalidMessage):
* WebProcess/Plugins/PluginProcessConnection.h:
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/WebInspectorUI.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::didReceiveInvalidMessage):
* WebProcess/WebProcess.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2DatabaseProcessDatabaseProcesscpp">trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2DatabaseProcessDatabaseProcessh">trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.h</a></li>
<li><a href="#trunkSourceWebKit2DatabaseProcessDatabaseToWebProcessConnectioncpp">trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.cpp</a></li>
<li><a href="#trunkSourceWebKit2DatabaseProcessDatabaseToWebProcessConnectionh">trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkConnectionToWebProcesscpp">trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkConnectionToWebProcessh">trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkProcesscpp">trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkProcessh">trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h</a></li>
<li><a href="#trunkSourceWebKit2PlatformIPCConnectioncpp">trunk/Source/WebKit2/Platform/IPC/Connection.cpp</a></li>
<li><a href="#trunkSourceWebKit2PlatformIPCConnectionh">trunk/Source/WebKit2/Platform/IPC/Connection.h</a></li>
<li><a href="#trunkSourceWebKit2PluginProcessPluginProcesscpp">trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2PluginProcessPluginProcessh">trunk/Source/WebKit2/PluginProcess/PluginProcess.h</a></li>
<li><a href="#trunkSourceWebKit2PluginProcessWebProcessConnectioncpp">trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp</a></li>
<li><a href="#trunkSourceWebKit2PluginProcessWebProcessConnectionh">trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxycpp">trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxyh">trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessNetworkNetworkProcessProxycpp">trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessNetworkNetworkProcessProxyh">trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPluginsPluginProcessProxycpp">trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPluginsPluginProcessProxyh">trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessProxycpp">trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessProxyh">trunk/Source/WebKit2/UIProcess/WebProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessDatabasesWebToDatabaseProcessConnectioncpp">trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessDatabasesWebToDatabaseProcessConnectionh">trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessNetworkNetworkProcessConnectioncpp">trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessNetworkNetworkProcessConnectionh">trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPluginProcessConnectioncpp">trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPluginProcessConnectionh">trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorh">trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorUIh">trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcesscpp">trunk/Source/WebKit2/WebProcess/WebProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcessh">trunk/Source/WebKit2/WebProcess/WebProcess.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/ChangeLog 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -1,3 +1,81 @@
</span><ins>+2015-01-04 Anders Carlsson <andersca@apple.com>
+
+ Clean up some of the IPC code
+ https://bugs.webkit.org/show_bug.cgi?id=140057
+
+ Reviewed by Antti Koivisto.
+
+ Use std::mutex instead of WTF::Mutex. Change a couple of pointers to references in the connection client.
+
+ * DatabaseProcess/DatabaseProcess.cpp:
+ (WebKit::DatabaseProcess::didClose):
+ (WebKit::DatabaseProcess::didReceiveInvalidMessage):
+ * DatabaseProcess/DatabaseProcess.h:
+ * DatabaseProcess/DatabaseToWebProcessConnection.cpp:
+ (WebKit::DatabaseToWebProcessConnection::didClose):
+ (WebKit::DatabaseToWebProcessConnection::didReceiveInvalidMessage):
+ * DatabaseProcess/DatabaseToWebProcessConnection.h:
+ * NetworkProcess/NetworkConnectionToWebProcess.cpp:
+ (WebKit::NetworkConnectionToWebProcess::didClose):
+ (WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):
+ * NetworkProcess/NetworkConnectionToWebProcess.h:
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::didClose):
+ (WebKit::NetworkProcess::didReceiveInvalidMessage):
+ * NetworkProcess/NetworkProcess.h:
+ * Platform/IPC/Connection.cpp:
+ (IPC::Connection::sendMessage):
+ (IPC::Connection::waitForMessage):
+ (IPC::Connection::connectionDidClose):
+ (IPC::Connection::sendOutgoingMessages):
+ (IPC::Connection::dispatchDidReceiveInvalidMessage):
+ (IPC::Connection::enqueueIncomingMessage):
+ (IPC::Connection::dispatchMessage):
+ (IPC::Connection::dispatchOneMessage):
+ * Platform/IPC/Connection.h:
+ * PluginProcess/PluginProcess.cpp:
+ (WebKit::PluginProcess::didClose):
+ (WebKit::PluginProcess::didReceiveInvalidMessage):
+ * PluginProcess/PluginProcess.h:
+ * PluginProcess/WebProcessConnection.cpp:
+ (WebKit::WebProcessConnection::didClose):
+ (WebKit::WebProcessConnection::didReceiveInvalidMessage):
+ * PluginProcess/WebProcessConnection.h:
+ * UIProcess/Databases/DatabaseProcessProxy.cpp:
+ (WebKit::DatabaseProcessProxy::didClose):
+ (WebKit::DatabaseProcessProxy::didReceiveInvalidMessage):
+ * UIProcess/Databases/DatabaseProcessProxy.h:
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::didClose):
+ (WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
+ * UIProcess/Network/NetworkProcessProxy.h:
+ * UIProcess/Plugins/PluginProcessProxy.cpp:
+ (WebKit::PluginProcessProxy::didClose):
+ (WebKit::PluginProcessProxy::didReceiveInvalidMessage):
+ * UIProcess/Plugins/PluginProcessProxy.h:
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::didClose):
+ (WebKit::WebProcessProxy::didReceiveInvalidMessage):
+ * UIProcess/WebProcessProxy.h:
+ * WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
+ (WebKit::WebToDatabaseProcessConnection::didClose):
+ (WebKit::WebToDatabaseProcessConnection::didReceiveInvalidMessage):
+ * WebProcess/Databases/WebToDatabaseProcessConnection.h:
+ * WebProcess/Network/NetworkProcessConnection.cpp:
+ (WebKit::NetworkProcessConnection::didClose):
+ (WebKit::NetworkProcessConnection::didReceiveInvalidMessage):
+ * WebProcess/Network/NetworkProcessConnection.h:
+ * WebProcess/Plugins/PluginProcessConnection.cpp:
+ (WebKit::PluginProcessConnection::didClose):
+ (WebKit::PluginProcessConnection::didReceiveInvalidMessage):
+ * WebProcess/Plugins/PluginProcessConnection.h:
+ * WebProcess/WebPage/WebInspector.h:
+ * WebProcess/WebPage/WebInspectorUI.h:
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::didClose):
+ (WebKit::WebProcess::didReceiveInvalidMessage):
+ * WebProcess/WebProcess.h:
+
</ins><span class="cx"> 2015-01-01 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove GroupSettings
</span></span></pre></div>
<a id="trunkSourceWebKit2DatabaseProcessDatabaseProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseProcess::didClose(IPC::Connection*)
</del><ins>+void DatabaseProcess::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> RunLoop::current().stop();
</span><span class="cx"> }
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseProcess::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void DatabaseProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> RunLoop::current().stop();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2DatabaseProcessDatabaseProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -80,8 +80,8 @@
</span><span class="cx">
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx"> void didReceiveDatabaseProcessMessage(IPC::Connection*, IPC::MessageDecoder&);
</span><span class="cx">
</span><span class="cx"> // Message Handlers
</span></span></pre></div>
<a id="trunkSourceWebKit2DatabaseProcessDatabaseToWebProcessConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -81,14 +81,14 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseToWebProcessConnection::didClose(IPC::Connection*)
</del><ins>+void DatabaseToWebProcessConnection::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // The WebProcess has disconnected, close all of the connections associated with it
</span><span class="cx"> while (!m_idbConnections.isEmpty())
</span><span class="cx"> removeDatabaseProcessIDBConnection(m_idbConnections.begin()->key);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseToWebProcessConnection::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</del><ins>+void DatabaseToWebProcessConnection::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</ins><span class="cx"> {
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2DatabaseProcessDatabaseToWebProcessConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -49,8 +49,8 @@
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx"> void didReceiveDatabaseToWebProcessConnectionMessage(IPC::Connection*, IPC::MessageDecoder&);
</span><span class="cx">
</span><span class="cx"> // IPC::MessageSender
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkConnectionToWebProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkConnectionToWebProcess::didClose(IPC::Connection*)
</del><ins>+void NetworkConnectionToWebProcess::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // Protect ourself as we might be otherwise be deleted during this function.
</span><span class="cx"> Ref<NetworkConnectionToWebProcess> protector(*this);
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> NetworkProcess::shared().removeNetworkConnectionToWebProcess(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkConnectionToWebProcess::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void NetworkConnectionToWebProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkConnectionToWebProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -63,8 +63,8 @@
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&);
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&);
</span><del>- virtual void didClose(IPC::Connection*);
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName);
</del><ins>+ virtual void didClose(IPC::Connection&);
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName);
</ins><span class="cx">
</span><span class="cx"> // Message handlers.
</span><span class="cx"> void didReceiveNetworkConnectionToWebProcessMessage(IPC::Connection*, IPC::MessageDecoder&);
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -124,13 +124,13 @@
</span><span class="cx"> messageReceiverMap().dispatchSyncMessage(connection, decoder, replyEncoder);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcess::didClose(IPC::Connection*)
</del><ins>+void NetworkProcess::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // The UIProcess just exited.
</span><span class="cx"> RunLoop::current().stop();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcess::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void NetworkProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> RunLoop::current().stop();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -97,8 +97,8 @@
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // DownloadManager::Client
</span><span class="cx"> virtual void didCreateDownload() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformIPCConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Platform/IPC/Connection.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Platform/IPC/Connection.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/Platform/IPC/Connection.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -376,7 +376,7 @@
</span><span class="cx"> encoder->setShouldDispatchMessageWhenWaitingForSyncReply(true);
</span><span class="cx">
</span><span class="cx"> {
</span><del>- MutexLocker locker(m_outgoingMessagesLock);
</del><ins>+ std::lock_guard<std::mutex> lock(m_outgoingMessagesMutex);
</ins><span class="cx"> m_outgoingMessages.append(WTF::move(encoder));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -396,7 +396,7 @@
</span><span class="cx">
</span><span class="cx"> // First, check if this message is already in the incoming messages queue.
</span><span class="cx"> {
</span><del>- MutexLocker locker(m_incomingMessagesLock);
</del><ins>+ std::lock_guard<std::mutex> lock(m_incomingMessagesMutex);
</ins><span class="cx">
</span><span class="cx"> for (auto it = m_incomingMessages.begin(), end = m_incomingMessages.end(); it != end; ++it) {
</span><span class="cx"> std::unique_ptr<MessageDecoder>& message = *it;
</span><span class="lines">@@ -724,7 +724,7 @@
</span><span class="cx"> Client* client = connection->m_client;
</span><span class="cx"> connection->m_client = nullptr;
</span><span class="cx">
</span><del>- client->didClose(connection.get());
</del><ins>+ client->didClose(*connection);
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -742,7 +742,7 @@
</span><span class="cx"> std::unique_ptr<MessageEncoder> message;
</span><span class="cx">
</span><span class="cx"> {
</span><del>- MutexLocker locker(m_outgoingMessagesLock);
</del><ins>+ std::lock_guard<std::mutex> lock(m_outgoingMessagesMutex);
</ins><span class="cx"> if (m_outgoingMessages.isEmpty())
</span><span class="cx"> break;
</span><span class="cx"> message = m_outgoingMessages.takeFirst();
</span><span class="lines">@@ -783,7 +783,7 @@
</span><span class="cx"> if (!m_client)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- m_client->didReceiveInvalidMessage(this, StringReference(messageReceiverNameString.data(), messageReceiverNameString.length()), StringReference(messageNameString.data(), messageNameString.length()));
</del><ins>+ m_client->didReceiveInvalidMessage(*this, StringReference(messageReceiverNameString.data(), messageReceiverNameString.length()), StringReference(messageNameString.data(), messageNameString.length()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Connection::didFailToSendSyncMessage()
</span><span class="lines">@@ -797,7 +797,7 @@
</span><span class="cx"> void Connection::enqueueIncomingMessage(std::unique_ptr<MessageDecoder> incomingMessage)
</span><span class="cx"> {
</span><span class="cx"> {
</span><del>- MutexLocker locker(m_incomingMessagesLock);
</del><ins>+ std::lock_guard<std::mutex> lock(m_incomingMessagesMutex);
</ins><span class="cx"> m_incomingMessages.append(WTF::move(incomingMessage));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -836,7 +836,7 @@
</span><span class="cx"> m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount--;
</span><span class="cx">
</span><span class="cx"> if (m_didReceiveInvalidMessage && m_client)
</span><del>- m_client->didReceiveInvalidMessage(this, message->messageReceiverName(), message->messageName());
</del><ins>+ m_client->didReceiveInvalidMessage(*this, message->messageReceiverName(), message->messageName());
</ins><span class="cx">
</span><span class="cx"> m_didReceiveInvalidMessage = oldDidReceiveInvalidMessage;
</span><span class="cx"> }
</span><span class="lines">@@ -846,7 +846,7 @@
</span><span class="cx"> std::unique_ptr<MessageDecoder> message;
</span><span class="cx">
</span><span class="cx"> {
</span><del>- MutexLocker locker(m_incomingMessagesLock);
</del><ins>+ std::lock_guard<std::mutex> lock(m_incomingMessagesMutex);
</ins><span class="cx"> if (m_incomingMessages.isEmpty())
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformIPCConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Platform/IPC/Connection.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Platform/IPC/Connection.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/Platform/IPC/Connection.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> // Use this to make waitForMessage be interrupted immediately by any incoming sync messages.
</span><span class="cx"> InterruptWaitingIfSyncMessageArrives = 1 << 0,
</span><span class="cx"> };
</span><del>-
</del><ins>+
</ins><span class="cx"> #define MESSAGE_CHECK_BASE(assertion, connection) do \
</span><span class="cx"> if (!(assertion)) { \
</span><span class="cx"> ASSERT(assertion); \
</span><span class="lines">@@ -89,8 +89,8 @@
</span><span class="cx"> public:
</span><span class="cx"> class Client : public MessageReceiver {
</span><span class="cx"> public:
</span><del>- virtual void didClose(Connection*) = 0;
- virtual void didReceiveInvalidMessage(Connection*, StringReference messageReceiverName, StringReference messageName) = 0;
</del><ins>+ virtual void didClose(Connection&) = 0;
+ virtual void didReceiveInvalidMessage(Connection&, StringReference messageReceiverName, StringReference messageName) = 0;
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> virtual ~Client() { }
</span><span class="lines">@@ -251,11 +251,11 @@
</span><span class="cx"> bool m_didReceiveInvalidMessage;
</span><span class="cx">
</span><span class="cx"> // Incoming messages.
</span><del>- Mutex m_incomingMessagesLock;
</del><ins>+ std::mutex m_incomingMessagesMutex;
</ins><span class="cx"> Deque<std::unique_ptr<MessageDecoder>> m_incomingMessages;
</span><span class="cx">
</span><span class="cx"> // Outgoing messages.
</span><del>- Mutex m_outgoingMessagesLock;
</del><ins>+ std::mutex m_outgoingMessagesMutex;
</ins><span class="cx"> Deque<std::unique_ptr<MessageEncoder>> m_outgoingMessages;
</span><span class="cx">
</span><span class="cx"> std::condition_variable m_waitForMessageCondition;
</span></span></pre></div>
<a id="trunkSourceWebKit2PluginProcessPluginProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -125,14 +125,14 @@
</span><span class="cx"> didReceivePluginProcessMessage(connection, decoder);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PluginProcess::didClose(IPC::Connection*)
</del><ins>+void PluginProcess::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // The UI process has crashed, just go ahead and quit.
</span><span class="cx"> // FIXME: If the plug-in is spinning in the main loop, we'll never get this message.
</span><span class="cx"> stopRunLoop();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PluginProcess::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void PluginProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2PluginProcessPluginProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PluginProcess/PluginProcess.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PluginProcess/PluginProcess.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/PluginProcess/PluginProcess.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -89,8 +89,8 @@
</span><span class="cx">
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // Message handlers.
</span><span class="cx"> void didReceivePluginProcessMessage(IPC::Connection*, IPC::MessageDecoder&);
</span></span></pre></div>
<a id="trunkSourceWebKit2PluginProcessWebProcessConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -164,7 +164,7 @@
</span><span class="cx"> pluginControllerProxy->didReceiveSyncPluginControllerProxyMessage(connection, decoder, replyEncoder);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessConnection::didClose(IPC::Connection*)
</del><ins>+void WebProcessConnection::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // The web process crashed. Destroy all the plug-in controllers. Destroying the last plug-in controller
</span><span class="cx"> // will cause the web process connection itself to be destroyed.
</span><span class="lines">@@ -200,7 +200,7 @@
</span><span class="cx"> destroyPluginControllerProxy(pluginControllerProxy);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessConnection::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void WebProcessConnection::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: Implement.
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2PluginProcessWebProcessConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -67,8 +67,8 @@
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*);
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName);
</del><ins>+ virtual void didClose(IPC::Connection&);
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName);
</ins><span class="cx">
</span><span class="cx"> // Message handlers.
</span><span class="cx"> void didReceiveWebProcessConnectionMessage(IPC::Connection*, IPC::MessageDecoder&);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> connection()->send(Messages::DatabaseProcess::CreateDatabaseToWebProcessConnection(), 0, IPC::DispatchMessageEvenWhenWaitingForSyncReply);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseProcessProxy::didClose(IPC::Connection*)
</del><ins>+void DatabaseProcessProxy::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // The database process must have crashed or exited, so send any pending sync replies we might have.
</span><span class="cx"> while (!m_pendingConnectionReplies.isEmpty()) {
</span><span class="lines">@@ -113,7 +113,7 @@
</span><span class="cx"> m_processPool->databaseProcessCrashed(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseProcessProxy::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</del><ins>+void DatabaseProcessProxy::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessDatabasesDatabaseProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -54,8 +54,8 @@
</span><span class="cx">
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> void didReceiveDatabaseProcessProxyMessage(IPC::Connection*, IPC::MessageDecoder&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessNetworkNetworkProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -165,7 +165,7 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcessProxy::didClose(IPC::Connection*)
</del><ins>+void NetworkProcessProxy::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> if (m_downloadProxyMap)
</span><span class="cx"> m_downloadProxyMap->processDidClose();
</span><span class="lines">@@ -174,7 +174,7 @@
</span><span class="cx"> networkProcessCrashedOrFailedToLaunch();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcessProxy::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void NetworkProcessProxy::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessNetworkNetworkProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -82,8 +82,8 @@
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // Message handlers
</span><span class="cx"> void didReceiveNetworkProcessProxyMessage(IPC::Connection*, IPC::MessageDecoder&);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPluginsPluginProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> m_pluginProcessManager->removePluginProcessProxy(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PluginProcessProxy::didClose(IPC::Connection*)
</del><ins>+void PluginProcessProxy::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> if (m_modalWindowIsShowing)
</span><span class="lines">@@ -174,7 +174,7 @@
</span><span class="cx"> pluginProcessCrashedOrFailedToLaunch();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PluginProcessProxy::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void PluginProcessProxy::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPluginsPluginProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -118,8 +118,8 @@
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><span class="cx">
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // ProcessLauncher::Client
</span><span class="cx"> virtual void didFinishLaunching(ProcessLauncher*, IPC::Connection::Identifier);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -440,7 +440,7 @@
</span><span class="cx"> // FIXME: Add unhandled message logging.
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessProxy::didClose(IPC::Connection*)
</del><ins>+void WebProcessProxy::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // Protect ourselves, as the call to disconnect() below may otherwise cause us
</span><span class="cx"> // to be deleted before we can finish our work.
</span><span class="lines">@@ -458,7 +458,7 @@
</span><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessProxy::didReceiveInvalidMessage(IPC::Connection* connection, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</del><ins>+void WebProcessProxy::didReceiveInvalidMessage(IPC::Connection& connection, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</ins><span class="cx"> {
</span><span class="cx"> WTFLogAlways("Received an invalid message \"%s.%s\" from the web process.\n", messageReceiverName.toString().data(), messageName.toString().data());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -182,8 +182,8 @@
</span><span class="cx"> friend class WebConnectionToWebProcess;
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // ResponsivenessTimer::Client
</span><span class="cx"> void didBecomeUnresponsive(ResponsivenessTimer*) override;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessDatabasesWebToDatabaseProcessConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -61,12 +61,12 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebToDatabaseProcessConnection::didClose(IPC::Connection* connection)
</del><ins>+void WebToDatabaseProcessConnection::didClose(IPC::Connection& connection)
</ins><span class="cx"> {
</span><span class="cx"> WebProcess::shared().webToDatabaseProcessConnectionClosed(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebToDatabaseProcessConnection::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</del><ins>+void WebToDatabaseProcessConnection::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessDatabasesWebToDatabaseProcessConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -56,8 +56,8 @@
</span><span class="cx">
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // IPC::MessageSender
</span><span class="cx"> virtual IPC::Connection* messageSenderConnection() override { return m_connection.get(); }
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessNetworkNetworkProcessConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -70,13 +70,13 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcessConnection::didClose(IPC::Connection*)
</del><ins>+void NetworkProcessConnection::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // The NetworkProcess probably crashed.
</span><span class="cx"> WebProcess::shared().networkProcessConnectionClosed(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NetworkProcessConnection::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void NetworkProcessConnection::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessNetworkNetworkProcessConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -66,8 +66,8 @@
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(SHAREABLE_RESOURCE)
</span><span class="cx"> // Message handlers.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPluginProcessConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> pluginProxy->didReceiveSyncPluginProxyMessage(connection, decoder, replyEncoder);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PluginProcessConnection::didClose(IPC::Connection*)
</del><ins>+void PluginProcessConnection::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> // The plug-in process must have crashed.
</span><span class="cx"> for (HashMap<uint64_t, PluginProxy*>::const_iterator::Values it = m_plugins.begin().values(), end = m_plugins.end().values(); it != end; ++it) {
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PluginProcessConnection::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void PluginProcessConnection::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPluginProcessConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -66,8 +66,8 @@
</span><span class="cx"> // IPC::Connection::Client
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*);
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&);
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // Message handlers.
</span><span class="cx"> void didReceivePluginProcessConnectionMessage(IPC::Connection*, IPC::MessageDecoder&);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -53,8 +53,8 @@
</span><span class="cx"> void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx">
</span><span class="cx"> // IPC::Connection::Client
</span><del>- void didClose(IPC::Connection*) override { close(); }
- void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference) override { close(); }
</del><ins>+ void didClose(IPC::Connection&) override { close(); }
+ void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference) override { close(); }
</ins><span class="cx">
</span><span class="cx"> // Called by WebInspector messages
</span><span class="cx"> void connectionEstablished();
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorUIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -48,8 +48,8 @@
</span><span class="cx"> void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx">
</span><span class="cx"> // IPC::Connection::Client
</span><del>- void didClose(IPC::Connection*) override { closeWindow(); }
- void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference) override { closeWindow(); }
</del><ins>+ void didClose(IPC::Connection&) override { closeWindow(); }
+ void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference) override { closeWindow(); }
</ins><span class="cx">
</span><span class="cx"> // Called by WebInspectorUI messages
</span><span class="cx"> void establishConnection(IPC::Attachment connectionIdentifier, uint64_t inspectedPageIdentifier, bool underTest);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -619,7 +619,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcess::didClose(IPC::Connection*)
</del><ins>+void WebProcess::didClose(IPC::Connection&)
</ins><span class="cx"> {
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx"> m_inDidClose = true;
</span><span class="lines">@@ -640,7 +640,7 @@
</span><span class="cx"> stopRunLoop();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcess::didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference, IPC::StringReference)
</del><ins>+void WebProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
</ins><span class="cx"> {
</span><span class="cx"> // We received an invalid message, but since this is from the UI process (which we trust),
</span><span class="cx"> // we'll let it slide.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (177874 => 177875)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.h 2015-01-04 19:39:13 UTC (rev 177874)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h 2015-01-04 20:14:45 UTC (rev 177875)
</span><span class="lines">@@ -288,8 +288,8 @@
</span><span class="cx"> friend class WebConnectionToUIProcess;
</span><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><del>- virtual void didClose(IPC::Connection*) override;
- virtual void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</del><ins>+ virtual void didClose(IPC::Connection&) override;
+ virtual void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) override;
</ins><span class="cx">
</span><span class="cx"> // Implemented in generated WebProcessMessageReceiver.cpp
</span><span class="cx"> void didReceiveWebProcessMessage(IPC::Connection*, IPC::MessageDecoder&);
</span></span></pre>
</div>
</div>
</body>
</html>