<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177842] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177842">177842</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2015-01-01 00:04:07 -0800 (Thu, 01 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>fast/ruby/ruby-svg-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=135610
Reviewed by Darin Adler.
* fast/ruby/ruby-svg-crash.html: Streamline the test to avoid timer races. I
verified that it still crashes without the original fix (it gets an
ASSERT_WITH_SECURITY_IMPILICATIONS).
* platform/mac/TestExpectations: Removed the expectation.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastrubyrubysvgcrashhtml">trunk/LayoutTests/fast/ruby/ruby-svg-crash.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (177841 => 177842)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-01 01:25:50 UTC (rev 177841)
+++ trunk/LayoutTests/ChangeLog 2015-01-01 08:04:07 UTC (rev 177842)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2014-12-31 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><ins>+ fast/ruby/ruby-svg-crash.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=135610
+
+ Reviewed by Darin Adler.
+
+ * fast/ruby/ruby-svg-crash.html: Streamline the test to avoid timer races. I
+ verified that it still crashes without the original fix (it gets an
+ ASSERT_WITH_SECURITY_IMPILICATIONS).
+ * platform/mac/TestExpectations: Removed the expectation.
+
+2014-12-31 Alexey Proskuryakov <ap@apple.com>
+
</ins><span class="cx"> execDeleteCommand() does not update spellchecker sometimes
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=139862
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastrubyrubysvgcrashhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/ruby/ruby-svg-crash.html (177841 => 177842)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/ruby/ruby-svg-crash.html 2015-01-01 01:25:50 UTC (rev 177841)
+++ trunk/LayoutTests/fast/ruby/ruby-svg-crash.html 2015-01-01 08:04:07 UTC (rev 177842)
</span><span class="lines">@@ -2,17 +2,17 @@
</span><span class="cx"> <ruby id=rubyEl><dl></dl><rt id=rubyTextEl></rt>><script>
</span><span class="cx"> var docElement = document.body ? document.body : document.documentElement;
</span><span class="cx"> function initCF() {
</span><del>-try { fontFaceNameEl = document.createElementNS("http://www.w3.org/2000/svg", "font-face-name"); } catch(e) {}
-try { clipPathEl = document.createElementNS("http://www.w3.org/2000/svg", "clipPath"); } catch(e) {}
-setTimeout("CFcrash()", 0);
</del><ins>+ try { fontFaceNameEl = document.createElementNS("http://www.w3.org/2000/svg", "font-face-name"); } catch(e) {}
+ try { clipPathEl = document.createElementNS("http://www.w3.org/2000/svg", "clipPath"); } catch(e) {}
+ setTimeout(CFcrash, 0);
</ins><span class="cx"> }
</span><del>-document.addEventListener("DOMContentLoaded", initCF, false);
</del><span class="cx"> function CFcrash() {
</span><del>-try { if (rubyTextEl != docElement) { rubyTextEl.parentNode.removeChild(rubyTextEl); }} catch(e) {}
-try { clipPathEl.scrollIntoView(true); } catch(e) {}
-try { fontFaceNameEl.appendChild(rubyEl); } catch(e) {}
</del><ins>+ try { if (rubyTextEl != docElement) { rubyTextEl.parentNode.removeChild(rubyTextEl); }} catch(e) {}
+ try { clipPathEl.scrollIntoView(true); } catch(e) {}
+ try { fontFaceNameEl.appendChild(rubyEl); } catch(e) {}
+ setTimeout(finish, 0);
</ins><span class="cx"> }
</span><del>-function runTest()
</del><ins>+function finish()
</ins><span class="cx"> {
</span><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><span class="lines">@@ -23,5 +23,5 @@
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-setTimeout("runTest()", 10);
</del><ins>+document.addEventListener("DOMContentLoaded", initCF, false);
</ins><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (177841 => 177842)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-01-01 01:25:50 UTC (rev 177841)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-01-01 08:04:07 UTC (rev 177842)
</span><span class="lines">@@ -1507,5 +1507,3 @@
</span><span class="cx"> webkit.org/b/139977 [ Mavericks+ ] fast/encoding/utf-16-little-endian.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/139982 [ Mavericks+ ] svg/custom/svg-fonts-without-missing-glyph.xhtml [ Pass Failure ]
</span><span class="cx"> webkit.org/b/139988 [ Mavericks+ ] fonts/sans-serif.html [ Pass Failure ]
</span><del>-
-webkit.org/b/135610 fast/ruby/ruby-svg-crash.html [ Pass Failure ]
</del></span></pre>
</div>
</div>
</body>
</html>