<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177846] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177846">177846</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2015-01-01 11:56:15 -0800 (Thu, 01 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>We often misspell identifier as "identifer"
https://bugs.webkit.org/show_bug.cgi?id=140025
Reviewed by Michael Saboff.
Source/JavaScriptCore:
* runtime/ArrayConventions.h: Fix it.
Source/WebCore:
* html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseNPTFragment):
* html/parser/AtomicHTMLToken.h:
* html/parser/HTMLToken.h:
* html/shadow/SliderThumbElement.h:
* platform/graphics/ISOVTTCue.cpp:
(WebCore::ISOWebVTTCue::ISOWebVTTCue):
* platform/graphics/ISOVTTCue.h:
(WebCore::ISOWebVTTCue::id):
Fix mispellings.
Source/WebInspectorUI:
* UserInterface/Base/Main.js:
(WebInspector._updateNavigationSidebarForCurrentContentView):
(WebInspector._contentBrowserCurrentContentViewDidChange):
Fix misspellings.
Source/WebKit2:
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h:
* UIProcess/WebPageGroup.cpp:
(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::identifier):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::createInspectorPage):
* WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
* WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::identifier):
Fix misspellings.
Tools:
* LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
* Scripts/webkitdirs.pm:
(appIdentifierFromBundle):
(installAndLaunchIOSWebKitAppInSimulator):
Fix misspellings</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeArrayConventionsh">trunk/Source/JavaScriptCore/runtime/ArrayConventions.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlMediaFragmentURIParsercpp">trunk/Source/WebCore/html/MediaFragmentURIParser.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserAtomicHTMLTokenh">trunk/Source/WebCore/html/parser/AtomicHTMLToken.h</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLTokenh">trunk/Source/WebCore/html/parser/HTMLToken.h</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementh">trunk/Source/WebCore/html/shadow/SliderThumbElement.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsISOVTTCuecpp">trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsISOVTTCueh">trunk/Source/WebCore/platform/graphics/ISOVTTCue.h</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPageGroupDatacpp">trunk/Source/WebKit2/Shared/WebPageGroupData.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPageGroupDatah">trunk/Source/WebKit2/Shared/WebPageGroupData.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageGroupcpp">trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageGrouph">trunk/Source/WebKit2/UIProcess/WebPageGroup.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorcpp">trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPageGroupProxycpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPageGroupProxyh">trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsLayoutTestRelayLayoutTestRelayLTRelayControllerm">trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m</a></li>
<li><a href="#trunkToolsScriptswebkitdirspm">trunk/Tools/Scripts/webkitdirs.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-01-01 Darin Adler <darin@apple.com>
+
+ We often misspell identifier as "identifer"
+ https://bugs.webkit.org/show_bug.cgi?id=140025
+
+ Reviewed by Michael Saboff.
+
+ * runtime/ArrayConventions.h: Fix it.
+
</ins><span class="cx"> 2014-12-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Move JavaScriptCore/yarr to std::unique_ptr
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeArrayConventionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ArrayConventions.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ArrayConventions.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/JavaScriptCore/runtime/ArrayConventions.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> // (specifically, this is only one property - the value 0xFFFFFFFFU as an unsigned 32-bit
</span><span class="cx"> // integer) are not considered array indices and will be stored in the JSObject property map.
</span><span class="cx"> //
</span><del>-// All properties with a numeric identifer, representable as an unsigned integer i,
</del><ins>+// All properties with a numeric identifier, representable as an unsigned integer i,
</ins><span class="cx"> // where (i <= MAX_ARRAY_INDEX), are an array index and will be stored in either the
</span><span class="cx"> // storage vector or the sparse map. An array index i will be handled in the following
</span><span class="cx"> // fashion:
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebCore/ChangeLog 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-01-01 Darin Adler <darin@apple.com>
+
+ We often misspell identifier as "identifer"
+ https://bugs.webkit.org/show_bug.cgi?id=140025
+
+ Reviewed by Michael Saboff.
+
+ * html/MediaFragmentURIParser.cpp:
+ (WebCore::MediaFragmentURIParser::parseNPTFragment):
+ * html/parser/AtomicHTMLToken.h:
+ * html/parser/HTMLToken.h:
+ * html/shadow/SliderThumbElement.h:
+ * platform/graphics/ISOVTTCue.cpp:
+ (WebCore::ISOWebVTTCue::ISOWebVTTCue):
+ * platform/graphics/ISOVTTCue.h:
+ (WebCore::ISOWebVTTCue::id):
+ Fix mispellings.
+
</ins><span class="cx"> 2015-01-01 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Saturated arithmetics: Incorrect float/double clamping.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlMediaFragmentURIParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/MediaFragmentURIParser.cpp (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/MediaFragmentURIParser.cpp 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebCore/html/MediaFragmentURIParser.cpp 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> const int secondsPerHour = 3600;
</span><span class="cx"> const int secondsPerMinute = 60;
</span><del>-const unsigned nptIdentiferLength = 4; // "npt:"
</del><ins>+const unsigned nptIdentifierLength = 4; // "npt:"
</ins><span class="cx">
</span><span class="cx"> static String collectDigits(const LChar* input, unsigned length, unsigned& position)
</span><span class="cx"> {
</span><span class="lines">@@ -200,8 +200,8 @@
</span><span class="cx"> bool MediaFragmentURIParser::parseNPTFragment(const LChar* timeString, unsigned length, MediaTime& startTime, MediaTime& endTime)
</span><span class="cx"> {
</span><span class="cx"> unsigned offset = 0;
</span><del>- if (length >= nptIdentiferLength && timeString[0] == 'n' && timeString[1] == 'p' && timeString[2] == 't' && timeString[3] == ':')
- offset += nptIdentiferLength;
</del><ins>+ if (length >= nptIdentifierLength && timeString[0] == 'n' && timeString[1] == 'p' && timeString[2] == 't' && timeString[3] == ':')
+ offset += nptIdentifierLength;
</ins><span class="cx">
</span><span class="cx"> if (offset == length)
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserAtomicHTMLTokenh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/AtomicHTMLToken.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/AtomicHTMLToken.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebCore/html/parser/AtomicHTMLToken.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -104,14 +104,14 @@
</span><span class="cx"> return m_data;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // FIXME: Distinguish between a missing public identifer and an empty one.
</del><ins>+ // FIXME: Distinguish between a missing public identifier and an empty one.
</ins><span class="cx"> Vector<UChar>& publicIdentifier() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_type == HTMLToken::DOCTYPE);
</span><span class="cx"> return m_doctypeData->m_publicIdentifier;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // FIXME: Distinguish between a missing system identifer and an empty one.
</del><ins>+ // FIXME: Distinguish between a missing system identifier and an empty one.
</ins><span class="cx"> Vector<UChar>& systemIdentifier() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_type == HTMLToken::DOCTYPE);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLTokenh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLToken.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLToken.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebCore/html/parser/HTMLToken.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -181,14 +181,14 @@
</span><span class="cx"> m_orAllData |= character;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // FIXME: Distinguish between a missing public identifer and an empty one.
</del><ins>+ // FIXME: Distinguish between a missing public identifier and an empty one.
</ins><span class="cx"> const WTF::Vector<UChar>& publicIdentifier() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_type == DOCTYPE);
</span><span class="cx"> return m_doctypeData->m_publicIdentifier;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // FIXME: Distinguish between a missing system identifer and an empty one.
</del><ins>+ // FIXME: Distinguish between a missing system identifier and an empty one.
</ins><span class="cx"> const WTF::Vector<UChar>& systemIdentifier() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_type == DOCTYPE);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -100,7 +100,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(IOS_TOUCH_EVENTS)
</span><span class="cx"> // FIXME: Currently it is safe to use 0, but this may need to change
</span><del>- // if touch identifers change in the future and can be 0.
</del><ins>+ // if touch identifiers change in the future and can be 0.
</ins><span class="cx"> static const unsigned NoIdentifier = 0;
</span><span class="cx"> unsigned m_exclusiveTouchIdentifier;
</span><span class="cx"> bool m_isRegisteredAsTouchEventListener;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsISOVTTCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx"> if (boxType == vttCueSourceIDBoxType())
</span><span class="cx"> m_sourceID = peekString(subBuffer.get(), ISOBox::boxHeaderSize(), boxDataSize);
</span><span class="cx"> else if (boxType == vttIdBoxType())
</span><del>- m_identifer = peekString(subBuffer.get(), ISOBox::boxHeaderSize(), boxDataSize);
</del><ins>+ m_identifier = peekString(subBuffer.get(), ISOBox::boxHeaderSize(), boxDataSize);
</ins><span class="cx"> else if (boxType == vttCurrentTimeBoxType())
</span><span class="cx"> m_originalStartTime = peekString(subBuffer.get(), ISOBox::boxHeaderSize(), boxDataSize);
</span><span class="cx"> else if (boxType == vttSettingsBoxType())
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsISOVTTCueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ISOVTTCue.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ISOVTTCue.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebCore/platform/graphics/ISOVTTCue.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> const MediaTime& duration() const { return m_duration; }
</span><span class="cx">
</span><span class="cx"> const String& sourceID() const { return m_sourceID; }
</span><del>- const String& id() const { return m_identifer; }
</del><ins>+ const String& id() const { return m_identifier; }
</ins><span class="cx"> const String& originalStartTime() const { return m_originalStartTime; }
</span><span class="cx"> const String& settings() const { return m_settings; }
</span><span class="cx"> const String& cueText() const { return m_cueText; }
</span><span class="lines">@@ -83,7 +83,7 @@
</span><span class="cx"> MediaTime m_duration;
</span><span class="cx">
</span><span class="cx"> String m_sourceID;
</span><del>- String m_identifer;
</del><ins>+ String m_identifier;
</ins><span class="cx"> String m_originalStartTime;
</span><span class="cx"> String m_settings;
</span><span class="cx"> String m_cueText;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-01-01 Darin Adler <darin@apple.com>
+
+ We often misspell identifier as "identifer"
+ https://bugs.webkit.org/show_bug.cgi?id=140025
+
+ Reviewed by Michael Saboff.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector._updateNavigationSidebarForCurrentContentView):
+ (WebInspector._contentBrowserCurrentContentViewDidChange):
+ Fix misspellings.
+
</ins><span class="cx"> 2014-12-29 Jonathan Wells <jonowells@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: SourceCode.requestContent should return a promise
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -970,7 +970,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!allowedNavigationSidebarPanels.length || allowedNavigationSidebarPanels.contains(selectedSidebarPanel.identifier))
</span><del>- currentContentView.__lastNavigationSidebarPanelIdentifer = selectedSidebarPanel.identifier;
</del><ins>+ currentContentView.__lastNavigationSidebarPanelIdentifier = selectedSidebarPanel.identifier;
</ins><span class="cx">
</span><span class="cx"> this._revealAndSelectRepresentedObjectInNavigationSidebar(currentContentView.representedObject);
</span><span class="cx"> };
</span><span class="lines">@@ -1110,12 +1110,12 @@
</span><span class="cx">
</span><span class="cx"> var allowedNavigationSidebarPanels = currentContentView.allowedNavigationSidebarPanels;
</span><span class="cx"> if (allowedNavigationSidebarPanels.length && !allowedNavigationSidebarPanels.contains(selectedSidebarPanelIdentifier)) {
</span><del>- console.assert(!currentContentView.__lastNavigationSidebarPanelIdentifer || allowedNavigationSidebarPanels.contains(currentContentView.__lastNavigationSidebarPanelIdentifer));
- this.navigationSidebar.selectedSidebarPanel = currentContentView.__lastNavigationSidebarPanelIdentifer || allowedNavigationSidebarPanels[0];
</del><ins>+ console.assert(!currentContentView.__lastNavigationSidebarPanelIdentifier || allowedNavigationSidebarPanels.contains(currentContentView.__lastNavigationSidebarPanelIdentifier));
+ this.navigationSidebar.selectedSidebarPanel = currentContentView.__lastNavigationSidebarPanelIdentifier || allowedNavigationSidebarPanels[0];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!allowedNavigationSidebarPanels.length || allowedNavigationSidebarPanels.contains(selectedSidebarPanelIdentifier))
</span><del>- currentContentView.__lastNavigationSidebarPanelIdentifer = selectedSidebarPanelIdentifier;
</del><ins>+ currentContentView.__lastNavigationSidebarPanelIdentifier = selectedSidebarPanelIdentifier;
</ins><span class="cx">
</span><span class="cx"> this._revealAndSelectRepresentedObjectInNavigationSidebar(currentContentView.representedObject);
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/ChangeLog 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2015-01-01 Darin Adler <darin@apple.com>
+
+ We often misspell identifier as "identifer"
+ https://bugs.webkit.org/show_bug.cgi?id=140025
+
+ Reviewed by Michael Saboff.
+
+ * Shared/WebPageGroupData.cpp:
+ (WebKit::WebPageGroupData::encode):
+ (WebKit::WebPageGroupData::decode):
+ * Shared/WebPageGroupData.h:
+ * UIProcess/WebPageGroup.cpp:
+ (WebKit::pageGroupData):
+ (WebKit::WebPageGroup::WebPageGroup):
+ * UIProcess/WebPageGroup.h:
+ (WebKit::WebPageGroup::identifier):
+ * WebProcess/WebPage/WebInspector.cpp:
+ (WebKit::WebInspector::createInspectorPage):
+ * WebProcess/WebPage/WebPageGroupProxy.cpp:
+ (WebKit::WebPageGroupProxy::WebPageGroupProxy):
+ * WebProcess/WebPage/WebPageGroupProxy.h:
+ (WebKit::WebPageGroupProxy::identifier):
+ Fix misspellings.
+
</ins><span class="cx"> 2014-12-31 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Suppress unused parameter warnings in ui clients
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPageGroupDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPageGroupData.cpp (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPageGroupData.cpp 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/Shared/WebPageGroupData.cpp 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx">
</span><span class="cx"> void WebPageGroupData::encode(IPC::ArgumentEncoder& encoder) const
</span><span class="cx"> {
</span><del>- encoder << identifer;
</del><ins>+ encoder << identifier;
</ins><span class="cx"> encoder << pageGroupID;
</span><span class="cx"> encoder << visibleToInjectedBundle;
</span><span class="cx"> encoder << visibleToHistoryClient;
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> bool WebPageGroupData::decode(IPC::ArgumentDecoder& decoder, WebPageGroupData& data)
</span><span class="cx"> {
</span><del>- if (!decoder.decode(data.identifer))
</del><ins>+ if (!decoder.decode(data.identifier))
</ins><span class="cx"> return false;
</span><span class="cx"> if (!decoder.decode(data.pageGroupID))
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPageGroupDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPageGroupData.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPageGroupData.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/Shared/WebPageGroupData.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> void encode(IPC::ArgumentEncoder&) const;
</span><span class="cx"> static bool decode(IPC::ArgumentDecoder&, WebPageGroupData&);
</span><span class="cx">
</span><del>- String identifer;
</del><ins>+ String identifier;
</ins><span class="cx"> uint64_t pageGroupID;
</span><span class="cx"> bool visibleToInjectedBundle;
</span><span class="cx"> bool visibleToHistoryClient;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageGroupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -72,9 +72,9 @@
</span><span class="cx"> data.pageGroupID = generatePageGroupID();
</span><span class="cx">
</span><span class="cx"> if (!identifier.isEmpty())
</span><del>- data.identifer = identifier;
</del><ins>+ data.identifier = identifier;
</ins><span class="cx"> else
</span><del>- data.identifer = makeString("__uniquePageGroupID-", String::number(data.pageGroupID));
</del><ins>+ data.identifier = makeString("__uniquePageGroupID-", String::number(data.pageGroupID));
</ins><span class="cx">
</span><span class="cx"> data.visibleToInjectedBundle = visibleToInjectedBundle;
</span><span class="cx"> data.visibleToHistoryClient = visibleToHistoryClient;
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> // If it turns out that it's wrong, we can change it to to "WebKit2." and get rid of the globalDebugKeyPrefix from WebPreferences.
</span><span class="cx"> WebPageGroup::WebPageGroup(const String& identifier, bool visibleToInjectedBundle, bool visibleToHistoryClient)
</span><span class="cx"> : m_data(pageGroupData(identifier, visibleToInjectedBundle, visibleToHistoryClient))
</span><del>- , m_preferences(WebPreferences::createWithLegacyDefaults(m_data.identifer, ".WebKit2", "WebKit2."))
</del><ins>+ , m_preferences(WebPreferences::createWithLegacyDefaults(m_data.identifier, ".WebKit2", "WebKit2."))
</ins><span class="cx"> {
</span><span class="cx"> webPageGroupMap().set(m_data.pageGroupID, this);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageGrouph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageGroup.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageGroup.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/UIProcess/WebPageGroup.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> void addPage(WebPageProxy*);
</span><span class="cx"> void removePage(WebPageProxy*);
</span><span class="cx">
</span><del>- const String& identifier() const { return m_data.identifer; }
</del><ins>+ const String& identifier() const { return m_data.identifier; }
</ins><span class="cx"> uint64_t pageGroupID() const { return m_data.pageGroupID; }
</span><span class="cx">
</span><span class="cx"> const WebPageGroupData& data() const { return m_data; }
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -80,18 +80,18 @@
</span><span class="cx"> mach_port_t listeningPort;
</span><span class="cx"> mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, &listeningPort);
</span><span class="cx">
</span><del>- IPC::Connection::Identifier connectionIdentifer(listeningPort);
</del><ins>+ IPC::Connection::Identifier connectionIdentifier(listeningPort);
</ins><span class="cx"> IPC::Attachment connectionClientPort(listeningPort, MACH_MSG_TYPE_MAKE_SEND);
</span><span class="cx"> #elif USE(UNIX_DOMAIN_SOCKETS)
</span><span class="cx"> IPC::Connection::SocketPair socketPair = IPC::Connection::createPlatformConnection();
</span><del>- IPC::Connection::Identifier connectionIdentifer(socketPair.server);
</del><ins>+ IPC::Connection::Identifier connectionIdentifier(socketPair.server);
</ins><span class="cx"> IPC::Attachment connectionClientPort(socketPair.client);
</span><span class="cx"> #else
</span><span class="cx"> notImplemented();
</span><span class="cx"> return;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- m_frontendConnection = IPC::Connection::createServerConnection(connectionIdentifer, this, RunLoop::main());
</del><ins>+ m_frontendConnection = IPC::Connection::createServerConnection(connectionIdentifier, this, RunLoop::main());
</ins><span class="cx"> m_frontendConnection->open();
</span><span class="cx">
</span><span class="cx"> WebProcess::shared().parentProcessConnection()->send(Messages::WebInspectorProxy::CreateInspectorPage(connectionClientPort, canAttachWindow(), underTest), m_page->pageID());
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPageGroupProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">
</span><span class="cx"> WebPageGroupProxy::WebPageGroupProxy(const WebPageGroupData& data)
</span><span class="cx"> : m_data(data)
</span><del>- , m_pageGroup(WebCore::PageGroup::pageGroup(m_data.identifer))
</del><ins>+ , m_pageGroup(WebCore::PageGroup::pageGroup(m_data.identifier))
</ins><span class="cx"> {
</span><span class="cx"> for (size_t i = 0; i < data.userStyleSheets.size(); ++i)
</span><span class="cx"> addUserStyleSheet(data.userStyleSheets[i]);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPageGroupProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.h (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.h 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.h 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> static PassRefPtr<WebPageGroupProxy> create(const WebPageGroupData&);
</span><span class="cx"> virtual ~WebPageGroupProxy();
</span><span class="cx">
</span><del>- const String& identifier() const { return m_data.identifer; }
</del><ins>+ const String& identifier() const { return m_data.identifier; }
</ins><span class="cx"> uint64_t pageGroupID() const { return m_data.pageGroupID; }
</span><span class="cx"> bool isVisibleToInjectedBundle() const { return m_data.visibleToInjectedBundle; }
</span><span class="cx"> bool isVisibleToHistoryClient() const { return m_data.visibleToHistoryClient; }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Tools/ChangeLog 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-01-01 Darin Adler <darin@apple.com>
+
+ We often misspell identifier as "identifer"
+ https://bugs.webkit.org/show_bug.cgi?id=140025
+
+ Reviewed by Michael Saboff.
+
+ * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
+ * Scripts/webkitdirs.pm:
+ (appIdentifierFromBundle):
+ (installAndLaunchIOSWebKitAppInSimulator):
+ Fix misspellings
+
</ins><span class="cx"> 2015-01-01 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Saturated arithmetics: Incorrect float/double clamping.
</span></span></pre></div>
<a id="trunkToolsLayoutTestRelayLayoutTestRelayLTRelayControllerm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> @property (readonly, strong) NSFileHandle *standardOutput;
</span><span class="cx"> @property (readonly, strong) NSFileHandle *standardError;
</span><span class="cx"> @property (readonly, strong) NSString *uniqueAppPath;
</span><del>-@property (readonly, strong) NSString *uniqueAppIdentifer;
</del><ins>+@property (readonly, strong) NSString *uniqueAppIdentifier;
</ins><span class="cx"> @property (readonly, strong) NSURL *uniqueAppURL;
</span><span class="cx"> @property (readonly, strong) NSString *originalAppIdentifier;
</span><span class="cx"> @property (readonly, strong) NSString *originalAppPath;
</span></span></pre></div>
<a id="trunkToolsScriptswebkitdirspm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitdirs.pm (177845 => 177846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitdirs.pm 2015-01-01 08:32:27 UTC (rev 177845)
+++ trunk/Tools/Scripts/webkitdirs.pm 2015-01-01 19:56:15 UTC (rev 177846)
</span><span class="lines">@@ -2048,12 +2048,12 @@
</span><span class="cx"> return "";
</span><span class="cx"> }
</span><span class="cx">
</span><del>-sub appIdentiferFromBundle($)
</del><ins>+sub appIdentifierFromBundle($)
</ins><span class="cx"> {
</span><span class="cx"> my ($appBundle) = @_;
</span><span class="cx"> my $plistPath = plistPathFromBundle($appBundle);
</span><del>- chomp(my $bundleIdentifer = `defaults read '$plistPath' CFBundleIdentifier 2> /dev/null`);
- return $bundleIdentifer;
</del><ins>+ chomp(my $bundleIdentifier = `defaults read '$plistPath' CFBundleIdentifier 2> /dev/null`);
+ return $bundleIdentifier;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub appDisplayNameFromBundle($)
</span><span class="lines">@@ -2155,7 +2155,7 @@
</span><span class="cx"> # $appBundle: the path to the app bundle to launch.
</span><span class="cx"> # $simulatedDevice: the simulator device to use to run the app.
</span><span class="cx"> # $simulatorOptions: a hash reference representing optional simulator options.
</span><del>-# sessionUUID: a unique identifer to use for the iOS Simulator session. Defaults to an identifer
</del><ins>+# sessionUUID: a unique identifier to use for the iOS Simulator session. Defaults to an identifier
</ins><span class="cx"> # of the form "theAwesomeUniqueSessionIdentifierForX" where X is the display name of
</span><span class="cx"> # the specified app.
</span><span class="cx"> # applicationArguments: an array reference representing the arguments to pass to the app (defaults to \@ARGV).
</span><span class="lines">@@ -2199,7 +2199,7 @@
</span><span class="cx"> my $sessionInfo = {
</span><span class="cx"> applicationArguments => &$makeNSArrayFromArray($applicationArguments),
</span><span class="cx"> applicationEnvironment => &$makeNSDictionaryFromHash($simulatorENVHashRef),
</span><del>- applicationIdentifier => NSString->stringWithCString_(appIdentiferFromBundle($appBundle)),
</del><ins>+ applicationIdentifier => NSString->stringWithCString_(appIdentifierFromBundle($appBundle)),
</ins><span class="cx"> applicationPath => NSString->stringWithCString_($appBundle),
</span><span class="cx"> deviceUDID => NSString->stringWithCString_($simulatedDevice->{UDID}),
</span><span class="cx"> sessionUUID => NSString->stringWithCString_($sessionUUID),
</span></span></pre>
</div>
</div>
</body>
</html>