<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177797] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177797">177797</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2014-12-29 11:08:18 -0800 (Mon, 29 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Removes some unnecessary use of LegacyReceiver
https://bugs.webkit.org/show_bug.cgi?id=139992
Reviewed by Anders Carlsson.
* Shared/WebConnection.cpp:
(WebKit::WebConnection::didReceiveMessage): Deleted.
* Shared/WebConnection.h:
* Shared/WebConnection.messages.in:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::didReceiveMessage): Deleted.
(WebKit::WebProcessPool::didReceiveSyncMessage): Deleted.
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessPool.messages.in:
Remove unnecessary use of LegacyReceiver.
* UIProcess/WebPageProxy.h:
Remove declarations for functions that don't exist.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebConnectioncpp">trunk/Source/WebKit2/Shared/WebConnection.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedWebConnectionh">trunk/Source/WebKit2/Shared/WebConnection.h</a></li>
<li><a href="#trunkSourceWebKit2SharedWebConnectionmessagesin">trunk/Source/WebKit2/Shared/WebConnection.messages.in</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolcpp">trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolh">trunk/Source/WebKit2/UIProcess/WebProcessPool.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolmessagesin">trunk/Source/WebKit2/UIProcess/WebProcessPool.messages.in</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-12-29 Sam Weinig <sam@webkit.org>
+
+ Removes some unnecessary use of LegacyReceiver
+ https://bugs.webkit.org/show_bug.cgi?id=139992
+
+ Reviewed by Anders Carlsson.
+
+ * Shared/WebConnection.cpp:
+ (WebKit::WebConnection::didReceiveMessage): Deleted.
+ * Shared/WebConnection.h:
+ * Shared/WebConnection.messages.in:
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::didReceiveMessage): Deleted.
+ (WebKit::WebProcessPool::didReceiveSyncMessage): Deleted.
+ * UIProcess/WebProcessPool.h:
+ * UIProcess/WebProcessPool.messages.in:
+ Remove unnecessary use of LegacyReceiver.
+
+ * UIProcess/WebPageProxy.h:
+ Remove declarations for functions that don't exist.
+
</ins><span class="cx"> 2014-12-29 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Convert all variadic web process messages to UserData
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebConnection.cpp (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebConnection.cpp 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/Shared/WebConnection.cpp 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -60,11 +60,6 @@
</span><span class="cx"> m_client.didClose(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebConnection::didReceiveMessage(IPC::Connection* connection, IPC::MessageDecoder& decoder)
-{
- didReceiveWebConnectionMessage(connection, decoder);
-}
-
</del><span class="cx"> void WebConnection::handleMessage(const String& messageName, const UserData& messageBody)
</span><span class="cx"> {
</span><span class="cx"> m_client.didReceiveMessage(this, messageName, transformHandlesToObjects(messageBody.object()).get());
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebConnection.h (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebConnection.h 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/Shared/WebConnection.h 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -51,11 +51,9 @@
</span><span class="cx"> virtual RefPtr<API::Object> transformObjectsToHandles(API::Object*) = 0;
</span><span class="cx">
</span><span class="cx"> // IPC::MessageReceiver
</span><ins>+ // Implemented in generated WebConnectionMessageReceiver.cpp
</ins><span class="cx"> void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx">
</span><del>- // Implemented in generated WebConnectionMessageReceiver.cpp
- void didReceiveWebConnectionMessage(IPC::Connection*, IPC::MessageDecoder&);
-
</del><span class="cx"> // Mesage handling implementation functions.
</span><span class="cx"> void handleMessage(const String& messageName, const UserData& messageBody);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebConnectionmessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebConnection.messages.in (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebConnection.messages.in 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/Shared/WebConnection.messages.in 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -20,6 +20,6 @@
</span><span class="cx"> # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
</span><span class="cx"> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">
</span><del>-messages -> WebConnection LegacyReceiver {
</del><ins>+messages -> WebConnection {
</ins><span class="cx"> HandleMessage(String messageName, WebKit::UserData messageBody)
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -975,6 +975,7 @@
</span><span class="cx"> void setUserAgent(const String&);
</span><span class="cx">
</span><span class="cx"> // IPC::MessageReceiver
</span><ins>+ // Implemented in generated WebPageProxyMessageReceiver.cpp
</ins><span class="cx"> virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
</span><span class="cx"> virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</span><span class="cx">
</span><span class="lines">@@ -990,10 +991,6 @@
</span><span class="cx"> virtual void failedToShowPopupMenu();
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- // Implemented in generated WebPageProxyMessageReceiver.cpp
- void didReceiveWebPageProxyMessage(IPC::Connection*, IPC::MessageDecoder&);
- void didReceiveSyncWebPageProxyMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&);
-
</del><span class="cx"> void didCreateMainFrame(uint64_t frameID);
</span><span class="cx"> void didCreateSubframe(uint64_t frameID);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -1125,26 +1125,6 @@
</span><span class="cx"> return m_messageReceiverMap.dispatchSyncMessage(connection, decoder, replyEncoder);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessPool::didReceiveMessage(IPC::Connection* connection, IPC::MessageDecoder& decoder)
-{
- if (decoder.messageReceiverName() == Messages::WebProcessPool::messageReceiverName()) {
- didReceiveWebProcessPoolMessage(connection, decoder);
- return;
- }
-
- ASSERT_NOT_REACHED();
-}
-
-void WebProcessPool::didReceiveSyncMessage(IPC::Connection* connection, IPC::MessageDecoder& decoder, std::unique_ptr<IPC::MessageEncoder>& replyEncoder)
-{
- if (decoder.messageReceiverName() == Messages::WebProcessPool::messageReceiverName()) {
- didReceiveSyncWebProcessPoolMessage(connection, decoder, replyEncoder);
- return;
- }
-
- ASSERT_NOT_REACHED();
-}
-
</del><span class="cx"> void WebProcessPool::setEnhancedAccessibility(bool flag)
</span><span class="cx"> {
</span><span class="cx"> sendToAllProcesses(Messages::WebProcess::SetEnhancedAccessibility(flag));
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.h (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -213,10 +213,6 @@
</span><span class="cx">
</span><span class="cx"> VisitedLinkProvider& visitedLinkProvider() { return *m_visitedLinkProvider; }
</span><span class="cx">
</span><del>- // MessageReceiver.
- virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
- virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
-
</del><span class="cx"> void setCacheModel(CacheModel);
</span><span class="cx"> CacheModel cacheModel() const { return m_cacheModel; }
</span><span class="cx">
</span><span class="lines">@@ -381,9 +377,10 @@
</span><span class="cx">
</span><span class="cx"> void didGetStatistics(const StatisticsData&, uint64_t callbackID);
</span><span class="cx">
</span><ins>+ // IPC::MessageReceiver.
</ins><span class="cx"> // Implemented in generated WebProcessPoolMessageReceiver.cpp
</span><del>- void didReceiveWebProcessPoolMessage(IPC::Connection*, IPC::MessageDecoder&);
- void didReceiveSyncWebProcessPoolMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&);
</del><ins>+ virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
+ virtual void didReceiveSyncMessage(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder>&) override;
</ins><span class="cx">
</span><span class="cx"> static void languageChanged(void* context);
</span><span class="cx"> void languageChanged();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolmessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.messages.in (177796 => 177797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.messages.in 2014-12-29 19:02:08 UTC (rev 177796)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.messages.in 2014-12-29 19:08:18 UTC (rev 177797)
</span><span class="lines">@@ -20,7 +20,7 @@
</span><span class="cx"> # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
</span><span class="cx"> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">
</span><del>-messages -> WebProcessPool LegacyReceiver {
</del><ins>+messages -> WebProcessPool {
</ins><span class="cx"> HandleMessage(String messageName, WebKit::UserData messageBody) WantsConnection
</span><span class="cx"> HandleSynchronousMessage(String messageName, WebKit::UserData messageBody) -> (WebKit::UserData returnData) WantsConnection
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>