<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177682] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177682">177682</a></dd>
<dt>Author</dt> <dd>g.czajkowski@samsung.com</dd>
<dt>Date</dt> <dd>2014-12-23 00:26:49 -0800 (Tue, 23 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value
https://bugs.webkit.org/show_bug.cgi?id=133939
Reviewed by Darin Adler.
First call of eval(expression) inside shouldBecomeEqual was always
made synchronously. If the testing expression returns the same value
as expected one then shouldBecomeEqual() will immediately report PASS,
for example,
shouldBecomeEqual(internals.hasSpellingMarker("wellcome"), false);
in consequence, assuming asynchronous path of spellchecking, spelling markers
may appear after a while.
The bug was caused by checking a condition at the beginning of shouldBecomeEqual(),
before calling a timer. As a result, queued asynchronous events doesn't effect
this checking.
* TestExpectations:
This fix reveals new bugs in execDeleteCommand() behaviour, two tests need
to marked as failure now.
* resources/js-test-pre.js:
(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):
* resources/js-test.js:
(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):
Always check a condition on timer.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsresourcesjstestprejs">trunk/LayoutTests/resources/js-test-pre.js</a></li>
<li><a href="#trunkLayoutTestsresourcesjstestjs">trunk/LayoutTests/resources/js-test.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (177681 => 177682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-12-23 07:28:53 UTC (rev 177681)
+++ trunk/LayoutTests/ChangeLog 2014-12-23 08:26:49 UTC (rev 177682)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2014-12-23 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value
+ https://bugs.webkit.org/show_bug.cgi?id=133939
+
+ Reviewed by Darin Adler.
+
+ First call of eval(expression) inside shouldBecomeEqual was always
+ made synchronously. If the testing expression returns the same value
+ as expected one then shouldBecomeEqual() will immediately report PASS,
+ for example,
+
+ shouldBecomeEqual(internals.hasSpellingMarker("wellcome"), false);
+
+ in consequence, assuming asynchronous path of spellchecking, spelling markers
+ may appear after a while.
+
+ The bug was caused by checking a condition at the beginning of shouldBecomeEqual(),
+ before calling a timer. As a result, queued asynchronous events doesn't effect
+ this checking.
+
+ * TestExpectations:
+ This fix reveals new bugs in execDeleteCommand() behaviour, two tests need
+ to marked as failure now.
+
+ * resources/js-test-pre.js:
+ (.condition):
+ (shouldBecomeEqual):
+ (shouldBecomeDifferent):
+ * resources/js-test.js:
+ (.condition):
+ (shouldBecomeEqual):
+ (shouldBecomeDifferent):
+ Always check a condition on timer.
+
</ins><span class="cx"> 2014-12-22 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html is flaky
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (177681 => 177682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2014-12-23 07:28:53 UTC (rev 177681)
+++ trunk/LayoutTests/TestExpectations 2014-12-23 08:26:49 UTC (rev 177682)
</span><span class="lines">@@ -10,6 +10,9 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/116473 editing/selection/user-drag-element-and-user-select-none.html [ Failure ]
</span><span class="cx">
</span><ins>+webkit.org/b/139862 editing/spelling/editing-multiple-words-with-markers.html [ Timeout ]
+webkit.org/b/139862 editing/spelling/grammar-edit-word.html [ Timeout ]
+
</ins><span class="cx"> # media/W3C/video/networkState/networkState_during_progress.html is flaky
</span><span class="cx"> webkit.org/b/76280 media/W3C/video/networkState/networkState_during_progress.html [ Pass Failure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsresourcesjstestprejs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/resources/js-test-pre.js (177681 => 177682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/resources/js-test-pre.js 2014-12-23 07:28:53 UTC (rev 177681)
+++ trunk/LayoutTests/resources/js-test-pre.js 2014-12-23 08:26:49 UTC (rev 177682)
</span><span class="lines">@@ -289,7 +289,7 @@
</span><span class="cx"> if (typeof _a != "string" || typeof _b != "string")
</span><span class="cx"> debug("WARN: shouldBecomeEqual() expects string arguments");
</span><span class="cx">
</span><del>- var condition = function() {
</del><ins>+ function condition() {
</ins><span class="cx"> var exception;
</span><span class="cx"> var _av;
</span><span class="cx"> try {
</span><span class="lines">@@ -305,8 +305,8 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><del>- };
- _waitForCondition(condition, completionHandler);
</del><ins>+ }
+ setTimeout(_waitForCondition, 0, condition, completionHandler);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function shouldBecomeEqualToString(value, reference, completionHandler)
</span><span class="lines">@@ -401,7 +401,7 @@
</span><span class="cx"> if (typeof _a != "string" || typeof _b != "string")
</span><span class="cx"> debug("WARN: shouldBecomeDifferent() expects string arguments");
</span><span class="cx">
</span><del>- var condition = function() {
</del><ins>+ function condition() {
</ins><span class="cx"> var exception;
</span><span class="cx"> var _av;
</span><span class="cx"> try {
</span><span class="lines">@@ -417,8 +417,8 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><del>- };
- _waitForCondition(condition, completionHandler);
</del><ins>+ }
+ setTimeout(_waitForCondition, 0, condition, completionHandler);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function shouldBeTrue(_a) { shouldBe(_a, "true"); }
</span></span></pre></div>
<a id="trunkLayoutTestsresourcesjstestjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/resources/js-test.js (177681 => 177682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/resources/js-test.js 2014-12-23 07:28:53 UTC (rev 177681)
+++ trunk/LayoutTests/resources/js-test.js 2014-12-23 08:26:49 UTC (rev 177682)
</span><span class="lines">@@ -256,7 +256,7 @@
</span><span class="cx"> if (typeof _a != "string" || typeof _b != "string")
</span><span class="cx"> debug("WARN: shouldBecomeEqual() expects string arguments");
</span><span class="cx">
</span><del>- var condition = function() {
</del><ins>+ function condition() {
</ins><span class="cx"> var exception;
</span><span class="cx"> var _av;
</span><span class="cx"> try {
</span><span class="lines">@@ -272,8 +272,8 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><del>- };
- _waitForCondition(condition, completionHandler);
</del><ins>+ }
+ setTimeout(_waitForCondition, 0, condition, completionHandler);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function shouldBecomeEqualToString(value, reference, completionHandler)
</span><span class="lines">@@ -368,7 +368,7 @@
</span><span class="cx"> if (typeof _a != "string" || typeof _b != "string")
</span><span class="cx"> debug("WARN: shouldBecomeDifferent() expects string arguments");
</span><span class="cx">
</span><del>- var condition = function() {
</del><ins>+ function condition() {
</ins><span class="cx"> var exception;
</span><span class="cx"> var _av;
</span><span class="cx"> try {
</span><span class="lines">@@ -384,8 +384,8 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><del>- };
- _waitForCondition(condition, completionHandler);
</del><ins>+ }
+ setTimeout(_waitForCondition, 0, condition, completionHandler);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function shouldBeTrue(a, quiet) { shouldBe(a, "true", quiet); }
</span></span></pre>
</div>
</div>
</body>
</html>