<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177638] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177638">177638</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-12-22 11:21:54 -0800 (Mon, 22 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Consistently use "FeatureCounter*Key" naming for FeatureCounter keys
https://bugs.webkit.org/show_bug.cgi?id=139867
Reviewed by Darin Adler.
Consistently use "FeatureCounter*Key" naming for FeatureCounter keys.
* loader/FrameLoader.cpp:
(WebCore::logNavigationWithFeatureCounter):
* platform/FeatureCounterKeys.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoadercpp">trunk/Source/WebCore/loader/FrameLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformFeatureCounterKeysh">trunk/Source/WebCore/platform/FeatureCounterKeys.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (177637 => 177638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-22 19:14:58 UTC (rev 177637)
+++ trunk/Source/WebCore/ChangeLog 2014-12-22 19:21:54 UTC (rev 177638)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-12-22 Chris Dumez <cdumez@apple.com>
+
+ Consistently use "FeatureCounter*Key" naming for FeatureCounter keys
+ https://bugs.webkit.org/show_bug.cgi?id=139867
+
+ Reviewed by Darin Adler.
+
+ Consistently use "FeatureCounter*Key" naming for FeatureCounter keys.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::logNavigationWithFeatureCounter):
+ * platform/FeatureCounterKeys.h:
+
</ins><span class="cx"> 2014-12-22 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Generic font code should not know about SVG font missing glyph
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (177637 => 177638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoader.cpp 2014-12-22 19:14:58 UTC (rev 177637)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2014-12-22 19:21:54 UTC (rev 177638)
</span><span class="lines">@@ -1383,25 +1383,25 @@
</span><span class="cx"> const char* key;
</span><span class="cx"> switch (type) {
</span><span class="cx"> case FrameLoadType::Standard:
</span><del>- key = FeatureCounterNavigationStandard;
</del><ins>+ key = FeatureCounterNavigationStandardKey;
</ins><span class="cx"> break;
</span><span class="cx"> case FrameLoadType::Back:
</span><del>- key = FeatureCounterNavigationBack;
</del><ins>+ key = FeatureCounterNavigationBackKey;
</ins><span class="cx"> break;
</span><span class="cx"> case FrameLoadType::Forward:
</span><del>- key = FeatureCounterNavigationForward;
</del><ins>+ key = FeatureCounterNavigationForwardKey;
</ins><span class="cx"> break;
</span><span class="cx"> case FrameLoadType::IndexedBackForward:
</span><del>- key = FeatureCounterNavigationIndexedBackForward;
</del><ins>+ key = FeatureCounterNavigationIndexedBackForwardKey;
</ins><span class="cx"> break;
</span><span class="cx"> case FrameLoadType::Reload:
</span><del>- key = FeatureCounterNavigationReload;
</del><ins>+ key = FeatureCounterNavigationReloadKey;
</ins><span class="cx"> break;
</span><span class="cx"> case FrameLoadType::Same:
</span><del>- key = FeatureCounterNavigationSame;
</del><ins>+ key = FeatureCounterNavigationSameKey;
</ins><span class="cx"> break;
</span><span class="cx"> case FrameLoadType::ReloadFromOrigin:
</span><del>- key = FeatureCounterNavigationReloadFromOrigin;
</del><ins>+ key = FeatureCounterNavigationReloadFromOriginKey;
</ins><span class="cx"> break;
</span><span class="cx"> case FrameLoadType::Replace:
</span><span class="cx"> case FrameLoadType::RedirectWithLockedBackForwardList:
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformFeatureCounterKeysh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/FeatureCounterKeys.h (177637 => 177638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/FeatureCounterKeys.h 2014-12-22 19:14:58 UTC (rev 177637)
+++ trunk/Source/WebCore/platform/FeatureCounterKeys.h 2014-12-22 19:21:54 UTC (rev 177638)
</span><span class="lines">@@ -77,13 +77,13 @@
</span><span class="cx"> static const char FeatureCounterMediaAudioElementPlayedKey[] = "com.apple.WebKit.media.audio.played";
</span><span class="cx">
</span><span class="cx"> // Navigation types.
</span><del>-static const char FeatureCounterNavigationStandard[] = "com.apple.WebKit.navigation.standard";
-static const char FeatureCounterNavigationBack[] = "com.apple.WebKit.navigation.back";
-static const char FeatureCounterNavigationForward[] = "com.apple.WebKit.navigation.forward";
-static const char FeatureCounterNavigationIndexedBackForward[] = "com.apple.WebKit.navigation.indexedBackForward";
-static const char FeatureCounterNavigationReload[] = "com.apple.WebKit.navigation.reload";
-static const char FeatureCounterNavigationSame[] = "com.apple.WebKit.navigation.same";
-static const char FeatureCounterNavigationReloadFromOrigin[] = "com.apple.WebKit.navigation.reloadFromOrigin";
</del><ins>+static const char FeatureCounterNavigationStandardKey[] = "com.apple.WebKit.navigation.standard";
+static const char FeatureCounterNavigationBackKey[] = "com.apple.WebKit.navigation.back";
+static const char FeatureCounterNavigationForwardKey[] = "com.apple.WebKit.navigation.forward";
+static const char FeatureCounterNavigationIndexedBackForwardKey[] = "com.apple.WebKit.navigation.indexedBackForward";
+static const char FeatureCounterNavigationReloadKey[] = "com.apple.WebKit.navigation.reload";
+static const char FeatureCounterNavigationSameKey[] = "com.apple.WebKit.navigation.same";
+static const char FeatureCounterNavigationReloadFromOriginKey[] = "com.apple.WebKit.navigation.reloadFromOrigin";
</ins><span class="cx">
</span><span class="cx"> // Memory cache.
</span><span class="cx"> static const char FeatureCounterResourceRequestInMemoryCacheKey[] = "com.apple.WebKit.resourceRequest.inMemoryCache";
</span></span></pre>
</div>
</div>
</body>
</html>