<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177627] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177627">177627</a></dd>
<dt>Author</dt> <dd>rgabor@webkit.org</dd>
<dt>Date</dt> <dd>2014-12-21 15:56:55 -0800 (Sun, 21 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Hidden aria table crash
https://bugs.webkit.org/show_bug.cgi?id=139856
Reviewed by Chris Fleizach.
Source/WebCore:
Change axCaption to pointer and check it's value because
AXObjectCache::getOrCreate() can return with nullptr.
Test: accessibility/aria-hidden-crash.html
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
LayoutTests:
Add layout test to cover this crash.
* accessibility/aria-hidden-crash-expected.txt: Added.
* accessibility/aria-hidden-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTablecpp">trunk/Source/WebCore/accessibility/AccessibilityTable.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilityariahiddencrashexpectedtxt">trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilityariahiddencrashhtml">trunk/LayoutTests/accessibility/aria-hidden-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (177626 => 177627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-12-21 22:11:53 UTC (rev 177626)
+++ trunk/LayoutTests/ChangeLog 2014-12-21 23:56:55 UTC (rev 177627)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-12-21 Gabor Rapcsanyi <rgabor@webkit.org>
+
+ AX: Hidden aria table crash
+ https://bugs.webkit.org/show_bug.cgi?id=139856
+
+ Reviewed by Chris Fleizach.
+
+ Add layout test to cover this crash.
+
+ * accessibility/aria-hidden-crash-expected.txt: Added.
+ * accessibility/aria-hidden-crash.html: Added.
+
</ins><span class="cx"> 2014-12-21 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Update expectations for two WebGL tests to match what bots see.
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityariahiddencrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt (0 => 177627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt 2014-12-21 23:56:55 UTC (rev 177627)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+Bug 139856: Hidden aria table crash.
+
+This test PASSES if it does not CRASH.
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilityariahiddencrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/aria-hidden-crash.html (0 => 177627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/aria-hidden-crash.html (rev 0)
+++ trunk/LayoutTests/accessibility/aria-hidden-crash.html 2014-12-21 23:56:55 UTC (rev 177627)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<html>
+ <head>
+ <script>
+ function test()
+ {
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ }
+ </script>
+ </head>
+ <body onload="test()">
+ <p>Bug <a href="https://bugs.webkit.org/show_bug.cgi?id=139856">139856</a>: Hidden aria table crash.</p>
+ <p>This test PASSES if it does not CRASH.</p>
+
+ <ul aria-hidden="true">
+ <table>
+ <theader>
+ <td>
+ <span aria-live="assertive"></span>
+ </td>
+ </theader>
+ <caption></caption>
+ </table>
+ </ul>
+ <svg onerror="logPass()"></svg>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (177626 => 177627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-21 22:11:53 UTC (rev 177626)
+++ trunk/Source/WebCore/ChangeLog 2014-12-21 23:56:55 UTC (rev 177627)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-12-21 Gabor Rapcsanyi <rgabor@webkit.org>
+
+ AX: Hidden aria table crash
+ https://bugs.webkit.org/show_bug.cgi?id=139856
+
+ Reviewed by Chris Fleizach.
+
+ Change axCaption to pointer and check it's value because
+ AXObjectCache::getOrCreate() can return with nullptr.
+
+ Test: accessibility/aria-hidden-crash.html
+
+ * accessibility/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::addChildren):
+
</ins><span class="cx"> 2014-12-20 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Get rid of error-prone ReleaseParsedCalcValueCondition argument in CSSParser
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (177626 => 177627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2014-12-21 22:11:53 UTC (rev 177626)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2014-12-21 23:56:55 UTC (rev 177627)
</span><span class="lines">@@ -364,9 +364,9 @@
</span><span class="cx">
</span><span class="cx"> if (HTMLTableElement* tableElement = this->tableElement()) {
</span><span class="cx"> if (HTMLTableCaptionElement* caption = tableElement->caption()) {
</span><del>- AccessibilityObject& axCaption = *axObjectCache()->getOrCreate(caption);
- if (!axCaption.accessibilityIsIgnored())
- m_children.append(&axCaption);
</del><ins>+ AccessibilityObject* axCaption = axObjectCache()->getOrCreate(caption);
+ if (axCaption && !axCaption->accessibilityIsIgnored())
+ m_children.append(axCaption);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>