<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177435] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177435">177435</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-12-16 21:20:09 -0800 (Tue, 16 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>text node should not be created, On setting document.title to the empty string.
https://bugs.webkit.org/show_bug.cgi?id=139121
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-12-16
Reviewed by Darin Adler.
Source/WebCore:
Do not create text node, On setting document.title to the empty string as in spec.
I have confirmed this matches the behavior of Firefox and Chrome.
Test: fast/dom/Document/document-set-title-no-child.html
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
LayoutTests:
* fast/dom/Document/document-set-title-no-child-expected.txt: Added.
* fast/dom/Document/document-set-title-no-child.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTitleElementcpp">trunk/Source/WebCore/html/HTMLTitleElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomDocumentdocumentsettitlenochildexpectedtxt">trunk/LayoutTests/fast/dom/Document/document-set-title-no-child-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentdocumentsettitlenochildhtml">trunk/LayoutTests/fast/dom/Document/document-set-title-no-child.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (177434 => 177435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-12-17 04:02:33 UTC (rev 177434)
+++ trunk/LayoutTests/ChangeLog        2014-12-17 05:20:09 UTC (rev 177435)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-12-16 Shivakumar JM <shiva.jm@samsung.com>
+
+ text node should not be created, On setting document.title to the empty string.
+ https://bugs.webkit.org/show_bug.cgi?id=139121
+
+ Reviewed by Darin Adler.
+
+ * fast/dom/Document/document-set-title-no-child-expected.txt: Added.
+ * fast/dom/Document/document-set-title-no-child.html: Added.
+
</ins><span class="cx"> 2014-12-16 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Update expected results for LayoutTests/fast
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentdocumentsettitlenochildexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/document-set-title-no-child-expected.txt (0 => 177435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/document-set-title-no-child-expected.txt         (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/document-set-title-no-child-expected.txt        2014-12-17 05:20:09 UTC (rev 177435)
</span><span class="lines">@@ -0,0 +1,22 @@
</span><ins>+On setting document.title to the empty string, no text node should be created
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.title is ""
+document.title = ''
+PASS document.title is ""
+PASS document.getElementsByTagName('title')[0].firstChild is null
+PASS document.title is "titletext"
+PASS document.getElementsByTagName('title')[0].firstChild is non-null.
+document.title = ''
+PASS document.title is ""
+PASS document.getElementsByTagName('title')[0].firstChild is null
+PASS document.title is "titletextnew"
+PASS document.getElementsByTagName('title')[0].firstChild is non-null.
+PASS document.title is "updatetitletextnew"
+PASS document.getElementsByTagName('title')[0].firstChild is non-null.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentdocumentsettitlenochildhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/document-set-title-no-child.html (0 => 177435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/document-set-title-no-child.html         (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/document-set-title-no-child.html        2014-12-17 05:20:09 UTC (rev 177435)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../../resources/js-test.js"></script>
+<body>
+<script>
+ description("On setting document.title to the empty string, no text node should be created");
+ shouldBeEmptyString("document.title");
+ evalAndLog("document.title = ''");
+ shouldBeEmptyString("document.title");
+ shouldBeNull("document.getElementsByTagName('title')[0].firstChild");
+
+ document.title = "titletext";
+ shouldBeEqualToString("document.title", "titletext");
+ shouldBeNonNull("document.getElementsByTagName('title')[0].firstChild");
+
+ evalAndLog("document.title = ''");
+ shouldBeEmptyString("document.title");
+ shouldBeNull("document.getElementsByTagName('title')[0].firstChild");
+
+ document.title = "titletextnew";
+ shouldBeEqualToString("document.title", "titletextnew");
+ shouldBeNonNull("document.getElementsByTagName('title')[0].firstChild");
+
+ document.title = "updatetitletextnew";
+ shouldBeEqualToString("document.title", "updatetitletextnew");
+ shouldBeNonNull("document.getElementsByTagName('title')[0].firstChild");
+
+</script>
+</body>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (177434 => 177435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-12-17 04:02:33 UTC (rev 177434)
+++ trunk/Source/WebCore/ChangeLog        2014-12-17 05:20:09 UTC (rev 177435)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-12-16 Shivakumar JM <shiva.jm@samsung.com>
+
+ text node should not be created, On setting document.title to the empty string.
+ https://bugs.webkit.org/show_bug.cgi?id=139121
+
+ Reviewed by Darin Adler.
+
+ Do not create text node, On setting document.title to the empty string as in spec.
+ I have confirmed this matches the behavior of Firefox and Chrome.
+
+ Test: fast/dom/Document/document-set-title-no-child.html
+
+ * html/HTMLTitleElement.cpp:
+ (WebCore::HTMLTitleElement::setText):
+
</ins><span class="cx"> 2014-12-16 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Move WebCore/platform/graphics/surfaces to std::unique_ptr
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTitleElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTitleElement.cpp (177434 => 177435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTitleElement.cpp        2014-12-17 04:02:33 UTC (rev 177434)
+++ trunk/Source/WebCore/html/HTMLTitleElement.cpp        2014-12-17 05:20:09 UTC (rev 177435)
</span><span class="lines">@@ -93,23 +93,25 @@
</span><span class="cx"> return StringWithDirection(text(), direction);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTitleElement::setText(const String &value)
</del><ins>+void HTMLTitleElement::setText(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> Ref<HTMLTitleElement> protectFromMutationEvents(*this);
</span><span class="cx">
</span><del>- if (hasOneChild() && is<Text>(*firstChild()))
</del><ins>+ if (!value.isEmpty() && hasOneChild() && is<Text>(*firstChild())) {
</ins><span class="cx"> downcast<Text>(*firstChild()).setData(value, IGNORE_EXCEPTION);
</span><del>- else {
- // We make a copy here because entity of "value" argument can be Document::m_title,
- // which goes empty during removeChildren() invocation below,
- // which causes HTMLTitleElement::childrenChanged(), which ends up Document::setTitle().
- String valueCopy(value);
</del><ins>+ return;
+ }
</ins><span class="cx">
</span><del>- if (hasChildNodes())
- removeChildren();
</del><ins>+ // We make a copy here because entity of "value" argument can be Document::m_title,
+ // which goes empty during removeChildren() invocation below,
+ // which causes HTMLTitleElement::childrenChanged(), which ends up Document::setTitle().
+ String valueCopy(value);
</ins><span class="cx">
</span><del>- appendChild(document().createTextNode(valueCopy.impl()), IGNORE_EXCEPTION);
- }
</del><ins>+ if (hasChildNodes())
+ removeChildren();
+
+ if (!valueCopy.isEmpty())
+ appendChild(document().createTextNode(valueCopy), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>