<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177260] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177260">177260</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-12-14 01:34:28 -0800 (Sun, 14 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Minor follow-up tweaks suggested by Darin on bug 139587.
Source/WebCore:
* css/CSSFunctionValue.h:
(WebCore::CSSFunctionValue::create):
* platform/graphics/Font.cpp:
(WebCore::retrieveOrAddCachedFontGlyphs):
(WebCore::FontGlyphsCacheEntry::FontGlyphsCacheEntry): Deleted.
* rendering/RenderScrollbarPart.h:
Source/WTF:
* wtf/text/WTFString.h:
(WTF::String::String):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextWTFStringh">trunk/Source/WTF/wtf/text/WTFString.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSFunctionValueh">trunk/Source/WebCore/css/CSSFunctionValue.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontcpp">trunk/Source/WebCore/platform/graphics/Font.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderScrollbarParth">trunk/Source/WebCore/rendering/RenderScrollbarPart.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (177259 => 177260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WTF/ChangeLog 2014-12-14 09:34:28 UTC (rev 177260)
</span><span class="lines">@@ -1,5 +1,12 @@
</span><span class="cx"> 2014-12-14 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><ins>+ Minor follow-up tweaks suggested by Darin on bug 139587.
+
+ * wtf/text/WTFString.h:
+ (WTF::String::String):
+
+2014-12-14 Andreas Kling <akling@apple.com>
+
</ins><span class="cx"> Replace PassRef with Ref/Ref&& across the board.
</span><span class="cx"> <https://webkit.org/b/139587>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFwtftextWTFStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/WTFString.h (177259 => 177260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/WTFString.h 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2014-12-14 09:34:28 UTC (rev 177260)
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> String(StringImpl& impl) : m_impl(&impl) { }
</span><span class="cx"> String(StringImpl* impl) : m_impl(impl) { }
</span><span class="cx"> String(PassRefPtr<StringImpl> impl) : m_impl(impl) { }
</span><del>- String(Ref<StringImpl>&& impl) : m_impl(std::forward<Ref<StringImpl>>(impl)) { }
</del><ins>+ String(Ref<StringImpl>&& impl) : m_impl(WTF::move(impl)) { }
</ins><span class="cx"> String(RefPtr<StringImpl>&& impl) : m_impl(impl) { }
</span><span class="cx">
</span><span class="cx"> // Construct a string from a constant string literal.
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (177259 => 177260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/ChangeLog 2014-12-14 09:34:28 UTC (rev 177260)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2014-12-14 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><ins>+ Minor follow-up tweaks suggested by Darin on bug 139587.
+
+ * css/CSSFunctionValue.h:
+ (WebCore::CSSFunctionValue::create):
+ * platform/graphics/Font.cpp:
+ (WebCore::retrieveOrAddCachedFontGlyphs):
+ (WebCore::FontGlyphsCacheEntry::FontGlyphsCacheEntry): Deleted.
+ * rendering/RenderScrollbarPart.h:
+
+2014-12-14 Andreas Kling <akling@apple.com>
+
</ins><span class="cx"> Replace PassRef with Ref/Ref&& across the board.
</span><span class="cx"> <https://webkit.org/b/139587>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFunctionValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFunctionValue.h (177259 => 177260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFunctionValue.h 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/css/CSSFunctionValue.h 2014-12-14 09:34:28 UTC (rev 177260)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> return adoptRef(*new CSSFunctionValue(function));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static Ref<CSSFunctionValue> create(String name, PassRefPtr<CSSValueList> args)
</del><ins>+ static Ref<CSSFunctionValue> create(const String& name, PassRefPtr<CSSValueList> args)
</ins><span class="cx"> {
</span><span class="cx"> return adoptRef(*new CSSFunctionValue(name, args));
</span><span class="cx"> }
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> explicit CSSFunctionValue(CSSParserFunction*);
</span><del>- CSSFunctionValue(String, PassRefPtr<CSSValueList>);
</del><ins>+ CSSFunctionValue(const String& , PassRefPtr<CSSValueList>);
</ins><span class="cx">
</span><span class="cx"> String m_name;
</span><span class="cx"> RefPtr<CSSValueList> m_args;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsFontcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (177259 => 177260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/Font.cpp 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp 2014-12-14 09:34:28 UTC (rev 177260)
</span><span class="lines">@@ -215,10 +215,6 @@
</span><span class="cx"> struct FontGlyphsCacheEntry {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- FontGlyphsCacheEntry(FontGlyphsCacheKey&& k, Ref<FontGlyphs>&& g)
- : key(WTF::move(k))
- , glyphs(WTF::move(g))
- { }
</del><span class="cx"> FontGlyphsCacheKey key;
</span><span class="cx"> Ref<FontGlyphs> glyphs;
</span><span class="cx"> };
</span><span class="lines">@@ -310,7 +306,7 @@
</span><span class="cx"> return addResult.iterator->value->glyphs.get();
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<FontGlyphsCacheEntry>& newEntry = addResult.iterator->value;
</span><del>- newEntry = std::make_unique<FontGlyphsCacheEntry>(WTF::move(key), FontGlyphs::create(fontSelector));
</del><ins>+ newEntry = std::make_unique<FontGlyphsCacheEntry>({WTF::move(key), FontGlyphs::create(fontSelector)});
</ins><span class="cx"> Ref<FontGlyphs> glyphs = newEntry->glyphs.get();
</span><span class="cx">
</span><span class="cx"> static const unsigned unreferencedPruneInterval = 50;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderScrollbarParth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderScrollbarPart.h (177259 => 177260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2014-12-14 08:21:05 UTC (rev 177259)
+++ trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2014-12-14 09:34:28 UTC (rev 177260)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderScrollbarPart final : public RenderBlock {
</span><span class="cx"> public:
</span><del>- RenderScrollbarPart(Document&, Ref<RenderStyle>&&, RenderScrollbar* = 0, ScrollbarPart = NoPart);
</del><ins>+ RenderScrollbarPart(Document&, Ref<RenderStyle>&&, RenderScrollbar* = nullptr, ScrollbarPart = NoPart);
</ins><span class="cx">
</span><span class="cx"> virtual ~RenderScrollbarPart();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>