<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177143] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177143">177143</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-12-11 02:31:28 -0800 (Thu, 11 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Implement sizes attribute for link tag
https://bugs.webkit.org/show_bug.cgi?id=125775
Reviewed by Martin Robinson.
* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_link_element_set_sizes): Add custom setter implementation.
* bindings/gobject/WebKitDOMCustomUnstable.h:
* bindings/js/JSHTMLLinkElementCustom.cpp:
(WebCore::JSHTMLLinkElement::sizes): Remove custom getter implementation.
* bindings/scripts/CodeGeneratorGObject.pm:
(HasUnstableCustomAPI): Mark WebKitDOMHTMLLinkElement as having custom unstable API.
* html/HTMLLinkElement.idl: Mark sizes attribute as CustomSetter
instead of Custom, since the getter can be autogenerated, and make
it available to the GObject DOM bindings too.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMCustomcpp">trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMCustomUnstableh">trunk/Source/WebCore/bindings/gobject/WebKitDOMCustomUnstable.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSHTMLLinkElementCustomcpp">trunk/Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLLinkElementidl">trunk/Source/WebCore/html/HTMLLinkElement.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (177142 => 177143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-11 09:18:47 UTC (rev 177142)
+++ trunk/Source/WebCore/ChangeLog 2014-12-11 10:31:28 UTC (rev 177143)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-12-11 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] Implement sizes attribute for link tag
+ https://bugs.webkit.org/show_bug.cgi?id=125775
+
+ Reviewed by Martin Robinson.
+
+ * bindings/gobject/WebKitDOMCustom.cpp:
+ (webkit_dom_html_link_element_set_sizes): Add custom setter implementation.
+ * bindings/gobject/WebKitDOMCustomUnstable.h:
+ * bindings/js/JSHTMLLinkElementCustom.cpp:
+ (WebCore::JSHTMLLinkElement::sizes): Remove custom getter implementation.
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (HasUnstableCustomAPI): Mark WebKitDOMHTMLLinkElement as having custom unstable API.
+ * html/HTMLLinkElement.idl: Mark sizes attribute as CustomSetter
+ instead of Custom, since the getter can be autogenerated, and make
+ it available to the GObject DOM bindings too.
+
</ins><span class="cx"> 2014-12-10 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> http://omfgdogs.info/ only animates when you resize the window
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (177142 => 177143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp 2014-12-11 09:18:47 UTC (rev 177142)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp 2014-12-11 10:31:28 UTC (rev 177143)
</span><span class="lines">@@ -21,9 +21,11 @@
</span><span class="cx">
</span><span class="cx"> #include "JSMainThreadExecState.h"
</span><span class="cx"> #include "SerializedScriptValue.h"
</span><ins>+#include "WebKitDOMDOMSettableTokenListPrivate.h"
</ins><span class="cx"> #include "WebKitDOMDOMWindowPrivate.h"
</span><span class="cx"> #include "WebKitDOMHTMLInputElement.h"
</span><span class="cx"> #include "WebKitDOMHTMLInputElementPrivate.h"
</span><ins>+#include "WebKitDOMHTMLLinkElementPrivate.h"
</ins><span class="cx"> #include "WebKitDOMHTMLTextAreaElement.h"
</span><span class="cx"> #include "WebKitDOMHTMLTextAreaElementPrivate.h"
</span><span class="cx"> #include "WebKitDOMPrivate.h"
</span><span class="lines">@@ -87,3 +89,11 @@
</span><span class="cx"> handler->postMessage(WebCore::SerializedScriptValue::create(String::fromUTF8(message)));
</span><span class="cx"> return TRUE;
</span><span class="cx"> }
</span><ins>+
+void webkit_dom_html_link_element_set_sizes(WebKitDOMHTMLLinkElement* linkElement, const gchar* value)
+{
+ g_return_if_fail(WEBKIT_DOM_IS_HTML_LINK_ELEMENT(linkElement));
+ g_return_if_fail(value);
+
+ core(linkElement)->setSizes(String::fromUTF8(value));
+}
</ins></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMCustomUnstableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustomUnstable.h (177142 => 177143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustomUnstable.h 2014-12-11 09:18:47 UTC (rev 177142)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustomUnstable.h 2014-12-11 10:31:28 UTC (rev 177143)
</span><span class="lines">@@ -50,6 +50,17 @@
</span><span class="cx"> WEBKIT_API WebKitDOMUserMessageHandler *
</span><span class="cx"> webkit_dom_user_message_handlers_namespace_get_handler(WebKitDOMUserMessageHandlersNamespace* self, const gchar* name);
</span><span class="cx">
</span><ins>+/**
+ * webkit_dom_html_link_element_set_sizes:
+ * @self: A #WebKitDOMHTMLLinkElement
+ * @value: a #gchar
+ *
+ * Stability: Unstable
+ * Since: 2.8
+ */
+WEBKIT_API void
+webkit_dom_html_link_element_set_sizes(WebKitDOMHTMLLinkElement* self, const gchar* value);
+
</ins><span class="cx"> G_END_DECLS
</span><span class="cx">
</span><span class="cx"> #endif /* WEBKIT_DOM_USE_UNSTABLE_API */
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSHTMLLinkElementCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp (177142 => 177143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp 2014-12-11 09:18:47 UTC (rev 177142)
+++ trunk/Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp 2014-12-11 10:31:28 UTC (rev 177143)
</span><span class="lines">@@ -36,11 +36,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
-{
- return toJS(exec, globalObject(), impl().sizes());
-}
-
</del><span class="cx"> void JSHTMLLinkElement::setSizes(ExecState* exec, JSValue value)
</span><span class="cx"> {
</span><span class="cx"> impl().setSizes(valueToStringWithNullCheck(exec, value));
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (177142 => 177143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-12-11 09:18:47 UTC (rev 177142)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-12-11 10:31:28 UTC (rev 177143)
</span><span class="lines">@@ -1595,7 +1595,7 @@
</span><span class="cx"> sub HasUnstableCustomAPI {
</span><span class="cx"> my $domClassName = shift;
</span><span class="cx">
</span><del>- return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace));
</del><ins>+ return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace WebKitDOMHTMLLinkElement));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub WriteData {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLLinkElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLLinkElement.idl (177142 => 177143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLLinkElement.idl 2014-12-11 09:18:47 UTC (rev 177142)
+++ trunk/Source/WebCore/html/HTMLLinkElement.idl 2014-12-11 10:31:28 UTC (rev 177143)
</span><span class="lines">@@ -27,8 +27,8 @@
</span><span class="cx"> [Reflect] attribute DOMString media;
</span><span class="cx"> [Reflect] attribute DOMString rel;
</span><span class="cx"> [Reflect] attribute DOMString rev;
</span><del>-#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
- [Custom] attribute DOMSettableTokenList sizes;
</del><ins>+#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || (defined(LANGUAGE_GOBJECT) || LANGUAGE_GOBJECT)
+ [CustomSetter] attribute DOMSettableTokenList sizes;
</ins><span class="cx"> #endif
</span><span class="cx"> [Reflect] attribute DOMString target;
</span><span class="cx"> [Reflect] attribute DOMString type;
</span></span></pre>
</div>
</div>
</body>
</html>