<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[177029] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/177029">177029</a></dd>
<dt>Author</dt> <dd>ggaren@apple.com</dd>
<dt>Date</dt> <dd>2014-12-09 11:39:29 -0800 (Tue, 09 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Re-enable function.arguments
https://bugs.webkit.org/show_bug.cgi?id=139452
Source/JavaScriptCore:
<rdar://problem/18848149>
Reviewed by Sam Weinig.
Disabling function.arguments broke a few websites, and we don't have
time right now to work through the details.
I'm re-enabling function.arguments but leaving in the infrastructure
to re-disable it, so we can try this experiment again in the future.
* runtime/Options.h:
LayoutTests:
Reviewed by Sam Weinig.
* TestExpectations: Re-enable these tests, since WebKit supports this
feature by default now.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsh">trunk/Source/JavaScriptCore/runtime/Options.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (177028 => 177029)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-12-09 19:32:54 UTC (rev 177028)
+++ trunk/LayoutTests/ChangeLog 2014-12-09 19:39:29 UTC (rev 177029)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-12-09 Geoffrey Garen <ggaren@apple.com>
+
+ Re-enable function.arguments
+ https://bugs.webkit.org/show_bug.cgi?id=139452
+
+ Reviewed by Sam Weinig.
+
+ * TestExpectations: Re-enable these tests, since WebKit supports this
+ feature by default now.
+
</ins><span class="cx"> 2014-12-09 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Mark several hidpi compositing tests that fail on EWS bots with ATI graphics.
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (177028 => 177029)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2014-12-09 19:32:54 UTC (rev 177028)
+++ trunk/LayoutTests/TestExpectations 2014-12-09 19:39:29 UTC (rev 177029)
</span><span class="lines">@@ -174,30 +174,6 @@
</span><span class="cx"> # nth-child tests takes long time and Debug build sometimes timeouts because there are many test cases.
</span><span class="cx"> webkit.org/b/137149 fast/selectors/nth-child-of-basics.html [ Slow ]
</span><span class="cx">
</span><del>-# Deprecated tests for function.arguments. These tests need to stay in the tree because the RJST
-# harness will run these after forcibly reenabling the function.arguments feature. We want to
-# keep testing the feature for as long as we haven't achieved confidence that it is safe to
-# remove it entirely.
-webkit.org/b/137167 js/dfg-arguments-unexpected-escape.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-become-double.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-become-int32.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-int32.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-osr-exit-and-capture.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-reset-changetype.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-reset.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-simple.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-directly-from-inlined-code.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-from-all-the-places.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-from-getter.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-from-uninlined-code.html [ Failure ]
-webkit.org/b/137167 js/dfg-tear-off-arguments-not-activation.html [ Failure ]
-webkit.org/b/137167 js/dfg-tear-off-function-dot-arguments.html [ Failure ]
-webkit.org/b/137167 js/dom/exception-thrown-from-function-with-lazy-activation.html [ Failure ]
-webkit.org/b/137167 js/dom/function-dot-arguments2.html [ Failure ]
-webkit.org/b/137167 js/function-dot-arguments.html [ Failure ]
-webkit.org/b/137167 js/kde/function.html [ Failure ]
-webkit.org/b/137167 js/kde/function_arguments.html [ Failure ]
-
</del><span class="cx"> # Promises/A+ 2.3.3 has many tests and it sometimes exceeds the time limit.
</span><span class="cx"> webkit.org/b/136878 js/promises-tests/promises-tests-2-3-3.html [ Slow ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (177028 => 177029)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-12-09 19:32:54 UTC (rev 177028)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-12-09 19:39:29 UTC (rev 177029)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-12-09 Geoffrey Garen <ggaren@apple.com>
+
+ Re-enable function.arguments
+ https://bugs.webkit.org/show_bug.cgi?id=139452
+ <rdar://problem/18848149>
+
+ Reviewed by Sam Weinig.
+
+ Disabling function.arguments broke a few websites, and we don't have
+ time right now to work through the details.
+
+ I'm re-enabling function.arguments but leaving in the infrastructure
+ to re-disable it, so we can try this experiment again in the future.
+
+ * runtime/Options.h:
+
</ins><span class="cx"> 2014-12-09 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Switch from using PLATFORM_NAME to SDK selectors in ANGLE, bmalloc, gtest, JavaScriptCore, WTF
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Options.h (177028 => 177029)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Options.h 2014-12-09 19:32:54 UTC (rev 177028)
+++ trunk/Source/JavaScriptCore/runtime/Options.h 2014-12-09 19:39:29 UTC (rev 177029)
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx"> v(bool, forceDebuggerBytecodeGeneration, false) \
</span><span class="cx"> v(bool, forceProfilerBytecodeGeneration, false) \
</span><span class="cx"> \
</span><del>- v(bool, enableFunctionDotArguments, false) \
</del><ins>+ v(bool, enableFunctionDotArguments, true) \
</ins><span class="cx"> \
</span><span class="cx"> /* showDisassembly implies showDFGDisassembly. */ \
</span><span class="cx"> v(bool, showDisassembly, false) \
</span></span></pre>
</div>
</div>
</body>
</html>