<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176923] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176923">176923</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-12-07 08:23:31 -0800 (Sun, 07 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove the option to automatically update the GObject DOM bindings symbols file
https://bugs.webkit.org/show_bug.cgi?id=139366
Reviewed by Martin Robinson.
It's currently broken, because symbols now need to be in a
specific order. Now that the symbols file only contains stable
API, it's not a problem to manually update it every time new API
is added.
* gtk/check-for-webkitdom-api-breaks:
(read_expected_api):
(check_api):
(write_expected_api): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsgtkcheckforwebkitdomapibreaks">trunk/Tools/gtk/check-for-webkitdom-api-breaks</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (176922 => 176923)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-12-07 16:11:01 UTC (rev 176922)
+++ trunk/Tools/ChangeLog 2014-12-07 16:23:31 UTC (rev 176923)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ Remove the option to automatically update the GObject DOM bindings symbols file
+ https://bugs.webkit.org/show_bug.cgi?id=139366
+
+ Reviewed by Martin Robinson.
+
+ It's currently broken, because symbols now need to be in a
+ specific order. Now that the symbols file only contains stable
+ API, it's not a problem to manually update it every time new API
+ is added.
+
+ * gtk/check-for-webkitdom-api-breaks:
+ (read_expected_api):
+ (check_api):
+ (write_expected_api): Deleted.
+
+2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> [GTK] Use GMainLoopSource in WebKitTestRunner
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=138831
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsgtkcheckforwebkitdomapibreaks"></a>
<div class="modfile"><h4>Modified: trunk/Tools/gtk/check-for-webkitdom-api-breaks (176922 => 176923)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/gtk/check-for-webkitdom-api-breaks 2014-12-07 16:11:01 UTC (rev 176922)
+++ trunk/Tools/gtk/check-for-webkitdom-api-breaks 2014-12-07 16:23:31 UTC (rev 176923)
</span><span class="lines">@@ -16,7 +16,6 @@
</span><span class="cx"> # License along with this library; if not, write to the Free Software
</span><span class="cx"> # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
</span><span class="cx">
</span><del>-import argparse
</del><span class="cx"> import common
</span><span class="cx"> import os
</span><span class="cx"> import sys
</span><span class="lines">@@ -35,11 +34,7 @@
</span><span class="cx"> with open(EXPECTED_API_PATH) as file_handle:
</span><span class="cx"> return set(file_handle.readlines())
</span><span class="cx">
</span><del>-def write_expected_api(new_expected_api):
- with open(EXPECTED_API_PATH, 'w') as file_handle:
- file_handle.writelines(new_expected_api)
-
-def check_api(options, expected_api, built_api):
</del><ins>+def check_api(expected_api, built_api):
</ins><span class="cx"> missing_api = expected_api.difference(built_api)
</span><span class="cx"> new_api = built_api.difference(expected_api)
</span><span class="cx">
</span><span class="lines">@@ -57,22 +52,12 @@
</span><span class="cx"> # DOM bindings API varies depending on the compilation options.
</span><span class="cx"> # So this shouldn't be made fatal until we figure out a way to handle it.
</span><span class="cx"> # See https://bugs.webkit.org/show_bug.cgi?id=121481
</span><del>- sys.stderr.write("Re-add the missing API and rerun the %s.\n" % __file__)
</del><span class="cx"> return 0
</span><span class="cx">
</span><span class="cx"> if new_api:
</span><del>- if options.reset_results:
- sys.stdout.write("Resetting expected API\n")
- write_expected_api(built_api)
- else:
- sys.stdout.write("API compatible changes found in GObject DOM bindings.\n")
- sys.stdout.write("To update the symbols file, run %s --reset-results.\n" % __file__)
</del><ins>+ sys.stdout.write("API compatible changes found in GObject DOM bindings.\n")
</ins><span class="cx">
</span><span class="cx"> return 0
</span><span class="cx">
</span><span class="cx"> if __name__ == '__main__':
</span><del>- parser = argparse.ArgumentParser(description='Detect API breakage in the WebKitGTK+ GObject DOM bindings.')
- parser.add_argument('--reset-results', action='store_true',
- help='When specified, rest the expected results file with the built results.')
- options = parser.parse_args()
- sys.exit(check_api(options, read_expected_api(), read_built_api()))
</del><ins>+ sys.exit(check_api(read_expected_api(), read_built_api()))
</ins></span></pre>
</div>
</div>
</body>
</html>