<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176912] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176912">176912</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-12-06 13:23:57 -0800 (Sat, 06 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix build with newer versions of clang.
rdar://problem/18978687
Source/WebCore:
Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.
* html/HTMLElement.h:
* html/HTMLMediaElement.h:
* html/track/VTTCue.h:
* loader/FrameNetworkingContext.h:
(WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Deleted.
* loader/cache/CachedImage.h:
* page/SuspendableTimer.h:
* platform/Scrollbar.h:
* platform/graphics/InbandTextTrackPrivate.h:
* rendering/RenderBlockFlow.h:
Source/WebKit/ios:
Cast the result of +alloc to the right type.
* Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider createLocationManager]):
* WebCoreSupport/WebSelectionRect.m:
(+[WebSelectionRect selectionRect]):
Source/WebKit/mac:
Add missing overrides and missing casts.
* Storage/WebDatabaseManagerClient.h:
* Storage/WebStorageTrackerClient.h:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebInspectorClient.h:
* WebView/WebDataSource.mm:
(-[WebDataSource _makeRepresentation]):
* WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementh">trunk/Source/WebCore/html/HTMLElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementh">trunk/Source/WebCore/html/HTMLMediaElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTCueh">trunk/Source/WebCore/html/track/VTTCue.h</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameNetworkingContexth">trunk/Source/WebCore/loader/FrameNetworkingContext.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedImageh">trunk/Source/WebCore/loader/cache/CachedImage.h</a></li>
<li><a href="#trunkSourceWebCorepageSuspendableTimerh">trunk/Source/WebCore/page/SuspendableTimer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollbarh">trunk/Source/WebCore/platform/Scrollbar.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsInbandTextTrackPrivateh">trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowh">trunk/Source/WebCore/rendering/RenderBlockFlow.h</a></li>
<li><a href="#trunkSourceWebKitiosChangeLog">trunk/Source/WebKit/ios/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitiosMiscWebGeolocationCoreLocationProvidermm">trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm</a></li>
<li><a href="#trunkSourceWebKitiosWebCoreSupportWebSelectionRectm">trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacStorageWebDatabaseManagerClienth">trunk/Source/WebKit/mac/Storage/WebDatabaseManagerClient.h</a></li>
<li><a href="#trunkSourceWebKitmacStorageWebStorageTrackerClienth">trunk/Source/WebKit/mac/Storage/WebStorageTrackerClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebChromeClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebInspectorClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebDataSourcemm">trunk/Source/WebKit/mac/WebView/WebDataSource.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebFrameViewmm">trunk/Source/WebKit/mac/WebView/WebFrameView.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/ChangeLog 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2014-12-06 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Fix build with newer versions of clang.
+ rdar://problem/18978687
+
+ Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.
+
+ * html/HTMLElement.h:
+ * html/HTMLMediaElement.h:
+ * html/track/VTTCue.h:
+ * loader/FrameNetworkingContext.h:
+ (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Deleted.
+ * loader/cache/CachedImage.h:
+ * page/SuspendableTimer.h:
+ * platform/Scrollbar.h:
+ * platform/graphics/InbandTextTrackPrivate.h:
+ * rendering/RenderBlockFlow.h:
+
+2014-12-06 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Follow-up build fix.
</span><span class="cx">
</span><span class="cx"> * Configurations/Base.xcconfig:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/html/HTMLElement.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> void applyAlignmentAttributeToStyle(const AtomicString&, MutableStyleProperties&);
</span><span class="cx"> void applyBorderAttributeToStyle(const AtomicString&, MutableStyleProperties&);
</span><span class="cx">
</span><del>- virtual bool matchesReadWritePseudoClass() const;
</del><ins>+ virtual bool matchesReadWritePseudoClass() const override;
</ins><span class="cx"> virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
</span><span class="cx"> virtual bool isPresentationAttribute(const QualifiedName&) const override;
</span><span class="cx"> virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStyleProperties&) override;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -577,7 +577,7 @@
</span><span class="cx"> virtual bool mediaPlayerIsPaused() const override;
</span><span class="cx"> virtual bool mediaPlayerIsLooping() const override;
</span><span class="cx"> virtual CachedResourceLoader* mediaPlayerCachedResourceLoader() override;
</span><del>- virtual PassRefPtr<PlatformMediaResourceLoader> mediaPlayerCreateResourceLoader(std::unique_ptr<PlatformMediaResourceLoaderClient>);
</del><ins>+ virtual PassRefPtr<PlatformMediaResourceLoader> mediaPlayerCreateResourceLoader(std::unique_ptr<PlatformMediaResourceLoaderClient>) override;
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(WIN) && USE(AVFOUNDATION)
</span><span class="cx"> virtual GraphicsDeviceAdapter* mediaPlayerGraphicsDeviceAdapter(const MediaPlayer*) const override;
</span><span class="lines">@@ -585,10 +585,10 @@
</span><span class="cx">
</span><span class="cx"> virtual bool mediaPlayerShouldWaitForResponseToAuthenticationChallenge(const AuthenticationChallenge&) override;
</span><span class="cx"> virtual void mediaPlayerHandlePlaybackCommand(MediaSession::RemoteControlCommandType command) override { didReceiveRemoteControlCommand(command); }
</span><del>- virtual String mediaPlayerSourceApplicationIdentifier() const;
</del><ins>+ virtual String mediaPlayerSourceApplicationIdentifier() const override;
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- virtual String mediaPlayerNetworkInterfaceName() const;
</del><ins>+ virtual String mediaPlayerNetworkInterfaceName() const override;
</ins><span class="cx"> virtual bool mediaPlayerGetRawCookies(const URL&, Vector<Cookie>&) const override;
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTCueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTCue.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTCue.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/html/track/VTTCue.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx"> void notifyRegionWhenRemovingDisplayTree(bool);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- virtual void setIsActive(bool);
</del><ins>+ virtual void setIsActive(bool) override;
</ins><span class="cx">
</span><span class="cx"> bool hasDisplayTree() const { return m_displayTree; }
</span><span class="cx"> VTTCueBox* getDisplayTree(const IntSize& videoSize, int fontSize);
</span><span class="lines">@@ -167,7 +167,7 @@
</span><span class="cx"> virtual bool cueContentsMatch(const TextTrackCue&) const override;
</span><span class="cx"> virtual bool doesExtendCue(const TextTrackCue&) const override;
</span><span class="cx">
</span><del>- virtual CueType cueType() const { return WebVTT; }
</del><ins>+ virtual CueType cueType() const override { return WebVTT; }
</ins><span class="cx"> virtual bool isRenderable() const override final { return true; }
</span><span class="cx">
</span><span class="cx"> virtual void didChange() override;
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameNetworkingContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameNetworkingContext.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameNetworkingContext.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/loader/FrameNetworkingContext.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> m_frame = 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool shouldClearReferrerOnHTTPSToHTTPRedirect() const
</del><ins>+ virtual bool shouldClearReferrerOnHTTPSToHTTPRedirect() const override
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: PingLoader finishes without a frame, but it should use its document's referrer policy.
</span><span class="cx"> if (!m_frame)
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedImage.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> void computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio);
</span><span class="cx">
</span><span class="cx"> bool isManuallyCached() const { return m_isManuallyCached; }
</span><del>- virtual bool mustRevalidateDueToCacheHeaders(CachePolicy) const;
</del><ins>+ virtual bool mustRevalidateDueToCacheHeaders(CachePolicy) const override;
</ins><span class="cx"> virtual void load(CachedResourceLoader*, const ResourceLoaderOptions&) override;
</span><span class="cx">
</span><span class="cx"> bool isOriginClean(SecurityOrigin*);
</span></span></pre></div>
<a id="trunkSourceWebCorepageSuspendableTimerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/SuspendableTimer.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/SuspendableTimer.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/page/SuspendableTimer.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> void cancel(); // Equivalent to TimerBase::stop(), whose name conflicts with ActiveDOMObject::stop().
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void fired() = 0;
</del><ins>+ virtual void fired() override = 0;
</ins><span class="cx">
</span><span class="cx"> // ActiveDOMObject
</span><span class="cx"> virtual bool hasPendingActivity() const final override;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollbarh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/Scrollbar.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/Scrollbar.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/platform/Scrollbar.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> virtual bool isAlphaLocked() const override { return m_isAlphaLocked; }
</span><span class="cx"> virtual void setIsAlphaLocked(bool flag) override { m_isAlphaLocked = flag; }
</span><span class="cx">
</span><del>- virtual bool supportsUpdateOnSecondaryThread() const;
</del><ins>+ virtual bool supportsUpdateOnSecondaryThread() const override;
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> Scrollbar(ScrollableArea*, ScrollbarOrientation, ScrollbarControlSize, ScrollbarTheme* = 0, bool isCustomScrollbar = false);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsInbandTextTrackPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -69,9 +69,9 @@
</span><span class="cx"> virtual bool isMainProgramContent() const { return true; }
</span><span class="cx"> virtual bool isEasyToRead() const { return false; }
</span><span class="cx"> virtual bool isDefault() const { return false; }
</span><del>- virtual AtomicString label() const { return emptyAtom; }
- virtual AtomicString language() const { return emptyAtom; }
- virtual AtomicString id() const { return emptyAtom; }
</del><ins>+ virtual AtomicString label() const override { return emptyAtom; }
+ virtual AtomicString language() const override { return emptyAtom; }
+ virtual AtomicString id() const override { return emptyAtom; }
</ins><span class="cx"> virtual AtomicString inBandMetadataTrackDispatchType() const { return emptyAtom; }
</span><span class="cx">
</span><span class="cx"> virtual int textTrackIndex() const { return 0; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -510,7 +510,7 @@
</span><span class="cx"> virtual bool hitTestInlineChildren(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
</span><span class="cx">
</span><span class="cx"> void addOverflowFromFloats();
</span><del>- virtual void addOverflowFromInlineChildren();
</del><ins>+ virtual void addOverflowFromInlineChildren() override;
</ins><span class="cx">
</span><span class="cx"> void fitBorderToLinesIfNeeded(); // Shrink the box in which the border paints if border-fit is set.
</span><span class="cx"> void adjustForBorderFit(LayoutUnit x, LayoutUnit& left, LayoutUnit& right) const;
</span></span></pre></div>
<a id="trunkSourceWebKitiosChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/ChangeLog (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/ChangeLog 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/ios/ChangeLog 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-12-06 Anders Carlsson <andersca@apple.com>
+
+ Fix build with newer versions of clang.
+ rdar://problem/18978687
+
+ Cast the result of +alloc to the right type.
+
+ * Misc/WebGeolocationCoreLocationProvider.mm:
+ (-[WebGeolocationCoreLocationProvider createLocationManager]):
+ * WebCoreSupport/WebSelectionRect.m:
+ (+[WebSelectionRect selectionRect]):
+
</ins><span class="cx"> 2014-11-20 Benjamin Poulain <bpoulain@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove the remaining vestiges of minimal-ui
</span></span></pre></div>
<a id="trunkSourceWebKitiosMiscWebGeolocationCoreLocationProvidermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -65,10 +65,8 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!_locationManager);
</span><span class="cx">
</span><del>-#define CLLocationManager getCLLocationManagerClass()
- _locationManager = adoptNS([[CLLocationManager alloc] init]);
- _lastAuthorizationStatus = [CLLocationManager authorizationStatus];
-#undef CLLocationManager
</del><ins>+ _locationManager = adoptNS([(CLLocationManager *)[getCLLocationManagerClass() alloc] init]);
+ _lastAuthorizationStatus = [getCLLocationManagerClass() authorizationStatus];
</ins><span class="cx">
</span><span class="cx"> [ _locationManager setDelegate:self];
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitiosWebCoreSupportWebSelectionRectm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx">
</span><span class="cx"> + (WebSelectionRect *)selectionRect
</span><span class="cx"> {
</span><del>- return [[[self alloc] init] autorelease];
</del><ins>+ return [[(WebSelectionRect *)[self alloc] init] autorelease];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> + (CGRect)startEdge:(NSArray *)rects
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-12-06 Anders Carlsson <andersca@apple.com>
+
+ Fix build with newer versions of clang.
+ rdar://problem/18978687
+
+ Add missing overrides and missing casts.
+
+ * Storage/WebDatabaseManagerClient.h:
+ * Storage/WebStorageTrackerClient.h:
+ * WebCoreSupport/WebChromeClient.h:
+ * WebCoreSupport/WebFrameLoaderClient.h:
+ * WebCoreSupport/WebInspectorClient.h:
+ * WebView/WebDataSource.mm:
+ (-[WebDataSource _makeRepresentation]):
+ * WebView/WebFrameView.mm:
+ (-[WebFrameView _makeDocumentViewForDataSource:]):
+
</ins><span class="cx"> 2014-12-05 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
</span></span></pre></div>
<a id="trunkSourceWebKitmacStorageWebDatabaseManagerClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Storage/WebDatabaseManagerClient.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Storage/WebDatabaseManagerClient.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/Storage/WebDatabaseManagerClient.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -32,8 +32,8 @@
</span><span class="cx"> static WebDatabaseManagerClient* sharedWebDatabaseManagerClient();
</span><span class="cx">
</span><span class="cx"> virtual ~WebDatabaseManagerClient();
</span><del>- virtual void dispatchDidModifyOrigin(WebCore::SecurityOrigin*);
- virtual void dispatchDidModifyDatabase(WebCore::SecurityOrigin*, const WTF::String& databaseIdentifier);
</del><ins>+ virtual void dispatchDidModifyOrigin(WebCore::SecurityOrigin*) override;
+ virtual void dispatchDidModifyDatabase(WebCore::SecurityOrigin*, const WTF::String& databaseIdentifier) override;
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> virtual void dispatchDidAddNewOrigin(WebCore::SecurityOrigin*) override;
</span><span class="cx"> virtual void dispatchDidDeleteDatabase() override;
</span></span></pre></div>
<a id="trunkSourceWebKitmacStorageWebStorageTrackerClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Storage/WebStorageTrackerClient.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Storage/WebStorageTrackerClient.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/Storage/WebStorageTrackerClient.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> static void dispatchDidModifyOriginOnMainThread(void* context);
</span><span class="cx">
</span><span class="cx"> virtual ~WebStorageTrackerClient();
</span><del>- virtual void dispatchDidModifyOrigin(const String& originIdentifier);
</del><ins>+ virtual void dispatchDidModifyOrigin(const String& originIdentifier) override;
</ins><span class="cx"> virtual void dispatchDidModifyOrigin(PassRefPtr<SecurityOrigin>);
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -166,7 +166,7 @@
</span><span class="cx"> virtual void setNeedsOneShotDrawingSynchronization() override;
</span><span class="cx"> virtual void scheduleCompositingLayerFlush() override;
</span><span class="cx">
</span><del>- virtual CompositingTriggerFlags allowedCompositingTriggers() const
</del><ins>+ virtual CompositingTriggerFlags allowedCompositingTriggers() const override
</ins><span class="cx"> {
</span><span class="cx"> return static_cast<CompositingTriggerFlags>(
</span><span class="cx"> ThreeDTransformTrigger |
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx"> virtual WebCore::Frame* dispatchCreatePage(const WebCore::NavigationAction&) override;
</span><span class="cx"> virtual void dispatchShow() override;
</span><span class="cx">
</span><del>- virtual void dispatchDecidePolicyForResponse(const WebCore::ResourceResponse&, const WebCore::ResourceRequest&, WebCore::FramePolicyFunction);
</del><ins>+ virtual void dispatchDecidePolicyForResponse(const WebCore::ResourceResponse&, const WebCore::ResourceRequest&, WebCore::FramePolicyFunction) override;
</ins><span class="cx"> virtual void dispatchDecidePolicyForNewWindowAction(const WebCore::NavigationAction&, const WebCore::ResourceRequest&, PassRefPtr<WebCore::FormState>, const WTF::String& frameName, WebCore::FramePolicyFunction) override;
</span><span class="cx"> virtual void dispatchDecidePolicyForNavigationAction(const WebCore::NavigationAction&, const WebCore::ResourceRequest&, PassRefPtr<WebCore::FormState>, WebCore::FramePolicyFunction) override;
</span><span class="cx"> virtual void cancelPolicyCheck() override;
</span><span class="lines">@@ -225,15 +225,15 @@
</span><span class="cx">
</span><span class="cx"> NSDictionary *actionDictionary(const WebCore::NavigationAction&, PassRefPtr<WebCore::FormState>) const;
</span><span class="cx">
</span><del>- virtual bool canCachePage() const;
</del><ins>+ virtual bool canCachePage() const override;
</ins><span class="cx">
</span><del>- virtual PassRefPtr<WebCore::FrameNetworkingContext> createNetworkingContext();
</del><ins>+ virtual PassRefPtr<WebCore::FrameNetworkingContext> createNetworkingContext() override;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(REQUEST_AUTOCOMPLETE)
</span><span class="cx"> virtual void didRequestAutocomplete(PassRefPtr<WebCore::FormState>) override { }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- virtual bool shouldPaintBrokenImage(const WebCore::URL&) const;
</del><ins>+ virtual bool shouldPaintBrokenImage(const WebCore::URL&) const override;
</ins><span class="cx">
</span><span class="cx"> #if USE(QUICK_LOOK)
</span><span class="cx"> virtual void didCreateQuickLookHandle(WebCore::QuickLookHandle&) override;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -110,22 +110,22 @@
</span><span class="cx">
</span><span class="cx"> void attachAvailabilityChanged(bool);
</span><span class="cx">
</span><del>- virtual void frontendLoaded();
</del><ins>+ virtual void frontendLoaded() override;
</ins><span class="cx">
</span><del>- virtual String localizedStringsURL();
</del><ins>+ virtual String localizedStringsURL() override;
</ins><span class="cx">
</span><del>- virtual void bringToFront();
- virtual void closeWindow();
</del><ins>+ virtual void bringToFront() override;
+ virtual void closeWindow() override;
</ins><span class="cx"> virtual void disconnectFromBackend();
</span><span class="cx">
</span><del>- virtual void attachWindow(DockSide);
- virtual void detachWindow();
</del><ins>+ virtual void attachWindow(DockSide) override;
+ virtual void detachWindow() override;
</ins><span class="cx">
</span><del>- virtual void setAttachedWindowHeight(unsigned height);
- virtual void setAttachedWindowWidth(unsigned height);
</del><ins>+ virtual void setAttachedWindowHeight(unsigned height) override;
+ virtual void setAttachedWindowWidth(unsigned height) override;
</ins><span class="cx"> virtual void setToolbarHeight(unsigned) override;
</span><span class="cx">
</span><del>- virtual void inspectedURLChanged(const String& newURL);
</del><ins>+ virtual void inspectedURLChanged(const String& newURL) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void updateWindowTitle() const;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebDataSourcemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebDataSource.mm (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebDataSource.mm 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/WebView/WebDataSource.mm 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -382,7 +382,7 @@
</span><span class="cx">
</span><span class="cx"> // Check if the data source was already bound?
</span><span class="cx"> if (![[self representation] isKindOfClass:repClass]) {
</span><del>- id newRep = repClass != nil ? [[repClass alloc] init] : nil;
</del><ins>+ id newRep = repClass != nil ? [(NSObject *)[repClass alloc] init] : nil;
</ins><span class="cx"> [self _setRepresentation:(id <WebDocumentRepresentation>)newRep];
</span><span class="cx"> [newRep release];
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebFrameViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebFrameView.mm (176911 => 176912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebFrameView.mm 2014-12-06 21:10:23 UTC (rev 176911)
+++ trunk/Source/WebKit/mac/WebView/WebFrameView.mm 2014-12-06 21:23:57 UTC (rev 176912)
</span><span class="lines">@@ -211,7 +211,7 @@
</span><span class="cx"> if (dataSourceRepresentation && [dataSourceRepresentation class] == viewClass)
</span><span class="cx"> documentView = (NSView <WebDocumentView> *)[dataSourceRepresentation retain];
</span><span class="cx"> else
</span><del>- documentView = [[viewClass alloc] init];
</del><ins>+ documentView = [(NSView <WebDocumentView> *)[viewClass alloc] init];
</ins><span class="cx"> } else
</span><span class="cx"> documentView = nil;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>