<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176815] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176815">176815</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2014-12-04 13:56:04 -0800 (Thu, 04 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
https://bugs.webkit.org/show_bug.cgi?id=138898
Reviewed by Mark Rowe.
Source/WebInspectorUI:
In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
we will copy all resources (for Tests) and still do the combine and
optimize phase for normal Production inspection resources.
* Scripts/copy-user-interface-resources.pl:
LayoutTests:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIScriptscopyuserinterfaceresourcespl">trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (176814 => 176815)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/LayoutTests/ChangeLog 2014-12-04 21:56:04 UTC (rev 176815)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-12-04 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
+ https://bugs.webkit.org/show_bug.cgi?id=138898
+
+ Reviewed by Mark Rowe.
+
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2014-12-04 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL][WebGL] Remove junk webgl layout tests from TestExpectations
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (176814 => 176815)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-12-04 21:56:04 UTC (rev 176815)
</span><span class="lines">@@ -1413,19 +1413,17 @@
</span><span class="cx"> # FIXME: Needs bugzilla (<rdar://problem/18273139>)
</span><span class="cx"> [ Yosemite+ ] storage/websql/sql-error-codes.html [ Failure ]
</span><span class="cx">
</span><del>-# Some inspector tests fail when run from Production builds due to missing test resources.
-# FIXME: Needs bugzilla (<rdar://problem/16200275>)
</del><span class="cx"> # Also, these tests are flaky in Debug/Release builds, <https://bugs.webkit.org/show_bug.cgi?id=138636>
</span><span class="cx"> # and <https://bugs.webkit.org/show_bug.cgi?id=129817>.
</span><del>-[ Yosemite+ ] inspector/css/matched-style-properties.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/css/pseudo-element-matches.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/css/selector-specificity.html [ Pass Failure Crash ]
</del><ins>+[ Yosemite+ ] inspector/css/matched-style-properties.html [ Pass Failure ]
+[ Yosemite+ ] inspector/css/pseudo-element-matches.html [ Pass Failure ]
+[ Yosemite+ ] inspector/css/selector-specificity.html [ Pass Failure ]
</ins><span class="cx"> [ Yosemite+ ] inspector/dom/content-flow-content-removal.html [ Skip ]
</span><span class="cx"> [ Yosemite+ ] inspector/dom/content-flow-list.html [ Skip ]
</span><del>-[ Yosemite+ ] inspector/event-listener-set.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/event-listener.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/model/parse-script-syntax-tree.html [ Pass Failure Crash ]
-[ Yosemite+ ] inspector/protocol-promise-result.html [ Pass Failure Crash ]
</del><ins>+[ Yosemite+ ] inspector/event-listener-set.html [ Pass Failure ]
+[ Yosemite+ ] inspector/event-listener.html [ Pass Failure ]
+[ Yosemite+ ] inspector/model/parse-script-syntax-tree.html [ Pass Failure ]
+[ Yosemite+ ] inspector/protocol-promise-result.html [ Pass Failure ]
</ins><span class="cx"> [ Yosemite+ ] inspector/test-harness-trivially-works.html [ Skip ]
</span><span class="cx">
</span><span class="cx"> # Specific to Yosemite's font fallback
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (176814 => 176815)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-12-04 21:56:04 UTC (rev 176815)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-12-04 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
+ https://bugs.webkit.org/show_bug.cgi?id=138898
+
+ Reviewed by Mark Rowe.
+
+ In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
+ we will copy all resources (for Tests) and still do the combine and
+ optimize phase for normal Production inspection resources.
+
+ * Scripts/copy-user-interface-resources.pl:
+
</ins><span class="cx"> 2014-12-03 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIScriptscopyuserinterfaceresourcespl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl (176814 => 176815)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2014-12-04 21:49:43 UTC (rev 176814)
+++ trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2014-12-04 21:56:04 UTC (rev 176815)
</span><span class="lines">@@ -111,6 +111,13 @@
</span><span class="cx"> # Copy over dynamically loaded files from other frameworks, even if we aren't combining resources.
</span><span class="cx"> copy(File::Spec->catfile($ENV{'JAVASCRIPTCORE_PRIVATE_HEADERS_DIR'}, 'InspectorBackendCommands.js'), File::Spec->catfile($protocolDir, 'InspectorBackendCommands.js')) or die "Copy of InspectorBackendCommands.js failed: $!";
</span><span class="cx">
</span><ins>+if (defined $ENV{'FORCE_TOOL_INSTALL'} && ($ENV{'FORCE_TOOL_INSTALL'} eq 'YES')) {
+ # Copy all files over individually to ensure we have Test.html / Test.js and files included from Test.html.
+ # We may then proceed to include combined & optimized resources which will output mostly to different paths
+ # but overwrite Main.html / Main.js with optimized versions.
+ ditto($uiRoot, $targetResourcePath);
+}
+
</ins><span class="cx"> if (defined $ENV{'COMBINE_INSPECTOR_RESOURCES'} && ($ENV{'COMBINE_INSPECTOR_RESOURCES'} eq 'YES')) {
</span><span class="cx"> my $combineResourcesCmd = File::Spec->catfile($scriptsRoot, 'combine-resources.pl');
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>