<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176670] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176670">176670</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-12-02 10:12:57 -0800 (Tue, 02 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove visited link handling from PageGroup
https://bugs.webkit.org/show_bug.cgi?id=139185
Reviewed by Sam Weinig.
Source/WebCore:
* CMakeLists.txt:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* loader/HistoryController.cpp:
* page/Chrome.cpp:
(WebCore::ChromeClient::populateVisitedLinks): Deleted.
* page/ChromeClient.h:
* page/DefaultVisitedLinkStore.cpp: Removed.
* page/DefaultVisitedLinkStore.h: Removed.
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::visitedLinkStore):
(WebCore::Page::setVisitedLinkStore):
(WebCore::Page::removeAllVisitedLinks): Deleted.
* page/Page.h:
* page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::visitedLinkStore): Deleted.
(WebCore::PageGroup::isLinkVisited): Deleted.
(WebCore::PageGroup::addVisitedLinkHash): Deleted.
(WebCore::PageGroup::addVisitedLink): Deleted.
(WebCore::PageGroup::removeVisitedLink): Deleted.
(WebCore::PageGroup::removeVisitedLinks): Deleted.
(WebCore::PageGroup::removeAllVisitedLinks): Deleted.
(WebCore::PageGroup::setShouldTrackVisitedLinks): Deleted.
* page/PageGroup.h:
Source/WebKit/mac:
* History/WebHistory.mm:
(-[WebHistoryPrivate removeItemForURLString:]):
(-[WebHistoryPrivate removeAllItems]):
(+[WebHistory setOptionalSharedHistory:]):
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
(+[WebHistory _removeAllVisitedLinks]):
(-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
(-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
* History/WebHistoryInternal.h:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::populateVisitedLinks): Deleted.
* WebView/WebView.mm:
(-[WebView addVisitedLinks:]):
(-[WebView removeVisitedLink:]):
Source/WebKit/win:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks): Deleted.
* WebCoreSupport/WebChromeClient.h:
Source/WebKit2:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::populateVisitedLinks): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>
<li><a href="#trunkSourceWebCoreWebCorevcxprojWebCorevcxproj">trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj</a></li>
<li><a href="#trunkSourceWebCoreWebCorevcxprojWebCorevcxprojfilters">trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCoreloaderHistoryControllercpp">trunk/Source/WebCore/loader/HistoryController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageChromecpp">trunk/Source/WebCore/page/Chrome.cpp</a></li>
<li><a href="#trunkSourceWebCorepageChromeClienth">trunk/Source/WebCore/page/ChromeClient.h</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageh">trunk/Source/WebCore/page/Page.h</a></li>
<li><a href="#trunkSourceWebCorepagePageGroupcpp">trunk/Source/WebCore/page/PageGroup.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageGrouph">trunk/Source/WebCore/page/PageGroup.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistorymm">trunk/Source/WebKit/mac/History/WebHistory.mm</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistoryInternalh">trunk/Source/WebKit/mac/History/WebHistoryInternal.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebChromeClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebChromeClientmm">trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebChromeClientcpp">trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebChromeClienth">trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClienth">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorepageDefaultVisitedLinkStorecpp">trunk/Source/WebCore/page/DefaultVisitedLinkStore.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDefaultVisitedLinkStoreh">trunk/Source/WebCore/page/DefaultVisitedLinkStore.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1889,7 +1889,6 @@
</span><span class="cx"> page/DOMWindowExtension.cpp
</span><span class="cx"> page/DOMWindowProperty.cpp
</span><span class="cx"> page/DebugPageOverlays.cpp
</span><del>- page/DefaultVisitedLinkStore.cpp
</del><span class="cx"> page/DeviceController.cpp
</span><span class="cx"> page/DiagnosticLoggingKeys.cpp
</span><span class="cx"> page/DragController.cpp
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/ChangeLog 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1,3 +1,40 @@
</span><ins>+2014-12-02 Anders Carlsson <andersca@apple.com>
+
+ Remove visited link handling from PageGroup
+ https://bugs.webkit.org/show_bug.cgi?id=139185
+
+ Reviewed by Sam Weinig.
+
+ * CMakeLists.txt:
+ * WebCore.exp.in:
+ * WebCore.vcxproj/WebCore.vcxproj:
+ * WebCore.vcxproj/WebCore.vcxproj.filters:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/HistoryController.cpp:
+ * page/Chrome.cpp:
+ (WebCore::ChromeClient::populateVisitedLinks): Deleted.
+ * page/ChromeClient.h:
+ * page/DefaultVisitedLinkStore.cpp: Removed.
+ * page/DefaultVisitedLinkStore.h: Removed.
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ (WebCore::Page::~Page):
+ (WebCore::Page::visitedLinkStore):
+ (WebCore::Page::setVisitedLinkStore):
+ (WebCore::Page::removeAllVisitedLinks): Deleted.
+ * page/Page.h:
+ * page/PageGroup.cpp:
+ (WebCore::PageGroup::PageGroup):
+ (WebCore::PageGroup::visitedLinkStore): Deleted.
+ (WebCore::PageGroup::isLinkVisited): Deleted.
+ (WebCore::PageGroup::addVisitedLinkHash): Deleted.
+ (WebCore::PageGroup::addVisitedLink): Deleted.
+ (WebCore::PageGroup::removeVisitedLink): Deleted.
+ (WebCore::PageGroup::removeVisitedLinks): Deleted.
+ (WebCore::PageGroup::removeAllVisitedLinks): Deleted.
+ (WebCore::PageGroup::setShouldTrackVisitedLinks): Deleted.
+ * page/PageGroup.h:
+
</ins><span class="cx"> 2014-12-02 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Use references instead of pointers in EditingStyle
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreexpin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.exp.in 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1550,13 +1550,8 @@
</span><span class="cx"> __ZN7WebCore9PageCache11setCapacityEi
</span><span class="cx"> __ZN7WebCore9PageCache33markPagesForVistedLinkStyleRecalcEv
</span><span class="cx"> __ZN7WebCore9PageCache6removeEPNS_11HistoryItemE
</span><del>-__ZN7WebCore9PageGroup13isLinkVisitedEy
-__ZN7WebCore9PageGroup14addVisitedLinkEPKtm
</del><span class="cx"> __ZN7WebCore9PageGroup16syncLocalStorageEv
</span><span class="cx"> __ZN7WebCore9PageGroup17closeLocalStorageEv
</span><del>-__ZN7WebCore9PageGroup18addVisitedLinkHashEy
-__ZN7WebCore9PageGroup21removeAllVisitedLinksEv
-__ZN7WebCore9PageGroup26setShouldTrackVisitedLinksEb
</del><span class="cx"> __ZN7WebCore9PageGroup30closeIdleLocalStorageDatabasesEv
</span><span class="cx"> __ZN7WebCore9PageGroup9pageGroupERKN3WTF6StringE
</span><span class="cx"> __ZN7WebCore9Scrollbar11mouseExitedEv
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorevcxprojWebCorevcxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -7153,7 +7153,6 @@
</span><span class="cx"> <ClCompile Include="..\page\DOMWindow.cpp" />
</span><span class="cx"> <ClCompile Include="..\page\DOMWindowExtension.cpp" />
</span><span class="cx"> <ClCompile Include="..\page\DOMWindowProperty.cpp" />
</span><del>- <ClCompile Include="..\page\DefaultVisitedLinkStore.cpp" />
</del><span class="cx"> <ClCompile Include="..\page\DebugPageOverlays.cpp" />
</span><span class="cx"> <ClCompile Include="..\page\DragController.cpp" />
</span><span class="cx"> <ClCompile Include="..\page\scrolling\coordinatedgraphics\ScrollingCoordinatorCoordinatedGraphics.cpp" />
</span><span class="lines">@@ -19168,7 +19167,6 @@
</span><span class="cx"> <ClInclude Include="..\page\DOMWindowExtension.h" />
</span><span class="cx"> <ClInclude Include="..\page\DOMWindowProperty.h" />
</span><span class="cx"> <ClInclude Include="..\page\DebugPageOverlays.h" />
</span><del>- <ClInclude Include="..\page\DefaultVisitedLinkStore.h" />
</del><span class="cx"> <ClInclude Include="..\page\DragActions.h" />
</span><span class="cx"> <ClInclude Include="..\page\DragClient.h" />
</span><span class="cx"> <ClInclude Include="..\page\DragController.h" />
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorevcxprojWebCorevcxprojfilters"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -738,9 +738,6 @@
</span><span class="cx"> <ClCompile Include="..\page\DebugPageOverlays.cpp">
</span><span class="cx"> <Filter>page</Filter>
</span><span class="cx"> </ClCompile>
</span><del>- <ClCompile Include="..\page\DefaultVisitedLinkStore.cpp">
- <Filter>page</Filter>
- </ClCompile>
</del><span class="cx"> <ClCompile Include="..\page\DragController.cpp">
</span><span class="cx"> <Filter>page</Filter>
</span><span class="cx"> </ClCompile>
</span><span class="lines">@@ -15137,9 +15134,6 @@
</span><span class="cx"> <ClInclude Include="..\page\DebugPageOverlays.h">
</span><span class="cx"> <Filter>page</Filter>
</span><span class="cx"> </ClInclude>
</span><del>- <ClInclude Include="..\page\DefaultVisitedLinkStore.h">
- <Filter>page</Filter>
- </ClInclude>
</del><span class="cx"> <ClInclude Include="..\rendering\BorderEdge.h">
</span><span class="cx"> <Filter>rendering</Filter>
</span><span class="cx"> </ClInclude>
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -910,8 +910,6 @@
</span><span class="cx"> 1AEF4E67170E160300AB2799 /* CachedFontClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AEF4E66170E160300AB2799 /* CachedFontClient.h */; };
</span><span class="cx"> 1AEF4E69170E174800AB2799 /* CachedSVGDocumentClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AEF4E68170E174800AB2799 /* CachedSVGDocumentClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> 1AF326790D78B9440068F0C4 /* EditorClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AF326770D78B9440068F0C4 /* EditorClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><del>- 1AF4CEE918BC350100BC2D34 /* DefaultVisitedLinkStore.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AF4CEE718BC350100BC2D34 /* DefaultVisitedLinkStore.cpp */; };
- 1AF4CEEA18BC350100BC2D34 /* DefaultVisitedLinkStore.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AF4CEE818BC350100BC2D34 /* DefaultVisitedLinkStore.h */; };
</del><span class="cx"> 1AF4CEEC18BC3C1B00BC2D34 /* VisitedLinkStore.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AF4CEEB18BC3C1B00BC2D34 /* VisitedLinkStore.cpp */; };
</span><span class="cx"> 1AF62EE614DA22A70041556C /* ScrollingCoordinatorMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AF62EE314DA22A70041556C /* ScrollingCoordinatorMac.mm */; };
</span><span class="cx"> 1AF62EE714DA22A70041556C /* ScrollingCoordinator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AF62EE414DA22A70041556C /* ScrollingCoordinator.cpp */; };
</span><span class="lines">@@ -7932,8 +7930,6 @@
</span><span class="cx"> 1AEF4E66170E160300AB2799 /* CachedFontClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedFontClient.h; sourceTree = "<group>"; };
</span><span class="cx"> 1AEF4E68170E174800AB2799 /* CachedSVGDocumentClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedSVGDocumentClient.h; sourceTree = "<group>"; };
</span><span class="cx"> 1AF326770D78B9440068F0C4 /* EditorClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditorClient.h; sourceTree = "<group>"; };
</span><del>- 1AF4CEE718BC350100BC2D34 /* DefaultVisitedLinkStore.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DefaultVisitedLinkStore.cpp; sourceTree = "<group>"; };
- 1AF4CEE818BC350100BC2D34 /* DefaultVisitedLinkStore.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DefaultVisitedLinkStore.h; sourceTree = "<group>"; };
</del><span class="cx"> 1AF4CEEB18BC3C1B00BC2D34 /* VisitedLinkStore.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = VisitedLinkStore.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 1AF62EE314DA22A70041556C /* ScrollingCoordinatorMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingCoordinatorMac.mm; sourceTree = "<group>"; };
</span><span class="cx"> 1AF62EE414DA22A70041556C /* ScrollingCoordinator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScrollingCoordinator.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -16607,8 +16603,6 @@
</span><span class="cx"> 975CA289130365F800E99AD9 /* Crypto.idl */,
</span><span class="cx"> 0F6A12BB1A00923700C6DE72 /* DebugPageOverlays.cpp */,
</span><span class="cx"> 0F6A12BC1A00923700C6DE72 /* DebugPageOverlays.h */,
</span><del>- 1AF4CEE718BC350100BC2D34 /* DefaultVisitedLinkStore.cpp */,
- 1AF4CEE818BC350100BC2D34 /* DefaultVisitedLinkStore.h */,
</del><span class="cx"> CCC2B51015F613060048CDD6 /* DeviceClient.h */,
</span><span class="cx"> CCC2B51115F613060048CDD6 /* DeviceController.cpp */,
</span><span class="cx"> CCC2B51215F613060048CDD6 /* DeviceController.h */,
</span><span class="lines">@@ -23853,7 +23847,6 @@
</span><span class="cx"> 41A3D58F101C152D00316D07 /* DedicatedWorkerThread.h in Headers */,
</span><span class="cx"> FD06DFA6134A4DEF006F5D7D /* DefaultAudioDestinationNode.h in Headers */,
</span><span class="cx"> 4167EBF6102962BA003D252A /* DefaultSharedWorkerRepository.h in Headers */,
</span><del>- 1AF4CEEA18BC350100BC2D34 /* DefaultVisitedLinkStore.h in Headers */,
</del><span class="cx"> FD31602C12B0267600C1A359 /* DelayDSPKernel.h in Headers */,
</span><span class="cx"> FD31602E12B0267600C1A359 /* DelayNode.h in Headers */,
</span><span class="cx"> FD31603112B0267600C1A359 /* DelayProcessor.h in Headers */,
</span><span class="lines">@@ -27531,7 +27524,6 @@
</span><span class="cx"> 41A3D58E101C152D00316D07 /* DedicatedWorkerThread.cpp in Sources */,
</span><span class="cx"> FD06DFA5134A4DEF006F5D7D /* DefaultAudioDestinationNode.cpp in Sources */,
</span><span class="cx"> 4167EBF5102962BA003D252A /* DefaultSharedWorkerRepository.cpp in Sources */,
</span><del>- 1AF4CEE918BC350100BC2D34 /* DefaultVisitedLinkStore.cpp in Sources */,
</del><span class="cx"> FD31602B12B0267600C1A359 /* DelayDSPKernel.cpp in Sources */,
</span><span class="cx"> FD31602D12B0267600C1A359 /* DelayNode.cpp in Sources */,
</span><span class="cx"> FD31603012B0267600C1A359 /* DelayProcessor.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderHistoryControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/HistoryController.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/HistoryController.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/loader/HistoryController.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -41,6 +41,7 @@
</span><span class="cx"> #include "FrameTree.h"
</span><span class="cx"> #include "FrameView.h"
</span><span class="cx"> #include "HistoryItem.h"
</span><ins>+#include "LinkHash.h"
</ins><span class="cx"> #include "Logging.h"
</span><span class="cx"> #include "MainFrame.h"
</span><span class="cx"> #include "Page.h"
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Chrome.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Chrome.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/Chrome.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -572,10 +572,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void ChromeClient::populateVisitedLinks()
-{
-}
-
</del><span class="cx"> bool ChromeClient::shouldReplaceWithGeneratedFileForUpload(const String&, String&)
</span><span class="cx"> {
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/ChromeClient.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/ChromeClient.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/ChromeClient.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -228,8 +228,6 @@
</span><span class="cx"> virtual void annotatedRegionsChanged();
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- virtual void populateVisitedLinks();
-
</del><span class="cx"> virtual bool shouldReplaceWithGeneratedFileForUpload(const String& path, String& generatedFilename);
</span><span class="cx"> virtual String generateReplacementFile(const String& path);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageDefaultVisitedLinkStorecpp"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/page/DefaultVisitedLinkStore.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DefaultVisitedLinkStore.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/DefaultVisitedLinkStore.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1,57 +0,0 @@
</span><del>-/*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "DefaultVisitedLinkStore.h"
-
-#include "Page.h"
-#include "PageGroup.h"
-
-namespace WebCore {
-
-PassRefPtr<DefaultVisitedLinkStore> DefaultVisitedLinkStore::create()
-{
- return adoptRef(new DefaultVisitedLinkStore);
-}
-
-DefaultVisitedLinkStore::DefaultVisitedLinkStore()
-{
-}
-
-DefaultVisitedLinkStore::~DefaultVisitedLinkStore()
-{
-}
-
-bool DefaultVisitedLinkStore::isLinkVisited(Page& page, LinkHash linkHash, const URL&, const AtomicString&)
-{
- return page.group().isLinkVisited(linkHash);
-}
-
-void DefaultVisitedLinkStore::addVisitedLink(Page& page, LinkHash linkHash)
-{
- page.group().addVisitedLinkHash(linkHash);
-}
-
-} // namespace WebCore
</del></span></pre></div>
<a id="trunkSourceWebCorepageDefaultVisitedLinkStoreh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/page/DefaultVisitedLinkStore.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DefaultVisitedLinkStore.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/DefaultVisitedLinkStore.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1,47 +0,0 @@
</span><del>-/*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef DefaultVisitedLinkStore_h
-#define DefaultVisitedLinkStore_h
-
-#include "VisitedLinkStore.h"
-
-namespace WebCore {
-
-class DefaultVisitedLinkStore : public VisitedLinkStore {
-public:
- static PassRefPtr<DefaultVisitedLinkStore> create();
- virtual ~DefaultVisitedLinkStore();
-
-private:
- DefaultVisitedLinkStore();
-
- virtual bool isLinkVisited(Page&, LinkHash, const URL& baseURL, const AtomicString& attributeURL) override;
- virtual void addVisitedLink(Page&, LinkHash) override;
-};
-
-} // namespace WebCore
-
-#endif // DefaultVisitedLinkStore_h
</del></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/Page.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -203,7 +203,7 @@
</span><span class="cx"> , m_lastSpatialNavigationCandidatesCount(0) // NOTE: Only called from Internals for Spatial Navigation testing.
</span><span class="cx"> , m_framesHandlingBeforeUnloadEvent(0)
</span><span class="cx"> , m_userContentController(WTF::move(pageConfiguration.userContentController))
</span><del>- , m_visitedLinkStore(WTF::move(pageConfiguration.visitedLinkStore))
</del><ins>+ , m_visitedLinkStore(*WTF::move(pageConfiguration.visitedLinkStore))
</ins><span class="cx"> , m_sessionID(SessionID::defaultSessionID())
</span><span class="cx"> , m_isClosing(false)
</span><span class="cx"> , m_isPlayingAudio(false)
</span><span class="lines">@@ -215,8 +215,7 @@
</span><span class="cx"> if (m_userContentController)
</span><span class="cx"> m_userContentController->addPage(*this);
</span><span class="cx">
</span><del>- if (m_visitedLinkStore)
- m_visitedLinkStore->addPage(*this);
</del><ins>+ m_visitedLinkStore->addPage(*this);
</ins><span class="cx">
</span><span class="cx"> if (!allPages) {
</span><span class="cx"> allPages = new HashSet<Page*>;
</span><span class="lines">@@ -270,8 +269,7 @@
</span><span class="cx">
</span><span class="cx"> if (m_userContentController)
</span><span class="cx"> m_userContentController->removePage(*this);
</span><del>- if (m_visitedLinkStore)
- m_visitedLinkStore->removePage(*this);
</del><ins>+ m_visitedLinkStore->removePage(*this);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Page::clearPreviousItemFromAllPages(HistoryItem* item)
</span><span class="lines">@@ -1034,21 +1032,6 @@
</span><span class="cx"> return m_userStyleSheet;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Page::removeAllVisitedLinks()
-{
- if (!allPages)
- return;
- HashSet<PageGroup*> groups;
- HashSet<Page*>::iterator pagesEnd = allPages->end();
- for (HashSet<Page*>::iterator it = allPages->begin(); it != pagesEnd; ++it) {
- if (PageGroup* group = (*it)->groupPtr())
- groups.add(group);
- }
- HashSet<PageGroup*>::iterator groupsEnd = groups.end();
- for (HashSet<PageGroup*>::iterator it = groups.begin(); it != groupsEnd; ++it)
- (*it)->removeVisitedLinks();
-}
-
</del><span class="cx"> void Page::invalidateStylesForAllLinks()
</span><span class="cx"> {
</span><span class="cx"> for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext())
</span><span class="lines">@@ -1631,17 +1614,12 @@
</span><span class="cx">
</span><span class="cx"> VisitedLinkStore& Page::visitedLinkStore()
</span><span class="cx"> {
</span><del>- if (m_visitedLinkStore)
- return *m_visitedLinkStore;
-
- return group().visitedLinkStore();
</del><ins>+ return m_visitedLinkStore;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Page::setVisitedLinkStore(PassRef<VisitedLinkStore> visitedLinkStore)
</span><span class="cx"> {
</span><del>- if (m_visitedLinkStore)
- m_visitedLinkStore->removePage(*this);
-
</del><ins>+ m_visitedLinkStore->removePage(*this);
</ins><span class="cx"> m_visitedLinkStore = WTF::move(visitedLinkStore);
</span><span class="cx"> m_visitedLinkStore->addPage(*this);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/Page.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -315,8 +315,6 @@
</span><span class="cx"> void setDebugger(JSC::Debugger*);
</span><span class="cx"> JSC::Debugger* debugger() const { return m_debugger; }
</span><span class="cx">
</span><del>- static void removeAllVisitedLinks();
-
</del><span class="cx"> WEBCORE_EXPORT void invalidateStylesForAllLinks();
</span><span class="cx"> WEBCORE_EXPORT void invalidateStylesForLink(LinkHash);
</span><span class="cx">
</span><span class="lines">@@ -570,7 +568,7 @@
</span><span class="cx"> unsigned m_framesHandlingBeforeUnloadEvent;
</span><span class="cx">
</span><span class="cx"> RefPtr<UserContentController> m_userContentController;
</span><del>- RefPtr<VisitedLinkStore> m_visitedLinkStore;
</del><ins>+ Ref<VisitedLinkStore> m_visitedLinkStore;
</ins><span class="cx">
</span><span class="cx"> HashSet<ViewStateChangeObserver*> m_viewStateChangeObservers;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageGroupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageGroup.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageGroup.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/PageGroup.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx"> #include "Chrome.h"
</span><span class="cx"> #include "ChromeClient.h"
</span><span class="cx"> #include "DOMWrapperWorld.h"
</span><del>-#include "DefaultVisitedLinkStore.h"
</del><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "DocumentStyleSheetCollection.h"
</span><span class="cx"> #include "GroupSettings.h"
</span><span class="lines">@@ -39,7 +38,6 @@
</span><span class="cx"> #include "SecurityOrigin.h"
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include "StorageNamespace.h"
</span><del>-#include "VisitedLinkStore.h"
</del><span class="cx"> #include <wtf/StdLibExtras.h>
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="lines">@@ -60,19 +58,15 @@
</span><span class="cx">
</span><span class="cx"> // --------
</span><span class="cx">
</span><del>-static bool shouldTrackVisitedLinks = false;
-
</del><span class="cx"> PageGroup::PageGroup(const String& name)
</span><span class="cx"> : m_name(name)
</span><del>- , m_visitedLinksPopulated(false)
</del><span class="cx"> , m_identifier(getUniqueIdentifier())
</span><span class="cx"> , m_groupSettings(std::make_unique<GroupSettings>())
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PageGroup::PageGroup(Page& page)
</span><del>- : m_visitedLinksPopulated(false)
- , m_identifier(getUniqueIdentifier())
</del><ins>+ : m_identifier(getUniqueIdentifier())
</ins><span class="cx"> , m_groupSettings(std::make_unique<GroupSettings>())
</span><span class="cx"> {
</span><span class="cx"> addPage(page);
</span><span class="lines">@@ -170,94 +164,6 @@
</span><span class="cx"> m_pages.remove(&page);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-VisitedLinkStore& PageGroup::visitedLinkStore()
-{
- if (!m_visitedLinkStore)
- m_visitedLinkStore = DefaultVisitedLinkStore::create();
-
- return *m_visitedLinkStore;
-}
-
-bool PageGroup::isLinkVisited(LinkHash visitedLinkHash)
-{
- if (!m_visitedLinksPopulated) {
- m_visitedLinksPopulated = true;
- ASSERT(!m_pages.isEmpty());
- (*m_pages.begin())->chrome().client().populateVisitedLinks();
- }
- return m_visitedLinkHashes.contains(visitedLinkHash);
-}
-
-void PageGroup::addVisitedLinkHash(LinkHash hash)
-{
- if (shouldTrackVisitedLinks)
- addVisitedLink(hash);
-}
-
-inline void PageGroup::addVisitedLink(LinkHash hash)
-{
- ASSERT(shouldTrackVisitedLinks);
- if (!m_visitedLinkHashes.add(hash).isNewEntry)
- return;
- for (auto& page : m_pages)
- page->invalidateStylesForLink(hash);
- pageCache()->markPagesForVistedLinkStyleRecalc();
-}
-
-void PageGroup::addVisitedLink(const URL& url)
-{
- if (!shouldTrackVisitedLinks)
- return;
- ASSERT(!url.isEmpty());
- addVisitedLink(visitedLinkHash(url.string()));
-}
-
-void PageGroup::addVisitedLink(const UChar* characters, size_t length)
-{
- if (!shouldTrackVisitedLinks)
- return;
- addVisitedLink(visitedLinkHash(characters, length));
-}
-
-void PageGroup::removeVisitedLink(const URL& url)
-{
- LinkHash hash = visitedLinkHash(url.string());
- ASSERT(m_visitedLinkHashes.contains(hash));
- m_visitedLinkHashes.remove(hash);
-
- // FIXME: Why can't we just invalidate the single visited link hash here?
- for (auto& page : m_pages)
- page->invalidateStylesForAllLinks();
- pageCache()->markPagesForVistedLinkStyleRecalc();
-}
-
-void PageGroup::removeVisitedLinks()
-{
- m_visitedLinksPopulated = false;
- if (m_visitedLinkHashes.isEmpty())
- return;
- m_visitedLinkHashes.clear();
-
- for (auto& page : m_pages)
- page->invalidateStylesForAllLinks();
- pageCache()->markPagesForVistedLinkStyleRecalc();
-}
-
-void PageGroup::removeAllVisitedLinks()
-{
- Page::removeAllVisitedLinks();
- pageCache()->markPagesForVistedLinkStyleRecalc();
-}
-
-void PageGroup::setShouldTrackVisitedLinks(bool shouldTrack)
-{
- if (shouldTrackVisitedLinks == shouldTrack)
- return;
- shouldTrackVisitedLinks = shouldTrack;
- if (!shouldTrackVisitedLinks)
- removeAllVisitedLinks();
-}
-
</del><span class="cx"> StorageNamespace* PageGroup::localStorage()
</span><span class="cx"> {
</span><span class="cx"> if (!m_localStorage)
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageGrouph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageGroup.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageGroup.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebCore/page/PageGroup.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -26,7 +26,6 @@
</span><span class="cx"> #ifndef PageGroup_h
</span><span class="cx"> #define PageGroup_h
</span><span class="cx">
</span><del>-#include "LinkHash.h"
</del><span class="cx"> #include "SecurityOriginHash.h"
</span><span class="cx"> #include "Supplementable.h"
</span><span class="cx"> #include "UserScript.h"
</span><span class="lines">@@ -42,7 +41,6 @@
</span><span class="cx"> class Page;
</span><span class="cx"> class SecurityOrigin;
</span><span class="cx"> class StorageNamespace;
</span><del>- class VisitedLinkStore;
</del><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx"> class CaptionPreferencesChangedListener;
</span><span class="lines">@@ -71,19 +69,6 @@
</span><span class="cx"> void addPage(Page&);
</span><span class="cx"> void removePage(Page&);
</span><span class="cx">
</span><del>- VisitedLinkStore& visitedLinkStore();
-
- WEBCORE_EXPORT bool isLinkVisited(LinkHash);
-
- void addVisitedLink(const URL&);
- WEBCORE_EXPORT void addVisitedLink(const UChar*, size_t);
- WEBCORE_EXPORT void addVisitedLinkHash(LinkHash);
- WEBCORE_EXPORT void removeVisitedLink(const URL&);
- void removeVisitedLinks();
-
- WEBCORE_EXPORT static void setShouldTrackVisitedLinks(bool);
- WEBCORE_EXPORT static void removeAllVisitedLinks();
-
</del><span class="cx"> const String& name() { return m_name; }
</span><span class="cx"> unsigned identifier() { return m_identifier; }
</span><span class="cx">
</span><span class="lines">@@ -100,16 +85,9 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- WEBCORE_EXPORT void addVisitedLink(LinkHash);
-
</del><span class="cx"> String m_name;
</span><span class="cx"> HashSet<Page*> m_pages;
</span><span class="cx">
</span><del>- RefPtr<VisitedLinkStore> m_visitedLinkStore;
-
- HashSet<LinkHash, LinkHashHash> m_visitedLinkHashes;
- bool m_visitedLinksPopulated;
-
</del><span class="cx"> unsigned m_identifier;
</span><span class="cx"> RefPtr<StorageNamespace> m_localStorage;
</span><span class="cx"> HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageNamespace>> m_transientLocalStorageMap;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-12-02 Anders Carlsson <andersca@apple.com>
+
+ Remove visited link handling from PageGroup
+ https://bugs.webkit.org/show_bug.cgi?id=139185
+
+ Reviewed by Sam Weinig.
+
+ * History/WebHistory.mm:
+ (-[WebHistoryPrivate removeItemForURLString:]):
+ (-[WebHistoryPrivate removeAllItems]):
+ (+[WebHistory setOptionalSharedHistory:]):
+ (+[WebHistory _setVisitedLinkTrackingEnabled:]):
+ (+[WebHistory _removeAllVisitedLinks]):
+ (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
+ (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
+ * History/WebHistoryInternal.h:
+ * WebCoreSupport/WebChromeClient.h:
+ * WebCoreSupport/WebChromeClient.mm:
+ (WebChromeClient::populateVisitedLinks): Deleted.
+ * WebView/WebView.mm:
+ (-[WebView addVisitedLinks:]):
+ (-[WebView removeVisitedLink:]):
+
</ins><span class="cx"> 2014-12-01 Timothy Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Try to fix the Mac build.
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistorymm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistory.mm (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistory.mm 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/mac/History/WebHistory.mm 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -111,8 +111,6 @@
</span><span class="cx"> - (void)setHistoryAgeInDaysLimit:(int)limit;
</span><span class="cx"> - (int)historyAgeInDaysLimit;
</span><span class="cx">
</span><del>-- (void)addVisitedLinksToPageGroup:(PageGroup&)group;
-
</del><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @implementation WebHistoryPrivate
</span><span class="lines">@@ -281,7 +279,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> if (![_entriesByURL count])
</span><del>- PageGroup::removeAllVisitedLinks();
</del><ins>+ WebVisitedLinkStore::removeAllVisitedLinks();
</ins><span class="cx">
</span><span class="cx"> return YES;
</span><span class="cx"> }
</span><span class="lines">@@ -447,7 +445,7 @@
</span><span class="cx"> [_orderedLastVisitedDays release];
</span><span class="cx"> _orderedLastVisitedDays = nil;
</span><span class="cx">
</span><del>- PageGroup::removeAllVisitedLinks();
</del><ins>+ WebVisitedLinkStore::removeAllVisitedLinks();
</ins><span class="cx">
</span><span class="cx"> return YES;
</span><span class="cx"> }
</span><span class="lines">@@ -695,22 +693,6 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)addVisitedLinksToPageGroup:(PageGroup&)group
-{
- NSEnumerator *enumerator = [_entriesByURL keyEnumerator];
- while (NSString *url = [enumerator nextObject]) {
- size_t length = [url length];
- const UChar* characters = CFStringGetCharactersPtr(reinterpret_cast<CFStringRef>(url));
- if (characters)
- group.addVisitedLink(characters, length);
- else {
- Vector<UChar, 512> buffer(length);
- [url getCharacters:buffer.data()];
- group.addVisitedLink(buffer.data(), length);
- }
- }
-}
-
</del><span class="cx"> - (void)addVisitedLinksToVisitedLinkStore:(WebVisitedLinkStore&)visitedLinkStore
</span><span class="cx"> {
</span><span class="cx"> for (NSString *urlString in _entriesByURL)
</span><span class="lines">@@ -735,8 +717,6 @@
</span><span class="cx"> [_sharedHistory release];
</span><span class="cx"> _sharedHistory = [history retain];
</span><span class="cx">
</span><del>- PageGroup::setShouldTrackVisitedLinks(history);
- PageGroup::removeAllVisitedLinks();
</del><span class="cx"> WebVisitedLinkStore::setShouldTrackVisitedLinks(history);
</span><span class="cx"> WebVisitedLinkStore::removeAllVisitedLinks();
</span><span class="cx"> }
</span><span class="lines">@@ -920,13 +900,11 @@
</span><span class="cx">
</span><span class="cx"> + (void)_setVisitedLinkTrackingEnabled:(BOOL)visitedLinkTrackingEnabled
</span><span class="cx"> {
</span><del>- PageGroup::setShouldTrackVisitedLinks(visitedLinkTrackingEnabled);
</del><span class="cx"> WebVisitedLinkStore::setShouldTrackVisitedLinks(visitedLinkTrackingEnabled);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> + (void)_removeAllVisitedLinks
</span><span class="cx"> {
</span><del>- PageGroup::removeAllVisitedLinks();
</del><span class="cx"> WebVisitedLinkStore::removeAllVisitedLinks();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -948,11 +926,6 @@
</span><span class="cx"> [entries release];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)_addVisitedLinksToPageGroup:(WebCore::PageGroup&)group
-{
- [_historyPrivate addVisitedLinksToPageGroup:group];
-}
-
</del><span class="cx"> - (void)_addVisitedLinksToVisitedLinkStore:(WebVisitedLinkStore &)visitedLinkStore
</span><span class="cx"> {
</span><span class="cx"> [_historyPrivate addVisitedLinksToVisitedLinkStore:visitedLinkStore];
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistoryInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistoryInternal.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistoryInternal.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/mac/History/WebHistoryInternal.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -36,6 +36,5 @@
</span><span class="cx">
</span><span class="cx"> @interface WebHistory (WebInternal)
</span><span class="cx"> - (void)_visitedURL:(NSURL *)URL withTitle:(NSString *)title method:(NSString *)method wasFailure:(BOOL)wasFailure;
</span><del>-- (void)_addVisitedLinksToPageGroup:(WebCore::PageGroup&)group;
</del><span class="cx"> - (void)_addVisitedLinksToVisitedLinkStore:(WebVisitedLinkStore&)visitedLinkStore;
</span><span class="cx"> @end
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -124,7 +124,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> virtual void reachedMaxAppCacheSize(int64_t spaceNeeded) override;
</span><span class="cx"> virtual void reachedApplicationCacheOriginQuota(WebCore::SecurityOrigin*, int64_t totalSpaceNeeded) override;
</span><del>- virtual void populateVisitedLinks() override;
</del><span class="cx">
</span><span class="cx"> #if ENABLE(DASHBOARD_SUPPORT)
</span><span class="cx"> virtual void annotatedRegionsChanged() override;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebChromeClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -707,22 +707,6 @@
</span><span class="cx"> END_BLOCK_OBJC_EXCEPTIONS;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::populateVisitedLinks()
-{
- if ([m_webView historyDelegate]) {
- WebHistoryDelegateImplementationCache* implementations = WebViewGetHistoryDelegateImplementations(m_webView);
-
- if (implementations->populateVisitedLinksFunc)
- CallHistoryDelegate(implementations->populateVisitedLinksFunc, m_webView, @selector(populateVisitedLinksForWebView:));
-
- return;
- }
-
- BEGIN_BLOCK_OBJC_EXCEPTIONS;
- [[WebHistory optionalSharedHistory] _addVisitedLinksToPageGroup:[m_webView page]->group()];
- END_BLOCK_OBJC_EXCEPTIONS;
-}
-
</del><span class="cx"> #if ENABLE(DASHBOARD_SUPPORT)
</span><span class="cx">
</span><span class="cx"> void WebChromeClient::annotatedRegionsChanged()
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -7005,28 +7005,12 @@
</span><span class="cx"> WebVisitedLinkStore& visitedLinkStore = _private->group->visitedLinkStore();
</span><span class="cx"> for (NSString *urlString in visitedLinks)
</span><span class="cx"> visitedLinkStore.addVisitedLink(urlString);
</span><del>-
- PageGroup& group = core(self)->group();
-
- NSEnumerator *enumerator = [visitedLinks objectEnumerator];
- while (NSString *url = [enumerator nextObject]) {
- size_t length = [url length];
- const UChar* characters = CFStringGetCharactersPtr(reinterpret_cast<CFStringRef>(url));
- if (characters)
- group.addVisitedLink(characters, length);
- else {
- Vector<UChar, 512> buffer(length);
- [url getCharacters:buffer.data()];
- group.addVisitedLink(buffer.data(), length);
- }
- }
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> - (void)removeVisitedLink:(NSURL *)url
</span><span class="cx"> {
</span><span class="cx"> _private->group->visitedLinkStore().removeVisitedLink(URL(url).string());
</span><del>- core(self)->group().removeVisitedLink(url);
</del><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/win/ChangeLog 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-12-02 Anders Carlsson <andersca@apple.com>
+
+ Remove visited link handling from PageGroup
+ https://bugs.webkit.org/show_bug.cgi?id=139185
+
+ Reviewed by Sam Weinig.
+
+ * WebCoreSupport/WebChromeClient.cpp:
+ (WebChromeClient::populateVisitedLinks): Deleted.
+ * WebCoreSupport/WebChromeClient.h:
+
</ins><span class="cx"> 2014-12-01 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove IWebCookieManager on Windows
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebChromeClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -635,10 +635,6 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::populateVisitedLinks()
-{
-}
-
</del><span class="cx"> void WebChromeClient::runOpenPanel(Frame*, PassRefPtr<FileChooser> prpFileChooser)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<FileChooser> fileChooser = prpFileChooser;
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -119,8 +119,6 @@
</span><span class="cx"> virtual void reachedMaxAppCacheSize(int64_t spaceNeeded);
</span><span class="cx"> virtual void reachedApplicationCacheOriginQuota(WebCore::SecurityOrigin*, int64_t totalSpaceNeeded);
</span><span class="cx">
</span><del>- virtual void populateVisitedLinks();
-
</del><span class="cx"> virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>);
</span><span class="cx"> virtual void loadIconForFiles(const Vector<WTF::String>&, WebCore::FileIconLoader*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit/win/WebView.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -6440,7 +6440,6 @@
</span><span class="cx"> for (unsigned i = 0; i < visitedURLCount; ++i) {
</span><span class="cx"> BSTR url = visitedURLs[i];
</span><span class="cx"> unsigned length = SysStringLen(url);
</span><del>- group.addVisitedLink(url, length);
</del><span class="cx">
</span><span class="cx"> visitedLinkStore.addVisitedLink(String(url, length));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-12-02 Anders Carlsson <andersca@apple.com>
+
+ Remove visited link handling from PageGroup
+ https://bugs.webkit.org/show_bug.cgi?id=139185
+
+ Reviewed by Sam Weinig.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::populateVisitedLinks): Deleted.
+ * WebProcess/WebCoreSupport/WebChromeClient.h:
+
</ins><span class="cx"> 2014-12-01 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove WKBundleRemoveAllVisitedLinks
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -733,10 +733,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void WebChromeClient::populateVisitedLinks()
-{
-}
-
</del><span class="cx"> bool WebChromeClient::shouldReplaceWithGeneratedFileForUpload(const String& path, String& generatedFilename)
</span><span class="cx"> {
</span><span class="cx"> generatedFilename = m_page->injectedBundleUIClient().shouldGenerateFileForUpload(m_page, path);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (176669 => 176670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-12-02 18:04:27 UTC (rev 176669)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-12-02 18:12:57 UTC (rev 176670)
</span><span class="lines">@@ -150,8 +150,6 @@
</span><span class="cx"> virtual void annotatedRegionsChanged() override;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- virtual void populateVisitedLinks() override;
-
</del><span class="cx"> virtual bool shouldReplaceWithGeneratedFileForUpload(const String& path, String& generatedFilename) override;
</span><span class="cx"> virtual String generateReplacementFile(const String& path) override;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>