<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176697] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176697">176697</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2014-12-02 16:32:33 -0800 (Tue, 02 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove a SnowLeopard-era quirk for QuickLook
https://bugs.webkit.org/show_bug.cgi?id=139208
<rdar://problem/19121822>
Reviewed by Alexey Proskuryakov.
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
* loader/FrameLoaderClient.h:
* platform/mac/QuickLookMac.h: Removed.
* platform/mac/QuickLookMac.mm: Removed.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::needsQuickLookResourceCachingQuirks): Deleted.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::needsQuickLookResourceCachingQuirks): Deleted.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCoreloaderEmptyClientsh">trunk/Source/WebCore/loader/EmptyClients.h</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoadercpp">trunk/Source/WebCore/loader/FrameLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoaderClienth">trunk/Source/WebCore/loader/FrameLoaderClient.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClientmm">trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebProcessCreationParameterscpp">trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedWebProcessCreationParametersh">trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacWebContextMacmm">trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClienth">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcesscpp">trunk/Source/WebKit2/WebProcess/WebProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcessh">trunk/Source/WebKit2/WebProcess/WebProcess.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcesscocoaWebProcessCocoamm">trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreplatformmacQuickLookMach">trunk/Source/WebCore/platform/mac/QuickLookMac.h</a></li>
<li><a href="#trunkSourceWebCoreplatformmacQuickLookMacmm">trunk/Source/WebCore/platform/mac/QuickLookMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/ChangeLog 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-12-02 Tim Horton <timothy_horton@apple.com>
+
+ Remove a SnowLeopard-era quirk for QuickLook
+ https://bugs.webkit.org/show_bug.cgi?id=139208
+ <rdar://problem/19121822>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebCore.exp.in:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/EmptyClients.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::subresourceCachePolicy):
+ * loader/FrameLoaderClient.h:
+ * platform/mac/QuickLookMac.h: Removed.
+ * platform/mac/QuickLookMac.mm: Removed.
+
</ins><span class="cx"> 2014-12-02 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Begin stubbing out a StorageNamespaceProvider class
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreexpin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.exp.in 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -242,7 +242,6 @@
</span><span class="cx"> __ZN7WebCore12PrintContext9spoolRectERNS_15GraphicsContextERKNS_7IntRectE
</span><span class="cx"> __ZN7WebCore12PrintContextC1EPNS_5FrameE
</span><span class="cx"> __ZN7WebCore12PrintContextD1Ev
</span><del>-__ZN7WebCore12QuickLookMac42computeNeedsQuickLookResourceCachingQuirksEv
</del><span class="cx"> __ZN7WebCore12RenderObject16paintingRootRectERNS_10LayoutRectE
</span><span class="cx"> __ZN7WebCore12RenderObject19scrollRectToVisibleERKNS_10LayoutRectERKNS_15ScrollAlignmentES6_
</span><span class="cx"> __ZN7WebCore12RenderWidget9setWidgetEN3WTF10PassRefPtrINS_6WidgetEEE
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -1615,8 +1615,6 @@
</span><span class="cx"> 45BAC2B01360BBAB005DA258 /* IconURL.h in Headers */ = {isa = PBXBuildFile; fileRef = 45BAC2AF1360BBAB005DA258 /* IconURL.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> 45FEA5CF156DDE8C00654101 /* Decimal.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 45FEA5CD156DDE8C00654101 /* Decimal.cpp */; };
</span><span class="cx"> 45FEA5D0156DDE8C00654101 /* Decimal.h in Headers */ = {isa = PBXBuildFile; fileRef = 45FEA5CE156DDE8C00654101 /* Decimal.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><del>- 4643783119F720EF001E38B3 /* QuickLookMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 4643782F19F720EF001E38B3 /* QuickLookMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 4643783219F720EF001E38B3 /* QuickLookMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 4643783019F720EF001E38B3 /* QuickLookMac.mm */; };
</del><span class="cx"> 4689F1AF1267BAE100E8D380 /* FileMetadata.h in Headers */ = {isa = PBXBuildFile; fileRef = 4689F1AE1267BAE100E8D380 /* FileMetadata.h */; };
</span><span class="cx"> 490707E61219C04300D90E51 /* ANGLEWebKitBridge.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 490707E41219C04300D90E51 /* ANGLEWebKitBridge.cpp */; };
</span><span class="cx"> 490707E71219C04300D90E51 /* ANGLEWebKitBridge.h in Headers */ = {isa = PBXBuildFile; fileRef = 490707E51219C04300D90E51 /* ANGLEWebKitBridge.h */; };
</span><span class="lines">@@ -8711,8 +8709,6 @@
</span><span class="cx"> 45BAC2AF1360BBAB005DA258 /* IconURL.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IconURL.h; sourceTree = "<group>"; };
</span><span class="cx"> 45FEA5CD156DDE8C00654101 /* Decimal.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Decimal.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 45FEA5CE156DDE8C00654101 /* Decimal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Decimal.h; sourceTree = "<group>"; };
</span><del>- 4643782F19F720EF001E38B3 /* QuickLookMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QuickLookMac.h; sourceTree = "<group>"; };
- 4643783019F720EF001E38B3 /* QuickLookMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = QuickLookMac.mm; sourceTree = "<group>"; };
</del><span class="cx"> 4689F1AE1267BAE100E8D380 /* FileMetadata.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FileMetadata.h; path = platform/FileMetadata.h; sourceTree = "<group>"; };
</span><span class="cx"> 490707E41219C04300D90E51 /* ANGLEWebKitBridge.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ANGLEWebKitBridge.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 490707E51219C04300D90E51 /* ANGLEWebKitBridge.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ANGLEWebKitBridge.h; sourceTree = "<group>"; };
</span><span class="lines">@@ -16508,8 +16504,6 @@
</span><span class="cx"> BC94D1070C274F88006BC617 /* PlatformScreenMac.mm */,
</span><span class="cx"> 29E4D8E016B0959800C84704 /* PlatformSpeechSynthesizerMac.mm */,
</span><span class="cx"> 0081FEFE16B0A2B6008AAA7A /* PublicSuffixMac.mm */,
</span><del>- 4643782F19F720EF001E38B3 /* QuickLookMac.h */,
- 4643783019F720EF001E38B3 /* QuickLookMac.mm */,
</del><span class="cx"> BCAE1FA512939DB7004CB026 /* ScrollAnimatorMac.h */,
</span><span class="cx"> BC51156D12B1749C00C96754 /* ScrollAnimatorMac.mm */,
</span><span class="cx"> BC8B853C0E7C7F1100AB6984 /* ScrollbarThemeMac.h */,
</span><span class="lines">@@ -25727,7 +25721,6 @@
</span><span class="cx"> 442AF7A9102CDDEA008FD4D3 /* QuickLook.h in Headers */,
</span><span class="cx"> CE1252391A166FA000864480 /* QuickLookSPI.h in Headers */,
</span><span class="cx"> A10DBF4718F92317000D70C6 /* QuickLookHandleClient.h in Headers */,
</span><del>- 4643783119F720EF001E38B3 /* QuickLookMac.h in Headers */,
</del><span class="cx"> 072AE1E8183C0741000A5988 /* QuickTimePluginReplacement.h in Headers */,
</span><span class="cx"> 379E371713736A6600B9E919 /* QuotedPrintable.h in Headers */,
</span><span class="cx"> 5A574F29131DB96D00471B88 /* QuotesData.h in Headers */,
</span><span class="lines">@@ -29212,7 +29205,6 @@
</span><span class="cx"> CDEE393717974259001D7580 /* PublicURLManager.cpp in Sources */,
</span><span class="cx"> 550A0BC9085F6039007353D6 /* QualifiedName.cpp in Sources */,
</span><span class="cx"> 442AF7AA102CDDEA008FD4D3 /* QuickLook.mm in Sources */,
</span><del>- 4643783219F720EF001E38B3 /* QuickLookMac.mm in Sources */,
</del><span class="cx"> 072AE1E6183C0741000A5988 /* QuickTimePluginReplacement.mm in Sources */,
</span><span class="cx"> 379E371613736A6600B9E919 /* QuotedPrintable.cpp in Sources */,
</span><span class="cx"> 5A574F28131DB96D00471B88 /* QuotesData.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderEmptyClientsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/EmptyClients.h (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/EmptyClients.h 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -403,10 +403,6 @@
</span><span class="cx"> virtual void didRequestAutocomplete(PassRefPtr<FormState>) override { }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if PLATFORM(MAC)
- virtual bool needsQuickLookResourceCachingQuirks() const override { return false; }
-#endif
-
</del><span class="cx"> virtual bool isEmptyFrameLoaderClient() override { return true; }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoader.cpp 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -2152,11 +2152,6 @@
</span><span class="cx"> return CachePolicyRevalidate;
</span><span class="cx">
</span><span class="cx"> const ResourceRequest& request(documentLoader()->request());
</span><del>-#if PLATFORM(MAC)
- if (request.cachePolicy() == ReloadIgnoringCacheData && !equalIgnoringCase(request.httpMethod(), "post") && m_client.needsQuickLookResourceCachingQuirks())
- return CachePolicyRevalidate;
-#endif
-
</del><span class="cx"> if (request.cachePolicy() == ReturnCacheDataElseLoad)
</span><span class="cx"> return CachePolicyHistoryBuffer;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoaderClient.h 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -283,10 +283,6 @@
</span><span class="cx">
</span><span class="cx"> virtual void registerForIconNotification(bool listen = true) = 0;
</span><span class="cx">
</span><del>-#if PLATFORM(MAC)
- virtual bool needsQuickLookResourceCachingQuirks() const = 0;
-#endif
-
</del><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> // Allow an accessibility object to retrieve a Frame parent if there's no PlatformWidget.
</span><span class="cx"> virtual RemoteAXObjectRef accessibilityRemoteObject() = 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacQuickLookMach"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/platform/mac/QuickLookMac.h (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/QuickLookMac.h 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/platform/mac/QuickLookMac.h 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -1,38 +0,0 @@
</span><del>-/*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef QuickLookMac_h
-#define QuickLookMac_h
-
-namespace WebCore {
-
-class QuickLookMac {
-public:
- WEBCORE_EXPORT static bool computeNeedsQuickLookResourceCachingQuirks();
-};
-
-} // namespace WebCore
-
-#endif // QuickLookMac_h
</del></span></pre></div>
<a id="trunkSourceWebCoreplatformmacQuickLookMacmm"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/platform/mac/QuickLookMac.mm (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/QuickLookMac.mm 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebCore/platform/mac/QuickLookMac.mm 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -1,51 +0,0 @@
</span><del>-/*
- * Copyright (C) 2006, 2007, 2008, 2014 Apple, Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#import "config.h"
-#import "QuickLookMac.h"
-
-#import "RuntimeApplicationChecks.h"
-
-namespace WebCore {
-
-bool QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
-{
- if (applicationIsSafari())
- return false;
-
- NSArray *frameworks = [NSBundle allFrameworks];
-
- if (!frameworks)
- return false;
-
- for (NSBundle *bundle in frameworks) {
- NSString *bundleID = [bundle bundleIdentifier];
- if (bundleID && [bundleID caseInsensitiveCompare:@"com.apple.QuickLookUIFramework"] == NSOrderedSame)
- return true;
- }
- return false;
-}
-
-} // namespace WebCore
</del></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2014-12-02 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><ins>+ Remove a SnowLeopard-era quirk for QuickLook
+ https://bugs.webkit.org/show_bug.cgi?id=139208
+ <rdar://problem/19121822>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebCoreSupport/WebFrameLoaderClient.h:
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+
+2014-12-02 Tim Horton <timothy_horton@apple.com>
+
</ins><span class="cx"> Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=139204
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -239,10 +239,6 @@
</span><span class="cx"> virtual void didCreateQuickLookHandle(WebCore::QuickLookHandle&) override;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if PLATFORM(MAC)
- virtual bool needsQuickLookResourceCachingQuirks() const override;
-#endif
-
</del><span class="cx"> virtual void contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter>) override;
</span><span class="cx">
</span><span class="cx"> RetainPtr<WebFrame> m_webFrame;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebFrameLoaderClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -2249,14 +2249,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if PLATFORM(MAC)
-bool WebFrameLoaderClient::needsQuickLookResourceCachingQuirks() const
-{
- static const bool shouldUseQuickLookResourceCachingQuirks = QuickLookMac::computeNeedsQuickLookResourceCachingQuirks();
- return shouldUseQuickLookResourceCachingQuirks;
-}
-#endif
-
</del><span class="cx"> void WebFrameLoaderClient::contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter> contentFilter)
</span><span class="cx"> {
</span><span class="cx"> m_webFrame->_private->contentFilterForBlockedLoad = WTF::move(contentFilter);
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-12-02 Tim Horton <timothy_horton@apple.com>
+
+ Remove a SnowLeopard-era quirk for QuickLook
+ https://bugs.webkit.org/show_bug.cgi?id=139208
+ <rdar://problem/19121822>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Shared/WebProcessCreationParameters.cpp:
+ (WebKit::WebProcessCreationParameters::encode):
+ (WebKit::WebProcessCreationParameters::decode):
+ * Shared/WebProcessCreationParameters.h:
+ * UIProcess/mac/WebContextMac.mm:
+ (WebKit::WebContext::platformInitializeWebProcess):
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::needsQuickLookResourceCachingQuirks): Deleted.
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::WebProcess):
+ * WebProcess/WebProcess.h:
+ (WebKit::WebProcess::needsQuickLookResourceCachingQuirks): Deleted.
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::platformInitializeWebProcess):
+
</ins><span class="cx"> 2014-12-02 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> Build fix.
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebProcessCreationParameterscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -108,7 +108,6 @@
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> encoder << presenterApplicationPid;
</span><span class="cx"> encoder << accessibilityEnhancedUserInterfaceEnabled;
</span><del>- encoder << needsQuickLookResourceCachingQuirks;
</del><span class="cx"> encoder << nsURLCacheMemoryCapacity;
</span><span class="cx"> encoder << nsURLCacheDiskCapacity;
</span><span class="cx"> encoder << acceleratedCompositingPort;
</span><span class="lines">@@ -237,8 +236,6 @@
</span><span class="cx"> return false;
</span><span class="cx"> if (!decoder.decode(parameters.accessibilityEnhancedUserInterfaceEnabled))
</span><span class="cx"> return false;
</span><del>- if (!decoder.decode(parameters.needsQuickLookResourceCachingQuirks))
- return false;
</del><span class="cx"> if (!decoder.decode(parameters.nsURLCacheMemoryCapacity))
</span><span class="cx"> return false;
</span><span class="cx"> if (!decoder.decode(parameters.nsURLCacheDiskCapacity))
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebProcessCreationParametersh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -126,7 +126,6 @@
</span><span class="cx"> pid_t presenterApplicationPid;
</span><span class="cx">
</span><span class="cx"> bool accessibilityEnhancedUserInterfaceEnabled;
</span><del>- bool needsQuickLookResourceCachingQuirks;
</del><span class="cx">
</span><span class="cx"> uint64_t nsURLCacheMemoryCapacity;
</span><span class="cx"> uint64_t nsURLCacheDiskCapacity;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacWebContextMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -167,11 +167,8 @@
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> parameters.accessibilityEnhancedUserInterfaceEnabled = [[NSApp accessibilityAttributeValue:@"AXEnhancedUserInterface"] boolValue];
</span><del>- static const bool shouldUseQuickLookResourceCachingQuirks = QuickLookMac::computeNeedsQuickLookResourceCachingQuirks();
- parameters.needsQuickLookResourceCachingQuirks = shouldUseQuickLookResourceCachingQuirks;
</del><span class="cx"> #else
</span><span class="cx"> parameters.accessibilityEnhancedUserInterfaceEnabled = false;
</span><del>- parameters.needsQuickLookResourceCachingQuirks = false;
</del><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> NSURLCache *urlCache = [NSURLCache sharedURLCache];
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -1642,11 +1642,4 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if PLATFORM(MAC)
-bool WebFrameLoaderClient::needsQuickLookResourceCachingQuirks() const
-{
- return WebProcess::shared().needsQuickLookResourceCachingQuirks();
-}
-#endif
-
</del><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -231,10 +231,6 @@
</span><span class="cx"> virtual void didCreateQuickLookHandle(WebCore::QuickLookHandle&) override;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if PLATFORM(MAC)
- virtual bool needsQuickLookResourceCachingQuirks() const override;
-#endif
-
</del><span class="cx"> #if ENABLE(CONTENT_FILTERING)
</span><span class="cx"> virtual void contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter>) override;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -161,9 +161,6 @@
</span><span class="cx"> , m_compositingRenderServerPort(MACH_PORT_NULL)
</span><span class="cx"> , m_clearResourceCachesDispatchGroup(0)
</span><span class="cx"> #endif
</span><del>-#if PLATFORM(MAC)
- , m_needsQuickLookResourceCachingQuirks(false)
-#endif
</del><span class="cx"> , m_fullKeyboardAccessEnabled(false)
</span><span class="cx"> , m_textCheckerState()
</span><span class="cx"> , m_iconDatabaseProxy(new WebIconDatabaseProxy(this))
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.h 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -118,10 +118,6 @@
</span><span class="cx"> mach_port_t compositingRenderServerPort() const { return m_compositingRenderServerPort; }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if PLATFORM(MAC)
- bool needsQuickLookResourceCachingQuirks() const { return m_needsQuickLookResourceCachingQuirks; }
-#endif
-
</del><span class="cx"> bool shouldPlugInAutoStartFromOrigin(WebPage&, const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
</span><span class="cx"> void plugInDidStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID);
</span><span class="cx"> void plugInDidReceiveUserInteraction(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID);
</span><span class="lines">@@ -323,9 +319,6 @@
</span><span class="cx"> dispatch_group_t m_clearResourceCachesDispatchGroup;
</span><span class="cx"> bool m_shouldForceScreenFontSubstitution;
</span><span class="cx"> #endif
</span><del>-#if PLATFORM(MAC)
- bool m_needsQuickLookResourceCachingQuirks;
-#endif
</del><span class="cx">
</span><span class="cx"> bool m_fullKeyboardAccessEnabled;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcesscocoaWebProcessCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm (176696 => 176697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm 2014-12-03 00:30:17 UTC (rev 176696)
+++ trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm 2014-12-03 00:32:33 UTC (rev 176697)
</span><span class="lines">@@ -195,9 +195,6 @@
</span><span class="cx"> MemoryPressureHandler::ReliefLogger::setLoggingEnabled(parameters.shouldEnableMemoryPressureReliefLogging);
</span><span class="cx">
</span><span class="cx"> setEnhancedAccessibility(parameters.accessibilityEnhancedUserInterfaceEnabled);
</span><del>-#if PLATFORM(MAC)
- m_needsQuickLookResourceCachingQuirks = parameters.needsQuickLookResourceCachingQuirks;
-#endif
</del><span class="cx">
</span><span class="cx"> #if USE(APPKIT)
</span><span class="cx"> [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"NSApplicationCrashOnExceptions" : @YES }];
</span></span></pre>
</div>
</div>
</body>
</html>