<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176598] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176598">176598</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-12-01 12:18:33 -0800 (Mon, 01 Dec 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove old site specific quirks code that was added in 2009
https://bugs.webkit.org/show_bug.cgi?id=139141
Reviewed by Antti Koivisto.
Source/WebCore:
* platform/network/NetworkingContext.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
Source/WebKit/mac:
* WebCoreSupport/WebFrameNetworkingContext.h:
* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
Source/WebKit2:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::needsSiteSpecificQuirks): Deleted.
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkNetworkingContexth">trunk/Source/WebCore/platform/network/NetworkingContext.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkResourceHandleInternalh">trunk/Source/WebCore/platform/network/ResourceHandleInternal.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkmacResourceHandleMacmm">trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebFrameNetworkingContexth">trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebFrameNetworkingContextmm">trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessRemoteNetworkingContexth">trunk/Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessmacRemoteNetworkingContextmm">trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportmacWebFrameNetworkingContexth">trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportmacWebFrameNetworkingContextmm">trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebCore/ChangeLog 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-12-01 Anders Carlsson <andersca@apple.com>
+
+ Remove old site specific quirks code that was added in 2009
+ https://bugs.webkit.org/show_bug.cgi?id=139141
+
+ Reviewed by Antti Koivisto.
+
+ * platform/network/NetworkingContext.h:
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::start):
+
</ins><span class="cx"> 2014-12-01 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: DOMExceptions do not show the error message string in Pause Reason section
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkNetworkingContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/NetworkingContext.h (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/NetworkingContext.h 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebCore/platform/network/NetworkingContext.h 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -50,7 +50,6 @@
</span><span class="cx"> virtual bool shouldClearReferrerOnHTTPSToHTTPRedirect() const = 0;
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span><del>- virtual bool needsSiteSpecificQuirks() const = 0;
</del><span class="cx"> virtual bool localFileContentSniffingEnabled() const = 0; // FIXME: Reconcile with ResourceHandle::forceContentSniffing().
</span><span class="cx"> virtual SchedulePairHashSet* scheduledRunLoopPairs() const { return 0; }
</span><span class="cx"> virtual RetainPtr<CFDataRef> sourceApplicationAuditData() const = 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkResourceHandleInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ResourceHandleInternal.h (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ResourceHandleInternal.h 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebCore/platform/network/ResourceHandleInternal.h 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -115,7 +115,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> , m_startWhenScheduled(false)
</span><del>- , m_needsSiteSpecificQuirks(false)
</del><span class="cx"> , m_currentMacChallenge(nil)
</span><span class="cx"> #endif
</span><span class="cx"> , m_scheduledFailureType(ResourceHandle::NoFailure)
</span><span class="lines">@@ -157,7 +156,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> bool m_startWhenScheduled;
</span><del>- bool m_needsSiteSpecificQuirks;
</del><span class="cx"> #endif
</span><span class="cx"> #if PLATFORM(COCOA) || USE(CFNETWORK)
</span><span class="cx"> RetainPtr<CFURLStorageSessionRef> m_storageSession;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkmacResourceHandleMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -244,8 +244,6 @@
</span><span class="cx"> // FIXME: Do not use the sync version of shouldUseCredentialStorage when the client returns true from usesAsyncCallbacks.
</span><span class="cx"> bool shouldUseCredentialStorage = !client() || client()->shouldUseCredentialStorage(this);
</span><span class="cx">
</span><del>- d->m_needsSiteSpecificQuirks = d->m_context->needsSiteSpecificQuirks();
-
</del><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> createNSURLConnection(
</span><span class="cx"> ResourceHandle::makeDelegate(shouldUseCredentialStorage),
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-12-01 Anders Carlsson <andersca@apple.com>
+
+ Remove old site specific quirks code that was added in 2009
+ https://bugs.webkit.org/show_bug.cgi?id=139141
+
+ Reviewed by Antti Koivisto.
+
+ * WebCoreSupport/WebFrameNetworkingContext.h:
+ * WebCoreSupport/WebFrameNetworkingContext.mm:
+ (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
+
</ins><span class="cx"> 2014-11-30 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix a test failure.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebFrameNetworkingContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -51,7 +51,6 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool needsSiteSpecificQuirks() const override;
</del><span class="cx"> virtual bool localFileContentSniffingEnabled() const override;
</span><span class="cx"> virtual SchedulePairHashSet* scheduledRunLoopPairs() const override;
</span><span class="cx"> virtual RetainPtr<CFDataRef> sourceApplicationAuditData() const override;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebFrameNetworkingContextmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -76,11 +76,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-bool WebFrameNetworkingContext::needsSiteSpecificQuirks() const
-{
- return frame() && frame()->settings().needsSiteSpecificQuirks();
-}
-
</del><span class="cx"> bool WebFrameNetworkingContext::localFileContentSniffingEnabled() const
</span><span class="cx"> {
</span><span class="cx"> return frame() && frame()->settings().localFileContentSniffingEnabled();
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-12-01 Anders Carlsson <andersca@apple.com>
+
+ Remove old site specific quirks code that was added in 2009
+ https://bugs.webkit.org/show_bug.cgi?id=139141
+
+ Reviewed by Antti Koivisto.
+
+ * NetworkProcess/RemoteNetworkingContext.h:
+ * NetworkProcess/mac/RemoteNetworkingContext.mm:
+ (WebKit::RemoteNetworkingContext::needsSiteSpecificQuirks): Deleted.
+ * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
+ * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
+ (WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
+
</ins><span class="cx"> 2014-12-01 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Crash in WebInspectorClient::hideHighlight when page is destroyed
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessRemoteNetworkingContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -49,18 +49,13 @@
</span><span class="cx"> RemoteNetworkingContext(WebCore::SessionID sessionID, bool shouldClearReferrerOnHTTPSToHTTPRedirect)
</span><span class="cx"> : m_sessionID(sessionID)
</span><span class="cx"> , m_shouldClearReferrerOnHTTPSToHTTPRedirect(shouldClearReferrerOnHTTPSToHTTPRedirect)
</span><del>-#if PLATFORM(COCOA)
- , m_needsSiteSpecificQuirks(false)
- , m_localFileContentSniffingEnabled(false)
-#endif
- { }
</del><ins>+ {
+ }
</ins><span class="cx">
</span><span class="cx"> virtual bool isValid() const override;
</span><span class="cx"> virtual WebCore::NetworkStorageSession& storageSession() const override;
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span><del>- void setNeedsSiteSpecificQuirks(bool value) { m_needsSiteSpecificQuirks = value; }
- virtual bool needsSiteSpecificQuirks() const override;
</del><span class="cx"> void setLocalFileContentSniffingEnabled(bool value) { m_localFileContentSniffingEnabled = value; }
</span><span class="cx"> virtual bool localFileContentSniffingEnabled() const override;
</span><span class="cx"> virtual RetainPtr<CFDataRef> sourceApplicationAuditData() const override;
</span><span class="lines">@@ -72,8 +67,7 @@
</span><span class="cx"> bool m_shouldClearReferrerOnHTTPSToHTTPRedirect;
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span><del>- bool m_needsSiteSpecificQuirks;
- bool m_localFileContentSniffingEnabled;
</del><ins>+ bool m_localFileContentSniffingEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessmacRemoteNetworkingContextmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -48,11 +48,6 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool RemoteNetworkingContext::needsSiteSpecificQuirks() const
-{
- return m_needsSiteSpecificQuirks;
-}
-
</del><span class="cx"> bool RemoteNetworkingContext::localFileContentSniffingEnabled() const
</span><span class="cx"> {
</span><span class="cx"> return m_localFileContentSniffingEnabled;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportmacWebFrameNetworkingContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -53,7 +53,6 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual bool needsSiteSpecificQuirks() const override;
</del><span class="cx"> virtual bool localFileContentSniffingEnabled() const override;
</span><span class="cx"> virtual SchedulePairHashSet* scheduledRunLoopPairs() const override;
</span><span class="cx"> virtual RetainPtr<CFDataRef> sourceApplicationAuditData() const override;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportmacWebFrameNetworkingContextmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm (176597 => 176598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm 2014-12-01 20:06:55 UTC (rev 176597)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm 2014-12-01 20:18:33 UTC (rev 176598)
</span><span class="lines">@@ -72,11 +72,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WebFrameNetworkingContext::needsSiteSpecificQuirks() const
-{
- return frame() && frame()->settings().needsSiteSpecificQuirks();
-}
-
</del><span class="cx"> bool WebFrameNetworkingContext::localFileContentSniffingEnabled() const
</span><span class="cx"> {
</span><span class="cx"> return frame() && frame()->settings().localFileContentSniffingEnabled();
</span></span></pre>
</div>
</div>
</body>
</html>