<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176514] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176514">176514</a></dd>
<dt>Author</dt> <dd>k.czech@samsung.com</dd>
<dt>Date</dt> <dd>2014-11-24 03:30:55 -0800 (Mon, 24 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Utilize Eail library to support accessibility in EFL
https://bugs.webkit.org/show_bug.cgi?id=137742
Reviewed by Gyuyoung Kim.
Source/WebKit2:
Initialize EAIL module so that all the listeners and atk-bridge started properly.
Dynamic loading of EAIL help us to avoid elementary dependencies in WebKit.
* WebProcess/efl/WebProcessMainEfl.cpp:
(eailLibraryPath): reads path provided by ACCESSIBILITY_EAIL_LIBRARY_PATH variable.
(eail):
Tools:
Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
* efl/jhbuild-optional.modules: Added.
* efl/jhbuild.modules:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcesseflWebProcessMainEflcpp">trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsefljhbuildmodules">trunk/Tools/efl/jhbuild.modules</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkToolsefljhbuildoptionalmodules">trunk/Tools/efl/jhbuild-optional.modules</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (176513 => 176514)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-11-24 11:18:55 UTC (rev 176513)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-24 11:30:55 UTC (rev 176514)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-11-24 Krzysztof Czech <k.czech@samsung.com>
+
+ [EFL] Utilize Eail library to support accessibility in EFL
+ https://bugs.webkit.org/show_bug.cgi?id=137742
+
+ Reviewed by Gyuyoung Kim.
+
+ Initialize EAIL module so that all the listeners and atk-bridge started properly.
+ Dynamic loading of EAIL help us to avoid elementary dependencies in WebKit.
+
+ * WebProcess/efl/WebProcessMainEfl.cpp:
+ (eailLibraryPath): reads path provided by ACCESSIBILITY_EAIL_LIBRARY_PATH variable.
+ (eail):
+
</ins><span class="cx"> 2014-11-24 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcesseflWebProcessMainEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp (176513 => 176514)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp 2014-11-24 11:18:55 UTC (rev 176513)
+++ trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp 2014-11-24 11:30:55 UTC (rev 176514)
</span><span class="lines">@@ -35,6 +35,28 @@
</span><span class="cx"> #include <WebCore/SoupNetworkSession.h>
</span><span class="cx"> #include <libsoup/soup.h>
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
+#include "Module.h"
+/*
+ * This should be defined and filled in elementary but to avoid undefined reference it's defined here.
+ * Setting this variable to nullptr will not cause any trouble to webkit and eail as well.
+ */
+Eina_List* _elm_win_list = nullptr;
+
+typedef int (*EailFunction)(void*);
+
+static char* eailLibraryPath()
+{
+ return getenv("ACCESSIBILITY_EAIL_LIBRARY_PATH");
+}
+
+static WebKit::Module& eail()
+{
+ static NeverDestroyed<WebKit::Module> eail(eailLibraryPath());
+ return eail;
+}
+#endif
+
</ins><span class="cx"> #ifdef HAVE_ECORE_X
</span><span class="cx"> #include <Ecore_X.h>
</span><span class="cx"> #include <X11/Xlib.h>
</span><span class="lines">@@ -98,6 +120,14 @@
</span><span class="cx"> if (!ecore_main_loop_glib_integrate())
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+#if HAVE(ACCESSIBILITY)
+ // Initialize EAIL module (adding listeners, init atk-bridge)
+ if (eail().load()) {
+ if (EailFunction eailInit = eail().functionPointer<EailFunction>("elm_modapi_init"))
+ eailInit(nullptr);
+ }
+#endif
+
</ins><span class="cx"> SoupNetworkSession::defaultSession().setupHTTPProxyFromEnvironment();
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -116,6 +146,11 @@
</span><span class="cx"> #endif
</span><span class="cx"> ecore_shutdown();
</span><span class="cx"> eina_shutdown();
</span><ins>+
+#if HAVE(ACCESSIBILITY)
+ if (EailFunction eailShutdown = eail().functionPointer<EailFunction>("elm_modapi_shutdown"))
+ eailShutdown(nullptr);
+#endif
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (176513 => 176514)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-11-24 11:18:55 UTC (rev 176513)
+++ trunk/Tools/ChangeLog 2014-11-24 11:30:55 UTC (rev 176514)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-11-24 Krzysztof Czech <k.czech@samsung.com>
+
+ [EFL] Utilize Eail library to support accessibility in EFL
+ https://bugs.webkit.org/show_bug.cgi?id=137742
+
+ Reviewed by Gyuyoung Kim.
+
+ Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
+
+ * efl/jhbuild-optional.modules: Added.
+ * efl/jhbuild.modules:
+
</ins><span class="cx"> 2014-11-24 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
</span></span></pre></div>
<a id="trunkToolsefljhbuildoptionalmodules"></a>
<div class="addfile"><h4>Added: trunk/Tools/efl/jhbuild-optional.modules (0 => 176514)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/efl/jhbuild-optional.modules (rev 0)
+++ trunk/Tools/efl/jhbuild-optional.modules 2014-11-24 11:30:55 UTC (rev 176514)
</span><span class="lines">@@ -0,0 +1,38 @@
</span><ins>+<?xml version="1.0"?>
+<!DOCTYPE moduleset SYSTEM "moduleset.dtd">
+<?xml-stylesheet type="text/xsl" href="moduleset.xsl"?>
+<moduleset>
+
+ <repository type="tarball" name="ftp.gnome.org"
+ href="http://ftp.gnome.org"/>
+ <repository type="git" name="github"
+ href="https://github.com/czechk"/>
+
+ <autotools id="at-spi2-core"
+ autogenargs="--disable-introspection">
+ <branch module="pub/GNOME/sources/at-spi2-core/2.10/at-spi2-core-2.10.0.tar.xz" version="2.10.0"
+ repo="ftp.gnome.org"
+ hash="sha256:964155c7574220a00e11e1c0d91f2d3017ed603920eb1333ff9cbdb6a22744db">
+ </branch>
+ <dependencies>
+ <dep package="glib"/>
+ </dependencies>
+ </autotools>
+
+ <autotools id="at-spi2-atk">
+ <branch module="pub/GNOME/sources/at-spi2-atk/2.10/at-spi2-atk-2.10.0.tar.xz" version="2.10.0"
+ repo="ftp.gnome.org"
+ hash="sha256:dea7ff2f9bc9bbdb0351112616d738de718b55739cd2511afecac51604c31a94">
+ </branch>
+ <dependencies>
+ <dep package="glib"/>
+ <dep package="atk"/>
+ <dep package="at-spi2-core"/>
+ </dependencies>
+ </autotools>
+
+ <autotools id="eail" autogen-sh="autogen.sh">
+ <branch repo="github" module="eail.git" checkoutdir="eail-1.0.0"/>
+</autotools>
+
+</moduleset>
</ins></span></pre></div>
<a id="trunkToolsefljhbuildmodules"></a>
<div class="modfile"><h4>Modified: trunk/Tools/efl/jhbuild.modules (176513 => 176514)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/efl/jhbuild.modules 2014-11-24 11:18:55 UTC (rev 176513)
+++ trunk/Tools/efl/jhbuild.modules 2014-11-24 11:30:55 UTC (rev 176514)
</span><span class="lines">@@ -26,6 +26,8 @@
</span><span class="cx"> </dependencies>
</span><span class="cx"> </metamodule>
</span><span class="cx">
</span><ins>+ <include href="jhbuild-optional.modules"/>
+
</ins><span class="cx"> <repository type="tarball" name="github.com"
</span><span class="cx"> href="https://github.com"/>
</span><span class="cx"> <repository type="tarball" name="sourceware.org"
</span></span></pre>
</div>
</div>
</body>
</html>