<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176504] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176504">176504</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-11-22 02:11:13 -0800 (Sat, 22 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unused Document::ignoreAutofocus().
<https://webkit.org/b/139002>
Reviewed by Antti Koivisto.
No one ever actually changes this flag, so let's remove it.
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::ignoreAutofocus): Deleted.
(WebCore::Document::setIgnoreAutofocus): Deleted.
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlElementcpp">trunk/Source/WebCore/html/HTMLFormControlElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (176503 => 176504)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/ChangeLog 2014-11-22 10:11:13 UTC (rev 176504)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-11-22 Andreas Kling <akling@apple.com>
+
+ Remove unused Document::ignoreAutofocus().
+ <https://webkit.org/b/139002>
+
+ Reviewed by Antti Koivisto.
+
+ No one ever actually changes this flag, so let's remove it.
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ * dom/Document.h:
+ (WebCore::Document::ignoreAutofocus): Deleted.
+ (WebCore::Document::setIgnoreAutofocus): Deleted.
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::shouldAutofocus):
+
</ins><span class="cx"> 2014-11-22 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> URTBF after r176459 to fix GTK build.
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (176503 => 176504)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-11-22 10:11:13 UTC (rev 176504)
</span><span class="lines">@@ -421,7 +421,6 @@
</span><span class="cx"> , m_wellFormed(false)
</span><span class="cx"> , m_printing(false)
</span><span class="cx"> , m_paginatedForScreen(false)
</span><del>- , m_ignoreAutofocus(false)
</del><span class="cx"> , m_compatibilityMode(DocumentCompatibilityMode::NoQuirksMode)
</span><span class="cx"> , m_compatibilityModeLocked(false)
</span><span class="cx"> , m_textColor(Color::black)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (176503 => 176504)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/dom/Document.h 2014-11-22 10:11:13 UTC (rev 176504)
</span><span class="lines">@@ -752,11 +752,6 @@
</span><span class="cx"> UserActionElementSet& userActionElements() { return m_userActionElements; }
</span><span class="cx"> const UserActionElementSet& userActionElements() const { return m_userActionElements; }
</span><span class="cx">
</span><del>- // The m_ignoreAutofocus flag specifies whether or not the document has been changed by the user enough
- // for WebCore to ignore the autofocus attribute on any form controls
- bool ignoreAutofocus() const { return m_ignoreAutofocus; };
- void setIgnoreAutofocus(bool shouldIgnore = true) { m_ignoreAutofocus = shouldIgnore; };
-
</del><span class="cx"> void removeFocusedNodeOfSubtree(Node*, bool amongChildrenOnly = false);
</span><span class="cx"> void hoveredElementDidDetach(Element*);
</span><span class="cx"> void elementInActiveChainDidDetach(Element*);
</span><span class="lines">@@ -1421,8 +1416,6 @@
</span><span class="cx"> bool m_printing;
</span><span class="cx"> bool m_paginatedForScreen;
</span><span class="cx">
</span><del>- bool m_ignoreAutofocus;
-
</del><span class="cx"> DocumentCompatibilityMode m_compatibilityMode;
</span><span class="cx"> bool m_compatibilityModeLocked; // This is cheaper than making setCompatibilityMode virtual.
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (176503 => 176504)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2014-11-22 09:44:21 UTC (rev 176503)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2014-11-22 10:11:13 UTC (rev 176504)
</span><span class="lines">@@ -181,8 +181,6 @@
</span><span class="cx"> return false;
</span><span class="cx"> if (!element->inDocument() || !element->document().renderView())
</span><span class="cx"> return false;
</span><del>- if (element->document().ignoreAutofocus())
- return false;
</del><span class="cx"> if (element->document().isSandboxed(SandboxAutomaticFeatures)) {
</span><span class="cx"> // FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
</span><span class="cx"> element->document().addConsoleMessage(MessageSource::Security, MessageLevel::Error, ASCIILiteral("Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set."));
</span></span></pre>
</div>
</div>
</body>
</html>