<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176493] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176493">176493</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-11-21 18:06:00 -0800 (Fri, 21 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>There should be a way to associate bugs with analysis tasks
https://bugs.webkit.org/show_bug.cgi?id=138977
Reviewed by Benjamin Poulain.
Updated associate-bug.php to match the new database schema.
* public/include/json-header.php:
(require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
already camel-cased in require_existence_of. This makes the function usable elsewhere.
* public/privileged-api/associate-bug.php:
(main): Changed the API to take run, bugTracker, and number to match the new database schema.
Also verify that those values are integers using require_format.
* public/v2/analysis.js:
(App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
(App.Bug.label): Added.
(App.BugAdapter): Added.
(App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
(App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
* public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
containing the bug information.
* public/v2/app.js:
(App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
(App.AnalysisTaskRoute):
(App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
(App.AnalysisTaskController._fetchedManifest): Added.
(App.AnalysisTaskController.actions.associateBug): Added.
* public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
* public/v2/data.js:
(Measurement.prototype.associateBug): Deleted.
* public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
Added a table show the bug information. Also hide the chart until chartData is available.
* public/v2/manifest.js:
(App.Model): Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludejsonheaderphp">trunk/Websites/perf.webkit.org/public/include/json-header.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicprivilegedapiassociatebugphp">trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2analysisjs">trunk/Websites/perf.webkit.org/public/v2/analysis.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appcss">trunk/Websites/perf.webkit.org/public/v2/app.css</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2chartpanecss">trunk/Websites/perf.webkit.org/public/v2/chart-pane.css</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2datajs">trunk/Websites/perf.webkit.org/public/v2/data.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2indexhtml">trunk/Websites/perf.webkit.org/public/v2/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -1,3 +1,48 @@
</span><ins>+2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
+
+ There should be a way to associate bugs with analysis tasks
+ https://bugs.webkit.org/show_bug.cgi?id=138977
+
+ Reviewed by Benjamin Poulain.
+
+ Updated associate-bug.php to match the new database schema.
+
+ * public/include/json-header.php:
+ (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
+ already camel-cased in require_existence_of. This makes the function usable elsewhere.
+
+ * public/privileged-api/associate-bug.php:
+ (main): Changed the API to take run, bugTracker, and number to match the new database schema.
+ Also verify that those values are integers using require_format.
+
+ * public/v2/analysis.js:
+ (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
+ (App.Bug.label): Added.
+ (App.BugAdapter): Added.
+ (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
+ (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
+
+ * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
+ containing the bug information.
+
+ * public/v2/app.js:
+ (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
+ (App.AnalysisTaskRoute):
+ (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
+ (App.AnalysisTaskController._fetchedManifest): Added.
+ (App.AnalysisTaskController.actions.associateBug): Added.
+
+ * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
+
+ * public/v2/data.js:
+ (Measurement.prototype.associateBug): Deleted.
+
+ * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
+ Added a table show the bug information. Also hide the chart until chartData is available.
+
+ * public/v2/manifest.js:
+ (App.Model): Added.
+
</ins><span class="cx"> 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Fix misc bugs and typos in app.js
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludejsonheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/json-header.php (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/json-header.php 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/include/json-header.php 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -53,9 +53,9 @@
</span><span class="cx"> return implode('', array_map('ucfirst', explode('_', $name)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function require_format($key, $value, $pattern) {
</del><ins>+function require_format($name, $value, $pattern) {
</ins><span class="cx"> if (!preg_match($pattern, $value))
</span><del>- exit_with_error('Invalid' . camel_case_words_separated_by_underscore($key), array('value' => $value));
</del><ins>+ exit_with_error('Invalid' . $name, array('value' => $value));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function require_existence_of($array, $list_of_arguments, $prefix = '') {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicprivilegedapiassociatebugphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -5,29 +5,28 @@
</span><span class="cx"> function main() {
</span><span class="cx"> $data = ensure_privileged_api_data_and_token();
</span><span class="cx">
</span><del>- $run_id = array_get($data, 'run');
- $bug_tracker_id = array_get($data, 'tracker');
- $bug_number = array_get($data, 'bugNumber');
</del><ins>+ $analysis_task_id = array_get($data, 'task');
+ $bug_tracker_id = array_get($data, 'bugTracker');
+ $bug_number = array_get($data, 'number');
</ins><span class="cx">
</span><del>- if (!$run_id)
- exit_with_error('InvalidRunId', array('run' => $run_id));
- if (!$bug_tracker_id)
- exit_with_error('InvalidBugTrackerId', array('tracker' => $bug_tracker_id));
</del><ins>+ require_format('AnalysisTask', $analysis_task_id, '/^\d+$/');
+ require_format('BugTracker', $bug_tracker_id, '/^\d+$/');
+ require_format('BugNumber', $bug_number, '/^\d*$/');
</ins><span class="cx">
</span><span class="cx"> $db = connect();
</span><span class="cx"> $db->begin_transaction();
</span><span class="cx">
</span><span class="cx"> $bug_id = NULL;
</span><span class="cx"> if (!$bug_number) {
</span><del>- $count = $db->query_and_get_affected_rows("DELETE FROM bugs WHERE bug_run = $1 AND bug_tracker = $2",
- array($run_id, $bug_tracker_id));
</del><ins>+ $count = $db->query_and_get_affected_rows("DELETE FROM bugs WHERE bug_task = $1 AND bug_tracker = $2",
+ array($analysis_task_id, $bug_tracker_id));
</ins><span class="cx"> if ($count > 1) {
</span><span class="cx"> $db->rollback_transaction();
</span><span class="cx"> exit_with_error('UnexpectedNumberOfAffectedRows', array('affectedRows' => $count));
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- $bug_id = $db->update_or_insert_row('bugs', 'bug', array('run' => $run_id, 'tracker' => $bug_tracker_id),
- array('run' => $run_id, 'tracker' => $bug_tracker_id, 'number' => $bug_number));
</del><ins>+ $bug_id = $db->update_or_insert_row('bugs', 'bug', array('task' => $analysis_task_id, 'tracker' => $bug_tracker_id),
+ array('task' => $analysis_task_id, 'tracker' => $bug_tracker_id, 'number' => $bug_number));
</ins><span class="cx"> }
</span><span class="cx"> $db->commit_transaction();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2analysisjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/analysis.js (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/analysis.js 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/v2/analysis.js 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -9,13 +9,21 @@
</span><span class="cx"> testGroups: function () {
</span><span class="cx"> return this.store.find('testGroup', {task: this.get('id')});
</span><span class="cx"> }.property(),
</span><ins>+ label: function () {
+ var label = this.get('name');
+ var bugs = this.get('bugs').map(function (bug) { return bug.get('label'); }).join(' / ');
+ return bugs ? label + ' (' + bugs + ')' : label;
+ }.property('name', 'bugs'),
</ins><span class="cx"> });
</span><span class="cx">
</span><del>-App.Bug = App.NameLabelModel.extend({
</del><ins>+App.Bug = App.Model.extend({
</ins><span class="cx"> task: DS.belongsTo('AnalysisTask'),
</span><span class="cx"> bugTracker: DS.belongsTo('BugTracker'),
</span><span class="cx"> createdAt: DS.attr('date'),
</span><span class="cx"> number: DS.attr('number'),
</span><ins>+ label: function () {
+ return this.get('bugTracker').get('label') + ': ' + this.get('number');
+ }.property('name', 'bugTracker'),
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> // FIXME: Use DS.RESTAdapter instead.
</span><span class="lines">@@ -35,6 +43,21 @@
</span><span class="cx"> },
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+App.BugAdapter = DS.RESTAdapter.extend({
+ createRecord: function (store, type, record)
+ {
+ var param = {
+ task: record.get('task').get('id'),
+ bugTracker: record.get('bugTracker').get('id'),
+ number: record.get('number'),
+ };
+ return PrivilegedAPI.sendRequest('associate-bug', param).then(function (data) {
+ param['id'] = data['bugId'];
+ return {'bug': param};
+ });
+ }
+});
+
</ins><span class="cx"> App.TestGroup = App.NameLabelModel.extend({
</span><span class="cx"> analysisTask: DS.belongsTo('analysisTask'),
</span><span class="cx"> author: DS.attr('string'),
</span><span class="lines">@@ -57,7 +80,7 @@
</span><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span><del>-App.BuildRequest = DS.Model.extend({
</del><ins>+App.BuildRequest = App.Model.extend({
</ins><span class="cx"> group: DS.belongsTo('testGroup'),
</span><span class="cx"> order: DS.attr('number'),
</span><span class="cx"> rootSet: DS.attr('number'),
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appcss"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.css (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.css 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/v2/app.css 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -413,32 +413,32 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #analysis-tasks,
</span><del>-.test-groups > table {
</del><ins>+.analysis-group > table {
</ins><span class="cx"> border: solid 0px #999;
</span><span class="cx"> border-collapse: collapse;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #analysis-tasks thead,
</span><del>-.test-groups > table thead {
</del><ins>+.analysis-group > table thead {
</ins><span class="cx"> color: #c93;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #analysis-tasks th,
</span><del>-.test-groups > table th {
</del><ins>+.analysis-group > table th {
</ins><span class="cx"> font-weight: normal;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #analysis-tasks td,
</span><span class="cx"> #analysis-tasks th,
</span><del>-.test-groups > table td,
-.test-groups > table th {
</del><ins>+.analysis-group > table td,
+.analysis-group > table th {
</ins><span class="cx"> padding: 0.2rem 0.5rem;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #analysis-tasks tbody td,
</span><span class="cx"> #analysis-tasks tbody th,
</span><del>-.test-groups > table tbody td,
-.test-groups > table tbody th {
</del><ins>+.analysis-group > table tbody td,
+.analysis-group > table tbody th {
</ins><span class="cx"> border-top: solid 1px #ddd;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -457,7 +457,7 @@
</span><span class="cx"> color: #333;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.test-groups {
</del><ins>+.analysis-group {
</ins><span class="cx"> border: 1px solid #bbb;
</span><span class="cx"> border-radius: 0.5rem;
</span><span class="cx"> box-shadow: rgba(0, 0, 0, 0.03) 1px 1px 0px 0px;
</span><span class="lines">@@ -466,8 +466,13 @@
</span><span class="cx"> margin-bottom: 1.5rem;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.test-groups caption {
</del><ins>+.analysis-group caption {
</ins><span class="cx"> font-size: 1.1rem;
</span><span class="cx"> text-align: left;
</span><span class="cx"> margin-bottom: 0.5rem;
</span><span class="cx"> }
</span><ins>+
+.analysis-bugs th {
+ font-weight: normal;
+ text-align: right;
+}
</ins></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -1470,6 +1470,7 @@
</span><span class="cx"> bottom: null,
</span><span class="cx"> linkRoute: linkRoute,
</span><span class="cx"> linkId: range.get('id'),
</span><ins>+ label: range.get('label'),
</ins><span class="cx"> });
</span><span class="cx"> }));
</span><span class="cx">
</span><span class="lines">@@ -1653,22 +1654,46 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> App.AnalysisTaskRoute = Ember.Route.extend({
</span><del>- model: function (param) {
- return this.store.find('analysisTask', param.taskId).then(function (task) {
- return App.AnalysisTaskViewModel.create({content: task, store: store});
- });
</del><ins>+ model: function (param)
+ {
+ return this.store.find('analysisTask', param.taskId);
</ins><span class="cx"> },
</span><span class="cx"> });
</span><span class="cx">
</span><del>-App.AnalysisTaskViewModel = Ember.ObjectProxy.extend({
</del><ins>+App.AnalysisTaskController = Ember.Controller.extend({
+ label: Ember.computed.alias('model.name'),
+ platform: Ember.computed.alias('model.platform'),
+ metric: Ember.computed.alias('model.metric'),
</ins><span class="cx"> testSets: [],
</span><span class="cx"> roots: [],
</span><ins>+ bugTrackers: [],
</ins><span class="cx"> _taskUpdated: function ()
</span><span class="cx"> {
</span><del>- var platformId = this.get('platform').get('id');
- var metricId = this.get('metric').get('id');
- App.Manifest.fetchRunsWithPlatformAndMetric(this.get('store'), platformId, metricId).then(this._fetchedRuns.bind(this));
- }.observes('platform', 'metric').on('init'),
</del><ins>+ var model = this.get('model');
+ if (!model)
+ return;
+
+ var platformId = model.get('platform').get('id');
+ var metricId = model.get('metric').get('id');
+ App.Manifest.fetch(this.store).then(this._fetchedManifest.bind(this));
+ App.Manifest.fetchRunsWithPlatformAndMetric(this.store, platformId, metricId).then(this._fetchedRuns.bind(this));
+ }.observes('model').on('init'),
+ _fetchedManifest: function ()
+ {
+ var trackerIdToBugNumber = {};
+ this.get('model').get('bugs').forEach(function (bug) {
+ trackerIdToBugNumber[bug.get('bugTracker').get('id')] = bug.get('number');
+ });
+
+ this.set('bugTrackers', App.Manifest.get('bugTrackers').map(function (bugTracker) {
+ var bugNumber = trackerIdToBugNumber[bugTracker.get('id')];
+ return Ember.ObjectProxy.create({
+ content: bugTracker,
+ bugNumber: bugNumber,
+ editedBugNumber: bugNumber,
+ });
+ }));
+ },
</ins><span class="cx"> _fetchedRuns: function (data) {
</span><span class="cx"> var runs = data.runs;
</span><span class="cx">
</span><span class="lines">@@ -1676,8 +1701,8 @@
</span><span class="cx"> if (!currentTimeSeries)
</span><span class="cx"> return; // FIXME: Report an error.
</span><span class="cx">
</span><del>- var start = currentTimeSeries.findPointByMeasurementId(this.get('startRun'));
- var end = currentTimeSeries.findPointByMeasurementId(this.get('endRun'));
</del><ins>+ var start = currentTimeSeries.findPointByMeasurementId(this.get('model').get('startRun'));
+ var end = currentTimeSeries.findPointByMeasurementId(this.get('model').get('endRun'));
</ins><span class="cx"> if (!start || !end)
</span><span class="cx"> return; // FIXME: Report an error.
</span><span class="cx">
</span><span class="lines">@@ -1768,4 +1793,16 @@
</span><span class="cx"> }
</span><span class="cx"> return roots;
</span><span class="cx"> }.property('analysisPoints'),
</span><ins>+ actions: {
+ associateBug: function (bugTracker, bugNumber)
+ {
+ var model = this.get('model');
+ this.store.createRecord('bug',
+ {task: this.get('model'), bugTracker: bugTracker.get('content'), number: bugNumber}).save().then(function () {
+ // FIXME: Should we notify the user?
+ }, function (error) {
+ alert('Failed to associate the bug: ' + error);
+ });
+ }
+ },
</ins><span class="cx"> });
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2chartpanecss"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> top: 0.55rem;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.search-pane, .bugs-pane {
</del><ins>+.search-pane, .analysis-pane {
</ins><span class="cx"> position: absolute;
</span><span class="cx"> top: 1.7rem;
</span><span class="cx"> border: 1px solid #bbb;
</span><span class="lines">@@ -74,16 +74,16 @@
</span><span class="cx"> background: white;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.bugs-pane {
</del><ins>+.analysis-pane {
</ins><span class="cx"> right: 1.3rem;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.bugs-pane table {
</del><ins>+.analysis-pane table {
</ins><span class="cx"> margin: 0.2rem;
</span><span class="cx"> font-size: 0.8rem;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.bugs-pane th {
</del><ins>+.analysis-pane th {
</ins><span class="cx"> font-weight: normal;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> right: 0rem;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.bugs-pane.hidden,
</del><ins>+.analysis-pane.hidden,
</ins><span class="cx"> .search-pane.hidden {
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2datajs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/data.js 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -278,23 +278,6 @@
</span><span class="cx"> return bugs && Object.keys(bugs).length;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Measurement.prototype.associateBug = function (trackerId, bugNumber)
-{
- var bugs = this._raw['bugs'];
- trackerId = parseInt(trackerId);
- bugNumber = bugNumber ? parseInt(bugNumber) : null;
- return PrivilegedAPI.sendRequest('associate-bug', {
- run: this.id(),
- tracker: trackerId,
- bugNumber: bugNumber,
- }).then(function () {
- if (bugNumber)
- bugs[trackerId] = bugNumber;
- else
- delete bugs[trackerId];
- });
-}
-
</del><span class="cx"> function RunsData(rawData)
</span><span class="cx"> {
</span><span class="cx"> this._measurements = rawData.map(function (run) { return new Measurement(run); });
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/index.html 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -196,7 +196,7 @@
</span><span class="cx"> {{input action="searchCommit" placeholder="Name or email" value=commitSearchKeyword}}
</span><span class="cx"> </form>
</span><span class="cx">
</span><del>- <div {{bind-attr class=":bugs-pane showingAnalysisPane::hidden"}}>
</del><ins>+ <div {{bind-attr class=":analysis-pane showingAnalysisPane::hidden"}}>
</ins><span class="cx"> <table>
</span><span class="cx"> <tbody>
</span><span class="cx"> <tr>
</span><span class="lines">@@ -229,7 +229,7 @@
</span><span class="cx"> {{/if}}
</span><span class="cx"> <div class="rangeBarsContainerInlineStyle">
</span><span class="cx"> {{#each rangeBars}}
</span><del>- {{#link-to linkRoute linkId}}
</del><ins>+ {{#link-to linkRoute linkId title=label}}
</ins><span class="cx"> <span class="rangeBar" {{bind-attr style=inlineStyle}}></span>
</span><span class="cx"> {{/link-to}}
</span><span class="cx"> {{/each}}
</span><span class="lines">@@ -447,10 +447,12 @@
</span><span class="cx"> {{partial "navbar"}}
</span><span class="cx"> </header>
</span><span class="cx">
</span><del>- <h2 id="analysis-task-title">{{name}}</h2>
</del><ins>+ <h2 id="analysis-task-title">{{label}}</h2>
</ins><span class="cx"> {{#if platform.label}}
</span><span class="cx"> <h3 id="analysis-task-testname">{{metric.fullName}} - {{platform.label}}</h3>
</span><ins>+ {{/if}}
</ins><span class="cx">
</span><ins>+ {{#if chartData}}
</ins><span class="cx"> <section class="analysis-chart-pane chart-pane">
</span><span class="cx"> <div class="svg-container">
</span><span class="cx"> {{interactive-chart
</span><span class="lines">@@ -461,6 +463,20 @@
</span><span class="cx"> markedPoints=markedPoints}}
</span><span class="cx"> </div>
</span><span class="cx"> <div class="details">
</span><ins>+ <table class="analysis-bugs">
+ <tbody>
+ {{#each bugTrackers}}
+ <tr>
+ <th>{{label}}</th>
+ <td>
+ <form {{action "associateBug" this editedBugNumber on="submit"}}>
+ {{input type=text value=editedBugNumber}}
+ </form>
+ </td>
+ </tr>
+ {{/each}}
+ </tbody>
+ </table>
</ins><span class="cx"> <table>
</span><span class="cx"> <tbody>
</span><span class="cx"> {{#each analysisPoints}}
</span><span class="lines">@@ -472,7 +488,7 @@
</span><span class="cx"> </section>
</span><span class="cx">
</span><span class="cx"> {{#each testGroups}}
</span><del>- <section class="test-groups">
</del><ins>+ <section class="analysis-group">
</ins><span class="cx"> <table>
</span><span class="cx"> <caption>{{name}}</caption>
</span><span class="cx"> <thead>
</span><span class="lines">@@ -497,7 +513,7 @@
</span><span class="cx"> </section>
</span><span class="cx"> {{/each}}
</span><span class="cx">
</span><del>- <form class="test-groups">
</del><ins>+ <form class="analysis-group">
</ins><span class="cx"> <table>
</span><span class="cx"> <caption><input name="name" placeholder="Test group name" required></caption>
</span><span class="cx"> <thead>
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (176492 => 176493)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2014-11-22 01:43:07 UTC (rev 176492)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2014-11-22 02:06:00 UTC (rev 176493)
</span><span class="lines">@@ -1,3 +1,5 @@
</span><ins>+App.Model = DS.Model;
+
</ins><span class="cx"> App.NameLabelModel = DS.Model.extend({
</span><span class="cx"> name: DS.attr('string'),
</span><span class="cx"> label: function ()
</span></span></pre>
</div>
</div>
</body>
</html>