<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176481] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176481">176481</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-11-21 16:02:59 -0800 (Fri, 21 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline.
https://bugs.webkit.org/show_bug.cgi?id=138904
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Add an attribute that marks when a text field is auto-filled.
Test: accessibility/auto-filled-value.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isValueAutofilled):
* accessibility/AccessibilityObject.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
* accessibility/auto-filled-value.html: Added.
* platform/mac/accessibility/auto-filled-value-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjecth">trunk/Source/WebCore/accessibility/AccessibilityObject.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilityautofilledvaluehtml">trunk/LayoutTests/accessibility/auto-filled-value.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityautofilledvalueexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/auto-filled-value-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (176480 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-11-21 23:53:13 UTC (rev 176480)
+++ trunk/LayoutTests/ChangeLog 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-11-21 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline.
+ https://bugs.webkit.org/show_bug.cgi?id=138904
+
+ Reviewed by Mario Sanchez Prada.
+
+ * accessibility/auto-filled-value.html: Added.
+ * platform/mac/accessibility/auto-filled-value-expected.txt: Added.
+
</ins><span class="cx"> 2014-11-21 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> Allocate local ScopeChain register
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityautofilledvaluehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/auto-filled-value.html (0 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/auto-filled-value.html (rev 0)
+++ trunk/LayoutTests/accessibility/auto-filled-value.html 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<meta charset="utf-8">
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<input type="text" value="hello" id="textfield">
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that the auto-filled attribute is reported correctly.");
+
+ if (window.accessibilityController) {
+
+ var textField = document.getElementById("textfield");
+ var axTextField = accessibilityController.accessibleElementById("textfield");
+
+ debug("Initial auto-fill value: " + axTextField.boolAttributeValue("AXValueAutofilled"));
+ window.internals.setAutofilled(textField, true);
+ debug("Set auto-fill to true value: " + axTextField.boolAttributeValue("AXValueAutofilled"));
+ window.internals.setAutofilled(textField, false);
+ debug("Set auto-fill to false value: " + axTextField.boolAttributeValue("AXValueAutofilled"));
+ }
+
+</script>
+
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityautofilledvalueexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/auto-filled-value-expected.txt (0 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/auto-filled-value-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/auto-filled-value-expected.txt 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+
+This tests that the auto-filled attribute is reported correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Initial auto-fill value: false
+Set auto-fill to true value: true
+Set auto-fill to false value: false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (176480 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-11-21 23:53:13 UTC (rev 176480)
+++ trunk/Source/WebCore/ChangeLog 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-11-21 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline.
+ https://bugs.webkit.org/show_bug.cgi?id=138904
+
+ Reviewed by Mario Sanchez Prada.
+
+ Add an attribute that marks when a text field is auto-filled.
+
+ Test: accessibility/auto-filled-value.html
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::isValueAutofilled):
+ * accessibility/AccessibilityObject.h:
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
</ins><span class="cx"> 2014-11-21 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> RenderElement::removeChild() doesn't need a return value.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (176480 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-11-21 23:53:13 UTC (rev 176480)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -40,6 +40,7 @@
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "FrameLoader.h"
</span><span class="cx"> #include "FrameSelection.h"
</span><ins>+#include "HTMLInputElement.h"
</ins><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "HTMLParserIdioms.h"
</span><span class="cx"> #include "HitTestResult.h"
</span><span class="lines">@@ -1971,6 +1972,18 @@
</span><span class="cx"> return downcast<Element>(node);
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><ins>+
+bool AccessibilityObject::isValueAutofilled() const
+{
+ if (!isNativeTextControl())
+ return false;
+
+ Node* node = this->node();
+ if (!node || !is<HTMLInputElement>(*node))
+ return false;
+
+ return downcast<HTMLInputElement>(*node).isAutofilled();
+}
</ins><span class="cx">
</span><span class="cx"> const AtomicString& AccessibilityObject::placeholderValue() const
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (176480 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-11-21 23:53:13 UTC (rev 176480)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -832,7 +832,8 @@
</span><span class="cx"> virtual AccessibilityRole roleValueForMSAA() const { return roleValue(); }
</span><span class="cx">
</span><span class="cx"> virtual String passwordFieldValue() const { return String(); }
</span><del>-
</del><ins>+ bool isValueAutofilled() const;
+
</ins><span class="cx"> // Used by an ARIA tree to get all its rows.
</span><span class="cx"> void ariaTreeRows(AccessibilityChildrenVector&);
</span><span class="cx"> // Used by an ARIA tree item to get all of its direct rows that it can disclose.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (176480 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-11-21 23:53:13 UTC (rev 176480)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -750,6 +750,14 @@
</span><span class="cx"> [result appendString:string];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)_accessibilityValueIsAutofilled
+{
+ if (![self _prepareAccessibilityCall])
+ return NO;
+
+ return m_object->isValueAutofilled();
+}
+
</ins><span class="cx"> - (CGFloat)_accessibilityMinValue
</span><span class="cx"> {
</span><span class="cx"> return m_object->minValueForRange();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (176480 => 176481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-11-21 23:53:13 UTC (rev 176480)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-11-22 00:02:59 UTC (rev 176481)
</span><span class="lines">@@ -129,6 +129,10 @@
</span><span class="cx"> #define NSAccessibilityAccessKeyAttribute @"AXAccessKey"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#ifndef NSAccessibilityValueAutofilledAttribute
+#define NSAccessibilityValueAutofilledAttribute @"AXValueAutofilled"
+#endif
+
</ins><span class="cx"> #ifndef NSAccessibilityLanguageAttribute
</span><span class="cx"> #define NSAccessibilityLanguageAttribute @"AXLanguage"
</span><span class="cx"> #endif
</span><span class="lines">@@ -1373,6 +1377,7 @@
</span><span class="cx"> [tempArray addObject:NSAccessibilityRequiredAttribute];
</span><span class="cx"> [tempArray addObject:NSAccessibilityInvalidAttribute];
</span><span class="cx"> [tempArray addObject:NSAccessibilityPlaceholderValueAttribute];
</span><ins>+ [tempArray addObject:NSAccessibilityValueAutofilledAttribute];
</ins><span class="cx"> textAttrs = [[NSArray alloc] initWithArray:tempArray];
</span><span class="cx"> [tempArray release];
</span><span class="cx"> }
</span><span class="lines">@@ -1540,6 +1545,7 @@
</span><span class="cx"> [tempArray addObject:NSAccessibilityRequiredAttribute];
</span><span class="cx"> [tempArray addObject:NSAccessibilityInvalidAttribute];
</span><span class="cx"> [tempArray addObject:NSAccessibilityPlaceholderValueAttribute];
</span><ins>+ [tempArray addObject:NSAccessibilityValueAutofilledAttribute];
</ins><span class="cx"> passwordFieldAttrs = [[NSArray alloc] initWithArray:tempArray];
</span><span class="cx"> [tempArray release];
</span><span class="cx"> }
</span><span class="lines">@@ -2860,7 +2866,10 @@
</span><span class="cx">
</span><span class="cx"> if ([attributeName isEqualToString:NSAccessibilityPlaceholderValueAttribute])
</span><span class="cx"> return m_object->placeholderValue();
</span><del>-
</del><ins>+
+ if ([attributeName isEqualToString:NSAccessibilityValueAutofilledAttribute])
+ return @(m_object->isValueAutofilled());
+
</ins><span class="cx"> if ([attributeName isEqualToString:NSAccessibilityHasPopupAttribute])
</span><span class="cx"> return [NSNumber numberWithBool:m_object->ariaHasPopup()];
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>