<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176406] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176406">176406</a></dd>
<dt>Author</dt> <dd>eric.carlson@apple.com</dd>
<dt>Date</dt> <dd>2014-11-20 11:12:32 -0800 (Thu, 20 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update media/track/track-in-band-cues-added-once.html to make failures easier to diagnose
https://bugs.webkit.org/show_bug.cgi?id=138908
Reviewed by Alexey Proskuryakov.
* media/track/track-in-band-cues-added-once.html: Update test to remove one potential
source of flakeyness and to do more logging in the event of a failure to make debugging
failures simpler.
* media/track/track-in-band-cues-added-once-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediatracktrackinbandcuesaddedonceexpectedtxt">trunk/LayoutTests/media/track/track-in-band-cues-added-once-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediatracktrackinbandcuesaddedoncehtml">trunk/LayoutTests/media/track/track-in-band-cues-added-once.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (176405 => 176406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-11-20 19:06:43 UTC (rev 176405)
+++ trunk/LayoutTests/ChangeLog 2014-11-20 19:12:32 UTC (rev 176406)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-11-20 Eric Carlson <eric.carlson@apple.com>
+
+ Update media/track/track-in-band-cues-added-once.html to make failures easier to diagnose
+ https://bugs.webkit.org/show_bug.cgi?id=138908
+
+ Reviewed by Alexey Proskuryakov.
+
+ * media/track/track-in-band-cues-added-once.html: Update test to remove one potential
+ source of flakeyness and to do more logging in the event of a failure to make debugging
+ failures simpler.
+ * media/track/track-in-band-cues-added-once-expected.txt:
+
</ins><span class="cx"> 2014-11-20 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Temporarily skip almost all DRT tests
</span></span></pre></div>
<a id="trunkLayoutTestsmediatracktrackinbandcuesaddedonceexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/track/track-in-band-cues-added-once-expected.txt (176405 => 176406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/track/track-in-band-cues-added-once-expected.txt 2014-11-20 19:06:43 UTC (rev 176405)
+++ trunk/LayoutTests/media/track/track-in-band-cues-added-once-expected.txt 2014-11-20 19:12:32 UTC (rev 176406)
</span><span class="lines">@@ -16,13 +16,11 @@
</span><span class="cx">
</span><span class="cx"> RUN(inbandTrack1.mode = 'showing')
</span><span class="cx"> RUN(video.play())
</span><del>-EXPECTED (inbandTrack1.cues.length > '0') OK
</del><span class="cx"> RUN(video.pause())
</span><span class="cx"> RUN(video.currentTime = 0)
</span><span class="cx"> RUN(video.play())
</span><span class="cx">
</span><span class="cx"> EVENT(seeked)
</span><del>-EXPECTED (inbandTrack1.cues.length > '0') OK
</del><span class="cx"> RUN(video.pause())
</span><span class="cx"> END OF TEST
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsmediatracktrackinbandcuesaddedoncehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/track/track-in-band-cues-added-once.html (176405 => 176406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/track/track-in-band-cues-added-once.html 2014-11-20 19:06:43 UTC (rev 176405)
+++ trunk/LayoutTests/media/track/track-in-band-cues-added-once.html 2014-11-20 19:12:32 UTC (rev 176406)
</span><span class="lines">@@ -30,9 +30,7 @@
</span><span class="cx"> if (video.currentTime < 2)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- testExpected("inbandTrack1.cues.length", 0, ">");
-
- if (!seekedCount) {
</del><ins>+ if (!seekedCount && inbandTrack1.cues.length >= 5) {
</ins><span class="cx"> // Collect the start times of all cues, seek back to the beginning and play
</span><span class="cx"> // the same segment of the video file.
</span><span class="cx"> run("video.pause()");
</span><span class="lines">@@ -44,11 +42,28 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if (inbandTrack1.cues.length < cuesStarts.length)
+ return;
+
</ins><span class="cx"> run("video.pause()");
</span><ins>+ var failure = false;
</ins><span class="cx"> for (var i = 0; i < cuesStarts.length; ++i) {
</span><del>- if (cuesStarts[i] != inbandTrack1.cues[i].startTime)
- logResult(false, "Found unexpected cue starting at " + inbandTrack1.cues[i].startTime);
</del><ins>+ if (cuesStarts[i] != inbandTrack1.cues[i].startTime) {
+ failure = true;
+ break;
+ }
</ins><span class="cx"> }
</span><ins>+
+ if (failure) {
+ consoleWrite("<br><i>** FAIL<" + "/i>");
+ for (var i = 0; i < cuesStarts.length; ++i) {
+ var oldStart = cuesStarts[i];
+ var newStart = inbandTrack1.cues[i].startTime;
+ consoleWrite("Cue " + i + " start time was: " + oldStart + ", is now: " + newStart);
+ }
+ consoleWrite("");
+ }
+
</ins><span class="cx"> endTest();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>