<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176247] branches/safari-600.3-branch/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176247">176247</a></dd>
<dt>Author</dt> <dd>dburkart@apple.com</dd>
<dt>Date</dt> <dd>2014-11-17 19:29:02 -0800 (Mon, 17 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/176150">r176150</a>. rdar://problem/18982046</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari6003branchSourceWebKit2ChangeLog">branches/safari-600.3-branch/Source/WebKit2/ChangeLog</a></li>
<li><a href="#branchessafari6003branchSourceWebKit2UIProcessmacWKActionMenuControllermm">branches/safari-600.3-branch/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari6003branchSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-600.3-branch/Source/WebKit2/ChangeLog (176246 => 176247)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-600.3-branch/Source/WebKit2/ChangeLog 2014-11-18 03:23:07 UTC (rev 176246)
+++ branches/safari-600.3-branch/Source/WebKit2/ChangeLog 2014-11-18 03:29:02 UTC (rev 176247)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-11-17 Dana Burkart <dburkart@apple.com>
</span><span class="cx">
</span><ins>+ Merge r176150. <rdar://problem/18982046>
+
+ 2014-11-14 Tim Horton <timothy_horton@apple.com>
+
+ Remove pre-[DDActionContext contextForView:...] fallback path
+ https://bugs.webkit.org/show_bug.cgi?id=138735
+ <rdar://problem/18982046>
+
+ Reviewed by Simon Fraser.
+
+ * UIProcess/mac/WKActionMenuController.mm:
+ (-[WKActionMenuController willOpenMenu:withEvent:]):
+ (-[WKActionMenuController didCloseMenu:withEvent:]):
+ (-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
+ (hasDataDetectorsCompletionAPI): Deleted.
+ Remove the now-unnecessary fallback path.
+
+2014-11-17 Dana Burkart <dburkart@apple.com>
+
</ins><span class="cx"> Merge r176148. <rdar://problem/18990684>
</span><span class="cx">
</span><span class="cx"> 2014-11-14 Tim Horton <timothy_horton@apple.com>
</span></span></pre></div>
<a id="branchessafari6003branchSourceWebKit2UIProcessmacWKActionMenuControllermm"></a>
<div class="modfile"><h4>Modified: branches/safari-600.3-branch/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (176246 => 176247)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-600.3-branch/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-18 03:23:07 UTC (rev 176246)
+++ branches/safari-600.3-branch/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-18 03:29:02 UTC (rev 176247)
</span><span class="lines">@@ -54,15 +54,6 @@
</span><span class="cx"> SOFT_LINK_FRAMEWORK_IN_UMBRELLA(Quartz, ImageKit)
</span><span class="cx"> SOFT_LINK_CLASS(ImageKit, IKSlideshow)
</span><span class="cx">
</span><del>-static bool hasDataDetectorsCompletionAPI() {
- static bool hasCompletionAPI;
- static dispatch_once_t onceToken;
- dispatch_once(&onceToken, ^{
- hasCompletionAPI = [getDDActionsManagerClass() respondsToSelector:@selector(shouldUseActionsWithContext:)] && [getDDActionsManagerClass() respondsToSelector:@selector(didUseActions)];
- });
- return hasCompletionAPI;
-}
-
</del><span class="cx"> using namespace WebCore;
</span><span class="cx"> using namespace WebKit;
</span><span class="cx">
</span><span class="lines">@@ -201,17 +192,13 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (_type == kWKActionMenuDataDetectedItem) {
</span><del>- if (_currentActionContext && hasDataDetectorsCompletionAPI()) {
- if (![getDDActionsManagerClass() shouldUseActionsWithContext:_currentActionContext.get()]) {
- [menu cancelTracking];
- return;
- }
</del><ins>+ if (_currentActionContext && ![getDDActionsManagerClass() shouldUseActionsWithContext:_currentActionContext.get()]) {
+ [menu cancelTracking];
+ return;
</ins><span class="cx"> }
</span><del>- if (menu.numberOfItems == 1) {
</del><ins>+ if (menu.numberOfItems == 1)
</ins><span class="cx"> _page->clearSelection();
</span><del>- if (!hasDataDetectorsCompletionAPI())
- [self _showTextIndicator];
- } else
</del><ins>+ else
</ins><span class="cx"> _page->selectLastActionMenuRange();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -234,13 +221,8 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (_type == kWKActionMenuDataDetectedItem) {
</span><del>- if (hasDataDetectorsCompletionAPI()) {
- if (_currentActionContext)
- [getDDActionsManagerClass() didUseActions];
- } else {
- if (menu.numberOfItems > 1)
- [self _hideTextIndicator];
- }
</del><ins>+ if (_currentActionContext)
+ [getDDActionsManagerClass() didUseActions];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!_shouldKeepPreviewPopoverOpen)
</span><span class="lines">@@ -588,28 +570,18 @@
</span><span class="cx"> if (!actionContext)
</span><span class="cx"> return @[ ];
</span><span class="cx">
</span><del>- if (hasDataDetectorsCompletionAPI()) {
- // Ref our WebPageProxy for use in the blocks below.
- RefPtr<WebPageProxy> page = _page;
- _currentActionContext = [actionContext contextForView:_wkView altMode:YES interactionStartedHandler:^() {
- page->send(Messages::WebPage::DataDetectorsDidPresentUI());
- } interactionChangedHandler:^() {
- [self _showTextIndicator];
- page->send(Messages::WebPage::DataDetectorsDidChangeUI());
- } interactionStoppedHandler:^() {
- [self _hideTextIndicator];
- page->send(Messages::WebPage::DataDetectorsDidHideUI());
- }];
- } else {
- _currentActionContext = actionContext;
</del><ins>+ // Ref our WebPageProxy for use in the blocks below.
+ RefPtr<WebPageProxy> page = _page;
+ _currentActionContext = [actionContext contextForView:_wkView altMode:YES interactionStartedHandler:^() {
+ page->send(Messages::WebPage::DataDetectorsDidPresentUI());
+ } interactionChangedHandler:^() {
+ [self _showTextIndicator];
+ page->send(Messages::WebPage::DataDetectorsDidChangeUI());
+ } interactionStoppedHandler:^() {
+ [self _hideTextIndicator];
+ page->send(Messages::WebPage::DataDetectorsDidHideUI());
+ }];
</ins><span class="cx">
</span><del>- [_currentActionContext setCompletionHandler:^() {
- [self _hideTextIndicator];
- }];
-
- [_currentActionContext setForActionMenuContent:YES];
- }
-
</del><span class="cx"> [_currentActionContext setHighlightFrame:[_wkView.window convertRectToScreen:[_wkView convertRect:_hitTestResult.detectedDataBoundingBox toView:nil]]];
</span><span class="cx">
</span><span class="cx"> return [[getDDActionsManagerClass() sharedManager] menuItemsForResult:[_currentActionContext mainResult] actionContext:_currentActionContext.get()];
</span></span></pre>
</div>
</div>
</body>
</html>