<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176133] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176133">176133</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2014-11-14 12:05:26 -0800 (Fri, 14 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add some tracing to help investigating <rdar://problem/18905383> [iOS] Crash due to null m_webPageProxyForBackForwardListForCurrentSwipe in ViewGestureController::endSwipeGesture
https://bugs.webkit.org/show_bug.cgi?id=138750
Reviewed by Tim Horton.
Emit trace messages at various points, and log them prior to crashing if the error condition
occurs. Otherwise, clear the trace messages.
* UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::addLogEntry): Helper function that adds a message, including a time stamp and a
backtrace, to m_logEntries.
(WebKit::dumpLogEntries): Helper function that logs everything in m_logEntries.
(WebKit::ViewGestureController::beginSwipeGesture): Add a log entry.
(WebKit::ViewGestureController::endSwipeGesture): If
m_webPageProxyForBackForwardListForCurrentSwipe is null, dump the log entries just before
crashing. Otherwise, clear m_logEntries.
(WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree): Add a log entry.
(WebKit::ViewGestureController::removeSwipeSnapshot): Add a log entry.
* UIProcess/mac/ViewGestureController.h: Defined ENABLE_VIEW_GESTURE_CONTROLLER_TRACING,
and added m_logEntries member variable.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosViewGestureControllerIOSmm">trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacViewGestureControllerh">trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (176132 => 176133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-11-14 19:25:34 UTC (rev 176132)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-14 20:05:26 UTC (rev 176133)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-11-14 Dan Bernstein <mitz@apple.com>
+
+ Add some tracing to help investigating <rdar://problem/18905383> [iOS] Crash due to null m_webPageProxyForBackForwardListForCurrentSwipe in ViewGestureController::endSwipeGesture
+ https://bugs.webkit.org/show_bug.cgi?id=138750
+
+ Reviewed by Tim Horton.
+
+ Emit trace messages at various points, and log them prior to crashing if the error condition
+ occurs. Otherwise, clear the trace messages.
+
+ * UIProcess/ios/ViewGestureControllerIOS.mm:
+ (WebKit::addLogEntry): Helper function that adds a message, including a time stamp and a
+ backtrace, to m_logEntries.
+ (WebKit::dumpLogEntries): Helper function that logs everything in m_logEntries.
+ (WebKit::ViewGestureController::beginSwipeGesture): Add a log entry.
+ (WebKit::ViewGestureController::endSwipeGesture): If
+ m_webPageProxyForBackForwardListForCurrentSwipe is null, dump the log entries just before
+ crashing. Otherwise, clear m_logEntries.
+ (WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree): Add a log entry.
+ (WebKit::ViewGestureController::removeSwipeSnapshot): Add a log entry.
+ * UIProcess/mac/ViewGestureController.h: Defined ENABLE_VIEW_GESTURE_CONTROLLER_TRACING,
+ and added m_logEntries member variable.
+
</ins><span class="cx"> 2014-11-14 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> URLs for some videos are not valid URLs, should not be exposed to action menu
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosViewGestureControllerIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm (176132 => 176133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm 2014-11-14 19:25:34 UTC (rev 176132)
+++ trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm 2014-11-14 20:05:26 UTC (rev 176133)
</span><span class="lines">@@ -46,6 +46,7 @@
</span><span class="cx"> #import <UIKit/_UINavigationParallaxTransition.h>
</span><span class="cx"> #import <WebCore/IOSurface.h>
</span><span class="cx"> #import <wtf/NeverDestroyed.h>
</span><ins>+#import <wtf/text/StringBuilder.h>
</ins><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="lines">@@ -170,6 +171,32 @@
</span><span class="cx"> m_liveSwipeView = swipingView;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if ENABLE(VIEW_GESTURE_CONTROLLER_TRACING)
+static void addLogEntry(Vector<String>& entries, const String& message)
+{
+ void* stack[32];
+ int size = WTF_ARRAY_LENGTH(stack);
+ WTFGetBacktrace(stack, &size);
+ StringBuilder stringBuilder;
+ stringBuilder.append(String::format("%f [ ]", CFAbsoluteTimeGetCurrent()));
+ for (int i = 2; i < size; ++i) {
+ if (i > 2)
+ stringBuilder.appendLiteral(", ");
+ stringBuilder.append(String::format("%p", stack[i]));
+ }
+ stringBuilder.appendLiteral(" ] ");
+ stringBuilder.append(message);
+ entries.append(stringBuilder.toString());
+}
+
+static void dumpLogEntries(const Vector<String>& entries, WebPageProxy* webPageProxy)
+{
+ for (const auto& entry: entries)
+ WTFLogAlways(entry.utf8().data());
+ WTFLogAlways("m_webPageProxy: %p", webPageProxy);
+}
+#endif
+
</ins><span class="cx"> void ViewGestureController::beginSwipeGesture(_UINavigationInteractiveTransitionBase *transition, SwipeDirection direction)
</span><span class="cx"> {
</span><span class="cx"> if (m_activeGestureType != ViewGestureType::None)
</span><span class="lines">@@ -178,6 +205,9 @@
</span><span class="cx"> m_webPageProxy.recordNavigationSnapshot();
</span><span class="cx">
</span><span class="cx"> m_webPageProxyForBackForwardListForCurrentSwipe = m_alternateBackForwardListSourceView.get() ? m_alternateBackForwardListSourceView.get()->_page : &m_webPageProxy;
</span><ins>+#if ENABLE(VIEW_GESTURE_CONTROLLER_TRACING)
+ addLogEntry(m_logEntries, String::format("m_webPageProxyForBackForwardListForCurrentSwipe: %p", m_webPageProxyForBackForwardListForCurrentSwipe.get()));
+#endif
</ins><span class="cx"> m_webPageProxyForBackForwardListForCurrentSwipe->navigationGestureDidBegin();
</span><span class="cx">
</span><span class="cx"> auto& backForwardList = m_webPageProxyForBackForwardListForCurrentSwipe->backForwardList();
</span><span class="lines">@@ -279,7 +309,14 @@
</span><span class="cx"> // removeSwipeSnapshot will clear m_webPageProxyForBackForwardListForCurrentSwipe, so hold on to it here.
</span><span class="cx"> RefPtr<WebPageProxy> webPageProxyForBackForwardListForCurrentSwipe = m_webPageProxyForBackForwardListForCurrentSwipe;
</span><span class="cx"> removeSwipeSnapshot();
</span><ins>+#if ENABLE(VIEW_GESTURE_CONTROLLER_TRACING)
+ if (!webPageProxyForBackForwardListForCurrentSwipe)
+ dumpLogEntries(m_logEntries, &m_webPageProxy);
+ m_logEntries.clear();
+#endif
+
</ins><span class="cx"> webPageProxyForBackForwardListForCurrentSwipe->navigationGestureDidEnd(false, *targetItem);
</span><ins>+
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -287,6 +324,12 @@
</span><span class="cx"> if (ViewSnapshot* snapshot = targetItem->snapshot())
</span><span class="cx"> m_snapshotRemovalTargetRenderTreeSize = snapshot->renderTreeSize() * swipeSnapshotRemovalRenderTreeSizeTargetFraction;
</span><span class="cx">
</span><ins>+#if ENABLE(VIEW_GESTURE_CONTROLLER_TRACING)
+ if (!m_webPageProxyForBackForwardListForCurrentSwipe)
+ dumpLogEntries(m_logEntries, &m_webPageProxy);
+ m_logEntries.clear();
+#endif
+
</ins><span class="cx"> m_webPageProxyForBackForwardListForCurrentSwipe->navigationGestureDidEnd(true, *targetItem);
</span><span class="cx"> m_webPageProxyForBackForwardListForCurrentSwipe->goToBackForwardItem(targetItem);
</span><span class="cx">
</span><span class="lines">@@ -307,6 +350,9 @@
</span><span class="cx">
</span><span class="cx"> void ViewGestureController::willCommitPostSwipeTransitionLayerTree(bool successful)
</span><span class="cx"> {
</span><ins>+#if ENABLE(VIEW_GESTURE_CONTROLLER_TRACING)
+ addLogEntry(m_logEntries, String::format("successful: %d; m_activeGestureType: %d; m_webPageProxyForBackForwardListForCurrentSwipe: %p", successful, m_activeGestureType, m_webPageProxyForBackForwardListForCurrentSwipe.get()));
+#endif
</ins><span class="cx"> if (m_activeGestureType != ViewGestureType::Swipe)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -341,6 +387,9 @@
</span><span class="cx">
</span><span class="cx"> m_swipeWatchdogTimer.stop();
</span><span class="cx">
</span><ins>+#if ENABLE(VIEW_GESTURE_CONTROLLER_TRACING)
+ addLogEntry(m_logEntries, String::format("m_activeGestureType: %d; m_webPageProxyForBackForwardListForCurrentSwipe: %p", m_activeGestureType, m_webPageProxyForBackForwardListForCurrentSwipe.get()));
+#endif
</ins><span class="cx"> if (m_activeGestureType != ViewGestureType::Swipe)
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacViewGestureControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h (176132 => 176133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h 2014-11-14 19:25:34 UTC (rev 176132)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h 2014-11-14 20:05:26 UTC (rev 176133)
</span><span class="lines">@@ -33,6 +33,8 @@
</span><span class="cx"> #include <wtf/RetainPtr.h>
</span><span class="cx"> #include <wtf/RunLoop.h>
</span><span class="cx">
</span><ins>+#define ENABLE_VIEW_GESTURE_CONTROLLER_TRACING 1
+
</ins><span class="cx"> OBJC_CLASS CALayer;
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="lines">@@ -213,7 +215,10 @@
</span><span class="cx"> bool m_shouldRemoveSnapshotWhenTargetRenderTreeSizeHit;
</span><span class="cx"> WeakObjCPtr<WKWebView> m_alternateBackForwardListSourceView;
</span><span class="cx"> RefPtr<WebPageProxy> m_webPageProxyForBackForwardListForCurrentSwipe;
</span><ins>+#if ENABLE(VIEW_GESTURE_CONTROLLER_TRACING)
+ Vector<String> m_logEntries;
</ins><span class="cx"> #endif
</span><ins>+#endif
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre>
</div>
</div>
</body>
</html>