<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[176124] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/176124">176124</a></dd>
<dt>Author</dt> <dd>hyatt@apple.com</dd>
<dt>Date</dt> <dd>2014-11-14 08:53:03 -0800 (Fri, 14 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Table rows repaint entire table when their background color changes.
https://bugs.webkit.org/show_bug.cgi?id=26662
Reviewed by Simon Fraser.
Added fast/repaint/table-row-repaint.html
Source/WebCore:
* rendering/RenderTableCell.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
Improve table row's function to unite with the cell rects that can possibly
have the the row's background color painted behind them.
LayoutTests:
* fast/repaint/table-row-repaint-expected.txt: Added.
* fast/repaint/table-row-repaint.html: Added.
* platform/mac/accessibility/table-detection-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitytabledetectionexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/table-detection-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableCellh">trunk/Source/WebCore/rendering/RenderTableCell.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableRowcpp">trunk/Source/WebCore/rendering/RenderTableRow.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepainttablerowrepaintexpectedtxt">trunk/LayoutTests/fast/repaint/table-row-repaint-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepainttablerowrepainthtml">trunk/LayoutTests/fast/repaint/table-row-repaint.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (176123 => 176124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-11-14 16:20:18 UTC (rev 176123)
+++ trunk/LayoutTests/ChangeLog 2014-11-14 16:53:03 UTC (rev 176124)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-11-11 David Hyatt <hyatt@apple.com>
+
+ Table rows repaint entire table when their background color changes.
+ https://bugs.webkit.org/show_bug.cgi?id=26662
+
+ Reviewed by Simon Fraser.
+
+ Added fast/repaint/table-row-repaint.html
+
+ * fast/repaint/table-row-repaint-expected.txt: Added.
+ * fast/repaint/table-row-repaint.html: Added.
+ * platform/mac/accessibility/table-detection-expected.txt:
+
</ins><span class="cx"> 2014-11-14 Andrzej Badowski <a.badowski@samsung.com>
</span><span class="cx">
</span><span class="cx"> AX: Improve AccessibilityTableCell isColumnHeaderCell function.
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepainttablerowrepaintexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/table-row-repaint-expected.txt (0 => 176124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/table-row-repaint-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/repaint/table-row-repaint-expected.txt 2014-11-14 16:53:03 UTC (rev 176124)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+(repaint rects
+ (rect 8 61 106 15)
+ (rect 8 61 106 15)
+ (rect 8 61 106 15)
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepainttablerowrepainthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/table-row-repaint.html (0 => 176124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/table-row-repaint.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/table-row-repaint.html 2014-11-14 16:53:03 UTC (rev 176124)
</span><span class="lines">@@ -0,0 +1,43 @@
</span><ins>+<html>
+<head>
+ <script src="resources/text-based-repaint.js" type="text/javascript"></script>
+ <script type="text/javascript">
+ function repaintTest()
+ {
+ var div = document.getElementById("target");
+ div.className = "green";
+ }
+ </script>
+ <style>
+ #target {
+ background-color: red;
+ }
+
+ td {
+ width: 100px;
+ height: 15px;
+ }
+
+ #target.green {
+ background-color:green;
+ }
+ </style>
+</head>
+<body onload="runRepaintTest()">
+ <table>
+ <tr><td>
+ <tr><td>
+ <tr><td>
+
+ <tr id="target">
+ <td>
+ </td>
+ </tr>
+
+ <tr><td>
+ <tr><td>
+ <tr><td>
+
+ </table>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitytabledetectionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/table-detection-expected.txt (176123 => 176124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/table-detection-expected.txt 2014-11-14 16:20:18 UTC (rev 176123)
+++ trunk/LayoutTests/platform/mac/accessibility/table-detection-expected.txt 2014-11-14 16:53:03 UTC (rev 176124)
</span><span class="lines">@@ -725,7 +725,7 @@
</span><span class="cx"> AXDOMIdentifier:
</span><span class="cx"> AXDOMClassList: <array of size 0>
</span><span class="cx"> AXRows: <array of size 24>
</span><del>-AXVisibleRows: <array of size 24>
</del><ins>+AXVisibleRows: <array of size 13>
</ins><span class="cx"> AXColumns: <array of size 1>
</span><span class="cx"> AXVisibleColumns: <array of size 1>
</span><span class="cx"> AXVisibleCells: <array of size 24>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (176123 => 176124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-11-14 16:20:18 UTC (rev 176123)
+++ trunk/Source/WebCore/ChangeLog 2014-11-14 16:53:03 UTC (rev 176124)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-11-11 David Hyatt <hyatt@apple.com>
+
+ Table rows repaint entire table when their background color changes.
+ https://bugs.webkit.org/show_bug.cgi?id=26662
+
+ Reviewed by Simon Fraser.
+
+ Added fast/repaint/table-row-repaint.html
+
+ * rendering/RenderTableCell.h:
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
+ Improve table row's function to unite with the cell rects that can possibly
+ have the the row's background color painted behind them.
+
</ins><span class="cx"> 2014-11-14 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple line layout: Move simple line layout RunResolver and LineResolver implementation to SimpleLineLayoutResolver.cpp
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableCellh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableCell.h (176123 => 176124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableCell.h 2014-11-14 16:20:18 UTC (rev 176123)
+++ trunk/Source/WebCore/rendering/RenderTableCell.h 2014-11-14 16:53:03 UTC (rev 176124)
</span><span class="lines">@@ -216,6 +216,9 @@
</span><span class="cx"> return !table()->cellAfter(this) || !table()->cellBefore(this);
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><ins>+
+ virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
+
</ins><span class="cx"> protected:
</span><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</span><span class="cx"> virtual void computePreferredLogicalWidths() override;
</span><span class="lines">@@ -235,7 +238,6 @@
</span><span class="cx"> virtual bool boxShadowShouldBeAppliedToBackground(BackgroundBleedAvoidance, InlineFlowBox*) const override;
</span><span class="cx">
</span><span class="cx"> virtual LayoutSize offsetFromContainer(RenderElement&, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override;
</span><del>- virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
</del><span class="cx"> virtual void computeRectForRepaint(const RenderLayerModelObject* repaintContainer, LayoutRect&, bool fixed = false) const override;
</span><span class="cx">
</span><span class="cx"> int borderHalfLeft(bool outer) const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableRowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableRow.cpp (176123 => 176124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableRow.cpp 2014-11-14 16:20:18 UTC (rev 176123)
+++ trunk/Source/WebCore/rendering/RenderTableRow.cpp 2014-11-14 16:53:03 UTC (rev 176124)
</span><span class="lines">@@ -195,18 +195,17 @@
</span><span class="cx"> LayoutRect RenderTableRow::clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(parent());
</span><del>-
- if (repaintContainer == this)
- return RenderBox::clippedOverflowRectForRepaint(repaintContainer);
-
- // For now, just repaint the whole table.
- // FIXME: Find a better way to do this, e.g., need to repaint all the cells that we
- // might have propagated a background color into.
- // FIXME: do repaintContainer checks here
- if (RenderTable* parentTable = table())
- return parentTable->clippedOverflowRectForRepaint(repaintContainer);
-
- return LayoutRect();
</del><ins>+
+ // Rows and cells are in the same coordinate space. We need to both compute our overflow rect (which
+ // will accommodate a row outline and any visual effects on the row itself), but we also need to add in
+ // the repaint rects of cells.
+ LayoutRect result = RenderBox::clippedOverflowRectForRepaint(repaintContainer);
+ for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell()) {
+ // Even if a cell is a repaint container, it's the row that paints the background behind it.
+ // So we don't care if a cell is a repaintContainer here.
+ result.uniteIfNonZero(cell->clippedOverflowRectForRepaint(repaintContainer));
+ }
+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Hit Testing
</span></span></pre>
</div>
</div>
</body>
</html>