<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175720] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175720">175720</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-11-06 15:17:32 -0800 (Thu, 06 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Stop special-casing wbr elements in HTMLElement::createElementRenderer()
https://bugs.webkit.org/show_bug.cgi?id=138474
Reviewed by Ryosuke Niwa.
Stop special-casing wbr elements in HTMLElement::createElementRenderer()
and move the code to a HTMLWBRElement subclass instead, that is
overriding createElementRenderer(). This function is already virtual.
No new tests, no behavior change.
* CMakeLists.txt:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::createElementRenderer):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLTagNames.in:
* html/HTMLWBRElement.cpp: Added.
(WebCore::HTMLWBRElement::create):
(WebCore::HTMLWBRElement::HTMLWBRElement):
(WebCore::HTMLWBRElement::createElementRenderer):
* html/HTMLWBRElement.h: Added.
* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::RenderLineBreak):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCorevcxprojWebCorevcxproj">trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementsAllInOnecpp">trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTagNamesin">trunk/Source/WebCore/html/HTMLTagNames.in</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLineBreakcpp">trunk/Source/WebCore/rendering/RenderLineBreak.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorehtmlHTMLWBRElementcpp">trunk/Source/WebCore/html/HTMLWBRElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLWBRElementh">trunk/Source/WebCore/html/HTMLWBRElement.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -1625,6 +1625,7 @@
</span><span class="cx"> html/HTMLTrackElement.cpp
</span><span class="cx"> html/HTMLUListElement.cpp
</span><span class="cx"> html/HTMLVideoElement.cpp
</span><ins>+ html/HTMLWBRElement.cpp
</ins><span class="cx"> html/HiddenInputType.cpp
</span><span class="cx"> html/ImageData.cpp
</span><span class="cx"> html/ImageDocument.cpp
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/ChangeLog 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2014-11-06 Chris Dumez <cdumez@apple.com>
+
+ Stop special-casing wbr elements in HTMLElement::createElementRenderer()
+ https://bugs.webkit.org/show_bug.cgi?id=138474
+
+ Reviewed by Ryosuke Niwa.
+
+ Stop special-casing wbr elements in HTMLElement::createElementRenderer()
+ and move the code to a HTMLWBRElement subclass instead, that is
+ overriding createElementRenderer(). This function is already virtual.
+
+ No new tests, no behavior change.
+
+ * CMakeLists.txt:
+ * WebCore.vcxproj/WebCore.vcxproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::createElementRenderer):
+ * html/HTMLElementsAllInOne.cpp:
+ * html/HTMLTagNames.in:
+ * html/HTMLWBRElement.cpp: Added.
+ (WebCore::HTMLWBRElement::create):
+ (WebCore::HTMLWBRElement::HTMLWBRElement):
+ (WebCore::HTMLWBRElement::createElementRenderer):
+ * html/HTMLWBRElement.h: Added.
+ * rendering/RenderLineBreak.cpp:
+ (WebCore::RenderLineBreak::RenderLineBreak):
+
</ins><span class="cx"> 2014-11-05 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> De-templatize Timer
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorevcxprojWebCorevcxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -16016,6 +16016,20 @@
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>
</span><span class="cx"> </ClCompile>
</span><ins>+ <ClCompile Include="..\html\HTMLWBRElement.cpp">
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>
+ </ClCompile>
</ins><span class="cx"> <ClCompile Include="..\html\ImageData.cpp" />
</span><span class="cx"> <ClCompile Include="..\html\ImageDocument.cpp" />
</span><span class="cx"> <ClCompile Include="..\html\ImageInputType.cpp" />
</span><span class="lines">@@ -20793,6 +20807,7 @@
</span><span class="cx"> <ClInclude Include="..\html\HTMLTrackElement.h" />
</span><span class="cx"> <ClInclude Include="..\html\HTMLUListElement.h" />
</span><span class="cx"> <ClInclude Include="..\html\HTMLVideoElement.h" />
</span><ins>+ <ClInclude Include="..\html\HTMLWBRElement.h" />
</ins><span class="cx"> <ClInclude Include="..\html\ImageData.h" />
</span><span class="cx"> <ClInclude Include="..\html\ImageDocument.h" />
</span><span class="cx"> <ClInclude Include="..\html\ImageInputType.h" />
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -2504,6 +2504,8 @@
</span><span class="cx"> 836FBCEC178C117F00B21A15 /* SVGAnimatedProperty.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 836FBCEB178C117F00B21A15 /* SVGAnimatedProperty.cpp */; };
</span><span class="cx"> 8386A96D19F61B2E00E1EC4A /* StyleBuilder.h in Headers */ = {isa = PBXBuildFile; fileRef = 8386A96C19F61B2E00E1EC4A /* StyleBuilder.h */; };
</span><span class="cx"> 8386A97019F61E4F00E1EC4A /* StyleBuilder.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 8386A96E19F61E4F00E1EC4A /* StyleBuilder.cpp */; };
</span><ins>+ 839AAFEC1A0C0C8D00605F99 /* HTMLWBRElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 839AAFEA1A0C0C8D00605F99 /* HTMLWBRElement.cpp */; };
+ 839AAFED1A0C0C8D00605F99 /* HTMLWBRElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 839AAFEB1A0C0C8D00605F99 /* HTMLWBRElement.h */; };
</ins><span class="cx"> 83B9687B19F8AB83004EF7AF /* StyleBuilderConverter.h in Headers */ = {isa = PBXBuildFile; fileRef = 83B9687919F8AB83004EF7AF /* StyleBuilderConverter.h */; };
</span><span class="cx"> 83C1D425178D5AB400141E68 /* SVGPathSegArcAbs.h in Headers */ = {isa = PBXBuildFile; fileRef = 83C1D413178D5AB400141E68 /* SVGPathSegArcAbs.h */; };
</span><span class="cx"> 83C1D426178D5AB400141E68 /* SVGPathSegArcRel.h in Headers */ = {isa = PBXBuildFile; fileRef = 83C1D414178D5AB400141E68 /* SVGPathSegArcRel.h */; };
</span><span class="lines">@@ -9686,6 +9688,8 @@
</span><span class="cx"> 836FBCEB178C117F00B21A15 /* SVGAnimatedProperty.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SVGAnimatedProperty.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 8386A96C19F61B2E00E1EC4A /* StyleBuilder.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StyleBuilder.h; sourceTree = "<group>"; };
</span><span class="cx"> 8386A96E19F61E4F00E1EC4A /* StyleBuilder.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StyleBuilder.cpp; sourceTree = "<group>"; };
</span><ins>+ 839AAFEA1A0C0C8D00605F99 /* HTMLWBRElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLWBRElement.cpp; sourceTree = "<group>"; };
+ 839AAFEB1A0C0C8D00605F99 /* HTMLWBRElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLWBRElement.h; sourceTree = "<group>"; };
</ins><span class="cx"> 83B9687919F8AB83004EF7AF /* StyleBuilderConverter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StyleBuilderConverter.h; sourceTree = "<group>"; };
</span><span class="cx"> 83C1D413178D5AB400141E68 /* SVGPathSegArcAbs.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGPathSegArcAbs.h; sourceTree = "<group>"; };
</span><span class="cx"> 83C1D414178D5AB400141E68 /* SVGPathSegArcRel.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGPathSegArcRel.h; sourceTree = "<group>"; };
</span><span class="lines">@@ -17941,6 +17945,8 @@
</span><span class="cx"> E44613980CD6331000FADA75 /* HTMLVideoElement.cpp */,
</span><span class="cx"> E44613990CD6331000FADA75 /* HTMLVideoElement.h */,
</span><span class="cx"> E446139A0CD6331000FADA75 /* HTMLVideoElement.idl */,
</span><ins>+ 839AAFEA1A0C0C8D00605F99 /* HTMLWBRElement.cpp */,
+ 839AAFEB1A0C0C8D00605F99 /* HTMLWBRElement.h */,
</ins><span class="cx"> A77979130D6B9D0C003851B9 /* ImageData.cpp */,
</span><span class="cx"> A77979140D6B9D0C003851B9 /* ImageData.h */,
</span><span class="cx"> A77979150D6B9D0C003851B9 /* ImageData.idl */,
</span><span class="lines">@@ -26251,6 +26257,7 @@
</span><span class="cx"> B2227A270D00BF220071B782 /* SVGGElement.h in Headers */,
</span><span class="cx"> 087E0AF713606D0B00FA4BA8 /* SVGGlyph.h in Headers */,
</span><span class="cx"> B2A1F2AE0CEF0ABF00442F6A /* SVGGlyphElement.h in Headers */,
</span><ins>+ 839AAFED1A0C0C8D00605F99 /* HTMLWBRElement.h in Headers */,
</ins><span class="cx"> 3744570F0DB05FA500AE0992 /* SVGGlyphMap.h in Headers */,
</span><span class="cx"> 24D912BE13CA9A9700D21915 /* SVGGlyphRefElement.h in Headers */,
</span><span class="cx"> B2227A2A0D00BF220071B782 /* SVGGradientElement.h in Headers */,
</span><span class="lines">@@ -28031,6 +28038,7 @@
</span><span class="cx"> 977B3877122883E900B81FF8 /* HTMLTokenizer.cpp in Sources */,
</span><span class="cx"> 0707568B142262D600414161 /* HTMLTrackElement.cpp in Sources */,
</span><span class="cx"> 977B37251228721700B81FF8 /* HTMLTreeBuilder.cpp in Sources */,
</span><ins>+ 839AAFEC1A0C0C8D00605F99 /* HTMLWBRElement.cpp in Sources */,
</ins><span class="cx"> A8EA79F30A1916DF00A8EF5F /* HTMLUListElement.cpp in Sources */,
</span><span class="cx"> E44613AA0CD6331000FADA75 /* HTMLVideoElement.cpp in Sources */,
</span><span class="cx"> 0B8C56D40F28627F000502E1 /* HTTPHeaderMap.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.cpp (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.cpp 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> #include "HTMLTemplateElement.h"
</span><span class="cx"> #include "HTMLTextFormControlElement.h"
</span><span class="cx"> #include "NodeTraversal.h"
</span><del>-#include "RenderLineBreak.h"
</del><ins>+#include "RenderElement.h"
</ins><span class="cx"> #include "ScriptController.h"
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include "StyleProperties.h"
</span><span class="lines">@@ -855,8 +855,6 @@
</span><span class="cx">
</span><span class="cx"> RenderPtr<RenderElement> HTMLElement::createElementRenderer(PassRef<RenderStyle> style)
</span><span class="cx"> {
</span><del>- if (hasTagName(wbrTag))
- return createRenderer<RenderLineBreak>(*this, WTF::move(style));
</del><span class="cx"> return RenderElement::createFor(*this, WTF::move(style));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementsAllInOnecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -109,4 +109,5 @@
</span><span class="cx"> #include "HTMLTrackElement.cpp"
</span><span class="cx"> #include "HTMLUListElement.cpp"
</span><span class="cx"> #include "HTMLVideoElement.cpp"
</span><ins>+#include "HTMLWBRElement.cpp"
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTagNamesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTagNames.in (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTagNames.in 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/html/HTMLTagNames.in 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -135,6 +135,6 @@
</span><span class="cx"> ul interfaceName=HTMLUListElement
</span><span class="cx"> var interfaceName=HTMLElement
</span><span class="cx"> video wrapperOnlyIfMediaIsAvailable, conditional=VIDEO, constructorNeedsCreatedByParser, customTypeHelper
</span><del>-wbr interfaceName=HTMLElement
</del><ins>+wbr interfaceName=HTMLWBRElement, JSInterfaceName=HTMLElement
</ins><span class="cx"> xmp interfaceName=HTMLPreElement
</span><span class="cx"> noscript interfaceName=HTMLElement
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLWBRElementcpp"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/html/HTMLWBRElement.cpp (0 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLWBRElement.cpp (rev 0)
+++ trunk/Source/WebCore/html/HTMLWBRElement.cpp 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -0,0 +1,52 @@
</span><ins>+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "HTMLWBRElement.h"
+
+#include "HTMLNames.h"
+#include "RenderLineBreak.h"
+
+namespace WebCore {
+
+using namespace HTMLNames;
+
+PassRefPtr<HTMLWBRElement> HTMLWBRElement::create(const QualifiedName& tagName, Document& document)
+{
+ return adoptRef(new HTMLWBRElement(tagName, document));
+}
+
+HTMLWBRElement::HTMLWBRElement(const QualifiedName& tagName, Document& document)
+ : HTMLElement(tagName, document)
+{
+ ASSERT(hasTagName(wbrTag));
+}
+
+RenderPtr<RenderElement> HTMLWBRElement::createElementRenderer(PassRef<RenderStyle> style)
+{
+ return createRenderer<RenderLineBreak>(*this, WTF::move(style));
+}
+
+} // namespace WebCore
</ins></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLWBRElementh"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/html/HTMLWBRElement.h (0 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLWBRElement.h (rev 0)
+++ trunk/Source/WebCore/html/HTMLWBRElement.h 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -0,0 +1,46 @@
</span><ins>+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef HTMLWBRElement_h
+#define HTMLWBRElement_h
+
+#include "HTMLElement.h"
+
+namespace WebCore {
+
+class HTMLWBRElement final : public HTMLElement {
+public:
+ static PassRefPtr<HTMLWBRElement> create(const QualifiedName&, Document&);
+
+private:
+ HTMLWBRElement(const QualifiedName&, Document&);
+
+ virtual RenderPtr<RenderElement> createElementRenderer(PassRef<RenderStyle>) override;
+};
+
+} // namespace WebCore
+
+#endif // HTMLWBRElement_h
+
</ins></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLineBreakcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLineBreak.cpp (175719 => 175720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLineBreak.cpp 2014-11-06 23:06:03 UTC (rev 175719)
+++ trunk/Source/WebCore/rendering/RenderLineBreak.cpp 2014-11-06 23:17:32 UTC (rev 175720)
</span><span class="lines">@@ -24,6 +24,7 @@
</span><span class="cx">
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "HTMLElement.h"
</span><ins>+#include "HTMLWBRElement.h"
</ins><span class="cx"> #include "InlineElementBox.h"
</span><span class="cx"> #include "LogicalSelectionOffsetCaches.h"
</span><span class="cx"> #include "RenderBlock.h"
</span><span class="lines">@@ -43,7 +44,7 @@
</span><span class="cx"> : RenderBoxModelObject(element, WTF::move(style), 0)
</span><span class="cx"> , m_inlineBoxWrapper(nullptr)
</span><span class="cx"> , m_cachedLineHeight(invalidLineHeight)
</span><del>- , m_isWBR(element.hasTagName(HTMLNames::wbrTag))
</del><ins>+ , m_isWBR(is<HTMLWBRElement>(element))
</ins><span class="cx"> {
</span><span class="cx"> setIsLineBreak();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>