<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175688] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175688">175688</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-11-05 23:53:01 -0800 (Wed, 05 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>splitText API does not match DOM specification.
https://bugs.webkit.org/show_bug.cgi?id=138405
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-05
Reviewed by Chris Dumez.
Source/WebCore:
Make the offset argument for splitText API as mandatory (and thus throw if it is omitted) and stop throwing if the offset argument is
negative (and wraps to a valid index) as per specification: https://w3c.github.io/dom/#interface-text. Also This matches the behavior
of both Firefox 33 and Chrome 38.
Test: fast/dom/Text/splitText.html
* dom/Text.idl:
LayoutTests:
* fast/dom/Text/splitText-expected.txt: Added.
* fast/dom/Text/splitText.html: Added.
* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt">trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs">trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomTextidl">trunk/Source/WebCore/dom/Text.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomTextsplitTextexpectedtxt">trunk/LayoutTests/fast/dom/Text/splitText-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomTextsplitTexthtml">trunk/LayoutTests/fast/dom/Text/splitText.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (175687 => 175688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-11-06 07:43:41 UTC (rev 175687)
+++ trunk/LayoutTests/ChangeLog 2014-11-06 07:53:01 UTC (rev 175688)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-11-05 Shivakumar JM <shiva.jm@samsung.com>
+
+ splitText API does not match DOM specification.
+ https://bugs.webkit.org/show_bug.cgi?id=138405
+
+ Reviewed by Chris Dumez.
+
+ * fast/dom/Text/splitText-expected.txt: Added.
+ * fast/dom/Text/splitText.html: Added.
+ * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+ * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+
</ins><span class="cx"> 2014-11-05 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r175672.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomTextsplitTextexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Text/splitText-expected.txt (0 => 175688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Text/splitText-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Text/splitText-expected.txt 2014-11-06 07:53:01 UTC (rev 175688)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+Tests the splitText API arguments.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS text.data is "abcdefg"
+PASS text.splitText(4).data is "efg"
+PASS text.data is "abcd"
+PASS text.splitText() threw exception TypeError: Not enough arguments.
+PASS text.splitText(999) threw exception Error: IndexSizeError: DOM Exception 1.
+PASS text.splitText(-1) threw exception Error: IndexSizeError: DOM Exception 1.
+PASS text.data is "abcd"
+PASS text.splitText(-4294967294).data is "cd"
+PASS text.data is "ab"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomTextsplitTexthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Text/splitText.html (0 => 175688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Text/splitText.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Text/splitText.html 2014-11-06 07:53:01 UTC (rev 175688)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<html>
+<head>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+<head>
+<script>
+description("Tests the splitText API arguments.");
+
+var text = document.createTextNode("abcdefg");
+
+shouldBeEqualToString("text.data", "abcdefg");
+shouldBeEqualToString("text.splitText(4).data", "efg");
+shouldBeEqualToString("text.data", "abcd");
+shouldThrow("text.splitText()", "'TypeError: Not enough arguments'");
+shouldThrow("text.splitText(999)", '"Error: IndexSizeError: DOM Exception 1"');
+shouldThrow("text.splitText(-1)", '"Error: IndexSizeError: DOM Exception 1"');
+shouldBeEqualToString("text.data", "abcd");
+shouldBeEqualToString("text.splitText(-4294967294).data", "cd");
+shouldBeEqualToString("text.data", "ab");
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (175687 => 175688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2014-11-06 07:43:41 UTC (rev 175687)
+++ trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2014-11-06 07:53:01 UTC (rev 175688)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> PASS nonNumericPolicy('getSelection().extend(document, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('getSelection().getRangeAt(x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.styleSheets.item(x)') is 'any type allowed'
</span><del>-PASS nonNumericPolicy('document.createTextNode("a").splitText(x)') is 'any type allowed'
</del><ins>+PASS nonNumericPolicy('document.createTextNode("a").splitText(x)') is 'any type allowed (but not omitted)'
</ins><span class="cx"> PASS nonNumericPolicy('document.createTreeWalker(document, x, null, false)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createEvent("UIEvent").initUIEvent("a", false, false, null, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('window.scrollBy(x, 0)') is 'any type allowed'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (175687 => 175688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2014-11-06 07:43:41 UTC (rev 175687)
+++ trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2014-11-06 07:53:01 UTC (rev 175688)
</span><span class="lines">@@ -327,7 +327,7 @@
</span><span class="cx">
</span><span class="cx"> // Text
</span><span class="cx">
</span><del>-shouldBe("nonNumericPolicy('document.createTextNode(\"a\").splitText(x)')", "'any type allowed'");
</del><ins>+shouldBe("nonNumericPolicy('document.createTextNode(\"a\").splitText(x)')", "'any type allowed (but not omitted)'");
</ins><span class="cx">
</span><span class="cx"> // TimeRanges
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (175687 => 175688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-11-06 07:43:41 UTC (rev 175687)
+++ trunk/Source/WebCore/ChangeLog 2014-11-06 07:53:01 UTC (rev 175688)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-11-05 Shivakumar JM <shiva.jm@samsung.com>
+
+ splitText API does not match DOM specification.
+ https://bugs.webkit.org/show_bug.cgi?id=138405
+
+ Reviewed by Chris Dumez.
+
+ Make the offset argument for splitText API as mandatory (and thus throw if it is omitted) and stop throwing if the offset argument is
+ negative (and wraps to a valid index) as per specification: https://w3c.github.io/dom/#interface-text. Also This matches the behavior
+ of both Firefox 33 and Chrome 38.
+
+ Test: fast/dom/Text/splitText.html
+
+ * dom/Text.idl:
+
</ins><span class="cx"> 2014-11-05 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r175672.
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Text.idl (175687 => 175688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Text.idl 2014-11-06 07:43:41 UTC (rev 175687)
+++ trunk/Source/WebCore/dom/Text.idl 2014-11-06 07:53:01 UTC (rev 175688)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx">
</span><span class="cx"> // DOM Level 1
</span><span class="cx">
</span><del>- [RaisesException] Text splitText([IsIndex,Default=Undefined] optional unsigned long offset);
</del><ins>+ [RaisesException] Text splitText(unsigned long offset);
</ins><span class="cx">
</span><span class="cx"> // Introduced in DOM Level 3:
</span><span class="cx"> readonly attribute DOMString wholeText;
</span></span></pre>
</div>
</div>
</body>
</html>