<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175460] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175460">175460</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-11-01 23:59:49 -0700 (Sat, 01 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: Using a media element changes window.name
https://bugs.webkit.org/show_bug.cgi?id=138278
rdar://problem/18704134
Reviewed by Jer Noble.
Source/WebCore:
Test: fast/media/window-name.html
Use an actual variable for name (and while at it, for "item" as well).
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.disconnectControls):
LayoutTests:
* fast/media/window-name-expected.txt: Added.
* fast/media/window-name.html: Added.
* platform/mac/webarchive/loading/video-in-webarchive-expected.txt: Removed.
This result was incorrect due to this bug, and now Mac matches cross-platform
results.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastmediawindownameexpectedtxt">trunk/LayoutTests/fast/media/window-name-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediawindownamehtml">trunk/LayoutTests/fast/media/window-name.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacwebarchiveloadingvideoinwebarchiveexpectedtxt">trunk/LayoutTests/platform/mac/webarchive/loading/video-in-webarchive-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (175459 => 175460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/LayoutTests/ChangeLog 2014-11-02 06:59:49 UTC (rev 175460)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-11-01 Alexey Proskuryakov <ap@apple.com>
+
+ REGRESSION: Using a media element changes window.name
+ https://bugs.webkit.org/show_bug.cgi?id=138278
+ rdar://problem/18704134
+
+ Reviewed by Jer Noble.
+
+ * fast/media/window-name-expected.txt: Added.
+ * fast/media/window-name.html: Added.
+
+ * platform/mac/webarchive/loading/video-in-webarchive-expected.txt: Removed.
+ This result was incorrect due to this bug, and now Mac matches cross-platform
+ results.
+
</ins><span class="cx"> 2014-11-01 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediawindownameexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/media/window-name-expected.txt (0 => 175460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/media/window-name-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/media/window-name-expected.txt 2014-11-02 06:59:49 UTC (rev 175460)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+Test that having an audio element in DOM doesn't magically change window.name.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.name is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/media/window-name-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkLayoutTestsfastmediawindownamehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/media/window-name.html (0 => 175460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/media/window-name.html (rev 0)
+++ trunk/LayoutTests/fast/media/window-name.html 2014-11-02 06:59:49 UTC (rev 175460)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<audio controls></audio>
+<script>
+
+description("Test that having an audio element in DOM doesn't magically change window.name.");
+
+shouldBeEqualToString("window.name", "");
+
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/media/window-name.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsplatformmacwebarchiveloadingvideoinwebarchiveexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/webarchive/loading/video-in-webarchive-expected.txt (175459 => 175460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/webarchive/loading/video-in-webarchive-expected.txt 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/LayoutTests/platform/mac/webarchive/loading/video-in-webarchive-expected.txt 2014-11-02 06:59:49 UTC (rev 175460)
</span><span class="lines">@@ -1,16 +0,0 @@
</span><del>-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-main frame - willPerformClientRedirectToURL: resources/video-in-webarchive.webarchive
-main frame - didFinishDocumentLoadForFrame
-main frame - didFinishLoadForFrame
-main frame - didStartProvisionalLoadForFrame
-main frame - didCancelClientRedirectForFrame
-main frame - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFailLoadWithError
-main frame "webkitendfullscreen" - didFinishLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
-
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (175459 => 175460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/Source/WebCore/ChangeLog 2014-11-02 06:59:49 UTC (rev 175460)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-11-01 Alexey Proskuryakov <ap@apple.com>
+
+ REGRESSION: Using a media element changes window.name
+ https://bugs.webkit.org/show_bug.cgi?id=138278
+ rdar://problem/18704134
+
+ Reviewed by Jer Noble.
+
+ Test: fast/media/window-name.html
+
+ Use an actual variable for name (and while at it, for "item" as well).
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.addVideoListeners):
+ (Controller.prototype.removeVideoListeners):
+ (Controller.prototype.disconnectControls):
+
</ins><span class="cx"> 2014-11-01 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Move "direction" CSS property to the new StyleBuilder
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (175459 => 175460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2014-11-02 06:59:49 UTC (rev 175460)
</span><span class="lines">@@ -152,7 +152,7 @@
</span><span class="cx">
</span><span class="cx"> addVideoListeners: function()
</span><span class="cx"> {
</span><del>- for (name in this.HandledVideoEvents) {
</del><ins>+ for (var name in this.HandledVideoEvents) {
</ins><span class="cx"> this.listenFor(this.video, name, this.HandledVideoEvents[name]);
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -178,7 +178,7 @@
</span><span class="cx">
</span><span class="cx"> removeVideoListeners: function()
</span><span class="cx"> {
</span><del>- for (name in this.HandledVideoEvents) {
</del><ins>+ for (var name in this.HandledVideoEvents) {
</ins><span class="cx"> this.stopListeningFor(this.video, name, this.HandledVideoEvents[name]);
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -432,7 +432,7 @@
</span><span class="cx">
</span><span class="cx"> disconnectControls: function(event)
</span><span class="cx"> {
</span><del>- for (item in this.controls) {
</del><ins>+ for (var item in this.controls) {
</ins><span class="cx"> var control = this.controls[item];
</span><span class="cx"> if (control && control.parentNode)
</span><span class="cx"> control.parentNode.removeChild(control);
</span></span></pre>
</div>
</div>
</body>
</html>