<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175355] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175355">175355</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-10-29 16:28:55 -0700 (Wed, 29 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up virtual functions in inspector/
https://bugs.webkit.org/show_bug.cgi?id=138190
Reviewed by Andreas Kling.
Clean up virtual functions in inspector/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Explicitly marking functions / destructors as virtual when they are
inherently virtual
- Making isXXX() virtual functions private on XXX classes to avoid
unnecessary type checks
No new tests, no behavior change.
* inspector/InspectorApplicationCacheAgent.h:
(WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent): Deleted.
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorPageAgent.h:
* inspector/InspectorReplayAgent.h:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorStyleSheet.h:
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.h:
* inspector/PageConsoleAgent.h:
* inspector/WorkerInspectorController.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth">trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCSSAgenth">trunk/Source/WebCore/inspector/InspectorCSSAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgenth">trunk/Source/WebCore/inspector/InspectorDOMAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMDebuggerAgenth">trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMStorageAgenth">trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDatabaseAgenth">trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendClientLocalh">trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorIndexedDBAgenth">trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorLayerTreeAgenth">trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgenth">trunk/Source/WebCore/inspector/InspectorPageAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorReplayAgenth">trunk/Source/WebCore/inspector/InspectorReplayAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorResourceAgenth">trunk/Source/WebCore/inspector/InspectorResourceAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorStyleSheeth">trunk/Source/WebCore/inspector/InspectorStyleSheet.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgenth">trunk/Source/WebCore/inspector/InspectorTimelineAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorWorkerAgenth">trunk/Source/WebCore/inspector/InspectorWorkerAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorPageConsoleAgenth">trunk/Source/WebCore/inspector/PageConsoleAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerInspectorControllerh">trunk/Source/WebCore/inspector/WorkerInspectorController.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/ChangeLog 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -1,3 +1,39 @@
</span><ins>+2014-10-29 Chris Dumez <cdumez@apple.com>
+
+ Clean up virtual functions in inspector/
+ https://bugs.webkit.org/show_bug.cgi?id=138190
+
+ Reviewed by Andreas Kling.
+
+ Clean up virtual functions in inspector/ by:
+ - Making virtual functions final when possible
+ - Making classes final when possible
+ - Explicitly marking functions / destructors as virtual when they are
+ inherently virtual
+ - Making isXXX() virtual functions private on XXX classes to avoid
+ unnecessary type checks
+
+ No new tests, no behavior change.
+
+ * inspector/InspectorApplicationCacheAgent.h:
+ (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent): Deleted.
+ * inspector/InspectorCSSAgent.h:
+ * inspector/InspectorDOMAgent.h:
+ * inspector/InspectorDOMDebuggerAgent.h:
+ * inspector/InspectorDOMStorageAgent.h:
+ * inspector/InspectorDatabaseAgent.h:
+ * inspector/InspectorFrontendClientLocal.h:
+ * inspector/InspectorIndexedDBAgent.h:
+ * inspector/InspectorLayerTreeAgent.h:
+ * inspector/InspectorPageAgent.h:
+ * inspector/InspectorReplayAgent.h:
+ * inspector/InspectorResourceAgent.h:
+ * inspector/InspectorStyleSheet.h:
+ * inspector/InspectorTimelineAgent.h:
+ * inspector/InspectorWorkerAgent.h:
+ * inspector/PageConsoleAgent.h:
+ * inspector/WorkerInspectorController.h:
+
</ins><span class="cx"> 2014-10-29 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Generalize dirtying of parent's line boxes when taking a renderer out of tree.
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -49,11 +49,11 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorApplicationCacheAgent : public InspectorAgentBase, public Inspector::InspectorApplicationCacheBackendDispatcherHandler {
</del><ins>+class InspectorApplicationCacheAgent final : public InspectorAgentBase, public Inspector::InspectorApplicationCacheBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorApplicationCacheAgent); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> InspectorApplicationCacheAgent(InstrumentingAgents*, InspectorPageAgent*);
</span><del>- ~InspectorApplicationCacheAgent() { }
</del><ins>+ virtual ~InspectorApplicationCacheAgent() { }
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCSSAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCSSAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INSPECTOR)
</span><span class="cx">
</span><del>-class InspectorCSSAgent
</del><ins>+class InspectorCSSAgent final
</ins><span class="cx"> : public InspectorAgentBase
</span><span class="cx"> , public InspectorDOMAgent::DOMListener
</span><span class="cx"> , public Inspector::InspectorCSSBackendDispatcherHandler
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> InspectorCSSAgent(InstrumentingAgents*, InspectorDOMAgent*);
</span><del>- ~InspectorCSSAgent();
</del><ins>+ virtual ~InspectorCSSAgent();
</ins><span class="cx">
</span><span class="cx"> static CSSStyleRule* asCSSStyleRule(CSSRule&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx"> const EventListenerVector eventListenerVector;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class InspectorDOMAgent : public InspectorAgentBase, public Inspector::InspectorDOMBackendDispatcherHandler {
</del><ins>+class InspectorDOMAgent final : public InspectorAgentBase, public Inspector::InspectorDOMBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorDOMAgent);
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> InspectorDOMAgent(InstrumentingAgents*, InspectorPageAgent*, Inspector::InjectedScriptManager*, InspectorOverlay*);
</span><del>- ~InspectorDOMAgent();
</del><ins>+ virtual ~InspectorDOMAgent();
</ins><span class="cx">
</span><span class="cx"> static String toErrorString(const ExceptionCode&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMDebuggerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorDOMDebuggerAgent : public InspectorAgentBase, public Inspector::InspectorDebuggerAgent::Listener, public Inspector::InspectorDOMDebuggerBackendDispatcherHandler {
</del><ins>+class InspectorDOMDebuggerAgent final : public InspectorAgentBase, public Inspector::InspectorDebuggerAgent::Listener, public Inspector::InspectorDOMDebuggerBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorDOMDebuggerAgent);
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMStorageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -51,11 +51,11 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorDOMStorageAgent : public InspectorAgentBase, public Inspector::InspectorDOMStorageBackendDispatcherHandler {
</del><ins>+class InspectorDOMStorageAgent final : public InspectorAgentBase, public Inspector::InspectorDOMStorageBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> InspectorDOMStorageAgent(InstrumentingAgents*, InspectorPageAgent*);
</span><del>- ~InspectorDOMStorageAgent();
</del><ins>+ virtual ~InspectorDOMStorageAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDatabaseAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -49,11 +49,11 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorDatabaseAgent : public InspectorAgentBase, public Inspector::InspectorDatabaseBackendDispatcherHandler {
</del><ins>+class InspectorDatabaseAgent final : public InspectorAgentBase, public Inspector::InspectorDatabaseBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> explicit InspectorDatabaseAgent(InstrumentingAgents*);
</span><del>- ~InspectorDatabaseAgent();
</del><ins>+ virtual ~InspectorDatabaseAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendClientLocalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -58,15 +58,15 @@
</span><span class="cx"> WEBCORE_EXPORT InspectorFrontendClientLocal(InspectorController*, Page*, std::unique_ptr<Settings>);
</span><span class="cx"> WEBCORE_EXPORT virtual ~InspectorFrontendClientLocal();
</span><span class="cx">
</span><del>- WEBCORE_EXPORT virtual void windowObjectCleared() override;
</del><ins>+ WEBCORE_EXPORT virtual void windowObjectCleared() override final;
</ins><span class="cx"> WEBCORE_EXPORT virtual void frontendLoaded() override;
</span><span class="cx">
</span><del>- WEBCORE_EXPORT virtual void moveWindowBy(float x, float y) override;
</del><ins>+ WEBCORE_EXPORT virtual void moveWindowBy(float x, float y) override final;
</ins><span class="cx">
</span><del>- WEBCORE_EXPORT virtual void requestSetDockSide(DockSide) override;
- WEBCORE_EXPORT virtual void changeAttachedWindowHeight(unsigned) override;
- WEBCORE_EXPORT virtual void changeAttachedWindowWidth(unsigned) override;
- WEBCORE_EXPORT virtual void openInNewTab(const String& url) override;
</del><ins>+ WEBCORE_EXPORT virtual void requestSetDockSide(DockSide) override final;
+ WEBCORE_EXPORT virtual void changeAttachedWindowHeight(unsigned) override final;
+ WEBCORE_EXPORT virtual void changeAttachedWindowWidth(unsigned) override final;
+ WEBCORE_EXPORT virtual void openInNewTab(const String& url) override final;
</ins><span class="cx"> virtual bool canSave() override { return false; }
</span><span class="cx"> virtual void save(const String&, const String&, bool, bool) override { }
</span><span class="cx"> virtual void append(const String&, const String&) override { }
</span><span class="lines">@@ -74,9 +74,9 @@
</span><span class="cx"> virtual void attachWindow(DockSide) = 0;
</span><span class="cx"> virtual void detachWindow() = 0;
</span><span class="cx">
</span><del>- WEBCORE_EXPORT virtual void sendMessageToBackend(const String& message) override;
</del><ins>+ WEBCORE_EXPORT virtual void sendMessageToBackend(const String& message) override final;
</ins><span class="cx">
</span><del>- WEBCORE_EXPORT virtual bool isUnderTest() override;
</del><ins>+ WEBCORE_EXPORT virtual bool isUnderTest() override final;
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT bool canAttachWindow();
</span><span class="cx"> WEBCORE_EXPORT void setDockingUnavailable(bool);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorIndexedDBAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -47,10 +47,10 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorIndexedDBAgent : public InspectorAgentBase, public Inspector::InspectorIndexedDBBackendDispatcherHandler {
</del><ins>+class InspectorIndexedDBAgent final : public InspectorAgentBase, public Inspector::InspectorIndexedDBBackendDispatcherHandler {
</ins><span class="cx"> public:
</span><span class="cx"> InspectorIndexedDBAgent(InstrumentingAgents*, Inspector::InjectedScriptManager*, InspectorPageAgent*);
</span><del>- ~InspectorIndexedDBAgent();
</del><ins>+ virtual ~InspectorIndexedDBAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorLayerTreeAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -46,11 +46,11 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorLayerTreeAgent : public InspectorAgentBase, public Inspector::InspectorLayerTreeBackendDispatcherHandler {
</del><ins>+class InspectorLayerTreeAgent final : public InspectorAgentBase, public Inspector::InspectorLayerTreeBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> explicit InspectorLayerTreeAgent(InstrumentingAgents*);
</span><del>- ~InspectorLayerTreeAgent();
</del><ins>+ virtual ~InspectorLayerTreeAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorPageAgent : public InspectorAgentBase, public Inspector::InspectorPageBackendDispatcherHandler {
</del><ins>+class InspectorPageAgent final : public InspectorAgentBase, public Inspector::InspectorPageBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorPageAgent);
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorReplayAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorReplayAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorReplayAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorReplayAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorReplayAgent);
</span><span class="cx"> public:
</span><span class="cx"> InspectorReplayAgent(InstrumentingAgents*, InspectorPageAgent*);
</span><del>- ~InspectorReplayAgent();
</del><ins>+ virtual ~InspectorReplayAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorResourceAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorResourceAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -75,11 +75,11 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorResourceAgent : public InspectorAgentBase, public Inspector::InspectorNetworkBackendDispatcherHandler {
</del><ins>+class InspectorResourceAgent final : public InspectorAgentBase, public Inspector::InspectorNetworkBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> InspectorResourceAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorClient*);
</span><del>- ~InspectorResourceAgent();
</del><ins>+ virtual ~InspectorResourceAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorStyleSheeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorStyleSheet.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -257,7 +257,7 @@
</span><span class="cx"> Listener* m_listener;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class InspectorStyleSheetForInlineStyle : public InspectorStyleSheet {
</del><ins>+class InspectorStyleSheetForInlineStyle final : public InspectorStyleSheet {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<InspectorStyleSheetForInlineStyle> create(InspectorPageAgent*, const String& id, PassRefPtr<Element>, Inspector::Protocol::CSS::StyleSheetOrigin, Listener*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx"> WebSocketDestroy
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class InspectorTimelineAgent
</del><ins>+class InspectorTimelineAgent final
</ins><span class="cx"> : public InspectorAgentBase
</span><span class="cx"> , public Inspector::InspectorTimelineBackendDispatcherHandler
</span><span class="cx"> , public Inspector::ScriptDebugListener {
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> enum InspectorType { PageInspector, WorkerInspector };
</span><span class="cx">
</span><span class="cx"> InspectorTimelineAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorType, InspectorClient*);
</span><del>- ~InspectorTimelineAgent();
</del><ins>+ virtual ~InspectorTimelineAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorWorkerAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorWorkerAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorWorkerAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/InspectorWorkerAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -48,11 +48,11 @@
</span><span class="cx">
</span><span class="cx"> typedef String ErrorString;
</span><span class="cx">
</span><del>-class InspectorWorkerAgent : public InspectorAgentBase, public Inspector::InspectorWorkerBackendDispatcherHandler {
</del><ins>+class InspectorWorkerAgent final : public InspectorAgentBase, public Inspector::InspectorWorkerBackendDispatcherHandler {
</ins><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> explicit InspectorWorkerAgent(InstrumentingAgents*);
</span><del>- ~InspectorWorkerAgent();
</del><ins>+ virtual ~InspectorWorkerAgent();
</ins><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorPageConsoleAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/PageConsoleAgent.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/PageConsoleAgent.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/PageConsoleAgent.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -46,9 +46,8 @@
</span><span class="cx"> PageConsoleAgent(WebInjectedScriptManager*, InspectorDOMAgent*);
</span><span class="cx"> virtual ~PageConsoleAgent() { }
</span><span class="cx">
</span><del>- virtual bool isWorkerAgent() const override { return false; }
-
</del><span class="cx"> private:
</span><ins>+ virtual bool isWorkerAgent() const override { return false; }
</ins><span class="cx"> virtual void clearMessages(ErrorString&) override;
</span><span class="cx"> virtual void addInspectedNode(ErrorString&, int nodeId) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerInspectorControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerInspectorController.h (175354 => 175355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerInspectorController.h 2014-10-29 23:18:36 UTC (rev 175354)
+++ trunk/Source/WebCore/inspector/WorkerInspectorController.h 2014-10-29 23:28:55 UTC (rev 175355)
</span><span class="lines">@@ -60,7 +60,7 @@
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> explicit WorkerInspectorController(WorkerGlobalScope&);
</span><del>- ~WorkerInspectorController();
</del><ins>+ virtual ~WorkerInspectorController();
</ins><span class="cx">
</span><span class="cx"> void connectFrontend();
</span><span class="cx"> void disconnectFrontend(Inspector::InspectorDisconnectReason);
</span></span></pre>
</div>
</div>
</body>
</html>