<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175357] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175357">175357</a></dd>
<dt>Author</dt> <dd>matthew_hanson@apple.com</dd>
<dt>Date</dt> <dd>2014-10-29 17:13:14 -0700 (Wed, 29 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
https://bugs.webkit.org/show_bug.cgi?id=138193
This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
It also does a bit of refactoring, including distinguishing between versions and version strings and
saving versions to local variables instead of using eval in each conditional.
Reviewed by David Kilzer.
* Scripts/bisect-builds:
(makeNightlyList):
Restrict the set of nightlies to <a href="http://trac.webkit.org/projects/webkit/changeset/174650">r174650</a> and above when running Yosemite.
Restrict the set of nightlies to <a href="http://trac.webkit.org/projects/webkit/changeset/157846">r157846</a> and above when running Mavericks.
Restrict the set of nightlies to <a href="http://trac.webkit.org/projects/webkit/changeset/122421">r122421</a> and above when running Mountain Lion.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsbisectbuilds">trunk/Tools/Scripts/bisect-builds</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (175356 => 175357)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-10-29 23:33:38 UTC (rev 175356)
+++ trunk/Tools/ChangeLog 2014-10-30 00:13:14 UTC (rev 175357)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-10-29 Matthew Hanson <matthew_hanson@apple.com>
+
+ bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
+ https://bugs.webkit.org/show_bug.cgi?id=138193
+
+ This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
+ for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
+
+ It also does a bit of refactoring, including distinguishing between versions and version strings and
+ saving versions to local variables instead of using eval in each conditional.
+
+ Reviewed by David Kilzer.
+
+ * Scripts/bisect-builds:
+ (makeNightlyList):
+ Restrict the set of nightlies to r174650 and above when running Yosemite.
+ Restrict the set of nightlies to r157846 and above when running Mavericks.
+ Restrict the set of nightlies to r122421 and above when running Mountain Lion.
+
</ins><span class="cx"> 2014-10-29 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> [EFL] build-webkit should try harder to avoid re-running cmake
</span></span></pre></div>
<a id="trunkToolsScriptsbisectbuilds"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/bisect-builds (175356 => 175357)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/bisect-builds 2014-10-29 23:33:38 UTC (rev 175356)
+++ trunk/Tools/Scripts/bisect-builds 2014-10-30 00:13:14 UTC (rev 175357)
</span><span class="lines">@@ -312,7 +312,7 @@
</span><span class="cx">
</span><span class="cx"> sub makeNightlyList($$$$)
</span><span class="cx"> {
</span><del>- my ($useLocalFiles, $localDirectory, $macOSXVersion, $safariVersion) = @_;
</del><ins>+ my ($useLocalFiles, $localDirectory, $osxVersionString, $safariVersionString) = @_;
</ins><span class="cx"> my @files;
</span><span class="cx">
</span><span class="cx"> if ($useLocalFiles) {
</span><span class="lines">@@ -335,36 +335,49 @@
</span><span class="cx"> close(NIGHTLIES);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (eval "v$macOSXVersion" ge v10.5) {
- if ($safariVersion eq "4 Public Beta") {
</del><ins>+ my $osxVersion = eval("v$osxVersionString");
+ my $safariVersion = eval("v$safariVersionString");
+
+ if ($osxVersion ge v10.10 && $osxVersion lt v10.11) {
+ @files = grep { $_->{rev} >= 174650 } @files;
+ } elsif ($osxVersion ge v10.9 && $osxVersion lt v10.10) {
+ @files = grep { $_->{rev} >= 157846 } @files;
+ } elsif ($osxVersion ge v10.8 && $osxVersion lt v10.9) {
+ @files = grep { $_->{rev} >= 122421 } @files;
+ } elsif ($osxVersion ge v10.7 && $osxVersion lt v10.8) {
+ # FIXME: Add filter for 10.7.x
+ } elsif ($osxVersion ge v10.6 && $osxVersion lt v10.7) {
+ # FIXME: Add filter for 10.6.x
+ } elsif ($osxVersion ge v10.5 && $osxVersion lt v10.6) {
+ if ($safariVersionString eq "4 Public Beta") {
</ins><span class="cx"> @files = grep { $_->{rev} >= 39682 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v3.2) {
</del><ins>+ } elsif ($safariVersion ge v3.2) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 37348 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v3.1) {
</del><ins>+ } elsif ($safariVersion ge v3.1) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 29711 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v3.0) {
</del><ins>+ } elsif ($safariVersion ge v3.0) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 25124 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v2.0) {
</del><ins>+ } elsif ($safariVersion ge v2.0) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 19594 } @files;
</span><span class="cx"> } else {
</span><span class="cx"> die "Requires Safari 2.0 or newer";
</span><span class="cx"> }
</span><del>- } elsif (eval "v$macOSXVersion" ge v10.4) {
</del><ins>+ } elsif ($osxVersion ge v10.4 && $osxVersion lt v10.5) {
</ins><span class="cx"> if ($safariVersion eq "4 Public Beta") {
</span><span class="cx"> @files = grep { $_->{rev} >= 39682 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v3.2) {
</del><ins>+ } elsif ($safariVersion ge v3.2) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 37348 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v3.1) {
</del><ins>+ } elsif ($safariVersion ge v3.1) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 29711 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v3.0) {
</del><ins>+ } elsif ($safariVersion ge v3.0) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 19992 } @files;
</span><del>- } elsif (eval "v$safariVersion" ge v2.0) {
</del><ins>+ } elsif ($safariVersion ge v2.0) {
</ins><span class="cx"> @files = grep { $_->{rev} >= 11976 } @files;
</span><span class="cx"> } else {
</span><span class="cx"> die "Requires Safari 2.0 or newer";
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- die "Requires Mac OS X 10.4 (Tiger) or 10.5 (Leopard)";
</del><ins>+ die "Requires Mac OS X 10.4 (Tiger) or later";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> my $nightlycmp = sub { return $a->{rev} <=> $b->{rev}; };
</span></span></pre>
</div>
</div>
</body>
</html>