<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175278] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175278">175278</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-10-28 15:42:37 -0700 (Tue, 28 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up virtual functions in accessibility/
https://bugs.webkit.org/show_bug.cgi?id=138148
Reviewed by Chris Fleizach.
Clean up virtual functions in accessibility/ by:
- Marking classes as final when suitable
- Marking virtual functions as final when suitable
- Dropping final on virtual functions in classes that are already final
- Make isXXX() virtual type checking functions in XXX classes to avoid
useless type checks
No new tests, no behavior change.
* accessibility/AccessibilityARIAGrid.h:
* accessibility/AccessibilityARIAGridCell.h:
* accessibility/AccessibilityARIAGridRow.h:
* accessibility/AccessibilityImageMapLink.h:
* accessibility/AccessibilityList.h:
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityMediaControls.h:
* accessibility/AccessibilityMenuList.h:
* accessibility/AccessibilityMenuListOption.h:
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityMockObject.h:
(WebCore::AccessibilityMockObject::setParent):
* accessibility/AccessibilityNodeObject.h:
* accessibility/AccessibilityProgressIndicator.h:
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySVGRoot.h:
* accessibility/AccessibilityScrollView.h:
* accessibility/AccessibilityScrollbar.h:
* accessibility/AccessibilitySearchFieldButtons.h:
* accessibility/AccessibilitySlider.h:
* accessibility/AccessibilitySpinButton.h:
* accessibility/AccessibilityTable.h:
* accessibility/AccessibilityTableCell.h:
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableHeaderContainer.h:
* accessibility/AccessibilityTableRow.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityARIAGridh">trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityARIAGridCellh">trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityARIAGridRowh">trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityImageMapLinkh">trunk/Source/WebCore/accessibility/AccessibilityImageMapLink.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListh">trunk/Source/WebCore/accessibility/AccessibilityList.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListBoxh">trunk/Source/WebCore/accessibility/AccessibilityListBox.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListBoxOptionh">trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMediaControlsh">trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMenuListh">trunk/Source/WebCore/accessibility/AccessibilityMenuList.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMenuListOptionh">trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMenuListPopuph">trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMockObjecth">trunk/Source/WebCore/accessibility/AccessibilityMockObject.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjecth">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityProgressIndicatorh">trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjecth">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilitySVGRooth">trunk/Source/WebCore/accessibility/AccessibilitySVGRoot.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityScrollViewh">trunk/Source/WebCore/accessibility/AccessibilityScrollView.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityScrollbarh">trunk/Source/WebCore/accessibility/AccessibilityScrollbar.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilitySearchFieldButtonsh">trunk/Source/WebCore/accessibility/AccessibilitySearchFieldButtons.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilitySliderh">trunk/Source/WebCore/accessibility/AccessibilitySlider.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilitySpinButtonh">trunk/Source/WebCore/accessibility/AccessibilitySpinButton.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableh">trunk/Source/WebCore/accessibility/AccessibilityTable.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableCellh">trunk/Source/WebCore/accessibility/AccessibilityTableCell.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableColumnh">trunk/Source/WebCore/accessibility/AccessibilityTableColumn.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableHeaderContainerh">trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableRowh">trunk/Source/WebCore/accessibility/AccessibilityTableRow.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/ChangeLog 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -1,3 +1,47 @@
</span><ins>+2014-10-28 Chris Dumez <cdumez@apple.com>
+
+ Clean up virtual functions in accessibility/
+ https://bugs.webkit.org/show_bug.cgi?id=138148
+
+ Reviewed by Chris Fleizach.
+
+ Clean up virtual functions in accessibility/ by:
+ - Marking classes as final when suitable
+ - Marking virtual functions as final when suitable
+ - Dropping final on virtual functions in classes that are already final
+ - Make isXXX() virtual type checking functions in XXX classes to avoid
+ useless type checks
+
+ No new tests, no behavior change.
+
+ * accessibility/AccessibilityARIAGrid.h:
+ * accessibility/AccessibilityARIAGridCell.h:
+ * accessibility/AccessibilityARIAGridRow.h:
+ * accessibility/AccessibilityImageMapLink.h:
+ * accessibility/AccessibilityList.h:
+ * accessibility/AccessibilityListBox.h:
+ * accessibility/AccessibilityListBoxOption.h:
+ * accessibility/AccessibilityMediaControls.h:
+ * accessibility/AccessibilityMenuList.h:
+ * accessibility/AccessibilityMenuListOption.h:
+ * accessibility/AccessibilityMenuListPopup.h:
+ * accessibility/AccessibilityMockObject.h:
+ (WebCore::AccessibilityMockObject::setParent):
+ * accessibility/AccessibilityNodeObject.h:
+ * accessibility/AccessibilityProgressIndicator.h:
+ * accessibility/AccessibilityRenderObject.h:
+ * accessibility/AccessibilitySVGRoot.h:
+ * accessibility/AccessibilityScrollView.h:
+ * accessibility/AccessibilityScrollbar.h:
+ * accessibility/AccessibilitySearchFieldButtons.h:
+ * accessibility/AccessibilitySlider.h:
+ * accessibility/AccessibilitySpinButton.h:
+ * accessibility/AccessibilityTable.h:
+ * accessibility/AccessibilityTableCell.h:
+ * accessibility/AccessibilityTableColumn.h:
+ * accessibility/AccessibilityTableHeaderContainer.h:
+ * accessibility/AccessibilityTableRow.h:
+
</ins><span class="cx"> 2014-10-24 Jeffrey Pfau <jpfau@apple.com>
</span><span class="cx">
</span><span class="cx"> FrameProgressTracker expects Page to not have detached
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityARIAGridh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -37,23 +37,21 @@
</span><span class="cx"> class AccessibilityTableCell;
</span><span class="cx"> class AccessibilityTableHeaderContainer;
</span><span class="cx">
</span><del>-class AccessibilityARIAGrid : public AccessibilityTable {
-
-private:
- explicit AccessibilityARIAGrid(RenderObject*);
</del><ins>+class AccessibilityARIAGrid final : public AccessibilityTable {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityARIAGrid> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityARIAGrid();
</span><del>-
- virtual bool isAriaTable() const override { return true; }
</del><span class="cx">
</span><span class="cx"> virtual void addChildren() override;
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ explicit AccessibilityARIAGrid(RenderObject*);
+
</ins><span class="cx"> // ARIA treegrids and grids support selected rows.
</span><span class="cx"> virtual bool supportsSelectedRows() override { return true; }
</span><span class="cx"> virtual bool isMultiSelectable() const override { return true; }
</span><span class="cx"> virtual bool computeIsTableExposableThroughAccessibility() const override { return true; }
</span><ins>+ virtual bool isAriaTable() const override { return true; }
</ins><span class="cx">
</span><span class="cx"> void addRowDescendant(AccessibilityObject*, HashSet<AccessibilityObject*>& appendedRows, unsigned& columnCount);
</span><span class="cx"> bool addTableCellChild(AccessibilityObject*, HashSet<AccessibilityObject*>& appendedRows, unsigned& columnCount);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityARIAGridCellh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGridCell.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -33,10 +33,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class AccessibilityARIAGridCell : public AccessibilityTableCell {
-
-private:
- explicit AccessibilityARIAGridCell(RenderObject*);
</del><ins>+class AccessibilityARIAGridCell final : public AccessibilityTableCell {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityARIAGridCell> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityARIAGridCell();
</span><span class="lines">@@ -46,7 +43,9 @@
</span><span class="cx"> // fills in the start location and column span of cell
</span><span class="cx"> virtual void columnIndexRange(std::pair<unsigned, unsigned>& columnRange) const override;
</span><span class="cx">
</span><del>-protected:
</del><ins>+private:
+ explicit AccessibilityARIAGridCell(RenderObject*);
+
</ins><span class="cx"> virtual AccessibilityTable* parentTable() const override;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityARIAGridRowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -35,10 +35,7 @@
</span><span class="cx">
</span><span class="cx"> class AccessibilityTable;
</span><span class="cx">
</span><del>-class AccessibilityARIAGridRow : public AccessibilityTableRow {
-
-private:
- explicit AccessibilityARIAGridRow(RenderObject*);
</del><ins>+class AccessibilityARIAGridRow final : public AccessibilityTableRow {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityARIAGridRow> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityARIAGridRow();
</span><span class="lines">@@ -49,6 +46,8 @@
</span><span class="cx"> virtual AccessibilityObject* headerObject() override;
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ explicit AccessibilityARIAGridRow(RenderObject*);
+
</ins><span class="cx"> virtual bool isARIATreeGridRow() const override;
</span><span class="cx"> virtual AccessibilityTable* parentTable() const override;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityImageMapLinkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityImageMapLink.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityImageMapLink.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityImageMapLink.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -35,10 +35,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class AccessibilityImageMapLink : public AccessibilityMockObject {
-
-private:
- AccessibilityImageMapLink();
</del><ins>+class AccessibilityImageMapLink final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityImageMapLink> create();
</span><span class="cx"> virtual ~AccessibilityImageMapLink();
</span><span class="lines">@@ -68,17 +65,18 @@
</span><span class="cx">
</span><span class="cx"> virtual LayoutRect elementRect() const override;
</span><span class="cx">
</span><del>-private:
- RefPtr<HTMLAreaElement> m_areaElement;
- RefPtr<HTMLMapElement> m_mapElement;
</del><ins>+private:
+ AccessibilityImageMapLink();
</ins><span class="cx">
</span><span class="cx"> virtual void detachFromParent() override;
</span><del>-
</del><span class="cx"> virtual Path elementPath() const override;
</span><span class="cx"> RenderElement* imageMapLinkRenderer() const;
</span><span class="cx"> virtual void accessibilityText(Vector<AccessibilityText>&) override;
</span><span class="cx"> virtual bool isImageMapLink() const override { return true; }
</span><span class="cx"> virtual bool supportsPath() const override { return true; }
</span><ins>+
+ RefPtr<HTMLAreaElement> m_areaElement;
+ RefPtr<HTMLMapElement> m_mapElement;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityList.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -33,21 +33,20 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class AccessibilityList : public AccessibilityRenderObject {
-
-private:
- explicit AccessibilityList(RenderObject*);
</del><ins>+class AccessibilityList final : public AccessibilityRenderObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityList> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityList();
</span><span class="cx">
</span><del>- virtual bool isList() const override { return true; }
</del><span class="cx"> bool isUnorderedList() const;
</span><span class="cx"> bool isOrderedList() const;
</span><span class="cx"> bool isDescriptionList() const;
</span><span class="cx">
</span><del>- virtual AccessibilityRole roleValue() const override final;
</del><ins>+ virtual AccessibilityRole roleValue() const override;
+
</ins><span class="cx"> private:
</span><ins>+ explicit AccessibilityList(RenderObject*);
+ virtual bool isList() const override { return true; }
</ins><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><span class="cx"> virtual AccessibilityRole determineAccessibilityRole() override;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityListBox.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityListBox.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityListBox.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -33,16 +33,11 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class AccessibilityListBox : public AccessibilityRenderObject {
-
-private:
- explicit AccessibilityListBox(RenderObject*);
</del><ins>+class AccessibilityListBox final : public AccessibilityRenderObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityListBox> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityListBox();
</span><span class="cx">
</span><del>- virtual bool isListBox() const override { return true; }
-
</del><span class="cx"> virtual bool canSetSelectedChildrenAttribute() const override;
</span><span class="cx"> void setSelectedChildren(const AccessibilityChildrenVector&);
</span><span class="cx"> virtual AccessibilityRole roleValue() const override { return ListBoxRole; }
</span><span class="lines">@@ -52,7 +47,10 @@
</span><span class="cx">
</span><span class="cx"> virtual void addChildren() override;
</span><span class="cx">
</span><del>-private:
</del><ins>+private:
+ explicit AccessibilityListBox(RenderObject*);
+
+ virtual bool isListBox() const override { return true; }
</ins><span class="cx"> AccessibilityObject* listBoxOptionAccessibilityObject(HTMLElement*) const;
</span><span class="cx"> virtual AccessibilityObject* elementAccessibilityHitTest(const IntPoint&) const override;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListBoxOptionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -40,10 +40,7 @@
</span><span class="cx"> class HTMLElement;
</span><span class="cx"> class HTMLSelectElement;
</span><span class="cx">
</span><del>-class AccessibilityListBoxOption : public AccessibilityObject {
-
-private:
- AccessibilityListBoxOption();
</del><ins>+class AccessibilityListBoxOption final : public AccessibilityObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityListBoxOption> create();
</span><span class="cx"> virtual ~AccessibilityListBoxOption();
</span><span class="lines">@@ -62,17 +59,19 @@
</span><span class="cx">
</span><span class="cx"> virtual LayoutRect elementRect() const override;
</span><span class="cx"> virtual AccessibilityObject* parentObject() const override;
</span><del>- virtual bool isListBoxOption() const override final { return true; }
</del><span class="cx">
</span><span class="cx"> private:
</span><del>- HTMLElement* m_optionElement;
-
</del><ins>+ AccessibilityListBoxOption();
+
+ virtual bool isListBoxOption() const override { return true; }
</ins><span class="cx"> virtual bool canHaveChildren() const override { return false; }
</span><span class="cx"> HTMLSelectElement* listBoxOptionParentNode() const;
</span><span class="cx"> int listBoxOptionIndex() const;
</span><span class="cx"> IntRect listBoxOptionRect() const;
</span><span class="cx"> AccessibilityObject* listBoxOptionAccessibilityObject(HTMLElement*) const;
</span><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><ins>+
+ HTMLElement* m_optionElement;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMediaControlsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -60,24 +60,24 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx">
</span><del>-class AccessibilityMediaTimeline : public AccessibilitySlider {
</del><ins>+class AccessibilityMediaTimeline final : public AccessibilitySlider {
</ins><span class="cx">
</span><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityObject> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityMediaTimeline() { }
</span><span class="cx">
</span><del>- virtual bool isMediaTimeline() const override { return true; }
-
</del><span class="cx"> virtual String helpText() const override;
</span><span class="cx"> virtual String valueDescription() const override;
</span><span class="cx"> const AtomicString& getAttribute(const QualifiedName& attribute) const;
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> explicit AccessibilityMediaTimeline(RenderObject*);
</span><ins>+
+ virtual bool isMediaTimeline() const override { return true; }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx">
</span><del>-class AccessibilityMediaControlsContainer : public AccessibilityMediaControl {
</del><ins>+class AccessibilityMediaControlsContainer final : public AccessibilityMediaControl {
</ins><span class="cx">
</span><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityObject> create(RenderObject*);
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx">
</span><del>-class AccessibilityMediaTimeDisplay : public AccessibilityMediaControl {
</del><ins>+class AccessibilityMediaTimeDisplay final : public AccessibilityMediaControl {
</ins><span class="cx">
</span><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityObject> create(RenderObject*);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMenuListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuList.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMenuList.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuList.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> class HTMLOptionElement;
</span><span class="cx"> class RenderMenuList;
</span><span class="cx">
</span><del>-class AccessibilityMenuList : public AccessibilityRenderObject {
</del><ins>+class AccessibilityMenuList final : public AccessibilityRenderObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityMenuList> create(RenderMenuList* renderer);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMenuListOptionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx"> class AccessibilityMenuListPopup;
</span><span class="cx"> class HTMLElement;
</span><span class="cx">
</span><del>-class AccessibilityMenuListOption : public AccessibilityMockObject {
</del><ins>+class AccessibilityMenuListOption final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityMenuListOption> create() { return adoptRef(new AccessibilityMenuListOption); }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMenuListPopuph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> class HTMLElement;
</span><span class="cx"> class HTMLSelectElement;
</span><span class="cx">
</span><del>-class AccessibilityMenuListPopup : public AccessibilityMockObject {
</del><ins>+class AccessibilityMenuListPopup final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityMenuListPopup> create() { return adoptRef(new AccessibilityMenuListPopup); }
</span><span class="cx">
</span><span class="lines">@@ -44,7 +44,6 @@
</span><span class="cx">
</span><span class="cx"> void didUpdateActiveOption(int optionIndex);
</span><span class="cx">
</span><del>-
</del><span class="cx"> private:
</span><span class="cx"> AccessibilityMenuListPopup();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMockObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMockObject.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMockObject.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityMockObject.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> virtual ~AccessibilityMockObject();
</span><span class="cx">
</span><span class="cx"> virtual AccessibilityObject* parentObject() const override { return m_parent; }
</span><del>- virtual void setParent(AccessibilityObject* parent) { m_parent = parent; };
</del><ins>+ virtual void setParent(AccessibilityObject* parent) { m_parent = parent; }
</ins><span class="cx"> virtual bool isEnabled() const override { return true; }
</span><span class="cx">
</span><span class="cx"> protected:
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> virtual void detachFromParent() override { m_parent = nullptr; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual bool isMockObject() const override { return true; }
</del><ins>+ virtual bool isMockObject() const override final { return true; }
</ins><span class="cx">
</span><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -61,15 +61,11 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> class AccessibilityNodeObject : public AccessibilityObject {
</span><del>-protected:
- explicit AccessibilityNodeObject(Node*);
</del><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityNodeObject> create(Node*);
</span><span class="cx"> virtual ~AccessibilityNodeObject();
</span><span class="cx">
</span><span class="cx"> virtual void init() override;
</span><del>-
- virtual bool isAccessibilityNodeObject() const override { return true; }
</del><span class="cx">
</span><span class="cx"> virtual bool canvasHasFallbackContent() const override;
</span><span class="cx">
</span><span class="lines">@@ -158,6 +154,8 @@
</span><span class="cx"> virtual LayoutRect elementRect() const override;
</span><span class="cx">
</span><span class="cx"> protected:
</span><ins>+ explicit AccessibilityNodeObject(Node*);
+
</ins><span class="cx"> AccessibilityRole m_ariaRole;
</span><span class="cx"> bool m_childrenDirty;
</span><span class="cx"> mutable AccessibilityRole m_roleForMSAA;
</span><span class="lines">@@ -193,8 +191,7 @@
</span><span class="cx"> AccessibilityObject* menuButtonForMenu() const;
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- Node* m_node;
-
</del><ins>+ virtual bool isAccessibilityNodeObject() const override final { return true; }
</ins><span class="cx"> virtual void accessibilityText(Vector<AccessibilityText>&) override;
</span><span class="cx"> virtual void titleElementText(Vector<AccessibilityText>&) const;
</span><span class="cx"> void alternativeText(Vector<AccessibilityText>&) const;
</span><span class="lines">@@ -204,6 +201,8 @@
</span><span class="cx"> void ariaLabeledByText(Vector<AccessibilityText>&) const;
</span><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><span class="cx"> bool usesAltTagForTextComputation() const;
</span><ins>+
+ Node* m_node;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityProgressIndicatorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx"> class HTMLProgressElement;
</span><span class="cx"> class RenderProgress;
</span><span class="cx">
</span><del>-class AccessibilityProgressIndicator : public AccessibilityRenderObject {
</del><ins>+class AccessibilityProgressIndicator final : public AccessibilityRenderObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityProgressIndicator> create(RenderProgress*);
</span><span class="cx"> #if ENABLE(METER_ELEMENT)
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -57,13 +57,9 @@
</span><span class="cx"> class Widget;
</span><span class="cx">
</span><span class="cx"> class AccessibilityRenderObject : public AccessibilityNodeObject {
</span><del>-protected:
- explicit AccessibilityRenderObject(RenderObject*);
</del><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityRenderObject> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityRenderObject();
</span><del>-
- virtual bool isAccessibilityRenderObject() const override { return true; }
</del><span class="cx">
</span><span class="cx"> virtual void init() override;
</span><span class="cx">
</span><span class="lines">@@ -214,8 +210,7 @@
</span><span class="cx"> virtual String passwordFieldValue() const override;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- RenderObject* m_renderer;
-
</del><ins>+ explicit AccessibilityRenderObject(RenderObject*);
</ins><span class="cx"> void setRenderObject(RenderObject* renderer) { m_renderer = renderer; }
</span><span class="cx"> void ariaElementsFromAttribute(AccessibilityChildrenVector&, const QualifiedName&) const;
</span><span class="cx"> bool needsToUpdateChildren() const { return m_childrenDirty; }
</span><span class="lines">@@ -227,7 +222,10 @@
</span><span class="cx"> virtual AccessibilityRole determineAccessibilityRole() override;
</span><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><span class="cx">
</span><ins>+ RenderObject* m_renderer;
+
</ins><span class="cx"> private:
</span><ins>+ virtual bool isAccessibilityRenderObject() const override final { return true; }
</ins><span class="cx"> void ariaListboxSelectedChildren(AccessibilityChildrenVector&);
</span><span class="cx"> void ariaListboxVisibleChildren(AccessibilityChildrenVector&);
</span><span class="cx"> bool isAllowedChildOfTree() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilitySVGRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilitySVGRoot.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilitySVGRoot.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilitySVGRoot.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -33,21 +33,20 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class AccessibilitySVGRoot : public AccessibilityRenderObject {
-
-protected:
- explicit AccessibilitySVGRoot(RenderObject*);
</del><ins>+class AccessibilitySVGRoot final : public AccessibilityRenderObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilitySVGRoot> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilitySVGRoot();
</span><span class="cx">
</span><span class="cx"> void setParent(AccessibilityObject* parent) { m_parent = parent; }
</span><del>-
</del><ins>+
</ins><span class="cx"> private:
</span><del>- AccessibilityObject* m_parent;
</del><ins>+ explicit AccessibilitySVGRoot(RenderObject*);
</ins><span class="cx">
</span><span class="cx"> virtual AccessibilityObject* parentObject() const override;
</span><span class="cx"> virtual bool isAccessibilitySVGRoot() const override { return true; }
</span><ins>+
+ AccessibilityObject* m_parent;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityScrollViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityScrollView.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityScrollView.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityScrollView.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> class Scrollbar;
</span><span class="cx"> class ScrollView;
</span><span class="cx">
</span><del>-class AccessibilityScrollView : public AccessibilityObject {
</del><ins>+class AccessibilityScrollView final : public AccessibilityObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityScrollView> create(ScrollView*);
</span><span class="cx"> virtual AccessibilityRole roleValue() const override { return ScrollAreaRole; }
</span><span class="lines">@@ -43,13 +43,11 @@
</span><span class="cx"> virtual ~AccessibilityScrollView();
</span><span class="cx"> virtual void detach(AccessibilityDetachmentType, AXObjectCache*) override;
</span><span class="cx">
</span><del>-protected:
- virtual ScrollableArea* getScrollableAreaIfScrollable() const override;
- virtual void scrollTo(const IntPoint&) const override;
-
</del><span class="cx"> private:
</span><span class="cx"> explicit AccessibilityScrollView(ScrollView*);
</span><span class="cx">
</span><ins>+ virtual ScrollableArea* getScrollableAreaIfScrollable() const override;
+ virtual void scrollTo(const IntPoint&) const override;
</ins><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><span class="cx"> virtual bool isAccessibilityScrollView() const override { return true; }
</span><span class="cx"> virtual bool isEnabled() const override { return true; }
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityScrollbarh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityScrollbar.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityScrollbar.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityScrollbar.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx">
</span><span class="cx"> class Scrollbar;
</span><span class="cx">
</span><del>-class AccessibilityScrollbar : public AccessibilityMockObject {
</del><ins>+class AccessibilityScrollbar final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityScrollbar> create(Scrollbar*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilitySearchFieldButtonsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilitySearchFieldButtons.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilitySearchFieldButtons.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilitySearchFieldButtons.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -39,11 +39,10 @@
</span><span class="cx"> virtual bool press() override;
</span><span class="cx"> virtual AccessibilityRole roleValue() const override { return ButtonRole; }
</span><span class="cx">
</span><del>-protected:
- virtual bool computeAccessibilityIsIgnored() const override;
-
</del><span class="cx"> private:
</span><span class="cx"> explicit AccessibilitySearchFieldCancelButton(RenderObject*);
</span><ins>+
+ virtual bool computeAccessibilityIsIgnored() const override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilitySliderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilitySlider.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilitySlider.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilitySlider.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -37,7 +37,6 @@
</span><span class="cx"> class HTMLInputElement;
</span><span class="cx">
</span><span class="cx"> class AccessibilitySlider : public AccessibilityRenderObject {
</span><del>-
</del><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilitySlider> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilitySlider() { }
</span><span class="lines">@@ -50,7 +49,7 @@
</span><span class="cx"> virtual AccessibilityObject* elementAccessibilityHitTest(const IntPoint&) const override;
</span><span class="cx">
</span><span class="cx"> virtual AccessibilityRole roleValue() const override { return SliderRole; }
</span><del>- virtual bool isSlider() const override { return true; }
</del><ins>+ virtual bool isSlider() const override final { return true; }
</ins><span class="cx"> virtual bool isInputSlider() const override { return true; }
</span><span class="cx"> virtual bool isControl() const override { return true; }
</span><span class="cx">
</span><span class="lines">@@ -66,21 +65,18 @@
</span><span class="cx"> virtual AccessibilityOrientation orientation() const override;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class AccessibilitySliderThumb : public AccessibilityMockObject {
-
</del><ins>+class AccessibilitySliderThumb final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilitySliderThumb> create();
</span><span class="cx"> virtual ~AccessibilitySliderThumb() { }
</span><span class="cx">
</span><del>- virtual bool isSliderThumb() const override final { return true; }
-
</del><span class="cx"> virtual AccessibilityRole roleValue() const override { return SliderThumbRole; }
</span><del>-
</del><span class="cx"> virtual LayoutRect elementRect() const override;
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> AccessibilitySliderThumb();
</span><span class="cx">
</span><ins>+ virtual bool isSliderThumb() const override { return true; }
</ins><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilitySpinButtonh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilitySpinButton.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilitySpinButton.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilitySpinButton.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class AccessibilitySpinButton : public AccessibilityMockObject {
</del><ins>+class AccessibilitySpinButton final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilitySpinButton> create();
</span><span class="cx"> virtual ~AccessibilitySpinButton();
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> SpinButtonElement* m_spinButtonElement;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class AccessibilitySpinButtonPart : public AccessibilityMockObject {
</del><ins>+class AccessibilitySpinButtonPart final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilitySpinButtonPart> create();
</span><span class="cx"> virtual ~AccessibilitySpinButtonPart() { }
</span><span class="lines">@@ -66,12 +66,13 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> AccessibilitySpinButtonPart();
</span><del>- bool m_isIncrementor : 1;
</del><span class="cx">
</span><span class="cx"> virtual bool press() override;
</span><span class="cx"> virtual AccessibilityRole roleValue() const override { return ButtonRole; }
</span><span class="cx"> virtual bool isSpinButtonPart() const override { return true; }
</span><span class="cx"> virtual LayoutRect elementRect() const override;
</span><ins>+
+ unsigned m_isIncrementor : 1;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTable.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -39,20 +39,17 @@
</span><span class="cx"> class RenderTableSection;
</span><span class="cx">
</span><span class="cx"> class AccessibilityTable : public AccessibilityRenderObject {
</span><del>-
-protected:
- explicit AccessibilityTable(RenderObject*);
</del><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityTable> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityTable();
</span><span class="cx">
</span><del>- virtual void init() override;
</del><ins>+ virtual void init() override final;
</ins><span class="cx">
</span><del>- virtual AccessibilityRole roleValue() const override;
</del><ins>+ virtual AccessibilityRole roleValue() const override final;
</ins><span class="cx"> virtual bool isAriaTable() const { return false; }
</span><span class="cx">
</span><span class="cx"> virtual void addChildren() override;
</span><del>- virtual void clearChildren() override;
</del><ins>+ virtual void clearChildren() override final;
</ins><span class="cx">
</span><span class="cx"> const AccessibilityChildrenVector& columns();
</span><span class="cx"> const AccessibilityChildrenVector& rows();
</span><span class="lines">@@ -62,7 +59,7 @@
</span><span class="cx"> unsigned rowCount();
</span><span class="cx"> virtual int tableLevel() const override final;
</span><span class="cx">
</span><del>- virtual String title() const override;
</del><ins>+ virtual String title() const override final;
</ins><span class="cx">
</span><span class="cx"> // all the cells in the table
</span><span class="cx"> void cells(AccessibilityChildrenVector&);
</span><span class="lines">@@ -79,6 +76,8 @@
</span><span class="cx"> bool isExposableThroughAccessibility() const;
</span><span class="cx">
</span><span class="cx"> protected:
</span><ins>+ explicit AccessibilityTable(RenderObject*);
+
</ins><span class="cx"> AccessibilityChildrenVector m_rows;
</span><span class="cx"> AccessibilityChildrenVector m_columns;
</span><span class="cx">
</span><span class="lines">@@ -88,15 +87,15 @@
</span><span class="cx"> bool hasARIARole() const;
</span><span class="cx">
</span><span class="cx"> // isTable is whether it's an AccessibilityTable object.
</span><del>- virtual bool isTable() const override { return true; }
</del><ins>+ virtual bool isTable() const override final { return true; }
</ins><span class="cx"> // isDataTable is whether it is exposed as an AccessibilityTable because the heuristic
</span><span class="cx"> // think this "looks" like a data-based table (instead of a table used for layout).
</span><del>- virtual bool isDataTable() const override;
- virtual bool computeAccessibilityIsIgnored() const override;
</del><ins>+ virtual bool isDataTable() const override final;
+ virtual bool computeAccessibilityIsIgnored() const override final;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual bool computeIsTableExposableThroughAccessibility() const;
</span><del>- virtual void titleElementText(Vector<AccessibilityText>&) const override;
</del><ins>+ virtual void titleElementText(Vector<AccessibilityText>&) const override final;
</ins><span class="cx"> HTMLTableElement* tableElement() const;
</span><span class="cx"> void addChildrenFromSection(RenderTableSection*, unsigned& maxColumnCount);
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableCellh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableCell.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableCell.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableCell.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -36,14 +36,11 @@
</span><span class="cx"> class AccessibilityTable;
</span><span class="cx">
</span><span class="cx"> class AccessibilityTableCell : public AccessibilityRenderObject {
</span><del>-
-protected:
- explicit AccessibilityTableCell(RenderObject*);
</del><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityTableCell> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityTableCell();
</span><span class="cx">
</span><del>- virtual bool isTableCell() const override;
</del><ins>+ virtual bool isTableCell() const override final;
</ins><span class="cx"> bool isTableHeaderCell() const;
</span><span class="cx"> bool isColumnHeaderCell() const;
</span><span class="cx"> bool isRowHeaderCell() const;
</span><span class="lines">@@ -57,17 +54,20 @@
</span><span class="cx"> void rowHeaders(AccessibilityChildrenVector&);
</span><span class="cx">
</span><span class="cx"> protected:
</span><ins>+ explicit AccessibilityTableCell(RenderObject*);
+
</ins><span class="cx"> virtual AccessibilityTable* parentTable() const;
</span><ins>+ virtual AccessibilityRole determineAccessibilityRole() override final;
+
</ins><span class="cx"> int m_rowIndex;
</span><del>- virtual AccessibilityRole determineAccessibilityRole() override;
</del><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> // If a table cell is not exposed as a table cell, a TH element can serve as its title UI element.
</span><del>- virtual AccessibilityObject* titleUIElement() const override;
- virtual bool exposesTitleUIElement() const override { return true; }
- virtual bool computeAccessibilityIsIgnored() const override;
- virtual String expandedTextValue() const;
- virtual bool supportsExpandedTextValue() const;
</del><ins>+ virtual AccessibilityObject* titleUIElement() const override final;
+ virtual bool exposesTitleUIElement() const override final { return true; }
+ virtual bool computeAccessibilityIsIgnored() const override final;
+ virtual String expandedTextValue() const override final;
+ virtual bool supportsExpandedTextValue() const override final;
</ins><span class="cx">
</span><span class="cx"> bool isTableCellInSameRowGroup(AccessibilityTableCell*);
</span><span class="cx"> bool isTableCellInSameColGroup(AccessibilityTableCell*);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableColumnh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableColumn.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableColumn.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableColumn.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -37,10 +37,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderTableSection;
</span><span class="cx">
</span><del>-class AccessibilityTableColumn : public AccessibilityMockObject {
-
-private:
- AccessibilityTableColumn();
</del><ins>+class AccessibilityTableColumn final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityTableColumn> create();
</span><span class="cx"> virtual ~AccessibilityTableColumn();
</span><span class="lines">@@ -48,7 +45,6 @@
</span><span class="cx"> AccessibilityObject* headerObject();
</span><span class="cx">
</span><span class="cx"> virtual AccessibilityRole roleValue() const override { return ColumnRole; }
</span><del>- virtual bool isTableColumn() const override { return true; }
</del><span class="cx">
</span><span class="cx"> void setColumnIndex(int columnIndex) { m_columnIndex = columnIndex; }
</span><span class="cx"> int columnIndex() const { return m_columnIndex; }
</span><span class="lines">@@ -58,12 +54,15 @@
</span><span class="cx">
</span><span class="cx"> virtual LayoutRect elementRect() const override;
</span><span class="cx">
</span><del>-private:
- unsigned m_columnIndex;
- LayoutRect m_columnRect;
</del><ins>+private:
+ AccessibilityTableColumn();
</ins><span class="cx">
</span><span class="cx"> AccessibilityObject* headerObjectForSection(RenderTableSection*, bool thTagRequired);
</span><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><ins>+ virtual bool isTableColumn() const override { return true; }
+
+ unsigned m_columnIndex;
+ LayoutRect m_columnRect;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableHeaderContainerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -35,10 +35,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class AccessibilityTableHeaderContainer : public AccessibilityMockObject {
-
-private:
- AccessibilityTableHeaderContainer();
</del><ins>+class AccessibilityTableHeaderContainer final : public AccessibilityMockObject {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityTableHeaderContainer> create();
</span><span class="cx"> virtual ~AccessibilityTableHeaderContainer();
</span><span class="lines">@@ -50,9 +47,11 @@
</span><span class="cx"> virtual LayoutRect elementRect() const override;
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- LayoutRect m_headerRect;
</del><ins>+ AccessibilityTableHeaderContainer();
</ins><span class="cx">
</span><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><ins>+
+ LayoutRect m_headerRect;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableRowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableRow.h (175277 => 175278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableRow.h 2014-10-28 22:38:44 UTC (rev 175277)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableRow.h 2014-10-28 22:42:37 UTC (rev 175278)
</span><span class="lines">@@ -36,14 +36,9 @@
</span><span class="cx"> class AccessibilityTable;
</span><span class="cx">
</span><span class="cx"> class AccessibilityTableRow : public AccessibilityRenderObject {
</span><del>-
-protected:
- explicit AccessibilityTableRow(RenderObject*);
</del><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<AccessibilityTableRow> create(RenderObject*);
</span><span class="cx"> virtual ~AccessibilityTableRow();
</span><del>-
- virtual bool isTableRow() const override;
</del><span class="cx">
</span><span class="cx"> // retrieves the "row" header (a th tag in the rightmost column)
</span><span class="cx"> virtual AccessibilityObject* headerObject();
</span><span class="lines">@@ -57,13 +52,16 @@
</span><span class="cx"> void appendChild(AccessibilityObject*);
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual AccessibilityRole determineAccessibilityRole() override;
</del><ins>+ explicit AccessibilityTableRow(RenderObject*);
</ins><span class="cx">
</span><ins>+ virtual AccessibilityRole determineAccessibilityRole() override final;
+
</ins><span class="cx"> private:
</span><ins>+ virtual bool isTableRow() const override final;
+ virtual AccessibilityObject* observableObject() const override final;
+ virtual bool computeAccessibilityIsIgnored() const override final;
+
</ins><span class="cx"> int m_rowIndex;
</span><del>-
- virtual AccessibilityObject* observableObject() const override;
- virtual bool computeAccessibilityIsIgnored() const override;
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre>
</div>
</div>
</body>
</html>