<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175262] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175262">175262</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-10-28 11:01:32 -0700 (Tue, 28 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove App.PaneController.bugsChangeCount in the new perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=138111
Reviewed by Darin Adler.
* public/v2/app.js:
(App.PaneController.bugsChangeCount): Removed.
(App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
(App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
Finds the list of current run's points that are associated with bugs.
(App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
* public/v2/chart-pane.css:
(.chart .marked): Renamed from .hasBugs.
* public/v2/index.html: Specify chartPointRadius and markedPoints.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2chartpanecss">trunk/Websites/perf.webkit.org/public/v2/chart-pane.css</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2indexhtml">trunk/Websites/perf.webkit.org/public/v2/index.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (175261 => 175262)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2014-10-28 18:00:09 UTC (rev 175261)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-10-28 18:01:32 UTC (rev 175262)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
+
+ Remove App.PaneController.bugsChangeCount in the new perf dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=138111
+
+ Reviewed by Darin Adler.
+
+ * public/v2/app.js:
+ (App.PaneController.bugsChangeCount): Removed.
+ (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
+ (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
+ Finds the list of current run's points that are associated with bugs.
+ (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
+ * public/v2/chart-pane.css:
+ (.chart .marked): Renamed from .hasBugs.
+ * public/v2/index.html: Specify chartPointRadius and markedPoints.
+
</ins><span class="cx"> 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> REGRESSION: commit logs are not shown sometimes on the new dashboard UI
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (175261 => 175262)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2014-10-28 18:00:09 UTC (rev 175261)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2014-10-28 18:01:32 UTC (rev 175262)
</span><span class="lines">@@ -664,7 +664,6 @@
</span><span class="cx"> sharedTime: Ember.computed.alias('parentController.sharedTime'),
</span><span class="cx"> sharedSelection: Ember.computed.alias('parentController.sharedSelection'),
</span><span class="cx"> selection: null,
</span><del>- bugsChangeCount: 0, // Dirty hack. Used to call InteractiveChartComponent's _updateDotsWithBugs.
</del><span class="cx"> actions: {
</span><span class="cx"> toggleDetails: function()
</span><span class="cx"> {
</span><span class="lines">@@ -689,7 +688,7 @@
</span><span class="cx"> var self = this;
</span><span class="cx"> point.measurement.associateBug(bugTracker.get('id'), bugNumber).then(function () {
</span><span class="cx"> self._updateBugs();
</span><del>- self.set('bugsChangeCount', self.get('bugsChangeCount') + 1);
</del><ins>+ self._updateMarkedPoints();
</ins><span class="cx"> });
</span><span class="cx"> },
</span><span class="cx"> toggleSearchPane: function ()
</span><span class="lines">@@ -843,7 +842,24 @@
</span><span class="cx"> editedBugNumber: this._hasRange ? null : bugNumbers[0],
</span><span class="cx"> }); // FIXME: Create urls for new bugs.
</span><span class="cx"> }));
</span><del>- }
</del><ins>+ },
+ _updateMarkedPoints: function ()
+ {
+ var chartData = this.get('chartData');
+ if (!chartData || !chartData.current) {
+ this.set('markedPoints', {});
+ return;
+ }
+
+ var series = chartData.current.timeSeriesByCommitTime().series();
+ var markedPoints = {};
+ for (var i = 0; i < series.length; i++) {
+ var measurement = series[i].measurement;
+ if (measurement.hasBugs())
+ markedPoints[measurement.id()] = true;
+ }
+ this.set('markedPoints', markedPoints);
+ }.observes('chartData'),
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> App.InteractiveChartComponent = Ember.Component.extend({
</span><span class="lines">@@ -989,7 +1005,7 @@
</span><span class="cx"> .data(this._currentTimeSeriesData)
</span><span class="cx"> .enter().append("circle")
</span><span class="cx"> .attr("class", "dot")
</span><del>- .attr("r", this.get('interactive') ? 2 : 1));
</del><ins>+ .attr("r", this.get('chartPointRadius') || 1));
</ins><span class="cx">
</span><span class="cx"> if (this.get('interactive')) {
</span><span class="cx"> this._attachEventListener(element, "mousemove", this._mouseMoved.bind(this));
</span><span class="lines">@@ -1120,7 +1136,7 @@
</span><span class="cx"> .attr("cx", function(measurement) { return xScale(measurement.time); })
</span><span class="cx"> .attr("cy", function(measurement) { return yScale(measurement.value); });
</span><span class="cx"> });
</span><del>- this._updateDotsWithBugs();
</del><ins>+ this._updateMarkedDots();
</ins><span class="cx"> this._updateHighlightPositions();
</span><span class="cx">
</span><span class="cx"> if (this._brush) {
</span><span class="lines">@@ -1149,13 +1165,15 @@
</span><span class="cx"> .style("z-index", "100")
</span><span class="cx"> .text(this._yAxisUnit);
</span><span class="cx"> },
</span><del>- _updateDotsWithBugs: function () {
- if (!this.get('interactive'))
- return;
</del><ins>+ _updateMarkedDots: function () {
+ var markedPoints = this.get('markedPoints') || {};
+ var defaultDotRadius = this.get('chartPointRadius') || 1;
</ins><span class="cx"> this._dots.forEach(function (dot) {
</span><del>- dot.classed('hasBugs', function (point) { return !!point.measurement.hasBugs(); });
- })
- }.observes('bugsChangeCount'), // Never used for anything but to call this method :(
</del><ins>+ dot.classed('marked', function (point) { return markedPoints[point.measurement.id()]; });
+ dot.attr('r', function (point) {
+ return markedPoints[point.measurement.id()] ? defaultDotRadius * 1.5 : defaultDotRadius; });
+ });
+ }.observes('markedPoints'),
</ins><span class="cx"> _updateHighlightPositions: function () {
</span><span class="cx"> var xScale = this._x;
</span><span class="cx"> var yScale = this._y;
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2chartpanecss"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (175261 => 175262)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2014-10-28 18:00:09 UTC (rev 175261)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2014-10-28 18:01:32 UTC (rev 175262)
</span><span class="lines">@@ -258,8 +258,8 @@
</span><span class="cx"> stroke: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.chart .hasBugs {
- fill: #33f;
</del><ins>+.chart .marked {
+ fill: #c33;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .chart path.area {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (175261 => 175262)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/index.html 2014-10-28 18:00:09 UTC (rev 175261)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2014-10-28 18:01:32 UTC (rev 175262)
</span><span class="lines">@@ -154,6 +154,7 @@
</span><span class="cx"> chartData=chartData
</span><span class="cx"> domain=mainPlotDomain
</span><span class="cx"> interactive=true
</span><ins>+ chartPointRadius=2
</ins><span class="cx"> currentItem=currentItem
</span><span class="cx"> currentTime=sharedTime
</span><span class="cx"> selectedItem=selectedItem
</span><span class="lines">@@ -162,7 +163,7 @@
</span><span class="cx"> sharedSelection=sharedSelection
</span><span class="cx"> selectionChanged="rangeChanged"
</span><span class="cx"> selectionIsLocked=timeRangeIsLocked
</span><del>- bugsChangeCount=bugsChangeCount
</del><ins>+ markedPoints=markedPoints
</ins><span class="cx"> zoom="zoomed"}}
</span><span class="cx"> {{else}}
</span><span class="cx"> {{#if failure}}
</span></span></pre>
</div>
</div>
</body>
</html>