<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175234] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175234">175234</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-10-27 16:13:24 -0700 (Mon, 27 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: commit logs are not shown sometimes on the new dashboard UI
https://bugs.webkit.org/show_bug.cgi?id=138099
Reviewed by Benjamin Poulain.
The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
_showDetails inverting the order of the current and old measurements.
* public/v2/app.js:
(App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
(App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
current (latest) measurement and the first point is the oldest measurement.
(App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (175233 => 175234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2014-10-27 22:55:38 UTC (rev 175233)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-10-27 23:13:24 UTC (rev 175234)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION: commit logs are not shown sometimes on the new dashboard UI
+ https://bugs.webkit.org/show_bug.cgi?id=138099
+
+ Reviewed by Benjamin Poulain.
+
+ The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
+ _showDetails inverting the order of the current and old measurements.
+
+ * public/v2/app.js:
+ (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
+ (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
+ current (latest) measurement and the first point is the oldest measurement.
+ (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
+
</ins><span class="cx"> 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Perf dashboard should provide a way to associate bugs with a test run
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (175233 => 175234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2014-10-27 22:55:38 UTC (rev 175233)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2014-10-27 23:13:24 UTC (rev 175234)
</span><span class="lines">@@ -769,14 +769,16 @@
</span><span class="cx"> var point = this.get('currentItem');
</span><span class="cx"> if (!point || !point.measurement)
</span><span class="cx"> this.set('details', null);
</span><del>- else
- this._showDetails([point]);
</del><ins>+ else {
+ var previousPoint = point.series.previousPoint(point);
+ this._showDetails(previousPoint ? [previousPoint, point] : [point]);
+ }
</ins><span class="cx"> }.observes('currentItem'),
</span><span class="cx"> _showDetails: function (points)
</span><span class="cx"> {
</span><span class="cx"> var isShowingEndPoint = !this._hasRange;
</span><del>- var currentMeasurement = points[0].measurement;
- var oldMeasurement = points[points.length - 1].measurement;
</del><ins>+ var currentMeasurement = points[points.length - 1].measurement;
+ var oldMeasurement = points[0].measurement;
</ins><span class="cx"> var formattedRevisions = currentMeasurement.formattedRevisions(oldMeasurement);
</span><span class="cx"> var revisions = App.Manifest.get('repositories')
</span><span class="cx"> .filter(function (repository) { return formattedRevisions[repository.get('id')]; })
</span><span class="lines">@@ -1538,7 +1540,7 @@
</span><span class="cx"> var revisionInfo = this.get('revisionInfo');
</span><span class="cx">
</span><span class="cx"> var to = revisionInfo.get('currentRevision');
</span><del>- var from = revisionInfo.get('previousRevision') || to;
</del><ins>+ var from = revisionInfo.get('previousRevision');
</ins><span class="cx"> var repository = this.get('repository');
</span><span class="cx"> if (!from || !repository || !repository.get('hasReportedCommits'))
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>