<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175149] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175149">175149</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-10-23 16:30:34 -0700 (Thu, 23 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get rid of unnecessary vtables in WebKit
https://bugs.webkit.org/show_bug.cgi?id=138024
Reviewed by Benjamin Poulain.
Get rid of unnecessary vtables in WebKit by de-virtualizing destructors
when possible and marking the class as final to make sure people don't
subclass it.
No new tests, no behavior change.
* WebCore.exp.in:
* css/WebKitCSSMatrix.h:
* css/WebKitCSSMatrix.idl:
* html/canvas/WebGLContextGroup.h:
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLUniformLocation.h:
(WebCore::WebGLUniformLocation::~WebGLUniformLocation): Deleted.
* html/canvas/WebGLUniformLocation.idl:
* inspector/DOMPatchSupport.h:
* inspector/InspectorHistory.h:
* inspector/InspectorStyleSheet.h:
* page/WheelEventDeltaTracker.h:
* page/scrolling/ScrollLatchingState.h:
* platform/audio/Biquad.h:
* platform/graphics/Pattern.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSMatrixh">trunk/Source/WebCore/css/WebKitCSSMatrix.h</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSMatrixidl">trunk/Source/WebCore/css/WebKitCSSMatrix.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLContextGrouph">trunk/Source/WebCore/html/canvas/WebGLContextGroup.h</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLGetInfoh">trunk/Source/WebCore/html/canvas/WebGLGetInfo.h</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLUniformLocationh">trunk/Source/WebCore/html/canvas/WebGLUniformLocation.h</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLUniformLocationidl">trunk/Source/WebCore/html/canvas/WebGLUniformLocation.idl</a></li>
<li><a href="#trunkSourceWebCoreinspectorDOMPatchSupporth">trunk/Source/WebCore/inspector/DOMPatchSupport.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorHistoryh">trunk/Source/WebCore/inspector/InspectorHistory.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorStyleSheeth">trunk/Source/WebCore/inspector/InspectorStyleSheet.h</a></li>
<li><a href="#trunkSourceWebCorepageWheelEventDeltaTrackerh">trunk/Source/WebCore/page/WheelEventDeltaTracker.h</a></li>
<li><a href="#trunkSourceWebCorepagescrollingScrollLatchingStateh">trunk/Source/WebCore/page/scrolling/ScrollLatchingState.h</a></li>
<li><a href="#trunkSourceWebCoreplatformaudioBiquadh">trunk/Source/WebCore/platform/audio/Biquad.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsPatternh">trunk/Source/WebCore/platform/graphics/Pattern.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/ChangeLog 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -1,5 +1,34 @@
</span><span class="cx"> 2014-10-23 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Get rid of unnecessary vtables in WebKit
+ https://bugs.webkit.org/show_bug.cgi?id=138024
+
+ Reviewed by Benjamin Poulain.
+
+ Get rid of unnecessary vtables in WebKit by de-virtualizing destructors
+ when possible and marking the class as final to make sure people don't
+ subclass it.
+
+ No new tests, no behavior change.
+
+ * WebCore.exp.in:
+ * css/WebKitCSSMatrix.h:
+ * css/WebKitCSSMatrix.idl:
+ * html/canvas/WebGLContextGroup.h:
+ * html/canvas/WebGLGetInfo.h:
+ * html/canvas/WebGLUniformLocation.h:
+ (WebCore::WebGLUniformLocation::~WebGLUniformLocation): Deleted.
+ * html/canvas/WebGLUniformLocation.idl:
+ * inspector/DOMPatchSupport.h:
+ * inspector/InspectorHistory.h:
+ * inspector/InspectorStyleSheet.h:
+ * page/WheelEventDeltaTracker.h:
+ * page/scrolling/ScrollLatchingState.h:
+ * platform/audio/Biquad.h:
+ * platform/graphics/Pattern.h:
+
+2014-10-23 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Clean up virtual functions in dom/
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=138019
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreexpin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.exp.in 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -994,6 +994,7 @@
</span><span class="cx"> __ZN7WebCore22WheelEventDeltaTracker19beginTrackingDeltasEv
</span><span class="cx"> __ZN7WebCore22WheelEventDeltaTracker21recordWheelEventDeltaERKNS_18PlatformWheelEventE
</span><span class="cx"> __ZN7WebCore22WheelEventDeltaTrackerC1Ev
</span><ins>+__ZN7WebCore22WheelEventDeltaTrackerD1Ev
</ins><span class="cx"> __ZN7WebCore22colorWithOverrideAlphaEjf
</span><span class="cx"> __ZN7WebCore22counterValueForElementEPNS_7ElementE
</span><span class="cx"> __ZN7WebCore22createFragmentFromTextERNS_5RangeERKN3WTF6StringE
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSMatrixh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSMatrix.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx">
</span><span class="cx"> typedef int ExceptionCode;
</span><span class="cx">
</span><del>-class WebKitCSSMatrix : public ScriptWrappable, public RefCounted<WebKitCSSMatrix> {
</del><ins>+class WebKitCSSMatrix final : public ScriptWrappable, public RefCounted<WebKitCSSMatrix> {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<WebKitCSSMatrix> create(const TransformationMatrix& m)
</span><span class="cx"> {
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> return adoptRef(new WebKitCSSMatrix(s, ec));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual ~WebKitCSSMatrix();
</del><ins>+ ~WebKitCSSMatrix();
</ins><span class="cx">
</span><span class="cx"> double a() const { return m_matrix.a(); }
</span><span class="cx"> double b() const { return m_matrix.b(); }
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSMatrixidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> [
</span><span class="cx"> Constructor([Default=NullString] optional DOMString cssValue),
</span><span class="cx"> ConstructorRaisesException,
</span><ins>+ ImplementationLacksVTable,
</ins><span class="cx"> ] interface WebKitCSSMatrix {
</span><span class="cx">
</span><span class="cx"> // These attributes are simple aliases for certain elements of the 4x4 matrix
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLContextGrouph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLContextGroup.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLContextGroup.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/html/canvas/WebGLContextGroup.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -40,10 +40,10 @@
</span><span class="cx">
</span><span class="cx"> typedef int ExceptionCode;
</span><span class="cx">
</span><del>-class WebGLContextGroup : public RefCounted<WebGLContextGroup> {
</del><ins>+class WebGLContextGroup final : public RefCounted<WebGLContextGroup> {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<WebGLContextGroup> create();
</span><del>- virtual ~WebGLContextGroup();
</del><ins>+ ~WebGLContextGroup();
</ins><span class="cx">
</span><span class="cx"> void addContext(WebGLRenderingContext*);
</span><span class="cx"> void removeContext(WebGLRenderingContext*);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLGetInfoh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLGetInfo.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLGetInfo.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/html/canvas/WebGLGetInfo.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> // similar variants. For reference counted types, increments and
</span><span class="cx"> // decrements the reference count of the target object.
</span><span class="cx">
</span><del>-class WebGLGetInfo {
</del><ins>+class WebGLGetInfo final {
</ins><span class="cx"> public:
</span><span class="cx"> enum Type {
</span><span class="cx"> kTypeBool,
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx"> explicit WebGLGetInfo(PassRefPtr<Uint32Array> value);
</span><span class="cx"> explicit WebGLGetInfo(PassRefPtr<WebGLVertexArrayObjectOES> value);
</span><span class="cx">
</span><del>- virtual ~WebGLGetInfo();
</del><ins>+ ~WebGLGetInfo();
</ins><span class="cx">
</span><span class="cx"> Type getType() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLUniformLocationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLUniformLocation.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLUniformLocation.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/html/canvas/WebGLUniformLocation.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -34,9 +34,9 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class WebGLUniformLocation : public RefCounted<WebGLUniformLocation> {
</del><ins>+class WebGLUniformLocation final : public RefCounted<WebGLUniformLocation> {
</ins><span class="cx"> public:
</span><del>- virtual ~WebGLUniformLocation() { }
</del><ins>+ ~WebGLUniformLocation() { }
</ins><span class="cx">
</span><span class="cx"> static PassRefPtr<WebGLUniformLocation> create(WebGLProgram*, GC3Dint location, GC3Denum type);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLUniformLocationidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLUniformLocation.idl (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLUniformLocation.idl 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/html/canvas/WebGLUniformLocation.idl 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- Conditional=WEBGL
</del><ins>+ Conditional=WEBGL,
+ ImplementationLacksVTable,
</ins><span class="cx"> ] interface WebGLUniformLocation {
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorDOMPatchSupporth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/DOMPatchSupport.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/DOMPatchSupport.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/inspector/DOMPatchSupport.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -46,13 +46,13 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INSPECTOR)
</span><span class="cx">
</span><del>-class DOMPatchSupport {
</del><ins>+class DOMPatchSupport final {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(DOMPatchSupport);
</span><span class="cx"> public:
</span><span class="cx"> static void patchDocument(Document*, const String& markup);
</span><span class="cx">
</span><span class="cx"> DOMPatchSupport(DOMEditor*, Document*);
</span><del>- virtual ~DOMPatchSupport();
</del><ins>+ ~DOMPatchSupport();
</ins><span class="cx">
</span><span class="cx"> void patchDocument(const String& markup);
</span><span class="cx"> Node* patchNode(Node&, const String& markup, ExceptionCode&);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorHistoryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorHistory.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorHistory.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/inspector/InspectorHistory.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INSPECTOR)
</span><span class="cx">
</span><del>-class InspectorHistory {
</del><ins>+class InspectorHistory final {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(InspectorHistory); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> class Action {
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> InspectorHistory();
</span><del>- virtual ~InspectorHistory();
</del><ins>+ ~InspectorHistory();
</ins><span class="cx">
</span><span class="cx"> bool perform(std::unique_ptr<Action>, ExceptionCode&);
</span><span class="cx"> void markUndoableState();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorStyleSheeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorStyleSheet.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -133,10 +133,10 @@
</span><span class="cx"> String rawText;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class InspectorStyle : public RefCounted<InspectorStyle> {
</del><ins>+class InspectorStyle final : public RefCounted<InspectorStyle> {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<InspectorStyle> create(const InspectorCSSId& styleId, PassRefPtr<CSSStyleDeclaration> style, InspectorStyleSheet* parentStyleSheet);
</span><del>- virtual ~InspectorStyle();
</del><ins>+ ~InspectorStyle();
</ins><span class="cx">
</span><span class="cx"> CSSStyleDeclaration* cssStyle() const { return m_style.get(); }
</span><span class="cx"> PassRefPtr<Inspector::Protocol::CSS::CSSStyle> buildObjectForStyle() const;
</span></span></pre></div>
<a id="trunkSourceWebCorepageWheelEventDeltaTrackerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/WheelEventDeltaTracker.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/WheelEventDeltaTracker.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/page/WheelEventDeltaTracker.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -42,10 +42,10 @@
</span><span class="cx"> Horizontal
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class WheelEventDeltaTracker {
</del><ins>+class WheelEventDeltaTracker final {
</ins><span class="cx"> public:
</span><span class="cx"> WEBCORE_EXPORT WheelEventDeltaTracker();
</span><del>- virtual ~WheelEventDeltaTracker();
</del><ins>+ ~WheelEventDeltaTracker();
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void beginTrackingDeltas();
</span><span class="cx"> WEBCORE_EXPORT void endTrackingDeltas();
</span></span></pre></div>
<a id="trunkSourceWebCorepagescrollingScrollLatchingStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/scrolling/ScrollLatchingState.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/scrolling/ScrollLatchingState.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/page/scrolling/ScrollLatchingState.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -34,10 +34,10 @@
</span><span class="cx"> class Element;
</span><span class="cx"> class Frame;
</span><span class="cx">
</span><del>-class ScrollLatchingState {
</del><ins>+class ScrollLatchingState final {
</ins><span class="cx"> public:
</span><span class="cx"> ScrollLatchingState();
</span><del>- virtual ~ScrollLatchingState();
</del><ins>+ ~ScrollLatchingState();
</ins><span class="cx">
</span><span class="cx"> void clear();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformaudioBiquadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/audio/Biquad.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/audio/Biquad.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/platform/audio/Biquad.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -40,10 +40,10 @@
</span><span class="cx"> // It can be configured to a number of common and very useful filters:
</span><span class="cx"> // lowpass, highpass, shelving, parameteric, notch, allpass, ...
</span><span class="cx">
</span><del>-class Biquad {
</del><ins>+class Biquad final {
</ins><span class="cx"> public:
</span><span class="cx"> Biquad();
</span><del>- virtual ~Biquad();
</del><ins>+ ~Biquad();
</ins><span class="cx">
</span><span class="cx"> void process(const float* sourceP, float* destP, size_t framesToProcess);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsPatternh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/Pattern.h (175148 => 175149)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/Pattern.h 2014-10-23 23:26:01 UTC (rev 175148)
+++ trunk/Source/WebCore/platform/graphics/Pattern.h 2014-10-23 23:30:34 UTC (rev 175149)
</span><span class="lines">@@ -49,10 +49,10 @@
</span><span class="cx"> class AffineTransform;
</span><span class="cx"> class Image;
</span><span class="cx">
</span><del>-class Pattern : public RefCounted<Pattern> {
</del><ins>+class Pattern final : public RefCounted<Pattern> {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRef<Pattern> create(PassRefPtr<Image> tileImage, bool repeatX, bool repeatY);
</span><del>- virtual ~Pattern();
</del><ins>+ ~Pattern();
</ins><span class="cx">
</span><span class="cx"> Image* tileImage() const { return m_tileImage.get(); }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>