<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175080] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175080">175080</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2014-10-22 19:39:14 -0700 (Wed, 22 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Refactoring to simplify some code in DatePrototype.cpp.
<https://webkit.org/b/137997>
Reviewed by Filip Pizlo.
A bunch of functions in DatePrototype.cpp have the pattern of loading a
constant into a local variable only to pass it to a callee function
immediately after. There is no other use for that variable. This adds
additional verbosity with no added benefit.
This patch refactors those functions to just pass the constant arg directly.
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeDatePrototypecpp">trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (175079 => 175080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-10-23 01:37:08 UTC (rev 175079)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-10-23 02:39:14 UTC (rev 175080)
</span><span class="lines">@@ -1,3 +1,33 @@
</span><ins>+2014-10-22 Mark Lam <mark.lam@apple.com>
+
+ Refactoring to simplify some code in DatePrototype.cpp.
+ <https://webkit.org/b/137997>
+
+ Reviewed by Filip Pizlo.
+
+ A bunch of functions in DatePrototype.cpp have the pattern of loading a
+ constant into a local variable only to pass it to a callee function
+ immediately after. There is no other use for that variable. This adds
+ additional verbosity with no added benefit.
+
+ This patch refactors those functions to just pass the constant arg directly.
+
+ * runtime/DatePrototype.cpp:
+ (JSC::dateProtoFuncSetMilliSeconds):
+ (JSC::dateProtoFuncSetUTCMilliseconds):
+ (JSC::dateProtoFuncSetSeconds):
+ (JSC::dateProtoFuncSetUTCSeconds):
+ (JSC::dateProtoFuncSetMinutes):
+ (JSC::dateProtoFuncSetUTCMinutes):
+ (JSC::dateProtoFuncSetHours):
+ (JSC::dateProtoFuncSetUTCHours):
+ (JSC::dateProtoFuncSetDate):
+ (JSC::dateProtoFuncSetUTCDate):
+ (JSC::dateProtoFuncSetMonth):
+ (JSC::dateProtoFuncSetUTCMonth):
+ (JSC::dateProtoFuncSetFullYear):
+ (JSC::dateProtoFuncSetUTCFullYear):
+
</ins><span class="cx"> 2014-10-22 Byungseon Shin <sun.shin@lge.com>
</span><span class="cx">
</span><span class="cx"> String(new Date(Mar 30 2014 01:00:00)) is wrong in CET
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeDatePrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp (175079 => 175080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp 2014-10-23 01:37:08 UTC (rev 175079)
+++ trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp 2014-10-23 02:39:14 UTC (rev 175080)
</span><span class="lines">@@ -940,86 +940,72 @@
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetMilliSeconds(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::LocalTime;
- return setNewValueFromTimeArgs(exec, 1, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 1, WTF::LocalTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCMilliseconds(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::UTCTime;
- return setNewValueFromTimeArgs(exec, 1, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 1, WTF::UTCTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetSeconds(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::LocalTime;
- return setNewValueFromTimeArgs(exec, 2, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 2, WTF::LocalTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCSeconds(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::UTCTime;
- return setNewValueFromTimeArgs(exec, 2, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 2, WTF::UTCTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetMinutes(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::LocalTime;
- return setNewValueFromTimeArgs(exec, 3, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 3, WTF::LocalTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCMinutes(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::UTCTime;
- return setNewValueFromTimeArgs(exec, 3, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 3, WTF::UTCTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetHours(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::LocalTime;
- return setNewValueFromTimeArgs(exec, 4, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 4, WTF::LocalTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCHours(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::UTCTime;
- return setNewValueFromTimeArgs(exec, 4, inputTimeType);
</del><ins>+ return setNewValueFromTimeArgs(exec, 4, WTF::UTCTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetDate(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::LocalTime;
- return setNewValueFromDateArgs(exec, 1, inputTimeType);
</del><ins>+ return setNewValueFromDateArgs(exec, 1, WTF::LocalTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCDate(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::UTCTime;
- return setNewValueFromDateArgs(exec, 1, inputTimeType);
</del><ins>+ return setNewValueFromDateArgs(exec, 1, WTF::UTCTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetMonth(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::LocalTime;
- return setNewValueFromDateArgs(exec, 2, inputTimeType);
</del><ins>+ return setNewValueFromDateArgs(exec, 2, WTF::LocalTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCMonth(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::UTCTime;
- return setNewValueFromDateArgs(exec, 2, inputTimeType);
</del><ins>+ return setNewValueFromDateArgs(exec, 2, WTF::UTCTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetFullYear(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::LocalTime;
- return setNewValueFromDateArgs(exec, 3, inputTimeType);
</del><ins>+ return setNewValueFromDateArgs(exec, 3, WTF::LocalTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCFullYear(ExecState* exec)
</span><span class="cx"> {
</span><del>- const WTF::TimeType inputTimeType = WTF::UTCTime;
- return setNewValueFromDateArgs(exec, 3, inputTimeType);
</del><ins>+ return setNewValueFromDateArgs(exec, 3, WTF::UTCTime);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetYear(ExecState* exec)
</span></span></pre>
</div>
</div>
</body>
</html>