<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[175084] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/175084">175084</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-10-22 21:32:27 -0700 (Wed, 22 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up virtual functions in rendering/
https://bugs.webkit.org/show_bug.cgi?id=137984
Reviewed by Darin Adler.
Clean up virtual functions in rendering/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Using 'override' when appropriate
- Explicitly marking functions / destructors as virtual when they are
inherently virtual
- Dropping virtual destructors when the class does not have subclasses
and mark the class as final, to get rid of unnecessary vtables
- Making isXXX() virtual functions private on XXX classes to avoid
unnecessary type checks
- De-virtualizing some functions that do not need to be virtual
- Dropping final for virtual functions in classes already marked as
final
No new tests, no behavior change.
* html/shadow/SliderThumbElement.cpp:
* rendering/AutoTableLayout.h:
* rendering/ClipPathOperation.h:
(WebCore::ClipPathOperation::type):
(WebCore::ClipPathOperation::isSameType):
* rendering/EllipsisBox.h:
* rendering/FixedTableLayout.h:
* rendering/InlineElementBox.h:
* rendering/RenderBlockFlow.h:
* rendering/RenderCombineText.h:
* rendering/RenderCounter.h:
* rendering/RenderDeprecatedFlexibleBox.h:
* rendering/RenderFlexibleBox.h:
* rendering/RenderFullScreen.h:
* rendering/RenderGrid.h:
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.h:
* rendering/RenderLayerFilterInfo.h:
* rendering/RenderLineBreak.h:
* rendering/RenderMarquee.h:
* rendering/RenderMediaControlElements.h:
* rendering/RenderMultiColumnFlowThread.h:
* rendering/RenderMultiColumnSet.h:
* rendering/RenderMultiColumnSpannerPlaceholder.h:
* rendering/RenderNamedFlowFragment.h:
* rendering/RenderNamedFlowThread.h:
* rendering/RenderQuote.h:
* rendering/RenderRegion.h:
(WebCore::RenderRegion::renderName): Deleted.
* rendering/RenderReplica.h:
* rendering/RenderRubyBase.h:
* rendering/RenderRubyRun.h:
* rendering/RenderScrollbar.h:
* rendering/RenderScrollbarPart.h:
* rendering/RenderScrollbarTheme.h:
(WebCore::RenderScrollbarTheme::~RenderScrollbarTheme): Deleted.
(WebCore::RenderScrollbarTheme::scrollbarThickness): Deleted.
(WebCore::RenderScrollbarTheme::buttonsPlacement): Deleted.
(WebCore::RenderScrollbarTheme::supportsControlTints): Deleted.
(WebCore::RenderScrollbarTheme::shouldCenterOnThumb): Deleted.
(WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay): Deleted.
(WebCore::RenderScrollbarTheme::autoscrollTimerDelay): Deleted.
(WebCore::RenderScrollbarTheme::registerScrollbar): Deleted.
(WebCore::RenderScrollbarTheme::unregisterScrollbar): Deleted.
* rendering/RenderSnapshottedPlugIn.h:
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextFragment.h:
* rendering/RenderThemeGtk.h:
* rendering/RenderThemeIOS.h:
* rendering/RenderThemeWin.h:
* rendering/RenderVideo.h:
* rendering/TextAutosizer.h:
* rendering/TrailingFloatsRootInlineBox.h:
* rendering/mathml/RenderMathMLBlock.h:
* rendering/mathml/RenderMathMLMenclose.h:
* rendering/mathml/RenderMathMLOperator.h:
* rendering/mathml/RenderMathMLRadicalOperator.h:
* rendering/mathml/RenderMathMLRoot.h:
* rendering/mathml/RenderMathMLRow.h:
* rendering/mathml/RenderMathMLScripts.h:
* rendering/mathml/RenderMathMLToken.h:
* rendering/mathml/RenderMathMLUnderOver.h:
* rendering/shapes/BoxShape.h:
* rendering/shapes/PolygonShape.h:
* rendering/shapes/RasterShape.h:
* rendering/shapes/RectangleShape.h:
* rendering/style/BasicShapes.h:
* rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::computeIntrinsicDimensions): Deleted.
* rendering/svg/RenderSVGBlock.h:
* rendering/svg/RenderSVGContainer.h:
* rendering/svg/RenderSVGEllipse.h:
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGPath.h:
* rendering/svg/RenderSVGRect.h:
* rendering/svg/RenderSVGResourceClipper.h:
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
* rendering/svg/RenderSVGResourceLinearGradient.h:
* rendering/svg/RenderSVGResourceMarker.h:
* rendering/svg/RenderSVGResourceMasker.h:
* rendering/svg/RenderSVGResourcePattern.h:
* rendering/svg/RenderSVGResourceRadialGradient.h:
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGTSpan.h:
* rendering/svg/RenderSVGText.h:
* rendering/svg/RenderSVGTransformableContainer.h:
* rendering/svg/RenderSVGViewportContainer.h:
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRootInlineBox.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementcpp">trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingAutoTableLayouth">trunk/Source/WebCore/rendering/AutoTableLayout.h</a></li>
<li><a href="#trunkSourceWebCorerenderingClipPathOperationh">trunk/Source/WebCore/rendering/ClipPathOperation.h</a></li>
<li><a href="#trunkSourceWebCorerenderingEllipsisBoxh">trunk/Source/WebCore/rendering/EllipsisBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingFixedTableLayouth">trunk/Source/WebCore/rendering/FixedTableLayout.h</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineElementBoxh">trunk/Source/WebCore/rendering/InlineElementBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowh">trunk/Source/WebCore/rendering/RenderBlockFlow.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderCombineTexth">trunk/Source/WebCore/rendering/RenderCombineText.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderCounterh">trunk/Source/WebCore/rendering/RenderCounter.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderDeprecatedFlexibleBoxh">trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderFlexibleBoxh">trunk/Source/WebCore/rendering/RenderFlexibleBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderFullScreenh">trunk/Source/WebCore/rendering/RenderFullScreen.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderGridh">trunk/Source/WebCore/rendering/RenderGrid.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerh">trunk/Source/WebCore/rendering/RenderLayer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingh">trunk/Source/WebCore/rendering/RenderLayerBacking.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorh">trunk/Source/WebCore/rendering/RenderLayerCompositor.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerFilterInfoh">trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLineBreakh">trunk/Source/WebCore/rendering/RenderLineBreak.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMarqueeh">trunk/Source/WebCore/rendering/RenderMarquee.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMediaControlElementsh">trunk/Source/WebCore/rendering/RenderMediaControlElements.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMultiColumnFlowThreadh">trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMultiColumnSeth">trunk/Source/WebCore/rendering/RenderMultiColumnSet.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMultiColumnSpannerPlaceholderh">trunk/Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowFragmenth">trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowThreadh">trunk/Source/WebCore/rendering/RenderNamedFlowThread.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderQuoteh">trunk/Source/WebCore/rendering/RenderQuote.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderRegionh">trunk/Source/WebCore/rendering/RenderRegion.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderReplicah">trunk/Source/WebCore/rendering/RenderReplica.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderRubyBaseh">trunk/Source/WebCore/rendering/RenderRubyBase.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderRubyRunh">trunk/Source/WebCore/rendering/RenderRubyRun.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderScrollbarh">trunk/Source/WebCore/rendering/RenderScrollbar.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderScrollbarParth">trunk/Source/WebCore/rendering/RenderScrollbarPart.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderScrollbarThemeh">trunk/Source/WebCore/rendering/RenderScrollbarTheme.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderSnapshottedPlugInh">trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTextControlMultiLineh">trunk/Source/WebCore/rendering/RenderTextControlMultiLine.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTextFragmenth">trunk/Source/WebCore/rendering/RenderTextFragment.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeGtkh">trunk/Source/WebCore/rendering/RenderThemeGtk.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeIOSh">trunk/Source/WebCore/rendering/RenderThemeIOS.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeWinh">trunk/Source/WebCore/rendering/RenderThemeWin.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderVideoh">trunk/Source/WebCore/rendering/RenderVideo.h</a></li>
<li><a href="#trunkSourceWebCorerenderingTextAutosizerh">trunk/Source/WebCore/rendering/TextAutosizer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingTrailingFloatsRootInlineBoxh">trunk/Source/WebCore/rendering/TrailingFloatsRootInlineBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLBlockh">trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLMencloseh">trunk/Source/WebCore/rendering/mathml/RenderMathMLMenclose.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLOperatorh">trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLRadicalOperatorh">trunk/Source/WebCore/rendering/mathml/RenderMathMLRadicalOperator.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLRooth">trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLRowh">trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLScriptsh">trunk/Source/WebCore/rendering/mathml/RenderMathMLScripts.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLTokenh">trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLUnderOverh">trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h</a></li>
<li><a href="#trunkSourceWebCorerenderingshapesBoxShapeh">trunk/Source/WebCore/rendering/shapes/BoxShape.h</a></li>
<li><a href="#trunkSourceWebCorerenderingshapesPolygonShapeh">trunk/Source/WebCore/rendering/shapes/PolygonShape.h</a></li>
<li><a href="#trunkSourceWebCorerenderingshapesRasterShapeh">trunk/Source/WebCore/rendering/shapes/RasterShape.h</a></li>
<li><a href="#trunkSourceWebCorerenderingshapesRectangleShapeh">trunk/Source/WebCore/rendering/shapes/RectangleShape.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleBasicShapesh">trunk/Source/WebCore/rendering/style/BasicShapes.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStylePendingImageh">trunk/Source/WebCore/rendering/style/StylePendingImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGBlockh">trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGContainerh">trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGEllipseh">trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGForeignObjecth">trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGImageh">trunk/Source/WebCore/rendering/svg/RenderSVGImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGPathh">trunk/Source/WebCore/rendering/svg/RenderSVGPath.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGRecth">trunk/Source/WebCore/rendering/svg/RenderSVGRect.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceClipperh">trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceFilterh">trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceFilterPrimitiveh">trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceLinearGradienth">trunk/Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceMarkerh">trunk/Source/WebCore/rendering/svg/RenderSVGResourceMarker.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceMaskerh">trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourcePatternh">trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceRadialGradienth">trunk/Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGRooth">trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGTSpanh">trunk/Source/WebCore/rendering/svg/RenderSVGTSpan.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGTexth">trunk/Source/WebCore/rendering/svg/RenderSVGText.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGTransformableContainerh">trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGViewportContainerh">trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGInlineTextBoxh">trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGRootInlineBoxh">trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/ChangeLog 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -1,3 +1,119 @@
</span><ins>+2014-10-22 Chris Dumez <cdumez@apple.com>
+
+ Clean up virtual functions in rendering/
+ https://bugs.webkit.org/show_bug.cgi?id=137984
+
+ Reviewed by Darin Adler.
+
+ Clean up virtual functions in rendering/ by:
+ - Making virtual functions final when possible
+ - Making classes final when possible
+ - Using 'override' when appropriate
+ - Explicitly marking functions / destructors as virtual when they are
+ inherently virtual
+ - Dropping virtual destructors when the class does not have subclasses
+ and mark the class as final, to get rid of unnecessary vtables
+ - Making isXXX() virtual functions private on XXX classes to avoid
+ unnecessary type checks
+ - De-virtualizing some functions that do not need to be virtual
+ - Dropping final for virtual functions in classes already marked as
+ final
+
+ No new tests, no behavior change.
+
+ * html/shadow/SliderThumbElement.cpp:
+ * rendering/AutoTableLayout.h:
+ * rendering/ClipPathOperation.h:
+ (WebCore::ClipPathOperation::type):
+ (WebCore::ClipPathOperation::isSameType):
+ * rendering/EllipsisBox.h:
+ * rendering/FixedTableLayout.h:
+ * rendering/InlineElementBox.h:
+ * rendering/RenderBlockFlow.h:
+ * rendering/RenderCombineText.h:
+ * rendering/RenderCounter.h:
+ * rendering/RenderDeprecatedFlexibleBox.h:
+ * rendering/RenderFlexibleBox.h:
+ * rendering/RenderFullScreen.h:
+ * rendering/RenderGrid.h:
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderLayerFilterInfo.h:
+ * rendering/RenderLineBreak.h:
+ * rendering/RenderMarquee.h:
+ * rendering/RenderMediaControlElements.h:
+ * rendering/RenderMultiColumnFlowThread.h:
+ * rendering/RenderMultiColumnSet.h:
+ * rendering/RenderMultiColumnSpannerPlaceholder.h:
+ * rendering/RenderNamedFlowFragment.h:
+ * rendering/RenderNamedFlowThread.h:
+ * rendering/RenderQuote.h:
+ * rendering/RenderRegion.h:
+ (WebCore::RenderRegion::renderName): Deleted.
+ * rendering/RenderReplica.h:
+ * rendering/RenderRubyBase.h:
+ * rendering/RenderRubyRun.h:
+ * rendering/RenderScrollbar.h:
+ * rendering/RenderScrollbarPart.h:
+ * rendering/RenderScrollbarTheme.h:
+ (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme): Deleted.
+ (WebCore::RenderScrollbarTheme::scrollbarThickness): Deleted.
+ (WebCore::RenderScrollbarTheme::buttonsPlacement): Deleted.
+ (WebCore::RenderScrollbarTheme::supportsControlTints): Deleted.
+ (WebCore::RenderScrollbarTheme::shouldCenterOnThumb): Deleted.
+ (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay): Deleted.
+ (WebCore::RenderScrollbarTheme::autoscrollTimerDelay): Deleted.
+ (WebCore::RenderScrollbarTheme::registerScrollbar): Deleted.
+ (WebCore::RenderScrollbarTheme::unregisterScrollbar): Deleted.
+ * rendering/RenderSnapshottedPlugIn.h:
+ * rendering/RenderTextControlMultiLine.h:
+ * rendering/RenderTextFragment.h:
+ * rendering/RenderThemeGtk.h:
+ * rendering/RenderThemeIOS.h:
+ * rendering/RenderThemeWin.h:
+ * rendering/RenderVideo.h:
+ * rendering/TextAutosizer.h:
+ * rendering/TrailingFloatsRootInlineBox.h:
+ * rendering/mathml/RenderMathMLBlock.h:
+ * rendering/mathml/RenderMathMLMenclose.h:
+ * rendering/mathml/RenderMathMLOperator.h:
+ * rendering/mathml/RenderMathMLRadicalOperator.h:
+ * rendering/mathml/RenderMathMLRoot.h:
+ * rendering/mathml/RenderMathMLRow.h:
+ * rendering/mathml/RenderMathMLScripts.h:
+ * rendering/mathml/RenderMathMLToken.h:
+ * rendering/mathml/RenderMathMLUnderOver.h:
+ * rendering/shapes/BoxShape.h:
+ * rendering/shapes/PolygonShape.h:
+ * rendering/shapes/RasterShape.h:
+ * rendering/shapes/RectangleShape.h:
+ * rendering/style/BasicShapes.h:
+ * rendering/style/StylePendingImage.h:
+ (WebCore::StylePendingImage::computeIntrinsicDimensions): Deleted.
+ * rendering/svg/RenderSVGBlock.h:
+ * rendering/svg/RenderSVGContainer.h:
+ * rendering/svg/RenderSVGEllipse.h:
+ * rendering/svg/RenderSVGForeignObject.h:
+ * rendering/svg/RenderSVGImage.h:
+ * rendering/svg/RenderSVGPath.h:
+ * rendering/svg/RenderSVGRect.h:
+ * rendering/svg/RenderSVGResourceClipper.h:
+ * rendering/svg/RenderSVGResourceFilter.h:
+ * rendering/svg/RenderSVGResourceFilterPrimitive.h:
+ * rendering/svg/RenderSVGResourceLinearGradient.h:
+ * rendering/svg/RenderSVGResourceMarker.h:
+ * rendering/svg/RenderSVGResourceMasker.h:
+ * rendering/svg/RenderSVGResourcePattern.h:
+ * rendering/svg/RenderSVGResourceRadialGradient.h:
+ * rendering/svg/RenderSVGRoot.h:
+ * rendering/svg/RenderSVGTSpan.h:
+ * rendering/svg/RenderSVGText.h:
+ * rendering/svg/RenderSVGTransformableContainer.h:
+ * rendering/svg/RenderSVGViewportContainer.h:
+ * rendering/svg/SVGInlineTextBox.h:
+ * rendering/svg/SVGRootInlineBox.h:
+
</ins><span class="cx"> 2014-10-22 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r175000): Crash in SourceBufferPrivateAVFObjC::destroyParser()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: Find a way to cascade appearance and adjust heights, and get rid of this class.
</span><span class="cx"> // http://webkit.org/b/62535
</span><del>-class RenderSliderContainer : public RenderFlexibleBox {
</del><ins>+class RenderSliderContainer final : public RenderFlexibleBox {
</ins><span class="cx"> public:
</span><span class="cx"> RenderSliderContainer(SliderContainerElement& element, PassRef<RenderStyle> style)
</span><span class="cx"> : RenderFlexibleBox(element, WTF::move(style))
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingAutoTableLayouth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/AutoTableLayout.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/AutoTableLayout.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/AutoTableLayout.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> class RenderTable;
</span><span class="cx"> class RenderTableCell;
</span><span class="cx">
</span><del>-class AutoTableLayout : public TableLayout {
</del><ins>+class AutoTableLayout final : public TableLayout {
</ins><span class="cx"> public:
</span><span class="cx"> explicit AutoTableLayout(RenderTable*);
</span><span class="cx"> virtual ~AutoTableLayout();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingClipPathOperationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/ClipPathOperation.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/ClipPathOperation.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/ClipPathOperation.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -52,8 +52,8 @@
</span><span class="cx"> virtual bool operator==(const ClipPathOperation&) const = 0;
</span><span class="cx"> bool operator!=(const ClipPathOperation& o) const { return !(*this == o); }
</span><span class="cx">
</span><del>- virtual OperationType type() const { return m_type; }
- virtual bool isSameType(const ClipPathOperation& o) const { return o.type() == m_type; }
</del><ins>+ OperationType type() const { return m_type; }
+ bool isSameType(const ClipPathOperation& o) const { return o.type() == m_type; }
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> explicit ClipPathOperation(OperationType type)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> OperationType m_type;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class ReferenceClipPathOperation : public ClipPathOperation {
</del><ins>+class ReferenceClipPathOperation final : public ClipPathOperation {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<ReferenceClipPathOperation> create(const String& url, const String& fragment)
</span><span class="cx"> {
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> String m_fragment;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class ShapeClipPathOperation : public ClipPathOperation {
</del><ins>+class ShapeClipPathOperation final : public ClipPathOperation {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<ShapeClipPathOperation> create(PassRef<BasicShape> shape)
</span><span class="cx"> {
</span><span class="lines">@@ -133,7 +133,7 @@
</span><span class="cx"> CSSBoxType m_referenceBox;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class BoxClipPathOperation : public ClipPathOperation {
</del><ins>+class BoxClipPathOperation final : public ClipPathOperation {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<BoxClipPathOperation> create(CSSBoxType referenceBox)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingEllipsisBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/EllipsisBox.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/EllipsisBox.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/EllipsisBox.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> class EllipsisBox final : public InlineElementBox {
</span><span class="cx"> public:
</span><span class="cx"> EllipsisBox(RenderBlockFlow&, const AtomicString& ellipsisStr, InlineFlowBox* parent, int width, int height, int y, bool firstLine, bool isVertical, InlineBox* markupBox);
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;
</ins><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) override;
</span><span class="cx"> void setSelectionState(RenderObject::SelectionState s) { m_selectionState = s; }
</span><span class="cx"> IntRect selectionRect();
</span><span class="lines">@@ -40,8 +40,8 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void paintMarkupBox(PaintInfo&, const LayoutPoint& paintOffset, LayoutUnit lineTop, LayoutUnit lineBottom, const RenderStyle&);
</span><del>- virtual int height() const { return m_height; }
- virtual RenderObject::SelectionState selectionState() { return m_selectionState; }
</del><ins>+ int height() const { return m_height; }
+ virtual RenderObject::SelectionState selectionState() override { return m_selectionState; }
</ins><span class="cx"> void paintSelection(GraphicsContext*, const LayoutPoint&, const RenderStyle&, const Font&);
</span><span class="cx"> InlineBox* markupBox() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingFixedTableLayouth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/FixedTableLayout.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/FixedTableLayout.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/FixedTableLayout.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -30,13 +30,13 @@
</span><span class="cx">
</span><span class="cx"> class RenderTable;
</span><span class="cx">
</span><del>-class FixedTableLayout : public TableLayout {
</del><ins>+class FixedTableLayout final : public TableLayout {
</ins><span class="cx"> public:
</span><span class="cx"> explicit FixedTableLayout(RenderTable*);
</span><span class="cx">
</span><span class="cx"> virtual void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidth) override;
</span><span class="cx"> virtual void applyPreferredLogicalWidthQuirks(LayoutUnit& minWidth, LayoutUnit& maxWidth) const override;
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> int calcWidthArray();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineElementBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineElementBox.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineElementBox.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/InlineElementBox.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -44,9 +44,9 @@
</span><span class="cx">
</span><span class="cx"> RenderBoxModelObject& renderer() const { return downcast<RenderBoxModelObject>(InlineBox::renderer()); }
</span><span class="cx">
</span><del>- virtual void deleteLine() override;
- virtual void extractLine() override;
- virtual void attachLine() override;
</del><ins>+ virtual void deleteLine() override final;
+ virtual void extractLine() override final;
+ virtual void attachLine() override final;
</ins><span class="cx">
</span><span class="cx"> virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;
</span><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -280,7 +280,7 @@
</span><span class="cx"> RenderMultiColumnFlowThread* multiColumnFlowThread() const { return hasRareBlockFlowData() ? rareBlockFlowData()->m_multiColumnFlowThread : nullptr; }
</span><span class="cx"> void setMultiColumnFlowThread(RenderMultiColumnFlowThread*);
</span><span class="cx">
</span><del>- bool containsFloats() const override { return m_floatingObjects && !m_floatingObjects->set().isEmpty(); }
</del><ins>+ virtual bool containsFloats() const override { return m_floatingObjects && !m_floatingObjects->set().isEmpty(); }
</ins><span class="cx"> bool containsFloat(RenderBox&) const;
</span><span class="cx">
</span><span class="cx"> virtual void deleteLines() override;
</span><span class="lines">@@ -376,8 +376,8 @@
</span><span class="cx"> LayoutUnit logicalHeightForChildForFragmentation(const RenderBox& child) const;
</span><span class="cx"> bool hasNextPage(LayoutUnit logicalOffset, PageBoundaryRule = ExcludePageBoundary) const;
</span><span class="cx">
</span><del>- void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) override;
- RenderObject* removeChild(RenderObject&) override;
</del><ins>+ virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) override;
+ virtual RenderObject* removeChild(RenderObject&) override;
</ins><span class="cx">
</span><span class="cx"> void createMultiColumnFlowThread();
</span><span class="cx"> void destroyMultiColumnFlowThread();
</span><span class="lines">@@ -450,8 +450,8 @@
</span><span class="cx"> LayoutUnit computedColumnWidth() const;
</span><span class="cx"> unsigned computedColumnCount() const;
</span><span class="cx">
</span><del>- bool isTopLayoutOverflowAllowed() const override;
- bool isLeftLayoutOverflowAllowed() const override;
</del><ins>+ virtual bool isTopLayoutOverflowAllowed() const override;
+ virtual bool isLeftLayoutOverflowAllowed() const override;
</ins><span class="cx">
</span><span class="cx"> void moveFloatsTo(RenderBlockFlow* toBlock);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderCombineTexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderCombineText.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderCombineText.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderCombineText.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -45,10 +45,10 @@
</span><span class="cx"> private:
</span><span class="cx"> void node() const = delete;
</span><span class="cx">
</span><del>- virtual bool isCombineText() const { return true; }
- virtual float width(unsigned from, unsigned length, const Font&, float xPosition, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const;
- virtual const char* renderName() const { return "RenderCombineText"; }
- virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
</del><ins>+ virtual bool isCombineText() const override { return true; }
+ virtual float width(unsigned from, unsigned length, const Font&, float xPosition, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const override;
+ virtual const char* renderName() const override { return "RenderCombineText"; }
+ virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</ins><span class="cx"> virtual void setRenderedText(const String&) override;
</span><span class="cx">
</span><span class="cx"> RefPtr<RenderStyle> m_combineFontStyle;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderCounterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderCounter.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderCounter.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderCounter.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -43,12 +43,12 @@
</span><span class="cx"> void updateCounter();
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void willBeDestroyed();
</del><ins>+ virtual void willBeDestroyed() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual const char* renderName() const;
- virtual bool isCounter() const;
- virtual String originalText() const;
</del><ins>+ virtual const char* renderName() const override;
+ virtual bool isCounter() const override;
+ virtual String originalText() const override;
</ins><span class="cx">
</span><span class="cx"> virtual void computePreferredLogicalWidths(float leadWidth) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderDeprecatedFlexibleBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -36,22 +36,22 @@
</span><span class="cx">
</span><span class="cx"> Element& element() const { return downcast<Element>(nodeForNonAnonymous()); }
</span><span class="cx">
</span><del>- virtual const char* renderName() const;
</del><ins>+ virtual const char* renderName() const override;
</ins><span class="cx">
</span><span class="cx"> virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle) override;
</span><span class="cx">
</span><del>- virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageHeight = 0);
</del><ins>+ virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageHeight = 0) override;
</ins><span class="cx"> void layoutHorizontalBox(bool relayoutChildren);
</span><span class="cx"> void layoutVerticalBox(bool relayoutChildren);
</span><span class="cx">
</span><del>- virtual bool avoidsFloats() const { return true; }
- virtual bool isDeprecatedFlexibleBox() const { return true; }
- virtual bool isStretchingChildren() const { return m_stretchingChildren; }
</del><ins>+ virtual bool avoidsFloats() const override { return true; }
+ virtual bool isStretchingChildren() const override { return m_stretchingChildren; }
</ins><span class="cx"> virtual bool canCollapseAnonymousBlockChild() const override { return false; }
</span><span class="cx">
</span><span class="cx"> void placeChild(RenderBox* child, const LayoutPoint& location, LayoutSize* childLayoutDelta = 0);
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isDeprecatedFlexibleBox() const override { return true; }
</ins><span class="cx"> virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override;
</span><span class="cx"> virtual void computePreferredLogicalWidths() override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderFlexibleBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderFlexibleBox.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -44,7 +44,6 @@
</span><span class="cx">
</span><span class="cx"> virtual const char* renderName() const override;
</span><span class="cx">
</span><del>- virtual bool isFlexibleBox() const override final { return true; }
</del><span class="cx"> virtual bool avoidsFloats() const override final { return true; }
</span><span class="cx"> virtual bool canCollapseAnonymousBlockChild() const override final { return false; }
</span><span class="cx"> virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) override final;
</span><span class="lines">@@ -57,8 +56,8 @@
</span><span class="cx">
</span><span class="cx"> bool isHorizontalFlow() const;
</span><span class="cx">
</span><del>- bool isTopLayoutOverflowAllowed() const override;
- bool isLeftLayoutOverflowAllowed() const override;
</del><ins>+ virtual bool isTopLayoutOverflowAllowed() const override;
+ virtual bool isLeftLayoutOverflowAllowed() const override;
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override;
</span><span class="lines">@@ -86,6 +85,7 @@
</span><span class="cx"> // Use an inline capacity of 8, since flexbox containers usually have less than 8 children.
</span><span class="cx"> typedef Vector<LayoutRect, 8> ChildFrameRects;
</span><span class="cx">
</span><ins>+ virtual bool isFlexibleBox() const override final { return true; }
</ins><span class="cx"> bool hasOrthogonalFlow(RenderBox& child) const;
</span><span class="cx"> bool isColumnFlow() const;
</span><span class="cx"> bool isLeftToRightFlow() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderFullScreenh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderFullScreen.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderFullScreen.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderFullScreen.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -36,7 +36,6 @@
</span><span class="cx"> public:
</span><span class="cx"> RenderFullScreen(Document&, PassRef<RenderStyle>);
</span><span class="cx">
</span><del>- virtual bool isRenderFullScreen() const override { return true; }
</del><span class="cx"> virtual const char* renderName() const override { return "RenderFullScreen"; }
</span><span class="cx">
</span><span class="cx"> void setPlaceholder(RenderBlock*);
</span><span class="lines">@@ -47,6 +46,7 @@
</span><span class="cx"> void unwrapRenderer(bool& requiresRenderTreeRebuild);
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isRenderFullScreen() const override { return true; }
</ins><span class="cx"> virtual void willBeDestroyed() override;
</span><span class="cx">
</span><span class="cx"> protected:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderGridh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderGrid.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderGrid.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderGrid.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx">
</span><span class="cx"> LayoutUnit gridAreaBreadthForChild(const RenderBox& child, GridTrackSizingDirection, const Vector<GridTrack>&) const;
</span><span class="cx">
</span><del>- virtual void paintChildren(PaintInfo& forSelf, const LayoutPoint& paintOffset, PaintInfo& forChild, bool usePrintRect) override final;
</del><ins>+ virtual void paintChildren(PaintInfo& forSelf, const LayoutPoint& paintOffset, PaintInfo& forChild, bool usePrintRect) override;
</ins><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx"> bool tracksAreWiderThanMinTrackBreadth(GridTrackSizingDirection, const Vector<GridTrack>&);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -789,7 +789,7 @@
</span><span class="cx"> bool preserves3D() const { return renderer().style().transformStyle3D() == TransformStyle3DPreserve3D; }
</span><span class="cx"> bool has3DTransform() const { return m_transform && !m_transform->isAffine(); }
</span><span class="cx">
</span><del>- virtual void filterNeedsRepaint();
</del><ins>+ void filterNeedsRepaint();
</ins><span class="cx"> bool hasFilter() const { return renderer().hasFilter(); }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_COMPOSITING)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -219,7 +219,7 @@
</span><span class="cx"> virtual bool needsPixelAligment() const override { return !m_isMainFrameRenderViewLayer; }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><del>- virtual void verifyNotPainting();
</del><ins>+ virtual void verifyNotPainting() override;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT LayoutRect contentsBox() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -92,11 +92,11 @@
</span><span class="cx"> //
</span><span class="cx"> // There is one RenderLayerCompositor per RenderView.
</span><span class="cx">
</span><del>-class RenderLayerCompositor : public GraphicsLayerClient, public GraphicsLayerUpdaterClient {
</del><ins>+class RenderLayerCompositor final : public GraphicsLayerClient, public GraphicsLayerUpdaterClient {
</ins><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> explicit RenderLayerCompositor(RenderView&);
</span><del>- ~RenderLayerCompositor();
</del><ins>+ virtual ~RenderLayerCompositor();
</ins><span class="cx">
</span><span class="cx"> // Return true if this RenderView is in "compositing mode" (i.e. has one or more
</span><span class="cx"> // composited RenderLayers)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerFilterInfoh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> static void remove(RenderLayer&);
</span><span class="cx">
</span><span class="cx"> explicit FilterInfo(RenderLayer&);
</span><del>- ~FilterInfo();
</del><ins>+ virtual ~FilterInfo();
</ins><span class="cx">
</span><span class="cx"> const LayoutRect& dirtySourceRect() const { return m_dirtySourceRect; }
</span><span class="cx"> void expandDirtySourceRect(const LayoutRect& rect) { m_dirtySourceRect.unite(rect); }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLineBreakh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLineBreak.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLineBreak.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderLineBreak.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx"> void node() const = delete;
</span><span class="cx">
</span><span class="cx"> virtual bool canHaveChildren() const override { return false; }
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&) override final { }
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&) override { }
</ins><span class="cx">
</span><span class="cx"> virtual VisiblePosition positionForPoint(const LayoutPoint&, const RenderRegion*) override;
</span><span class="cx"> virtual int caretMinOffset() const override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMarqueeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMarquee.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMarquee.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderMarquee.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -53,11 +53,11 @@
</span><span class="cx"> class RenderLayer;
</span><span class="cx">
</span><span class="cx"> // This class handles the auto-scrolling of layers with overflow: marquee.
</span><del>-class RenderMarquee {
</del><ins>+class RenderMarquee final {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(RenderMarquee); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> explicit RenderMarquee(RenderLayer*);
</span><del>- virtual ~RenderMarquee();
</del><ins>+ ~RenderMarquee();
</ins><span class="cx">
</span><span class="cx"> int speed() const { return m_speed; }
</span><span class="cx"> int marqueeSpeed() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMediaControlElementsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMediaControlElements.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMediaControlElements.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderMediaControlElements.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> RenderMediaVolumeSliderContainer(Element&, PassRef<RenderStyle>);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> RenderMediaControlTimelineContainer(Element&, PassRef<RenderStyle>);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> RenderTextTrackContainerElement(Element&, PassRef<RenderStyle>);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> #endif // ENABLE(VIDEO_TRACK)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMultiColumnFlowThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -41,8 +41,6 @@
</span><span class="cx"> RenderMultiColumnFlowThread(Document&, PassRef<RenderStyle>);
</span><span class="cx"> ~RenderMultiColumnFlowThread();
</span><span class="cx">
</span><del>- virtual bool isRenderMultiColumnFlowThread() const override { return true; }
-
</del><span class="cx"> virtual void removeFlowChildInfo(RenderObject*) override;
</span><span class="cx">
</span><span class="cx"> RenderBlockFlow* multiColumnBlockFlow() const { return downcast<RenderBlockFlow>(parent()); }
</span><span class="lines">@@ -55,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> RenderMultiColumnSpannerPlaceholder* findColumnSpannerPlaceholder(RenderBox* spanner) const { return m_spannerMap.get(spanner); }
</span><span class="cx">
</span><del>- virtual void layout() override final;
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> // Find the set inside which the specified renderer would be rendered.
</span><span class="cx"> RenderMultiColumnSet* findSetRendering(RenderObject*) const;
</span><span class="lines">@@ -115,6 +113,7 @@
</span><span class="cx"> virtual bool shouldCheckColumnBreaks() const override;
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isRenderMultiColumnFlowThread() const override { return true; }
</ins><span class="cx"> virtual const char* renderName() const override;
</span><span class="cx"> virtual void addRegionToThread(RenderRegion*) override;
</span><span class="cx"> virtual void willBeRemovedFromTree() override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMultiColumnSeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSet.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -47,8 +47,6 @@
</span><span class="cx"> public:
</span><span class="cx"> RenderMultiColumnSet(RenderFlowThread&, PassRef<RenderStyle>);
</span><span class="cx">
</span><del>- virtual bool isRenderMultiColumnSet() const override { return true; }
-
</del><span class="cx"> RenderBlockFlow* multiColumnBlockFlow() const { return downcast<RenderBlockFlow>(parent()); }
</span><span class="cx"> RenderMultiColumnFlowThread* multiColumnFlowThread() const { return static_cast<RenderMultiColumnFlowThread*>(flowThread()); }
</span><span class="cx">
</span><span class="lines">@@ -131,9 +129,10 @@
</span><span class="cx"> unsigned columnCount() const;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- void addOverflowFromChildren() override;
</del><ins>+ virtual void addOverflowFromChildren() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isRenderMultiColumnSet() const override { return true; }
</ins><span class="cx"> virtual void layout() override;
</span><span class="cx">
</span><span class="cx"> virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;
</span><span class="lines">@@ -155,7 +154,7 @@
</span><span class="cx">
</span><span class="cx"> virtual VisiblePosition positionForPoint(const LayoutPoint&, const RenderRegion*) override;
</span><span class="cx">
</span><del>- virtual const char* renderName() const;
</del><ins>+ virtual const char* renderName() const override;
</ins><span class="cx">
</span><span class="cx"> LayoutUnit calculateMaxColumnHeight() const;
</span><span class="cx"> LayoutUnit columnGap() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMultiColumnSpannerPlaceholderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -40,15 +40,15 @@
</span><span class="cx"> public:
</span><span class="cx"> static RenderMultiColumnSpannerPlaceholder* createAnonymous(RenderMultiColumnFlowThread*, RenderBox* spanner, RenderStyle* parentStyle);
</span><span class="cx">
</span><del>- virtual bool isRenderMultiColumnSpannerPlaceholder() const override { return true; }
</del><span class="cx"> RenderBox* spanner() const { return m_spanner; }
</span><span class="cx"> RenderMultiColumnFlowThread* flowThread() const { return m_flowThread; }
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> RenderMultiColumnSpannerPlaceholder(RenderMultiColumnFlowThread*, RenderBox* spanner, PassRef<RenderStyle>);
</span><ins>+ virtual bool isRenderMultiColumnSpannerPlaceholder() const override { return true; }
</ins><span class="cx">
</span><del>- virtual bool canHaveChildren() const { return false; }
- virtual void paint(PaintInfo&, const LayoutPoint&) { }
</del><ins>+ virtual bool canHaveChildren() const override { return false; }
+ virtual void paint(PaintInfo&, const LayoutPoint&) override { }
</ins><span class="cx"> virtual const char* renderName() const override;
</span><span class="cx">
</span><span class="cx"> RenderBox* m_spanner;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderNamedFlowFragmenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -54,12 +54,11 @@
</span><span class="cx">
</span><span class="cx"> static PassRef<RenderStyle> createStyle(const RenderStyle& parentStyle);
</span><span class="cx">
</span><del>- virtual bool isRenderNamedFlowFragment() const override final { return true; }
</del><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</span><span class="cx">
</span><span class="cx"> void getRanges(Vector<RefPtr<Range>>&) const;
</span><span class="cx">
</span><del>- virtual LayoutUnit pageLogicalHeight() const;
</del><ins>+ virtual LayoutUnit pageLogicalHeight() const override;
</ins><span class="cx"> LayoutUnit maxPageLogicalHeight() const;
</span><span class="cx">
</span><span class="cx"> LayoutRect flowThreadPortionRectForClipping(bool isFirstRegionInRange, bool isLastRegionInRange) const;
</span><span class="lines">@@ -121,6 +120,7 @@
</span><span class="cx"> void invalidateRegionIfNeeded();
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isRenderNamedFlowFragment() const override { return true; }
</ins><span class="cx"> virtual const char* renderName() const override { return "RenderNamedFlowFragment"; }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<RenderStyle> computeStyleInRegion(RenderElement&, RenderStyle& parentStyle) const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderNamedFlowThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -83,7 +83,7 @@
</span><span class="cx"> bool isMarkedForDestruction() const;
</span><span class="cx"> void getRanges(Vector<RefPtr<Range>>&, const RenderNamedFlowFragment*) const;
</span><span class="cx">
</span><del>- virtual void applyBreakAfterContent(LayoutUnit) override final;
</del><ins>+ virtual void applyBreakAfterContent(LayoutUnit) override;
</ins><span class="cx">
</span><span class="cx"> virtual bool collectsGraphicsLayersUnderRegions() const override;
</span><span class="cx">
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx">
</span><span class="cx"> void clearRenderObjectCustomStyle(const RenderObject*);
</span><span class="cx">
</span><del>- virtual void removeFlowChildInfo(RenderObject*) override final;
</del><ins>+ virtual void removeFlowChildInfo(RenderObject*) override;
</ins><span class="cx">
</span><span class="cx"> LayoutUnit flowContentBottom() const { return m_flowContentBottom; }
</span><span class="cx"> void dispatchNamedFlowEvents();
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx"> virtual bool isRenderNamedFlowThread() const override { return true; }
</span><span class="cx"> virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const override;
</span><span class="cx"> virtual void computeOverflow(LayoutUnit, bool = false) override;
</span><del>- virtual void layout() override final;
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> void dispatchRegionOversetChangeEventIfNeeded();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderQuoteh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderQuote.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderQuote.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderQuote.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void willBeDestroyed() override;
</span><span class="cx"> virtual const char* renderName() const override { return "RenderQuote"; }
</span><del>- virtual bool isQuote() const override { return true; };
</del><ins>+ virtual bool isQuote() const override { return true; }
</ins><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle*) override;
</span><span class="cx"> virtual void willBeRemovedFromTree() override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderRegionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderRegion.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderRegion.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderRegion.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -48,8 +48,6 @@
</span><span class="cx">
</span><span class="cx"> class RenderRegion : public RenderBlockFlow {
</span><span class="cx"> public:
</span><del>- virtual bool isRenderRegion() const override final { return true; }
-
</del><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
</span><span class="cx">
</span><span class="cx"> void setFlowThreadPortionRect(const LayoutRect& rect) { m_flowThreadPortionRect = rect; }
</span><span class="lines">@@ -150,7 +148,8 @@
</span><span class="cx"> void computeOverflowFromFlowThread();
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual const char* renderName() const { return "RenderRegion"; }
</del><ins>+ virtual bool isRenderRegion() const override final { return true; }
+ virtual const char* renderName() const override { return "RenderRegion"; }
</ins><span class="cx">
</span><span class="cx"> virtual void insertedIntoTree() override;
</span><span class="cx"> virtual void willBeRemovedFromTree() override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderReplicah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderReplica.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderReplica.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderReplica.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -38,13 +38,13 @@
</span><span class="cx"> RenderReplica(Document&, PassRef<RenderStyle>);
</span><span class="cx"> virtual ~RenderReplica();
</span><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderReplica"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderReplica"; }
</ins><span class="cx">
</span><del>- virtual bool requiresLayer() const { return true; }
</del><ins>+ virtual bool requiresLayer() const override { return true; }
</ins><span class="cx">
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&);
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual bool isReplica() const override { return true; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderRubyBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderRubyBase.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderRubyBase.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderRubyBase.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -42,14 +42,13 @@
</span><span class="cx"> RenderRubyBase(Document&, PassRef<RenderStyle>);
</span><span class="cx"> virtual ~RenderRubyBase();
</span><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderRubyBase (anonymous)"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderRubyBase (anonymous)"; }
</ins><span class="cx">
</span><del>- virtual bool isRubyBase() const { return true; }
-
</del><span class="cx"> private:
</span><del>- virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const;
- virtual ETextAlign textAlignmentForLine(bool endsWithSoftBreak) const;
- virtual void adjustInlineDirectionLineBounds(int expansionOpportunityCount, float& logicalLeft, float& logicalWidth) const;
</del><ins>+ virtual bool isRubyBase() const override { return true; }
+ virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const override;
+ virtual ETextAlign textAlignmentForLine(bool endsWithSoftBreak) const override;
+ virtual void adjustInlineDirectionLineBounds(int expansionOpportunityCount, float& logicalLeft, float& logicalWidth) const override;
</ins><span class="cx"> void mergeChildrenWithBase(RenderRubyBase* toBlock);
</span><span class="cx">
</span><span class="cx"> void moveChildren(RenderRubyBase* toBase, RenderObject* beforeChild = 0);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderRubyRunh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderRubyRun.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderRubyRun.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderRubyRun.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -48,20 +48,20 @@
</span><span class="cx">
</span><span class="cx"> bool hasRubyText() const;
</span><span class="cx"> bool hasRubyBase() const;
</span><del>- bool isEmpty() const;
</del><ins>+ virtual bool isEmpty() const override;
</ins><span class="cx"> RenderRubyText* rubyText() const;
</span><span class="cx"> RenderRubyBase* rubyBase() const;
</span><span class="cx"> RenderRubyBase* rubyBaseSafe(); // creates the base if it doesn't already exist
</span><span class="cx">
</span><del>- virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren);
- virtual void layout();
</del><ins>+ virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren) override;
+ virtual void layout() override;
</ins><span class="cx">
</span><del>- virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const;
- virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0);
</del><ins>+ virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const override;
+ virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) override;
</ins><span class="cx"> virtual RenderObject* removeChild(RenderObject&) override;
</span><span class="cx">
</span><del>- virtual RenderBlock* firstLineBlock() const;
- virtual void updateFirstLetter();
</del><ins>+ virtual RenderBlock* firstLineBlock() const override;
+ virtual void updateFirstLetter() override;
</ins><span class="cx">
</span><span class="cx"> void getOverhang(bool firstLine, RenderObject* startRenderer, RenderObject* endRenderer, int& startOverhang, int& endOverhang) const;
</span><span class="cx">
</span><span class="lines">@@ -71,10 +71,10 @@
</span><span class="cx"> RenderRubyBase* createRubyBase() const;
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual bool isRubyRun() const { return true; }
- virtual const char* renderName() const { return "RenderRubyRun (anonymous)"; }
- virtual bool createsAnonymousWrapper() const { return true; }
- virtual void removeLeftoverAnonymousBlock(RenderBlock*) { }
</del><ins>+ virtual bool isRubyRun() const override { return true; }
+ virtual const char* renderName() const override { return "RenderRubyRun (anonymous)"; }
+ virtual bool createsAnonymousWrapper() const override { return true; }
+ virtual void removeLeftoverAnonymousBlock(RenderBlock*) override { }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderScrollbarh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderScrollbar.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderScrollbar.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderScrollbar.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">
</span><span class="cx"> int minimumThumbLength();
</span><span class="cx">
</span><del>- virtual bool isOverlayScrollbar() const { return false; }
</del><ins>+ virtual bool isOverlayScrollbar() const override { return false; }
</ins><span class="cx">
</span><span class="cx"> float opacity();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderScrollbarParth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderScrollbarPart.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderScrollbarPart.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -39,11 +39,11 @@
</span><span class="cx">
</span><span class="cx"> virtual ~RenderScrollbarPart();
</span><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderScrollbarPart"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderScrollbarPart"; }
</ins><span class="cx">
</span><del>- virtual bool requiresLayer() const { return false; }
</del><ins>+ virtual bool requiresLayer() const override { return false; }
</ins><span class="cx">
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> void paintIntoRect(GraphicsContext*, const LayoutPoint&, const LayoutRect&);
</span><span class="cx">
</span><span class="lines">@@ -53,15 +53,15 @@
</span><span class="cx"> virtual LayoutUnit marginLeft() const override { ASSERT(isIntegerValue(m_marginBox.left())); return m_marginBox.left(); }
</span><span class="cx"> virtual LayoutUnit marginRight() const override { ASSERT(isIntegerValue(m_marginBox.right())); return m_marginBox.right(); }
</span><span class="cx">
</span><del>- virtual bool isRenderScrollbarPart() const { return true; }
</del><span class="cx"> RenderBox* rendererOwningScrollbar() const;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
- virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);
</del><ins>+ virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
+ virtual void imageChanged(WrappedImagePtr, const IntRect* = nullptr) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual void computePreferredLogicalWidths();
</del><ins>+ virtual bool isRenderScrollbarPart() const override { return true; }
+ virtual void computePreferredLogicalWidths() override;
</ins><span class="cx">
</span><span class="cx"> void layoutHorizontalPart();
</span><span class="cx"> void layoutVerticalPart();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderScrollbarThemeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderScrollbarTheme.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderScrollbarTheme.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderScrollbarTheme.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -34,51 +34,51 @@
</span><span class="cx"> class Scrollbar;
</span><span class="cx"> class ScrollView;
</span><span class="cx">
</span><del>-class RenderScrollbarTheme : public ScrollbarThemeComposite {
</del><ins>+class RenderScrollbarTheme final : public ScrollbarThemeComposite {
</ins><span class="cx"> public:
</span><del>- virtual ~RenderScrollbarTheme() {};
</del><ins>+ virtual ~RenderScrollbarTheme() { }
</ins><span class="cx">
</span><del>- virtual int scrollbarThickness(ScrollbarControlSize controlSize) { return ScrollbarTheme::theme()->scrollbarThickness(controlSize); }
</del><ins>+ virtual int scrollbarThickness(ScrollbarControlSize controlSize) override { return ScrollbarTheme::theme()->scrollbarThickness(controlSize); }
</ins><span class="cx">
</span><del>- virtual ScrollbarButtonsPlacement buttonsPlacement() const { return ScrollbarTheme::theme()->buttonsPlacement(); }
</del><ins>+ virtual ScrollbarButtonsPlacement buttonsPlacement() const override { return ScrollbarTheme::theme()->buttonsPlacement(); }
</ins><span class="cx">
</span><del>- virtual bool supportsControlTints() const { return true; }
</del><ins>+ virtual bool supportsControlTints() const override { return true; }
</ins><span class="cx">
</span><del>- virtual void paintScrollCorner(ScrollView*, GraphicsContext* context, const IntRect& cornerRect);
</del><ins>+ virtual void paintScrollCorner(ScrollView*, GraphicsContext*, const IntRect& cornerRect) override;
</ins><span class="cx">
</span><del>- virtual bool shouldCenterOnThumb(ScrollbarThemeClient* scrollbar, const PlatformMouseEvent& event) { return ScrollbarTheme::theme()->shouldCenterOnThumb(scrollbar, event); }
</del><ins>+ virtual bool shouldCenterOnThumb(ScrollbarThemeClient* scrollbar, const PlatformMouseEvent& event) override { return ScrollbarTheme::theme()->shouldCenterOnThumb(scrollbar, event); }
</ins><span class="cx">
</span><del>- virtual double initialAutoscrollTimerDelay() { return ScrollbarTheme::theme()->initialAutoscrollTimerDelay(); }
- virtual double autoscrollTimerDelay() { return ScrollbarTheme::theme()->autoscrollTimerDelay(); }
</del><ins>+ virtual double initialAutoscrollTimerDelay() override { return ScrollbarTheme::theme()->initialAutoscrollTimerDelay(); }
+ virtual double autoscrollTimerDelay() override { return ScrollbarTheme::theme()->autoscrollTimerDelay(); }
</ins><span class="cx">
</span><del>- virtual void registerScrollbar(ScrollbarThemeClient* scrollbar) { return ScrollbarTheme::theme()->registerScrollbar(scrollbar); }
- virtual void unregisterScrollbar(ScrollbarThemeClient* scrollbar) { return ScrollbarTheme::theme()->unregisterScrollbar(scrollbar); }
</del><ins>+ virtual void registerScrollbar(ScrollbarThemeClient* scrollbar) override { return ScrollbarTheme::theme()->registerScrollbar(scrollbar); }
+ virtual void unregisterScrollbar(ScrollbarThemeClient* scrollbar) override { return ScrollbarTheme::theme()->unregisterScrollbar(scrollbar); }
</ins><span class="cx">
</span><del>- virtual int minimumThumbLength(ScrollbarThemeClient*);
</del><ins>+ virtual int minimumThumbLength(ScrollbarThemeClient*) override;
</ins><span class="cx">
</span><span class="cx"> void buttonSizesAlongTrackAxis(ScrollbarThemeClient*, int& beforeSize, int& afterSize);
</span><span class="cx">
</span><span class="cx"> static RenderScrollbarTheme* renderScrollbarTheme();
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual bool hasButtons(ScrollbarThemeClient*);
- virtual bool hasThumb(ScrollbarThemeClient*);
</del><ins>+ virtual bool hasButtons(ScrollbarThemeClient*) override;
+ virtual bool hasThumb(ScrollbarThemeClient*) override;
</ins><span class="cx">
</span><del>- virtual IntRect backButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false);
- virtual IntRect forwardButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false);
- virtual IntRect trackRect(ScrollbarThemeClient*, bool painting = false);
</del><ins>+ virtual IntRect backButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;
+ virtual IntRect forwardButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;
+ virtual IntRect trackRect(ScrollbarThemeClient*, bool painting = false) override;
</ins><span class="cx">
</span><span class="cx"> virtual void willPaintScrollbar(GraphicsContext*, ScrollbarThemeClient*) override;
</span><span class="cx"> virtual void didPaintScrollbar(GraphicsContext*, ScrollbarThemeClient*) override;
</span><span class="cx">
</span><del>- virtual void paintScrollbarBackground(GraphicsContext*, ScrollbarThemeClient*);
- virtual void paintTrackBackground(GraphicsContext*, ScrollbarThemeClient*, const IntRect&);
- virtual void paintTrackPiece(GraphicsContext*, ScrollbarThemeClient*, const IntRect&, ScrollbarPart);
- virtual void paintButton(GraphicsContext*, ScrollbarThemeClient*, const IntRect&, ScrollbarPart);
- virtual void paintThumb(GraphicsContext*, ScrollbarThemeClient*, const IntRect&);
</del><ins>+ virtual void paintScrollbarBackground(GraphicsContext*, ScrollbarThemeClient*) override;
+ virtual void paintTrackBackground(GraphicsContext*, ScrollbarThemeClient*, const IntRect&) override;
+ virtual void paintTrackPiece(GraphicsContext*, ScrollbarThemeClient*, const IntRect&, ScrollbarPart) override;
+ virtual void paintButton(GraphicsContext*, ScrollbarThemeClient*, const IntRect&, ScrollbarPart) override;
+ virtual void paintThumb(GraphicsContext*, ScrollbarThemeClient*, const IntRect&) override;
</ins><span class="cx"> virtual void paintTickmarks(GraphicsContext*, ScrollbarThemeClient*, const IntRect&) override;
</span><span class="cx">
</span><del>- virtual IntRect constrainTrackRectToTrackPieces(ScrollbarThemeClient*, const IntRect&);
</del><ins>+ virtual IntRect constrainTrackRectToTrackPieces(ScrollbarThemeClient*, const IntRect&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderSnapshottedPlugInh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -49,11 +49,11 @@
</span><span class="cx"> void frameOwnerElement() const = delete;
</span><span class="cx"> virtual const char* renderName() const { return "RenderSnapshottedPlugIn"; }
</span><span class="cx">
</span><del>- virtual CursorDirective getCursor(const LayoutPoint&, Cursor&) const override final;
- virtual bool isSnapshottedPlugIn() const override final { return true; }
</del><ins>+ virtual CursorDirective getCursor(const LayoutPoint&, Cursor&) const override;
+ virtual bool isSnapshottedPlugIn() const override { return true; }
</ins><span class="cx"> virtual void paint(PaintInfo&, const LayoutPoint&) override;
</span><span class="cx">
</span><del>- virtual bool canHaveWidget() const override final { return false; }
</del><ins>+ virtual bool canHaveWidget() const override { return false; }
</ins><span class="cx">
</span><span class="cx"> void paintSnapshot(PaintInfo&, const LayoutPoint&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTextControlMultiLineh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTextControlMultiLine.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTextControlMultiLine.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderTextControlMultiLine.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -38,17 +38,17 @@
</span><span class="cx"> private:
</span><span class="cx"> void element() const = delete;
</span><span class="cx">
</span><del>- virtual bool isTextArea() const { return true; }
</del><ins>+ virtual bool isTextArea() const override { return true; }
</ins><span class="cx">
</span><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
</span><span class="cx">
</span><del>- virtual float getAverageCharWidth();
- virtual LayoutUnit preferredContentLogicalWidth(float charWidth) const;
</del><ins>+ virtual float getAverageCharWidth() override;
+ virtual LayoutUnit preferredContentLogicalWidth(float charWidth) const override;
</ins><span class="cx"> virtual LayoutUnit computeControlLogicalHeight(LayoutUnit lineHeight, LayoutUnit nonContentHeight) const override;
</span><del>- virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const;
</del><ins>+ virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override;
</ins><span class="cx">
</span><del>- virtual PassRef<RenderStyle> createInnerTextStyle(const RenderStyle* startStyle) const;
- virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren);
</del><ins>+ virtual PassRef<RenderStyle> createInnerTextStyle(const RenderStyle* startStyle) const override;
+ virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTextFragmenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTextFragment.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTextFragment.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderTextFragment.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -39,8 +39,6 @@
</span><span class="cx">
</span><span class="cx"> virtual ~RenderTextFragment();
</span><span class="cx">
</span><del>- virtual bool isTextFragment() const override { return true; }
-
</del><span class="cx"> virtual bool canBeSelectionLeaf() const override;
</span><span class="cx">
</span><span class="cx"> unsigned start() const { return m_start; }
</span><span class="lines">@@ -59,6 +57,7 @@
</span><span class="cx"> void setAltText(const String& altText) { m_altText = altText; }
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isTextFragment() const override { return true; }
</ins><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</span><span class="cx"> virtual void willBeDestroyed() override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeGtkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeGtk.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -116,10 +116,10 @@
</span><span class="cx"> virtual bool paintTextField(const RenderObject&, const PaintInfo&, const FloatRect&) override;
</span><span class="cx"> virtual bool paintTextArea(const RenderObject&, const PaintInfo&, const FloatRect&) override;
</span><span class="cx">
</span><del>- int popupInternalPaddingLeft(RenderStyle&) const override;
- int popupInternalPaddingRight(RenderStyle&) const override;
- int popupInternalPaddingTop(RenderStyle&) const override;
- int popupInternalPaddingBottom(RenderStyle&) const override;
</del><ins>+ virtual int popupInternalPaddingLeft(RenderStyle&) const override;
+ virtual int popupInternalPaddingRight(RenderStyle&) const override;
+ virtual int popupInternalPaddingTop(RenderStyle&) const override;
+ virtual int popupInternalPaddingBottom(RenderStyle&) const override;
</ins><span class="cx">
</span><span class="cx"> // The Mac port differentiates between the "menu list" and the "menu list button."
</span><span class="cx"> // The former is used when a menu list button has been styled. This is used to ensure
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeIOS.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> class RenderStyle;
</span><span class="cx"> class GraphicsContext;
</span><span class="cx">
</span><del>-class RenderThemeIOS : public RenderTheme {
</del><ins>+class RenderThemeIOS final : public RenderTheme {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<RenderTheme> create();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeWinh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeWin.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeWin.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -47,12 +47,12 @@
</span><span class="cx"> unsigned m_classicState;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class RenderThemeWin : public RenderTheme {
</del><ins>+class RenderThemeWin final: public RenderTheme {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<RenderTheme> create();
</span><span class="cx">
</span><del>- virtual String extraDefaultStyleSheet();
- virtual String extraQuirksStyleSheet();
</del><ins>+ virtual String extraDefaultStyleSheet() override;
+ virtual String extraQuirksStyleSheet() override;
</ins><span class="cx">
</span><span class="cx"> // A method asking if the theme's controls actually care about redrawing when hovered.
</span><span class="cx"> virtual bool supportsHover(const RenderStyle&) const override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderVideoh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderVideo.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderVideo.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/RenderVideo.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -50,37 +50,37 @@
</span><span class="cx">
</span><span class="cx"> bool requiresImmediateCompositing() const;
</span><span class="cx">
</span><del>- virtual bool shouldDisplayVideo() const;
</del><ins>+ bool shouldDisplayVideo() const;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void mediaElement() const = delete;
</span><span class="cx">
</span><del>- virtual void updateFromElement();
</del><ins>+ virtual void updateFromElement() override;
</ins><span class="cx">
</span><del>- virtual void intrinsicSizeChanged();
</del><ins>+ virtual void intrinsicSizeChanged() override;
</ins><span class="cx"> LayoutSize calculateIntrinsicSize();
</span><span class="cx"> void updateIntrinsicSize();
</span><span class="cx">
</span><del>- virtual void imageChanged(WrappedImagePtr, const IntRect*);
</del><ins>+ virtual void imageChanged(WrappedImagePtr, const IntRect*) override;
</ins><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderVideo"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderVideo"; }
</ins><span class="cx">
</span><del>- virtual bool requiresLayer() const { return true; }
- virtual bool isVideo() const { return true; }
</del><ins>+ virtual bool requiresLayer() const override { return true; }
+ virtual bool isVideo() const override { return true; }
</ins><span class="cx">
</span><del>- virtual void paintReplaced(PaintInfo&, const LayoutPoint&);
</del><ins>+ virtual void paintReplaced(PaintInfo&, const LayoutPoint&) override;
</ins><span class="cx">
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = ComputeActual) const override;
</span><del>- virtual LayoutUnit computeReplacedLogicalHeight() const;
</del><ins>+ virtual LayoutUnit computeReplacedLogicalHeight() const override;
</ins><span class="cx"> virtual LayoutUnit minimumReplacedHeight() const override;
</span><span class="cx">
</span><span class="cx"> #if ENABLE(FULLSCREEN_API)
</span><del>- virtual LayoutUnit offsetLeft() const;
- virtual LayoutUnit offsetTop() const;
- virtual LayoutUnit offsetWidth() const;
- virtual LayoutUnit offsetHeight() const;
</del><ins>+ virtual LayoutUnit offsetLeft() const override;
+ virtual LayoutUnit offsetTop() const override;
+ virtual LayoutUnit offsetWidth() const override;
+ virtual LayoutUnit offsetHeight() const override;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> void updatePlayer();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingTextAutosizerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/TextAutosizer.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/TextAutosizer.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/TextAutosizer.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -41,12 +41,12 @@
</span><span class="cx"> struct TextAutosizingWindowInfo;
</span><span class="cx"> struct TextAutosizingClusterInfo;
</span><span class="cx">
</span><del>-class TextAutosizer {
</del><ins>+class TextAutosizer final {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(TextAutosizer);
</span><span class="cx">
</span><span class="cx"> public:
</span><span class="cx"> explicit TextAutosizer(Document*);
</span><del>- virtual ~TextAutosizer();
</del><ins>+ ~TextAutosizer();
</ins><span class="cx">
</span><span class="cx"> bool processSubtree(RenderObject* layoutRoot);
</span><span class="cx"> void recalculateMultipliers();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingTrailingFloatsRootInlineBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/TrailingFloatsRootInlineBox.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/TrailingFloatsRootInlineBox.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/TrailingFloatsRootInlineBox.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual float virtualLogicalHeight() const { return 0; }
</del><ins>+ virtual float virtualLogicalHeight() const override { return 0; }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLBlockh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -79,7 +79,7 @@
</span><span class="cx"> virtual int firstLineBaseline() const override;
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual bool isRenderMathMLTable() const override final { return true; }
</del><ins>+ virtual bool isRenderMathMLTable() const override { return true; }
</ins><span class="cx"> virtual const char* renderName() const override { return "RenderMathMLTable"; }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLMencloseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLMenclose.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLMenclose.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLMenclose.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> RenderMathMLMenclose(Element&, PassRef<RenderStyle>);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual const char* renderName() const { return "RenderMathMLMenclose"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderMathMLMenclose"; }
</ins><span class="cx"> virtual void paint(PaintInfo&, const LayoutPoint&) override;
</span><span class="cx"> virtual void updateLogicalHeight() override;
</span><span class="cx"> virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = nullptr) override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLOperatorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -72,12 +72,12 @@
</span><span class="cx"> // FIXME: The displaystyle property is not implemented (https://bugs.webkit.org/show_bug.cgi?id=118737).
</span><span class="cx"> bool isLargeOperatorInDisplayStyle() const { return !hasOperatorFlag(MathMLOperatorDictionary::Stretchy) && hasOperatorFlag(MathMLOperatorDictionary::LargeOp); }
</span><span class="cx">
</span><del>- void updateStyle() override final;
</del><ins>+ virtual void updateStyle() override final;
</ins><span class="cx">
</span><span class="cx"> virtual void paint(PaintInfo&, const LayoutPoint&);
</span><span class="cx">
</span><span class="cx"> void updateTokenContent(const String& operatorString);
</span><del>- void updateTokenContent() override final;
</del><ins>+ virtual void updateTokenContent() override final;
</ins><span class="cx"> void updateOperatorProperties();
</span><span class="cx"> void setOperatorFlagAndScheduleLayoutIfNeeded(MathMLOperatorDictionary::Flag, const AtomicString& attributeValue);
</span><span class="cx"> LayoutUnit trailingSpaceError();
</span><span class="lines">@@ -157,7 +157,7 @@
</span><span class="cx"> virtual int firstLineBaseline() const override;
</span><span class="cx"> virtual RenderMathMLOperator* unembellishedOperator() override { return this; }
</span><span class="cx"> void rebuildTokenContent(const String& operatorString);
</span><del>- void updateFromElement() override;
</del><ins>+ virtual void updateFromElement() override;
</ins><span class="cx">
</span><span class="cx"> bool shouldAllowStretching() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLRadicalOperatorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLRadicalOperator.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLRadicalOperator.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLRadicalOperator.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> class RenderMathMLRadicalOperator final : public RenderMathMLOperator {
</span><span class="cx"> public:
</span><span class="cx"> RenderMathMLRadicalOperator(Document&, PassRef<RenderStyle>);
</span><del>- virtual void stretchTo(LayoutUnit heightAboveBaseline, LayoutUnit depthBelowBaseline);
</del><ins>+ virtual void stretchTo(LayoutUnit heightAboveBaseline, LayoutUnit depthBelowBaseline) override;
</ins><span class="cx"> virtual void computePreferredLogicalWidths() override;
</span><span class="cx"> virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;
</span><span class="cx"> virtual void paint(PaintInfo&, const LayoutPoint& paintOffset) override;
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> private:
</span><span class="cx"> virtual bool isRenderMathMLRadicalOperator() const override { return true; }
</span><span class="cx"> virtual const char* renderName() const override { return isAnonymous() ? "RenderMathMLRadicalOperator (anonymous)" : "RenderMathMLRadicalOperator"; }
</span><del>- void setOperatorProperties() override;
</del><ins>+ virtual void setOperatorProperties() override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // These are specific wrappers for the index and base, that ask the parent to restructure the renderers after child removal.
</span><del>-class RenderMathMLRootWrapper : public RenderMathMLRow {
</del><ins>+class RenderMathMLRootWrapper final : public RenderMathMLRow {
</ins><span class="cx">
</span><span class="cx"> friend class RenderMathMLRoot;
</span><span class="cx">
</span><span class="lines">@@ -83,9 +83,9 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> RenderObject* removeChildWithoutRestructuring(RenderObject&);
</span><del>- RenderObject* removeChild(RenderObject&) override;
</del><ins>+ virtual RenderObject* removeChild(RenderObject&) override;
</ins><span class="cx"> static RenderPtr<RenderMathMLRootWrapper> createAnonymousWrapper(RenderMathMLRoot* renderObject);
</span><del>- virtual bool isRenderMathMLRootWrapper() const override final { return true; }
</del><ins>+ virtual bool isRenderMathMLRootWrapper() const override { return true; }
</ins><span class="cx"> virtual const char* renderName() const override { return "RenderMathMLRootWrapper"; }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLRowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> void updateOperatorProperties();
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual bool isRenderMathMLRow() const override final { return true; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLScriptsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLScripts.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLScripts.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLScripts.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderMathMLScripts;
</span><span class="cx">
</span><del>-class RenderMathMLScriptsWrapper : public RenderMathMLBlock {
</del><ins>+class RenderMathMLScriptsWrapper final : public RenderMathMLBlock {
</ins><span class="cx">
</span><span class="cx"> friend class RenderMathMLScripts;
</span><span class="cx">
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // Render a base with scripts.
</span><del>-class RenderMathMLScripts : public RenderMathMLBlock {
</del><ins>+class RenderMathMLScripts final : public RenderMathMLBlock {
</ins><span class="cx">
</span><span class="cx"> friend class RenderMathMLScriptsWrapper;
</span><span class="cx">
</span><span class="lines">@@ -75,17 +75,17 @@
</span><span class="cx"> virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) override;
</span><span class="cx"> virtual RenderObject* removeChild(RenderObject&) override;
</span><span class="cx">
</span><del>- virtual RenderMathMLOperator* unembellishedOperator();
</del><ins>+ virtual RenderMathMLOperator* unembellishedOperator() override;
</ins><span class="cx"> virtual int firstLineBaseline() const override;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void addChildInternal(bool normalInsertion, RenderObject* child, RenderObject* beforeChild = 0);
</span><span class="cx"> RenderObject* removeChildInternal(bool normalRemoval, RenderObject& child);
</span><span class="cx">
</span><del>- virtual bool isRenderMathMLScripts() const override final { return true; }
</del><ins>+ virtual bool isRenderMathMLScripts() const override { return true; }
</ins><span class="cx"> virtual const char* renderName() const override { return "RenderMathMLScripts"; }
</span><span class="cx">
</span><span class="cx"> void fixAnonymousStyleForSubSupPair(RenderObject* subSupPair, bool isPostScript);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLTokenh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -41,16 +41,16 @@
</span><span class="cx">
</span><span class="cx"> MathMLTextElement& element() { return static_cast<MathMLTextElement&>(nodeForNonAnonymous()); }
</span><span class="cx">
</span><del>- virtual bool isRenderMathMLToken() const override final { return true; }
</del><span class="cx"> virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const override { return true; };
</span><span class="cx"> virtual void addChild(RenderObject* newChild, RenderObject* beforeChild) override;
</span><span class="cx"> virtual void updateTokenContent();
</span><del>- void updateFromElement() override;
</del><ins>+ virtual void updateFromElement() override;
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> void createWrapperIfNeeded();
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isRenderMathMLToken() const override final { return true; }
</ins><span class="cx"> virtual const char* renderName() const override { return isAnonymous() ? "RenderMathMLToken (anonymous)" : "RenderMathMLToken"; }
</span><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</span><span class="cx"> virtual void updateStyle();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLUnderOverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -32,16 +32,16 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class RenderMathMLUnderOver : public RenderMathMLBlock {
</del><ins>+class RenderMathMLUnderOver final : public RenderMathMLBlock {
</ins><span class="cx"> public:
</span><span class="cx"> RenderMathMLUnderOver(Element&, PassRef<RenderStyle>);
</span><span class="cx">
</span><del>- virtual RenderMathMLOperator* unembellishedOperator();
</del><ins>+ virtual RenderMathMLOperator* unembellishedOperator() override;
</ins><span class="cx">
</span><span class="cx"> virtual int firstLineBaseline() const override;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void layout();
</del><ins>+ virtual void layout() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual bool isRenderMathMLUnderOver() const override { return true; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingshapesBoxShapeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/shapes/BoxShape.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/shapes/BoxShape.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/shapes/BoxShape.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx">
</span><span class="cx"> RoundedRect computeRoundedRectForBoxShape(CSSBoxType, const RenderBox&);
</span><span class="cx">
</span><del>-class BoxShape : public Shape {
</del><ins>+class BoxShape final : public Shape {
</ins><span class="cx"> public:
</span><span class="cx"> BoxShape(const FloatRoundedRect& bounds)
</span><span class="cx"> : m_bounds(bounds)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingshapesPolygonShapeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/shapes/PolygonShape.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/shapes/PolygonShape.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/shapes/PolygonShape.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class OffsetPolygonEdge : public VertexPair {
</del><ins>+class OffsetPolygonEdge final : public VertexPair {
</ins><span class="cx"> public:
</span><span class="cx"> OffsetPolygonEdge(const FloatPolygonEdge& edge, const FloatSize& offset)
</span><span class="cx"> : m_vertex1(edge.vertex1() + offset)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingshapesRasterShapeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/shapes/RasterShape.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/shapes/RasterShape.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/shapes/RasterShape.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> int m_offset;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class RasterShape : public Shape {
</del><ins>+class RasterShape final : public Shape {
</ins><span class="cx"> WTF_MAKE_NONCOPYABLE(RasterShape);
</span><span class="cx"> public:
</span><span class="cx"> RasterShape(std::unique_ptr<RasterShapeIntervals> intervals, const IntSize& marginRectSize)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingshapesRectangleShapeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/shapes/RectangleShape.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/shapes/RectangleShape.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/shapes/RectangleShape.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class RectangleShape : public Shape {
</del><ins>+class RectangleShape final : public Shape {
</ins><span class="cx"> public:
</span><span class="cx"> RectangleShape(const FloatRect& bounds, const FloatSize& radii)
</span><span class="cx"> : m_bounds(bounds)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleBasicShapesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/BasicShapes.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/BasicShapes.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/style/BasicShapes.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -145,7 +145,7 @@
</span><span class="cx">
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class BasicShapeCircle : public BasicShape {
</del><ins>+class BasicShapeCircle final : public BasicShape {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<BasicShapeCircle> create() { return adoptRef(new BasicShapeCircle); }
</span><span class="cx">
</span><span class="lines">@@ -170,7 +170,7 @@
</span><span class="cx"> BasicShapeRadius m_radius;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class BasicShapeEllipse : public BasicShape {
</del><ins>+class BasicShapeEllipse final : public BasicShape {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<BasicShapeEllipse> create() { return adoptRef(new BasicShapeEllipse); }
</span><span class="cx">
</span><span class="lines">@@ -198,7 +198,7 @@
</span><span class="cx"> BasicShapeRadius m_radiusY;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class BasicShapePolygon : public BasicShape {
</del><ins>+class BasicShapePolygon final : public BasicShape {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<BasicShapePolygon> create() { return adoptRef(new BasicShapePolygon); }
</span><span class="cx">
</span><span class="lines">@@ -224,7 +224,7 @@
</span><span class="cx"> Vector<Length> m_values;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class BasicShapeInset : public BasicShape {
</del><ins>+class BasicShapeInset final : public BasicShape {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<BasicShapeInset> create() { return adoptRef(new BasicShapeInset); }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStylePendingImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StylePendingImage.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StylePendingImage.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/style/StylePendingImage.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> // style resolution, in order to avoid loading images that are not referenced by the final style.
</span><span class="cx"> // They should never exist in a RenderStyle after it has been returned from the style selector.
</span><span class="cx">
</span><del>-class StylePendingImage : public StyleImage {
</del><ins>+class StylePendingImage final : public StyleImage {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<StylePendingImage> create(CSSValue* value) { return adoptRef(new StylePendingImage(value)); }
</span><span class="cx">
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> virtual FloatSize imageSize(const RenderElement*, float /*multiplier*/) const override { return FloatSize(); }
</span><span class="cx"> virtual bool imageHasRelativeWidth() const override { return false; }
</span><span class="cx"> virtual bool imageHasRelativeHeight() const override { return false; }
</span><del>- virtual void computeIntrinsicDimensions(const RenderElement*, Length& /* intrinsicWidth */ , Length& /* intrinsicHeight */, FloatSize& /* intrinsicRatio */) { }
</del><ins>+ virtual void computeIntrinsicDimensions(const RenderElement*, Length& /* intrinsicWidth */ , Length& /* intrinsicHeight */, FloatSize& /* intrinsicRatio */) override { }
</ins><span class="cx"> virtual bool usesImageContainerSize() const override { return false; }
</span><span class="cx"> virtual void setContainerSizeForRenderer(const RenderElement*, const FloatSize&, float) override { }
</span><span class="cx"> virtual void addClient(RenderElement*) override { }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGBlockh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void updateFromStyle() override final;
</span><span class="cx">
</span><del>- virtual bool isRenderSVGBlock() const override final { return true; };
</del><ins>+ virtual bool isRenderSVGBlock() const override final { return true; }
</ins><span class="cx">
</span><span class="cx"> virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGContainerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -42,7 +42,6 @@
</span><span class="cx"> protected:
</span><span class="cx"> RenderSVGContainer(SVGElement&, PassRef<RenderStyle>);
</span><span class="cx">
</span><del>- virtual bool isSVGContainer() const override final { return true; }
</del><span class="cx"> virtual const char* renderName() const override { return "RenderSVGContainer"; }
</span><span class="cx">
</span><span class="cx"> virtual bool canHaveChildren() const override final { return true; }
</span><span class="lines">@@ -73,6 +72,8 @@
</span><span class="cx"> void updateCachedBoundaries();
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isSVGContainer() const override final { return true; }
+
</ins><span class="cx"> FloatRect m_objectBoundingBox;
</span><span class="cx"> bool m_objectBoundingBoxValid;
</span><span class="cx"> FloatRect m_strokeBoundingBox;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGEllipseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -37,15 +37,15 @@
</span><span class="cx"> virtual ~RenderSVGEllipse();
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual const char* renderName() const { return "RenderSVGEllipse"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderSVGEllipse"; }
</ins><span class="cx">
</span><del>- virtual void updateShapeFromElement();
- virtual bool isEmpty() const { return m_usePathFallback ? RenderSVGShape::isEmpty() : m_fillBoundingBox.isEmpty(); };
</del><ins>+ virtual void updateShapeFromElement() override;
+ virtual bool isEmpty() const override { return m_usePathFallback ? RenderSVGShape::isEmpty() : m_fillBoundingBox.isEmpty(); }
</ins><span class="cx"> virtual bool isRenderingDisabled() const override;
</span><del>- virtual void fillShape(GraphicsContext*) const;
- virtual void strokeShape(GraphicsContext*) const;
- virtual bool shapeDependentStrokeContains(const FloatPoint&);
- virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;
</del><ins>+ virtual void fillShape(GraphicsContext*) const override;
+ virtual void strokeShape(GraphicsContext*) const override;
+ virtual bool shapeDependentStrokeContains(const FloatPoint&) override;
+ virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const override;
</ins><span class="cx"> void calculateRadiiAndCenter();
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGForeignObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -37,35 +37,35 @@
</span><span class="cx">
</span><span class="cx"> SVGForeignObjectElement& foreignObjectElement() const;
</span><span class="cx">
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&);
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&) override;
</ins><span class="cx">
</span><span class="cx"> virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
</span><span class="cx"> virtual void computeFloatRectForRepaint(const RenderLayerModelObject* repaintContainer, FloatRect&, bool fixed = false) const override;
</span><span class="cx">
</span><del>- virtual bool requiresLayer() const { return false; }
- virtual void layout();
</del><ins>+ virtual bool requiresLayer() const override { return false; }
+ virtual void layout() override;
</ins><span class="cx">
</span><del>- virtual FloatRect objectBoundingBox() const { return FloatRect(FloatPoint(), m_viewport.size()); }
- virtual FloatRect strokeBoundingBox() const { return FloatRect(FloatPoint(), m_viewport.size()); }
- virtual FloatRect repaintRectInLocalCoordinates() const { return FloatRect(FloatPoint(), m_viewport.size()); }
</del><ins>+ virtual FloatRect objectBoundingBox() const override { return FloatRect(FloatPoint(), m_viewport.size()); }
+ virtual FloatRect strokeBoundingBox() const override { return FloatRect(FloatPoint(), m_viewport.size()); }
+ virtual FloatRect repaintRectInLocalCoordinates() const override { return FloatRect(FloatPoint(), m_viewport.size()); }
</ins><span class="cx">
</span><del>- virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction);
</del><ins>+ virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override;
</ins><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
</span><del>- virtual bool isSVGForeignObject() const { return true; }
</del><span class="cx">
</span><span class="cx"> virtual void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = 0) const override;
</span><span class="cx"> virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const override;
</span><del>- virtual void setNeedsTransformUpdate() { m_needsTransformUpdate = true; }
</del><ins>+ virtual void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual bool isSVGForeignObject() const override { return true; }
</ins><span class="cx"> void graphicsElement() const = delete;
</span><span class="cx"> virtual const char* renderName() const override { return "RenderSVGForeignObject"; }
</span><span class="cx">
</span><span class="cx"> virtual void updateLogicalWidth() override;
</span><span class="cx"> virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;
</span><span class="cx">
</span><del>- virtual const AffineTransform& localToParentTransform() const;
- virtual AffineTransform localTransform() const { return m_localTransform; }
</del><ins>+ virtual const AffineTransform& localToParentTransform() const override;
+ virtual AffineTransform localTransform() const override { return m_localTransform; }
</ins><span class="cx">
</span><span class="cx"> bool m_needsTransformUpdate : 1;
</span><span class="cx"> FloatRect m_viewport;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGImage.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGImage.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGImage.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -42,9 +42,9 @@
</span><span class="cx"> SVGImageElement& imageElement() const;
</span><span class="cx">
</span><span class="cx"> bool updateImageViewport();
</span><del>- virtual void setNeedsBoundariesUpdate() { m_needsBoundariesUpdate = true; }
</del><ins>+ virtual void setNeedsBoundariesUpdate() override { m_needsBoundariesUpdate = true; }
</ins><span class="cx"> virtual bool needsBoundariesUpdate() override { return m_needsBoundariesUpdate; }
</span><del>- virtual void setNeedsTransformUpdate() { m_needsTransformUpdate = true; }
</del><ins>+ virtual void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }
</ins><span class="cx">
</span><span class="cx"> RenderImageResource& imageResource() { return *m_imageResource; }
</span><span class="cx"> const RenderImageResource& imageResource() const { return *m_imageResource; }
</span><span class="lines">@@ -55,29 +55,29 @@
</span><span class="cx"> private:
</span><span class="cx"> void element() const = delete;
</span><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderSVGImage"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderSVGImage"; }
</ins><span class="cx"> virtual bool isSVGImage() const override { return true; }
</span><span class="cx"> virtual bool canHaveChildren() const override { return false; }
</span><span class="cx">
</span><del>- virtual const AffineTransform& localToParentTransform() const { return m_localTransform; }
</del><ins>+ virtual const AffineTransform& localToParentTransform() const override { return m_localTransform; }
</ins><span class="cx">
</span><del>- virtual FloatRect objectBoundingBox() const { return m_objectBoundingBox; }
- virtual FloatRect strokeBoundingBox() const { return m_objectBoundingBox; }
- virtual FloatRect repaintRectInLocalCoordinates() const { return m_repaintBoundingBox; }
</del><ins>+ virtual FloatRect objectBoundingBox() const override { return m_objectBoundingBox; }
+ virtual FloatRect strokeBoundingBox() const override { return m_objectBoundingBox; }
+ virtual FloatRect repaintRectInLocalCoordinates() const override { return m_repaintBoundingBox; }
</ins><span class="cx"> virtual FloatRect repaintRectInLocalCoordinatesExcludingSVGShadow() const override { return m_repaintBoundingBoxExcludingShadow; }
</span><span class="cx">
</span><span class="cx"> virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& additionalOffset, const RenderLayerModelObject* paintContainer = 0) override;
</span><span class="cx">
</span><del>- virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);
</del><ins>+ virtual void imageChanged(WrappedImagePtr, const IntRect* = nullptr) override;
</ins><span class="cx">
</span><del>- virtual void layout();
- virtual void paint(PaintInfo&, const LayoutPoint&);
</del><ins>+ virtual void layout() override;
+ virtual void paint(PaintInfo&, const LayoutPoint&) override;
</ins><span class="cx">
</span><span class="cx"> void invalidateBufferedForeground();
</span><span class="cx">
</span><del>- virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction);
</del><ins>+ virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override;
</ins><span class="cx">
</span><del>- virtual AffineTransform localTransform() const { return m_localTransform; }
</del><ins>+ virtual AffineTransform localTransform() const override { return m_localTransform; }
</ins><span class="cx"> void calculateImageViewport();
</span><span class="cx">
</span><span class="cx"> bool m_needsBoundariesUpdate : 1;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGPathh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGPath.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGPath.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGPath.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual bool isSVGPath() const override { return true; }
</span><del>- virtual const char* renderName() const { return "RenderSVGPath"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderSVGPath"; }
</ins><span class="cx">
</span><span class="cx"> virtual void updateShapeFromElement() override;
</span><span class="cx"> FloatRect calculateUpdatedStrokeBoundingBox() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGRecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRect.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGRect.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRect.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -43,15 +43,15 @@
</span><span class="cx"> private:
</span><span class="cx"> void graphicsElement() const = delete;
</span><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderSVGRect"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderSVGRect"; }
</ins><span class="cx">
</span><del>- virtual void updateShapeFromElement();
- virtual bool isEmpty() const { return m_usePathFallback ? RenderSVGShape::isEmpty() : m_fillBoundingBox.isEmpty(); };
</del><ins>+ virtual void updateShapeFromElement() override;
+ virtual bool isEmpty() const override { return m_usePathFallback ? RenderSVGShape::isEmpty() : m_fillBoundingBox.isEmpty(); }
</ins><span class="cx"> virtual bool isRenderingDisabled() const override;
</span><del>- virtual void fillShape(GraphicsContext*) const;
- virtual void strokeShape(GraphicsContext*) const;
- virtual bool shapeDependentStrokeContains(const FloatPoint&);
- virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;
</del><ins>+ virtual void fillShape(GraphicsContext*) const override;
+ virtual void strokeShape(GraphicsContext*) const override;
+ virtual bool shapeDependentStrokeContains(const FloatPoint&) override;
+ virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> FloatRect m_innerStrokeRect;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceClipperh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> bool applyClippingToContext(RenderElement&, const FloatRect&, const FloatRect&, GraphicsContext*);
</span><span class="cx"> virtual FloatRect resourceBoundingBox(const RenderObject&) override;
</span><span class="cx">
</span><del>- virtual RenderSVGResourceType resourceType() const { return ClipperResourceType; }
</del><ins>+ virtual RenderSVGResourceType resourceType() const override { return ClipperResourceType; }
</ins><span class="cx">
</span><span class="cx"> bool hitTestClipContent(const FloatRect&, const FloatPoint&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceFilterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx">
</span><span class="cx"> void primitiveAttributeChanged(RenderObject*, const QualifiedName&);
</span><span class="cx">
</span><del>- virtual RenderSVGResourceType resourceType() const { return s_resourceType; }
</del><ins>+ virtual RenderSVGResourceType resourceType() const override { return s_resourceType; }
</ins><span class="cx"> static RenderSVGResourceType s_resourceType;
</span><span class="cx">
</span><span class="cx"> FloatRect drawingRegion(RenderObject*) const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceFilterPrimitiveh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -39,10 +39,9 @@
</span><span class="cx"> RenderSVGResourceFilterPrimitive(SVGFilterPrimitiveStandardAttributes&, PassRef<RenderStyle>);
</span><span class="cx"> SVGFilterPrimitiveStandardAttributes& filterPrimitiveElement() const;
</span><span class="cx">
</span><del>- virtual void styleDidChange(StyleDifference, const RenderStyle*);
</del><ins>+ virtual void styleDidChange(StyleDifference, const RenderStyle*) override;
</ins><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderSVGResourceFilterPrimitive"; }
- virtual bool isSVGResourceFilterPrimitive() const { return true; }
</del><ins>+ virtual const char* renderName() const override { return "RenderSVGResourceFilterPrimitive"; }
</ins><span class="cx">
</span><span class="cx"> // They depend on the RenderObject argument of RenderSVGResourceFilter::applyResource.
</span><span class="cx"> static FloatRect determineFilterPrimitiveSubregion(FilterEffect&);
</span><span class="lines">@@ -55,6 +54,7 @@
</span><span class="cx"> static_cast<RenderSVGResourceFilter*>(filter)->primitiveAttributeChanged(this, attribute);
</span><span class="cx"> }
</span><span class="cx"> private:
</span><ins>+ virtual bool isSVGResourceFilterPrimitive() const override { return true; }
</ins><span class="cx"> void element() const = delete;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceLinearGradienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -34,13 +34,13 @@
</span><span class="cx">
</span><span class="cx"> SVGLinearGradientElement& linearGradientElement() const { return downcast<SVGLinearGradientElement>(RenderSVGResourceGradient::gradientElement()); }
</span><span class="cx">
</span><del>- virtual RenderSVGResourceType resourceType() const { return s_resourceType; }
</del><ins>+ virtual RenderSVGResourceType resourceType() const override { return s_resourceType; }
</ins><span class="cx"> static RenderSVGResourceType s_resourceType;
</span><span class="cx">
</span><del>- virtual SVGUnitTypes::SVGUnitType gradientUnits() const { return m_attributes.gradientUnits(); }
- virtual void calculateGradientTransform(AffineTransform& transform) { transform = m_attributes.gradientTransform(); }
</del><ins>+ virtual SVGUnitTypes::SVGUnitType gradientUnits() const override { return m_attributes.gradientUnits(); }
+ virtual void calculateGradientTransform(AffineTransform& transform) override { transform = m_attributes.gradientTransform(); }
</ins><span class="cx"> virtual bool collectGradientAttributes() override;
</span><del>- virtual void buildGradient(GradientData*) const;
</del><ins>+ virtual void buildGradient(GradientData*) const override;
</ins><span class="cx">
</span><span class="cx"> FloatPoint startPoint(const LinearGradientAttributes&) const;
</span><span class="cx"> FloatPoint endPoint(const LinearGradientAttributes&) const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceMarkerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceMarker.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceMarker.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceMarker.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -45,11 +45,11 @@
</span><span class="cx"> // Calculates marker boundaries, mapped to the target element's coordinate space
</span><span class="cx"> FloatRect markerBoundaries(const AffineTransform& markerTransformation) const;
</span><span class="cx">
</span><del>- virtual void applyViewportClip(PaintInfo&);
- virtual void layout();
- virtual void calcViewport();
</del><ins>+ virtual void applyViewportClip(PaintInfo&) override;
+ virtual void layout() override;
+ virtual void calcViewport() override;
</ins><span class="cx">
</span><del>- virtual const AffineTransform& localToParentTransform() const;
</del><ins>+ virtual const AffineTransform& localToParentTransform() const override;
</ins><span class="cx"> AffineTransform markerTransformation(const FloatPoint& origin, float angle, float strokeWidth) const;
</span><span class="cx">
</span><span class="cx"> virtual bool applyResource(RenderElement&, const RenderStyle&, GraphicsContext*&, unsigned short) override { return false; }
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx"> float angle() const;
</span><span class="cx"> SVGMarkerUnitsType markerUnits() const { return markerElement().markerUnits(); }
</span><span class="cx">
</span><del>- virtual RenderSVGResourceType resourceType() const { return s_resourceType; }
</del><ins>+ virtual RenderSVGResourceType resourceType() const override { return s_resourceType; }
</ins><span class="cx"> static RenderSVGResourceType s_resourceType;
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceMaskerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> SVGUnitTypes::SVGUnitType maskUnits() const { return maskElement().maskUnits(); }
</span><span class="cx"> SVGUnitTypes::SVGUnitType maskContentUnits() const { return maskElement().maskContentUnits(); }
</span><span class="cx">
</span><del>- virtual RenderSVGResourceType resourceType() const { return s_resourceType; }
</del><ins>+ virtual RenderSVGResourceType resourceType() const override { return s_resourceType; }
</ins><span class="cx"> static RenderSVGResourceType s_resourceType;
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourcePatternh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> virtual void postApplyResource(RenderElement&, GraphicsContext*&, unsigned short resourceMode, const Path*, const RenderSVGShape*) override;
</span><span class="cx"> virtual FloatRect resourceBoundingBox(const RenderObject&) override { return FloatRect(); }
</span><span class="cx">
</span><del>- virtual RenderSVGResourceType resourceType() const { return s_resourceType; }
</del><ins>+ virtual RenderSVGResourceType resourceType() const override { return s_resourceType; }
</ins><span class="cx"> static RenderSVGResourceType s_resourceType;
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceRadialGradienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -36,12 +36,12 @@
</span><span class="cx">
</span><span class="cx"> SVGRadialGradientElement& radialGradientElement() const { return downcast<SVGRadialGradientElement>(RenderSVGResourceGradient::gradientElement()); }
</span><span class="cx">
</span><del>- virtual RenderSVGResourceType resourceType() const { return s_resourceType; }
</del><ins>+ virtual RenderSVGResourceType resourceType() const override { return s_resourceType; }
</ins><span class="cx"> static RenderSVGResourceType s_resourceType;
</span><span class="cx">
</span><del>- virtual SVGUnitTypes::SVGUnitType gradientUnits() const { return m_attributes.gradientUnits(); }
- virtual void calculateGradientTransform(AffineTransform& transform) { transform = m_attributes.gradientTransform(); }
- virtual void buildGradient(GradientData*) const;
</del><ins>+ virtual SVGUnitTypes::SVGUnitType gradientUnits() const override { return m_attributes.gradientUnits(); }
+ virtual void calculateGradientTransform(AffineTransform& transform) override { transform = m_attributes.gradientTransform(); }
+ virtual void buildGradient(GradientData*) const override;
</ins><span class="cx">
</span><span class="cx"> FloatPoint centerPoint(const RadialGradientAttributes&) const;
</span><span class="cx"> FloatPoint focalPoint(const RadialGradientAttributes&) const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx"> virtual FloatRect objectBoundingBox() const override { return m_objectBoundingBox; }
</span><span class="cx"> virtual FloatRect strokeBoundingBox() const override { return m_strokeBoundingBox; }
</span><span class="cx"> virtual FloatRect repaintRectInLocalCoordinates() const override { return m_repaintBoundingBox; }
</span><del>- virtual FloatRect repaintRectInLocalCoordinatesExcludingSVGShadow() const { return m_repaintBoundingBoxExcludingShadow; }
</del><ins>+ FloatRect repaintRectInLocalCoordinatesExcludingSVGShadow() const { return m_repaintBoundingBoxExcludingShadow; }
</ins><span class="cx">
</span><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGTSpanh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGTSpan.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGTSpan.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGTSpan.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void graphicsElement() const = delete;
</span><del>- virtual const char* renderName() const { return "RenderSVGTSpan"; }
</del><ins>+ virtual const char* renderName() const override { return "RenderSVGTSpan"; }
</ins><span class="cx"> };
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGTexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGText.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGText.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGText.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -39,12 +39,12 @@
</span><span class="cx">
</span><span class="cx"> SVGTextElement& textElement() const;
</span><span class="cx">
</span><del>- virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const;
</del><ins>+ virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const override;
</ins><span class="cx">
</span><span class="cx"> void setNeedsPositioningValuesUpdate() { m_needsPositioningValuesUpdate = true; }
</span><del>- virtual void setNeedsTransformUpdate() { m_needsTransformUpdate = true; }
</del><ins>+ virtual void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }
</ins><span class="cx"> void setNeedsTextMetricsUpdate() { m_needsTextMetricsUpdate = true; }
</span><del>- virtual FloatRect repaintRectInLocalCoordinates() const;
</del><ins>+ virtual FloatRect repaintRectInLocalCoordinates() const override;
</ins><span class="cx">
</span><span class="cx"> static RenderSVGText* locateRenderSVGTextAncestor(RenderObject&);
</span><span class="cx"> static const RenderSVGText* locateRenderSVGTextAncestor(const RenderObject&);
</span><span class="lines">@@ -64,18 +64,18 @@
</span><span class="cx"> private:
</span><span class="cx"> void graphicsElement() const = delete;
</span><span class="cx">
</span><del>- virtual const char* renderName() const { return "RenderSVGText"; }
- virtual bool isSVGText() const { return true; }
</del><ins>+ virtual const char* renderName() const override { return "RenderSVGText"; }
+ virtual bool isSVGText() const override { return true; }
</ins><span class="cx">
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&);
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&) override;
</ins><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
</span><del>- virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction);
- virtual VisiblePosition positionForPoint(const LayoutPoint&, const RenderRegion*);
</del><ins>+ virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override;
+ virtual VisiblePosition positionForPoint(const LayoutPoint&, const RenderRegion*) override;
</ins><span class="cx">
</span><del>- virtual bool requiresLayer() const { return false; }
- virtual void layout();
</del><ins>+ virtual bool requiresLayer() const override { return false; }
+ virtual void layout() override;
</ins><span class="cx">
</span><del>- virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const;
</del><ins>+ virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;
</ins><span class="cx">
</span><span class="cx"> virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
</span><span class="cx"> virtual void computeRectForRepaint(const RenderLayerModelObject* repaintContainer, LayoutRect&, bool fixed = false) const override;
</span><span class="lines">@@ -83,16 +83,16 @@
</span><span class="cx">
</span><span class="cx"> virtual void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = 0) const override;
</span><span class="cx"> virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const override;
</span><del>- virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0);
</del><ins>+ virtual void addChild(RenderObject* child, RenderObject* beforeChild = nullptr) override;
</ins><span class="cx"> virtual RenderObject* removeChild(RenderObject&) override;
</span><span class="cx"> virtual void willBeDestroyed() override;
</span><span class="cx">
</span><del>- virtual const AffineTransform& localToParentTransform() const { return m_localTransform; }
- virtual AffineTransform localTransform() const { return m_localTransform; }
</del><ins>+ virtual const AffineTransform& localToParentTransform() const override { return m_localTransform; }
+ virtual AffineTransform localTransform() const override { return m_localTransform; }
</ins><span class="cx"> virtual std::unique_ptr<RootInlineBox> createRootInlineBox() override;
</span><span class="cx">
</span><del>- virtual RenderBlock* firstLineBlock() const;
- virtual void updateFirstLetter();
</del><ins>+ virtual RenderBlock* firstLineBlock() const override;
+ virtual void updateFirstLetter() override;
</ins><span class="cx">
</span><span class="cx"> bool shouldHandleSubtreeMutations() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGTransformableContainerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -32,15 +32,15 @@
</span><span class="cx"> RenderSVGTransformableContainer(SVGGraphicsElement&, PassRef<RenderStyle>);
</span><span class="cx"> SVGGraphicsElement& graphicsElement() { return downcast<SVGGraphicsElement>(RenderSVGContainer::element()); }
</span><span class="cx">
</span><del>- virtual bool isSVGTransformableContainer() const { return true; }
- virtual const AffineTransform& localToParentTransform() const { return m_localTransform; }
- virtual void setNeedsTransformUpdate() { m_needsTransformUpdate = true; }
- virtual bool didTransformToRootUpdate() { return m_didTransformToRootUpdate; }
</del><ins>+ virtual bool isSVGTransformableContainer() const override { return true; }
+ virtual const AffineTransform& localToParentTransform() const override { return m_localTransform; }
+ virtual void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }
+ virtual bool didTransformToRootUpdate() override { return m_didTransformToRootUpdate; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void element() const = delete;
</span><del>- virtual bool calculateLocalTransform();
- virtual AffineTransform localTransform() const { return m_localTransform; }
</del><ins>+ virtual bool calculateLocalTransform() override;
+ virtual AffineTransform localTransform() const override { return m_localTransform; }
</ins><span class="cx">
</span><span class="cx"> bool m_needsTransformUpdate : 1;
</span><span class="cx"> bool m_didTransformToRootUpdate : 1;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGViewportContainerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -38,27 +38,27 @@
</span><span class="cx"> FloatRect viewport() const { return m_viewport; }
</span><span class="cx">
</span><span class="cx"> bool isLayoutSizeChanged() const { return m_isLayoutSizeChanged; }
</span><del>- virtual bool didTransformToRootUpdate() { return m_didTransformToRootUpdate; }
</del><ins>+ virtual bool didTransformToRootUpdate() override { return m_didTransformToRootUpdate; }
</ins><span class="cx">
</span><del>- virtual void determineIfLayoutSizeChanged();
- virtual void setNeedsTransformUpdate() { m_needsTransformUpdate = true; }
</del><ins>+ virtual void determineIfLayoutSizeChanged() override;
+ virtual void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }
</ins><span class="cx">
</span><span class="cx"> virtual void paint(PaintInfo&, const LayoutPoint&) override;
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void element() const = delete;
</span><span class="cx">
</span><del>- virtual bool isSVGViewportContainer() const { return true; }
- virtual const char* renderName() const { return "RenderSVGViewportContainer"; }
</del><ins>+ virtual bool isSVGViewportContainer() const override { return true; }
+ virtual const char* renderName() const override { return "RenderSVGViewportContainer"; }
</ins><span class="cx">
</span><span class="cx"> AffineTransform viewportTransform() const;
</span><del>- virtual const AffineTransform& localToParentTransform() const { return m_localToParentTransform; }
</del><ins>+ virtual const AffineTransform& localToParentTransform() const override { return m_localToParentTransform; }
</ins><span class="cx">
</span><del>- virtual void calcViewport();
- virtual bool calculateLocalTransform();
</del><ins>+ virtual void calcViewport() override;
+ virtual bool calculateLocalTransform() override;
</ins><span class="cx">
</span><del>- virtual void applyViewportClip(PaintInfo&);
- virtual bool pointIsInsideViewportClip(const FloatPoint& pointInParent);
</del><ins>+ virtual void applyViewportClip(PaintInfo&) override;
+ virtual bool pointIsInsideViewportClip(const FloatPoint& pointInParent) override;
</ins><span class="cx">
</span><span class="cx"> FloatRect m_viewport;
</span><span class="cx"> mutable AffineTransform m_localToParentTransform;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGInlineTextBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -37,28 +37,28 @@
</span><span class="cx">
</span><span class="cx"> RenderSVGInlineText& renderer() const { return downcast<RenderSVGInlineText>(InlineTextBox::renderer()); }
</span><span class="cx">
</span><del>- virtual float virtualLogicalHeight() const { return m_logicalHeight; }
</del><ins>+ virtual float virtualLogicalHeight() const override { return m_logicalHeight; }
</ins><span class="cx"> void setLogicalHeight(float height) { m_logicalHeight = height; }
</span><span class="cx">
</span><del>- virtual int selectionTop() { return top(); }
- virtual int selectionHeight() { return static_cast<int>(ceilf(m_logicalHeight)); }
- virtual int offsetForPosition(float x, bool includePartialGlyphs = true) const;
- virtual float positionForOffset(int offset) const;
</del><ins>+ int selectionTop() { return top(); }
+ int selectionHeight() { return static_cast<int>(ceilf(m_logicalHeight)); }
+ virtual int offsetForPosition(float x, bool includePartialGlyphs = true) const override;
+ virtual float positionForOffset(int offset) const override;
</ins><span class="cx">
</span><span class="cx"> void paintSelectionBackground(PaintInfo&);
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;
</ins><span class="cx"> virtual LayoutRect localSelectionRect(int startPosition, int endPosition) const override;
</span><span class="cx">
</span><span class="cx"> bool mapStartEndPositionsIntoFragmentCoordinates(const SVGTextFragment&, int& startPosition, int& endPosition) const;
</span><span class="cx">
</span><del>- virtual FloatRect calculateBoundaries() const;
</del><ins>+ virtual FloatRect calculateBoundaries() const override;
</ins><span class="cx">
</span><span class="cx"> void clearTextFragments() { m_textFragments.clear(); }
</span><span class="cx"> Vector<SVGTextFragment>& textFragments() { return m_textFragments; }
</span><span class="cx"> const Vector<SVGTextFragment>& textFragments() const { return m_textFragments; }
</span><span class="cx">
</span><del>- virtual void dirtyOwnLineBoxes() override final;
- virtual void dirtyLineBoxes() override final;
</del><ins>+ virtual void dirtyOwnLineBoxes() override;
+ virtual void dirtyLineBoxes() override;
</ins><span class="cx">
</span><span class="cx"> bool startsNewTextChunk() const { return m_startsNewTextChunk; }
</span><span class="cx"> void setStartsNewTextChunk(bool newTextChunk) { m_startsNewTextChunk = newTextChunk; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGRootInlineBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h (175083 => 175084)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h 2014-10-23 03:49:41 UTC (rev 175083)
+++ trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h 2014-10-23 04:32:27 UTC (rev 175084)
</span><span class="lines">@@ -38,17 +38,17 @@
</span><span class="cx">
</span><span class="cx"> RenderSVGText& renderSVGText();
</span><span class="cx">
</span><del>- virtual float virtualLogicalHeight() const override final { return m_logicalHeight; }
</del><ins>+ virtual float virtualLogicalHeight() const override { return m_logicalHeight; }
</ins><span class="cx"> void setLogicalHeight(float height) { m_logicalHeight = height; }
</span><span class="cx">
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override final;
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;
</ins><span class="cx">
</span><span class="cx"> void computePerCharacterLayoutInformation();
</span><span class="cx">
</span><span class="cx"> InlineBox* closestLeafChildForPosition(const LayoutPoint&);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual bool isSVGRootInlineBox() const override final { return true; }
</del><ins>+ virtual bool isSVGRootInlineBox() const override { return true; }
</ins><span class="cx"> void reorderValueLists(Vector<SVGTextLayoutAttributes*>&);
</span><span class="cx"> void layoutCharactersInTextBoxes(InlineFlowBox*, SVGTextLayoutEngine&);
</span><span class="cx"> void layoutChildBoxes(InlineFlowBox*, FloatRect* = 0);
</span></span></pre>
</div>
</div>
</body>
</html>